Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet

2018-05-28 Thread Finn Thain
On Tue, 29 May 2018, Michael Schmitz wrote: > > > > Since an arch gets to apply limits in the dma ops it implements, why > > would arch code also have to set a limit in the form of default > > platform device masks? Powerpc seems to be the only arch that does > > this. > > One of Christoph's

Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet

2018-05-28 Thread Michael Schmitz
Hi Finn, Am 29.05.2018 um 14:15 schrieb Finn Thain: > > Since an arch gets to apply limits in the dma ops it implements, why would > arch code also have to set a limit in the form of default platform device > masks? Powerpc seems to be the only arch that does this. One of Christoph's recent

Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet

2018-05-28 Thread Finn Thain
On Mon, 28 May 2018, Geert Uytterhoeven wrote: > > Do we have a consensus on the way forward? My prefered solution remains the two driver patches that I originally submitted, which you objected to: https://lkml.org/lkml/2018/5/3/10 https://lkml.org/lkml/2018/5/3/9 So there is no consensus

Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet

2018-05-28 Thread Michael Schmitz
Hi Geert, my preference would be Finn's patch introducing a m68k arch_setup_pdev_archdata(). It nicely preserves what bus code sets up prior to registering a platform device (important for Zorro devices using platform or mfd devices), and allows overriding by drivers that need it. If ever a

Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet

2018-05-28 Thread Geert Uytterhoeven
On Mon, May 28, 2018 at 7:26 AM, Finn Thain wrote: > On Mon, 28 May 2018, Michael Schmitz wrote: >> Am 27.05.2018 um 17:49 schrieb Finn Thain: >> > On Sun, 27 May 2018, Michael Schmitz wrote: >> > >> >> That should have fixed the warning already ... >> > >> > It's