The block I/O code for the new X-Surf 100 ax88796 driver needs
ax_NS8390_init() for error fixup in its block_output function.
Export this function so we can lose the lib8380.c include in the
X-Surf 100 driver.
Signed-off-by: Michael Schmitz
---
drivers/net/ethernet/8390/ax88796.c |2 ++
1
Now that ax88796.c exports the ax_NS8390_init() symbol, we can
include 8390.h instead of lib8390.c, avoiding duplication of that
function and killing a few compile warnings in the bargain.
Signed-off-by: Michael Schmitz
---
drivers/net/ethernet/8390/xsurf100.c | 10 +++---
1 files
As suggested by Geert, xsurf100.c really does not need to duplicate code
from lib8390.c which is already part of ax88796.c, by including that file.
All we need from lib8390.c in the xsurf100 block output function is one
single function: ax_NS8390_init(). Export this symbol in ax88796.c so
the
Hi Michael,
Am 08.06.2018 um 21:28 schrieb Michael Karcher:
Let me add my 2 cents as main author of that code:
...
actually, the the block_input / block_output functions were the reason I
included the lib8390.c file. Except for xs100_write / xs100_read, they are
a verbatim copy from
Let me add my 2 cents as main author of that code:
Michael Schmitz wrote:
> Am 08.06.2018 um 02:36 schrieb Geert Uytterhoeven:
>> So I was wondering: why is this file included, as XSURF100 selects
>> AX88796,
>> while ax88796.c includes lib8390.c anyway?
>>
>> Apparently lib8390.c is included for
Hi Yamada-san,
On Fri, Jun 8, 2018 at 2:21 AM, Masahiro Yamada
wrote:
> Commit 21c54b774744 ("kconfig: show compiler version text in the top
> comment") was intended to detect the compiler upgrade, but Geert
> reported a breakage on the m68k build.
>
> The compiler upgrade is detected by the
Hi Geert,
Am 08.06.2018 um 02:36 schrieb Geert Uytterhoeven:
Hi Michael,
On Thu, Apr 19, 2018 at 4:05 AM, Michael Schmitz wrote:
From: Michael Karcher
Add platform device driver to populate the ax88796 platform data from
information provided by the XSurf100 zorro device driver. The ax88796
