[PATCH 2/2] net-next: xsurf100: drop include of lib8390.c

Now that ax88796.c exports the ax_NS8390_reinit() symbol, we can include 8390.h instead of lib8390.c, avoiding duplication of that function and killing a few compile warnings in the bargain. Fixes: 861928f4e60e826c ("net-next: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)")

[PATCH 1/2] net-next: ax88796: export ax_NS8390_init() hook

The block I/O code for the new X-Surf 100 ax88796 driver needs ax_NS8390_init() for error fixup in its block_output function. Export this static function through the ax_NS8390_reinit() wrapper so we can lose the lib8380.c include in the X-Surf 100 driver. Fixes: 861928f4e60e826c ("net-next: New

[PATCH 0/2] net-next: cleanup use of lib8390.c code in xsurf100.c

As suggested by Geert, xsurf100.c really does not need to duplicate code from lib8390.c which is already part of ax88796.c, by including that file. All we need from lib8390.c in the xsurf100 block output function is one single function: ax_NS8390_init(). Export this symbol through a wrapper in

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

On Sat, 9 Jun 2018, Andreas Schwab wrote: > On Jun 09 2018, Finn Thain wrote: > > > There is no ABI issue AFAIK. The value of pmu_kind is visible to userland > > only on powerpc. /dev/pmu and /proc/pmu/* do not exist on m68k. > > Then why are PMU_68K_V1 and PMU_68K_V2 defined in the first

Re: [PATCH v4 9/9] net-next: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

Hi Michael, Am 09.06.2018 um 21:15 schrieb Michael Karcher: Michael Schmitz schrieb: Hi Michael, actually, the the block_input / block_output functions were the reason I included the lib8390.c file. Except for xs100_write / xs100_read, they are a verbatim copy from ax88796.c I'm not that

Re: [RFC PATCH 2/2] net-next: xsurf100: drop include of lib8390.c

Hi Geert, Am 10.06.2018 um 02:33 schrieb Geert Uytterhoeven: Hi Michael, On Sat, Jun 9, 2018 at 7:58 AM Michael Schmitz wrote: Now that ax88796.c exports the ax_NS8390_init() symbol, we can include 8390.h instead of lib8390.c, avoiding duplication of that function and killing a few compile

Re: [RFC PATCH 2/2] net-next: xsurf100: drop include of lib8390.c

Hi Michael, On Sat, Jun 9, 2018 at 7:58 AM Michael Schmitz wrote: > > Now that ax88796.c exports the ax_NS8390_init() symbol, we can > include 8390.h instead of lib8390.c, avoiding duplication of that > function and killing a few compile warnings in the bargain. > > Signed-off-by: Michael

Re: [RFC PATCH 1/2] net-next: ax88796: export ax_NS8390_init() hook

Hi Michael, On Sat, Jun 9, 2018 at 7:58 AM Michael Schmitz wrote: > The block I/O code for the new X-Surf 100 ax88796 driver needs > ax_NS8390_init() for error fixup in its block_output function. > > Export this function so we can lose the lib8380.c include in the > X-Surf 100 driver. > >

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

On Jun 09 2018, Finn Thain wrote: > There is no ABI issue AFAIK. The value of pmu_kind is visible to userland > only on powerpc. /dev/pmu and /proc/pmu/* do not exist on m68k. Then why are PMU_68K_V1 and PMU_68K_V2 defined in the first place? Andreas. -- Andreas Schwab,

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

> > > Is this enum used by any user space code? If so, perhaps rather > > > leave the PMU_68K_V1 in there to avoid upsetting that? > > > > It also changes the value of PMU_68K_V2, which is an ABI break. > > Yes, that's what I worry about - but do we know of any users of that > particular

Re: [PATCH] kbuild: fix endless syncconfig in case arch Makefile sets CROSS_COMPILE

2018-06-08 17:20 GMT+09:00 Geert Uytterhoeven : > Hi Yamada-san, > > On Fri, Jun 8, 2018 at 2:21 AM, Masahiro Yamada > wrote: >> Commit 21c54b774744 ("kconfig: show compiler version text in the top >> comment") was intended to detect the compiler upgrade, but Geert >> reported a breakage on the

Re: [PATCH v4 9/9] net-next: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

Michael Schmitz schrieb: > Hi Michael, >> actually, the the block_input / block_output functions were the reason I >> included the lib8390.c file. Except for xs100_write / xs100_read, they >> are >> a verbatim copy from ax88796.c I'm not that enthusiastic about that idea >> anymore, but did not

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

Hi Andreas, Am 09.06.2018 um 19:14 schrieb Andreas Schwab: On Jun 09 2018, Michael Schmitz wrote: Hi Finn, Am 08.06.2018 um 14:24 schrieb Finn Thain: Don't load the via-pmu68k driver on early PowerBooks. The M50753 PMU device found in those models was never supported by this driver.

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

On Jun 09 2018, Michael Schmitz wrote: > Hi Finn, > > Am 08.06.2018 um 14:24 schrieb Finn Thain: >> Don't load the via-pmu68k driver on early PowerBooks. The M50753 PMU >> device found in those models was never supported by this driver. >> Attempting to load the driver usually causes a boot

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

Hi Finn, Am 08.06.2018 um 14:24 schrieb Finn Thain: Don't load the via-pmu68k driver on early PowerBooks. The M50753 PMU device found in those models was never supported by this driver. Attempting to load the driver usually causes a boot hang. Cc: Geert Uytterhoeven Signed-off-by: Finn Thain