Re: [PATCH 1/3] powerpc: mac: fix rtc read functions

2018-06-18 Thread Mathieu Malaterre
On Mon, Jun 18, 2018 at 10:04 PM Andreas Schwab wrote: > > On Jun 18 2018, Mathieu Malaterre wrote: > > > Sadly, trying again today does not work anymore. Adding some printk > > just before WARN_ON: > > > > +printk(KERN_ERR " rtc DBG pmu_get_time1: %lld %d %lld \n", now, > > RTC_OFFSET, now -

[PATCHv2] m68k: fix "bad page state" oops on ColdFire boot

2018-06-18 Thread Greg Ungerer
Booting a ColdFire m68k core with MMU enabled causes a "bad page state" oops since commit 1d40a5ea01d5 ("mm: mark pages in use for page tables"): BUG: Bad page state in process sh pfn:01ce2 page:004fefc8 count:0 mapcount:-1024 mapping: index:0x0 flags: 0x0() raw:

Re: mcf54415, mmu issues with last 4.18.0

2018-06-18 Thread Greg Ungerer
Hi Angelo, On 19/06/18 08:19, Angelo Dureghello wrote: after rebasing to master today, i am experiencing the following issue: [2.66] mcfuart.0: ttyS3 at MMIO 0xfc06c000 (irq = 93, base_baud = 750) is a ColdFire UART [2.70] m25p80 spi0.1: is25lp128 (16384 Kbytes) [

mcf54415, mmu issues with last 4.18.0

2018-06-18 Thread Angelo Dureghello
Dear all, after rebasing to master today, i am experiencing the following issue: [2.66] mcfuart.0: ttyS3 at MMIO 0xfc06c000 (irq = 93, base_baud = 750) is a ColdFire UART [2.70] m25p80 spi0.1: is25lp128 (16384 Kbytes) [2.71] Creating 3 MTD partitions on "is25lp128":

Re: [PATCH 1/3] powerpc: mac: fix rtc read functions

2018-06-18 Thread Andreas Schwab
On Jun 18 2018, Mathieu Malaterre wrote: > Sadly, trying again today does not work anymore. Adding some printk > just before WARN_ON: > > +printk(KERN_ERR " rtc DBG pmu_get_time1: %lld %d %lld \n", now, > RTC_OFFSET, now - RTC_OFFSET ); > +printk(KERN_ERR " rtc DBG pmu_get_time2: %x %x %x %x %d

Re: [PATCH 1/3] powerpc: mac: fix rtc read functions

2018-06-18 Thread Mathieu Malaterre
On Mon, Jun 18, 2018 at 4:07 PM Arnd Bergmann wrote: > > As Mathieu pointed out, my conversion to time64_t was incorrect and resulted > in negative times to be read from the RTC. The problem is that during the > conversion from a byte array to a time64_t, the 'unsigned char' variable > holding

Re: [PATCH 2/3] m68k: mac: use time64_t in RTC handling

2018-06-18 Thread kbuild test robot
Hi Arnd, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v4.18-rc1 next-20180618] [cannot apply to m68k/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[PATCH 1/3] powerpc: mac: fix rtc read functions

2018-06-18 Thread Arnd Bergmann
As Mathieu pointed out, my conversion to time64_t was incorrect and resulted in negative times to be read from the RTC. The problem is that during the conversion from a byte array to a time64_t, the 'unsigned char' variable holding the top byte gets turned into a negative signed 32-bit integer

[PATCH 3/3] m68k: remove unused set_clock_mmss() helpers

2018-06-18 Thread Arnd Bergmann
Commit 397ac99c6cef ("m68k: remove dead timer code") removed set_rtc_mmss() because it was unused in 2012. However, this was itself the only user of the mach_set_clock_mmss() callback and the many implementations of that callback, which are equally unused. This removes all of those as well.

[PATCH 2/3] m68k: mac: use time64_t in RTC handling

2018-06-18 Thread Arnd Bergmann
The real-time clock on m68k (and powerpc) mac systems uses an unsigned 32-bit value starting in 1904, which overflows in 2040, about two years later than everyone else, but this gets wrapped around in the Linux code in 2038 already because of the deprecated usage of time_t and/or long in the

Re: [PATCH] m68k: fix "bad page state" oops on ColdFire boot

2018-06-18 Thread Greg Ungerer
Hi Geert, On 18/06/18 16:58, Geert Uytterhoeven wrote: Hi Greg, On Mon, Jun 18, 2018 at 8:06 AM Greg Ungerer wrote: Booting a ColdFire m68k core with MMU enabled causes a "bad page state" oops since commit 1d40a5ea01d5 ("mm: mark pages in use for page tables"): BUG: Bad page state in

Re: [PATCH] m68k: fix "bad page state" oops on ColdFire boot

2018-06-18 Thread Geert Uytterhoeven
Hi Greg, On Mon, Jun 18, 2018 at 8:06 AM Greg Ungerer wrote: > Booting a ColdFire m68k core with MMU enabled causes a "bad page state" > oops since commit 1d40a5ea01d5 ("mm: mark pages in use for page tables"): > > BUG: Bad page state in process sh pfn:01ce2 > page:004fefc8 count:0

[PATCH] m68k: fix "bad page state" oops on ColdFire boot

2018-06-18 Thread Greg Ungerer
Booting a ColdFire m68k core with MMU enabled causes a "bad page state" oops since commit 1d40a5ea01d5 ("mm: mark pages in use for page tables"): BUG: Bad page state in process sh pfn:01ce2 page:004fefc8 count:0 mapcount:-1024 mapping: index:0x0 flags: 0x0() raw: