Re: [PATCH 2/2] include: warn for inconsistent endian config definition

2017-06-12 Thread Babu Moger
On 6/12/2017 3:58 PM, Max Filippov wrote: On Mon, Jun 12, 2017 at 1:51 PM, Arnd Bergmann wrote: That way, we don't have to guess what the toolchain does, but rather tell it to do whatever is configured, like we do for most other architectures. Unfortunately we can't do the same thing on xtens

Re: [PATCH 2/2] include: warn for inconsistent endian config definition

2017-06-12 Thread Babu Moger
On 6/12/2017 3:51 PM, Arnd Bergmann wrote: On Mon, Jun 12, 2017 at 10:30 PM, Babu Moger wrote: Looks like microblaze can be configured to either little or big endian formats. How about adding a choice statement to address this. Here is my proposed patch. Hi Babu, This part looks fine, but I

Re: [PATCH 2/2] include: warn for inconsistent endian config definition

2017-06-12 Thread Max Filippov
On Mon, Jun 12, 2017 at 1:51 PM, Arnd Bergmann wrote: > That way, we don't have to guess what the toolchain does, but rather > tell it to do whatever is configured, like we do for most other architectures. > > Unfortunately we can't do the same thing on xtensa, as that no longer > supports the -mb

Re: [PATCH 2/2] include: warn for inconsistent endian config definition

2017-06-12 Thread Arnd Bergmann
On Mon, Jun 12, 2017 at 10:30 PM, Babu Moger wrote: > > Looks like microblaze can be configured to either little or big endian > formats. How about > adding a choice statement to address this. > Here is my proposed patch. Hi Babu, This part looks fine, but I think we also need this one: diff -

Re: [PATCH 2/2] include: warn for inconsistent endian config definition

2017-06-12 Thread Babu Moger
Hi All, On 6/10/2017 9:06 AM, kbuild test robot wrote: Hi Babu, [auto build test WARNING on linus/master] [also build test WARNING on v4.12-rc4 next-20170609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH 2/2] include: warn for inconsistent endian config definition

2017-06-10 Thread kbuild test robot
Hi Babu, [auto build test WARNING on linus/master] [also build test WARNING on v4.12-rc4 next-20170609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Babu-Moger/Define-CPU_BIG_ENDIAN-or-warn-fo

Re: [PATCH 2/2] include: warn for inconsistent endian config definition

2017-06-09 Thread Babu Moger
On 6/9/2017 9:11 AM, Geert Uytterhoeven wrote: Hi Babu, On Fri, Jun 9, 2017 at 3:55 PM, Babu Moger wrote: On 6/9/2017 2:16 AM, Geert Uytterhoeven wrote: On Fri, Jun 9, 2017 at 9:05 AM, Geert Uytterhoeven wrote: Here is the original discussion http://www.spinics.net/lists/devicetree/msg1781

Re: [PATCH 2/2] include: warn for inconsistent endian config definition

2017-06-09 Thread Geert Uytterhoeven
Hi Babu, On Fri, Jun 9, 2017 at 3:55 PM, Babu Moger wrote: > On 6/9/2017 2:16 AM, Geert Uytterhoeven wrote: >> On Fri, Jun 9, 2017 at 9:05 AM, Geert Uytterhoeven >> wrote: Here is the original discussion http://www.spinics.net/lists/devicetree/msg178101.html Signed-off-by: Ba

Re: [PATCH 2/2] include: warn for inconsistent endian config definition

2017-06-09 Thread Babu Moger
Geert, On 6/9/2017 2:16 AM, Geert Uytterhoeven wrote: Hi Babu, On Fri, Jun 9, 2017 at 9:05 AM, Geert Uytterhoeven wrote: Here is the original discussion http://www.spinics.net/lists/devicetree/msg178101.html Signed-off-by: Babu Moger Suggested-by: Arnd Bergmann Hmm, the link above refers

Re: [PATCH 2/2] include: warn for inconsistent endian config definition

2017-06-09 Thread Geert Uytterhoeven
Hi Babu, On Fri, Jun 9, 2017 at 9:05 AM, Geert Uytterhoeven wrote: > >> Here is the original discussion >> http://www.spinics.net/lists/devicetree/msg178101.html >> >> Signed-off-by: Babu Moger >> Suggested-by: Arnd Bergmann > > Hmm, the link above refers to a mail from me? ;-) Please ignore t

Re: [PATCH 2/2] include: warn for inconsistent endian config definition

2017-06-09 Thread Geert Uytterhoeven
On Fri, Jun 9, 2017 at 12:17 AM, Babu Moger wrote: > Display warning if CPU_BIG_ENDIAN is not defined on big endian > architecture and also warn if it defined on little endian architectures. > > We have seen some generic code(for example code include/asm-generic/qrwlock.h) > uses CONFIG_CPU_BIG_EN

[PATCH 2/2] include: warn for inconsistent endian config definition

2017-06-08 Thread Babu Moger
Display warning if CPU_BIG_ENDIAN is not defined on big endian architecture and also warn if it defined on little endian architectures. We have seen some generic code(for example code include/asm-generic/qrwlock.h) uses CONFIG_CPU_BIG_ENDIAN to decide the endianess. Here is the original discussio