Re: [RFC] m68k/mm - adjust VM area to be unmapped by gap size for __iounmap()

Hi Geert, Am 24.05.2018 um 22:02 schrieb Geert Uytterhoeven: >> I happen to have a few old kernel trees around that I can consult for >> a rough history, and 2.4.30 still has the comment while 2.6.18 or >> 2.6.19 lost it. > > Of course all historical git trees contain linear history, not the

Re: [RFC] m68k/mm - adjust VM area to be unmapped by gap size for __iounmap()

Hi Michael, On Wed, May 23, 2018 at 11:39 PM, Michael Schmitz wrote: > On Wed, May 23, 2018 at 7:44 PM, Geert Uytterhoeven > wrote: At first sight (and looking in full-history-linux git history), I see no reason for the gap. I'd assume

Re: [RFC] m68k/mm - adjust VM area to be unmapped by gap size for __iounmap()

Hi Geert, see attached for the 2.4.30 version of kmap.c. Cheers, Michael Am 23.05.2018 um 19:44 schrieb Geert Uytterhoeven: > Hi Michael, > > On Tue, May 22, 2018 at 12:51 PM, Michael Schmitz > wrote: >> Am 22.05.2018 um 20:18 schrieb Geert Uytterhoeven: >>>

Re: [RFC] m68k/mm - adjust VM area to be unmapped by gap size for __iounmap()

Hi Geert, On Wed, May 23, 2018 at 7:44 PM, Geert Uytterhoeven wrote: >>> At first sight (and looking in full-history-linux git history), I see no >>> reason for the gap. I'd assume having a block with address and size aligned >>> to 256 KiB (which the caller already takes

Re: [RFC] m68k/mm - adjust VM area to be unmapped by gap size for __iounmap()

Hi Michael, On Tue, May 22, 2018 at 12:51 PM, Michael Schmitz wrote: > Am 22.05.2018 um 20:18 schrieb Geert Uytterhoeven: >> On Mon, May 14, 2018 at 1:10 PM, Michael Schmitz >> wrote: >>> Comment on whether the gap size should be considered in

Re: [RFC] m68k/mm - adjust VM area to be unmapped by gap size for __iounmap()

Hi Geert, Am 22.05.2018 um 20:18 schrieb Geert Uytterhoeven: > Hi Michael, > > On Mon, May 14, 2018 at 1:10 PM, Michael Schmitz wrote: > > On kernels with 020/030 support ... > >> get_io_area leaves an IO_SIZE gap between mappings which is added to >> the vm_struct

Re: [RFC] m68k/mm - adjust VM area to be unmapped by gap size for __iounmap()

Hi Michael, On Mon, May 14, 2018 at 1:10 PM, Michael Schmitz wrote: On kernels with 020/030 support ... > get_io_area leaves an IO_SIZE gap between mappings which is added to > the vm_struct representing the mapping. __ioremap() uses the actual > requested size (after

[RFC] m68k/mm - adjust VM area to be unmapped by gap size for __iounmap()

get_io_area leaves an IO_SIZE gap between mappings which is added to the vm_struct representing the mapping. __ioremap() uses the actual requested size (after alignment), while __iounmap() is passed the size from the vm_struct. On 020/030, early termination descriptors are used to set up