On Tue, Oct 16, 2018 at 10:52:26AM +1100, Finn Thain wrote:
> True enough. We agree that this #ifdef is undesirable. And yet when I
> tried it, I found an unexpected readability benefit to your suggestion:
>
> #ifdef CONFIG_SCSI_ESP_PIO
> u8 __iomem *fifo_reg;
> int
On Tue, Oct 16, 2018 at 04:39:07PM +1100, Finn Thain wrote:
>
> Perhaps I've misunderstood your concern here. Is it a problem that
> esp_scsi.ko may or may not export the function, depending on .config?
>
> For example, if esp_scsi.ko came from a build with CONFIG_SUN3X_ESP=y &&
>
I am Peter Wong director of operations, Hong Kong and Shanghai Banking
Corporation Limited Hong Kong. I have a very confidential business
proposition involving transfer of $18.350.000.00 that will be of great
benefit for both of us. Reply for more details as regards this
transaction
Best Regards
On Wed, 17 Oct 2018, Christoph Hellwig wrote:
>
> Please leave the possibly unused exports as-is.
>
I take that to mean "leave the conditional export as-is". Hence, I think
v3 (posted on the 16th) should address all of the concerns raised by
reviewers...
--
Finn,
> This series has fixes and cleanup for mac_esp, zorro_esp and the core
> esp_scsi driver.
>
> These improvements include elimination of duplicated code temporarily
> introduced for zorro_esp.
Had to hand-apply patch #5. Otherwise OK.
Applied to 4.20/scsi-queue. Thank you!
--
Martin
