Hi Geert,
Thanks for your feedback.
On Thu, 3 Jan 2019 at 16:15, Geert Uytterhoeven wrote:
> >
> > while [ $t_nxt -lt $t_nr ]; do
> > - printf "__SYSCALL(%s, sys_ni_syscall, )\n" "${t_nxt}"
> > + printf "__SYSCALL(%s,sys_ni_syscall)\n" "${t_nxt}"
>
> Please
> # All PPC32s use generic nvram driver through ppc_md
> -config GENERIC_NVRAM
> +config HAVE_ARCH_NVRAM_OPS
> bool
> default y if PPC32
Symbols like this really should be defined in common code, and then
just selected by the users.
Hi Firoz,
Thanks for your patch!
On Wed, Jan 2, 2019 at 4:19 PM Firoz Khan wrote:
> The __SYSCALL macro's arguments are system call number,
> system call entry name and number of arguments for the
name,
> system call.
>
> Argument- nargs in __SYSCALL(nr, entry, nargs) is neither
Argument
Hi Geert,
Thanks for your feedback!
On Thu, 3 Jan 2019 at 17:13, Geert Uytterhoeven wrote:
> > The generated uapi header file will be included in uapi/-
> > asm/unistd.h and generated system call table header file
> > will be included by kernel/syscalltable.S file.
>
> This doesn't really
> +
> +const struct nvram_ops arch_nvram_ops = {
> + .read_byte = nvram_read_byte,
> + .write_byte = nvram_write_byte,
> + .get_size = nvram_get_size,
> +};
> +EXPORT_SYMBOL(arch_nvram_ops);
I think something this internal should always be EXPORT_SYMBOL_GPL.
Hi Firoz,
Thanks for your patch!
On Wed, Jan 2, 2019 at 4:19 PM Firoz Khan wrote:
> Subject: m68k: generate uapi header and syscall table header files
>
> Unified system call table generation script must be run to
> generate unistd_32.h and syscall_table.h files. This patch
> will have changes
On Thu, 3 Jan 2019, Christoph Hellwig wrote:
> > # All PPC32s use generic nvram driver through ppc_md
> > -config GENERIC_NVRAM
> > +config HAVE_ARCH_NVRAM_OPS
> > bool
> > default y if PPC32
>
> Symbols like this really should be defined in common code, and then
> just selected by the
On Thu, 3 Jan 2019, Christoph Hellwig wrote:
> > +
> > +const struct nvram_ops arch_nvram_ops = {
> > + .read_byte = nvram_read_byte,
> > + .write_byte = nvram_write_byte,
> > + .get_size = nvram_get_size,
> > +};
> > +EXPORT_SYMBOL(arch_nvram_ops);
>
> I think something
