Re: [patch 1/2] m68k: runtime patching infrastructure

2007-05-30 Thread Linus Torvalds
On Wed, 30 May 2007, Geert Uytterhoeven wrote: > > Apparently you get a warning only if the _first_ occurrence of a struct > is declared inside a parameter list of a function. This is normal C behaviour (and afaik, the "inside a parameter list" part is actually just _modern_ C, not traditional

Re: [patch 1/2] m68k: runtime patching infrastructure

2007-05-30 Thread Joerg Dorchain
On Wed, May 30, 2007 at 01:19:45PM +0200, Geert Uytterhoeven wrote: > > > Actually, this is the only way to define circular referencing > > structures. > > No, you have forward declarations for that. These are missing here. I am no gcc expert, but might this be considred an implicit declaration?

Re: [patch 1/2] m68k: runtime patching infrastructure

2007-05-30 Thread Geert Uytterhoeven
On Wed, 30 May 2007, Joerg Dorchain wrote: > On Wed, May 30, 2007 at 09:06:08AM +0200, Geert Uytterhoeven wrote: > [...] > > > > > > > > I think it could be tightened up even if it happens not to warn? > > > > > > > > > struct a { > > > struct not_yet_defined *start, *end; > > > }; > > > > >

Re: [patch 1/2] m68k: runtime patching infrastructure

2007-05-30 Thread Joerg Dorchain
On Wed, May 30, 2007 at 09:06:08AM +0200, Geert Uytterhoeven wrote: [...] > > > > > > I think it could be tightened up even if it happens not to warn? > > > > > > struct a { > > struct not_yet_defined *start, *end; > > }; > > > > struct not_yet_defined { > > void *foo; > > }; > > > > I

Re: [patch 1/2] m68k: runtime patching infrastructure

2007-05-30 Thread Andreas Schwab
Geert Uytterhoeven <[EMAIL PROTECTED]> writes: > I was puzzled by this as well, as there were no compiler warnings... > > Apparently you get a warning only if the _first_ occurrence of a struct > is declared inside a parameter list of a function. The parameter list has its own scope. Andreas. -

Re: [patch 1/2] m68k: runtime patching infrastructure

2007-05-30 Thread Geert Uytterhoeven
On Wed, 30 May 2007, Eric Dumazet wrote: > Andrew Morton a �crit : > > On Mon, 28 May 2007 21:16:31 +0200 > > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > > > > > --- a/include/asm-m68k/module.h > > > +++ b/include/asm-m68k/module.h > > > @@ -1,7 +1,38 @@ > > > #ifndef _ASM_M68K_MODULE_H > > >