Re: [PATCH] mac8390: fix regression caused during net_device_ops conversion

2009-05-27 Thread Geert Uytterhoeven 
Hi Finn,

On Mon, May 25, 2009 at 17:36, Finn Thain fth...@telegraphics.com.au wrote:
 Changeset ca17584bf2ad1b1e37a5c0e4386728cc5fc9dabc broke mac8390 by adding
 8390.o to the link. That meant that lib8390.c was included twice, once in
 mac8390.c and once in 8390.c, subject to different macros. This patch
 reverts that by avoiding the wrappers in 8390.c. They seem to be of no
 value since COMPAT_NET_DEV_OPS is going away soon.

 Tested with a Kinetics EtherPort card.

http://kisskb.ellerman.id.au/kisskb/buildresult/544582/
| drivers/built-in.o:(.rodata+0x1da6): undefined reference to `ei_poll'

Any chance this is related?

I cannot check it myself right now, as the power supply of my main
development machine blew up, taking down some vital motherboard components
with it.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe linux-m68k in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mac8390: fix regression caused during net_device_ops conversion, take 2

2009-05-27 Thread David Miller 
From: Finn Thain fth...@telegraphics.com.au
Date: Thu, 28 May 2009 15:26:43 +1000 (EST)

 
 Changeset ca17584bf2ad1b1e37a5c0e4386728cc5fc9dabc broke mac8390 by adding 
 8390.o to the link. That meant that lib8390.c was included twice, once in 
 mac8390.c and once in 8390.c, subject to different macros. This patch 
 reverts that by avoiding the wrappers in 8390.c. They seem to be of no 
 value since COMPAT_NET_DEV_OPS is going away soon.
 
 Tested with a Kinetics EtherPort card.
 
 Signed-off-by: Finn Thain fth...@telegraphics.com.au

I already applied your other patch, it's in Linus's tree already
in fact.

So you need to send something relative to that.
--
To unsubscribe from this list: send the line unsubscribe linux-m68k in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html