Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

[Andrew, sorry for the dup. I did hit reply-to-auhor instead of reply-to-all first.] Andrew Lunn schrieb: >> > This should really be fixed in the PHY driver, not the MAC. >> >> OK - do you want this separate, or as part of this series? Might have >> a few side effects on more commonly used

Re: [PATCH v2 00/10] SWIM driver fixes

On Tue, Apr 17 2018, Finn Thain wrote: > On Wed, 11 Apr 2018, I wrote: > > > This patch series has fixes for bugs in the SWIM floppy disk controller > > driver, including an oops and a soft lockup. > > > > Apparently no-one is authorized to push this series intact. > > Geert, would you please

[PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

From: John Paul Adrian Glaubitz This complements the fix in 82533ad9a1c that removed the free_irq call in the error path of probe, to also not call free_irq when remove is called to revert the effects of probe. Signed-off-by: Michael Karcher

[PATCH v2 4/8] net: ax88796: Add block_input/output hooks to ax_plat_data

Add platform specific hooks for block transfer reads/writes of packet buffer data, superseding the default provided ax_block_input/output. Currently used for m68k Amiga XSurf100. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz

[PATCH v2 2/8] net: ax88796: Attach MII bus only when open

From: Michael Karcher Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources in ax_close(). This is needed to be able to unload the module, as the module is busy while the MII bus is attached. Signed-off-by: Michael Karcher

[PATCH v2 0/8] New network driver for Amiga X-Surf 100 (m68k)

This patch series adds support for the Individual Computers X-Surf 100 network card for m68k Amiga, a network adapter based on the AX88796 chip set. The driver was originally written for kernel version 3.19 by Michael Karcher (see CC:), and adapted to 4.16 for submission to netdev by me.

[PATCH v2 5/8] net: ax88796: add interrupt status callback to platform data

To be able to tell the ax88796 driver whether it is sensible to enter the 8390 interrupt handler, an "is this interrupt caused by the 88796" callback has been added to the ax_plat_data structure (with NULL being compatible to the previous behaviour). Signed-off-by: Michael Karcher

[PATCH v2 7/8] net: ax88796: release platform device drvdata on probe error and module remove

The net device struct pointer is stored as platform device drvdata on module probe - clear the drvdata entry on probe fail there, as well as when unloading the module. Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |2 ++ 1 files changed, 2

[PATCH v2 1/8] net: ax88796: Fix MAC address reading

From: Michael Karcher To read the MAC address from the (virtual) SAprom, the remote DMA unit needs to be set up like for every other process access to card-local memory. Signed-off-by: Michael Karcher Signed-off-by:

[PATCH v2 8/8] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

Add platform device driver to populate the ax88796 platform data from information provided by the XSurf100 zorro device driver. This driver will have to be loaded before loading the ax88796 module, or compiled as built-in. Signed-off-by: Michael Karcher

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

> > This should really be fixed in the PHY driver, not the MAC. > > OK - do you want this separate, or as part of this series? Might have > a few side effects on more commonly used hardware, perhaps? Hi Michael What PHY driver is used? In the driver you can implement a .soft_reset function

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

Hi Andrew, On Tue, Apr 17, 2018 at 11:12 AM, Andrew Lunn wrote: > On Tue, Apr 17, 2018 at 10:04:43AM +1200, Michael Schmitz wrote: >> From: John Paul Adrian Glaubitz >> >> The AX88796B as installed on the X-Surf-100 does not recognize a MII reset >>

Re: [PATCH 02/10] net: ax88796: Attach MII bus only when open

Hi Andrew, thank you for reviewing this series! On Tue, Apr 17, 2018 at 10:59 AM, Andrew Lunn wrote: > On Tue, Apr 17, 2018 at 10:04:37AM +1200, Michael Schmitz wrote: >> From: Michael Karcher >> >> Call ax_mii_init in ax_open(), and

Re: [PATCH v2 00/10] SWIM driver fixes

On Wed, 11 Apr 2018, I wrote: > This patch series has fixes for bugs in the SWIM floppy disk controller > driver, including an oops and a soft lockup. > Apparently no-one is authorized to push this series intact. Geert, would you please take just the first two patches? Jens, would you please

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

On Tue, Apr 17, 2018 at 10:04:43AM +1200, Michael Schmitz wrote: > From: John Paul Adrian Glaubitz > > The AX88796B as installed on the X-Surf-100 does not recognize a MII reset > request if the previous write to the MII control register also was a reset > request.

Re: [PATCH 02/10] net: ax88796: Attach MII bus only when open

On Tue, Apr 17, 2018 at 10:04:37AM +1200, Michael Schmitz wrote: > From: Michael Karcher > > Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources > in ax_close(). > > This is needed to be able to unload the module, as the module is busy >

[PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

Add platform specific hooks for block transfer reads/writes of packet buffer data, superseding the default provided ax_block_input/output. Currently used for m68k Amiga XSurf100. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz

[PATCH 07/10] net: ax88796: unregister mdiobus on ax_mii_init() fail

From: Michael Schmitz Unregister and free up mdiobus resources if ax_mii_init() failed. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |6 +- 1 files

[PATCH 06/10] net: ax88796: set IRQF_SHARED flag when IRQ resource is marked as shareable

From: John Paul Adrian Glaubitz On the Amiga X-Surf100, the network card interrupt is shared with many other interrupt sources, so requires the IRQF_SHARED flag to register. Signed-off-by: Michael Karcher Signed-off-by: Michael

[PATCH 09/10] net: ax88796: release platform device drvdata on probe error and module remove

The net device struct pointer is stored as platform device drvdata on module probe - clear the drvdata entry on probe fail there, as well as when unloading the module. Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |2 ++ 1 files changed, 2

[PATCH 03/10] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

From: John Paul Adrian Glaubitz This complements the fix in 82533ad9a1c that removed the free_irq call in the error path of probe, to also not call free_irq when remove is called to revert the effects of probe. Signed-off-by: Michael Karcher

[PATCH 10/10] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

Add platform device driver to populate the ax88796 platform data from information provided by the XSurf100 zorro device driver. This driver will have to be loaded before loading the ax88796 module, or compiled as built-in. Signed-off-by: Michael Karcher

[PATCH 02/10] net: ax88796: Attach MII bus only when open

From: Michael Karcher Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources in ax_close(). This is needed to be able to unload the module, as the module is busy while the MII bus is attached. Signed-off-by: Michael Karcher

[PATCH 01/10] net: ax88796: Fix MAC address reading

From: Michael Karcher To read the MAC address from the (virtual) SAprom, the remote DMA unit needs to be set up like for every other process access to card-local memory. Signed-off-by: Michael Karcher Signed-off-by:

[PATCH 05/10] net: ax88796: add interrupt status callback to platform data

To be able to tell the ax88796 driver whether it is sensible to enter the 8390 interrupt handler, an "is this interrupt caused by the 88796" callback has been added to the ax_plat_data structure (with NULL being compatible to the previous behaviour). Signed-off-by: Michael Karcher

[PATCH 00/10] New network driver for Amiga X-Surf 100 (m68k)

This patch series adds support for the Individual Computers X-Surf 100 network card for m68k Amiga, a network adapter based on the AX88796 chip set. The driver was originally written for kernel version 3.19 by Michael Karcher (see CC:), and adapted to 4.16 for submission to netdev by me.

Re: [PATCH v9] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

Thanks guys! Anything else needed for linux-scsi? Cheers, Michael On Mon, Apr 16, 2018 at 10:34 PM, John Paul Adrian Glaubitz wrote: > On 04/16/2018 11:26 AM, Christian T. Steigies wrote: >> >> On Thu, Apr 12, 2018 at 01:53:26PM +1200, Michael Schmitz wrote:

Re: [PATCH v9] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

On 04/16/2018 11:26 AM, Christian T. Steigies wrote: On Thu, Apr 12, 2018 at 01:53:26PM +1200, Michael Schmitz wrote: From: Michael Schmitz New combined SCSI driver for all ESP based Zorro SCSI boards for m68k Amiga. Code largely based on board specific parts of the old

[m68knommu:for-next 14/15] arch/m68k/include/asm/m525xsim.h:200:31: warning: passing argument 1 of '__raw_readl' makes pointer from integer without a cast

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git for-next head: a9f947bb3dc755158f69eea147d2ea92e3e4dcfe commit: c7088cea971e9fff1027861025778ab016a16c30 [14/15] m68k: remove local __raw_read/__raw_write macros for non-MMU config: m68k-m5249evb_defconfig (attached as