Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread David Miller
From: Jarkko Sakkinen Date: Fri, 30 Nov 2018 13:44:05 -0800 > On Fri, Nov 30, 2018 at 01:01:02PM -0800, James Bottomley wrote: >> No because use of what some people consider to be bad language isn't >> necessarily abusive, offensive or degrading. Our most heavily censored >> medium is TV and

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread David Miller
From: Jarkko Sakkinen Date: Fri, 30 Nov 2018 13:42:33 -0800 > Can you tell how the CoC should be interpreted then? Regardless of what I think, as others have showen the CoC explicitly does not apply to existing code.

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread David Miller
From: Abuse Date: Fri, 30 Nov 2018 20:39:01 + > I assume I will now be barred. Perhaps, but not because you said fuck. It would be because you're intentionally creating a disturbance on the list and making it more difficult for developers to get their work done and intentionally creating a

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread David Miller
From: Jens Axboe Date: Fri, 30 Nov 2018 13:12:26 -0700 > On 11/30/18 12:56 PM, Davidlohr Bueso wrote: >> On Fri, 30 Nov 2018, Kees Cook wrote: >> >>> On Fri, Nov 30, 2018 at 11:27 AM Jarkko Sakkinen >>> wrote: In order to comply with the CoC, replace with a hug. >> >> I hope

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread David Miller
From: Davidlohr Bueso Date: Fri, 30 Nov 2018 11:56:52 -0800 > I hope this is some kind of joke. Whether or not it is a joke, it is censorship. And because of that I have no intention to apply any patches like this to any code I am in charge of.

Re: [PATCH v2 2/2] mm: speed up mremap by 500x on large regions

2018-10-12 Thread David Miller
From: Joel Fernandes Date: Fri, 12 Oct 2018 05:50:46 -0700 > If its an issue, then how do transparent huge pages work on Sparc? I don't > see the huge page code (move_huge_pages) during mremap doing anything special > for Sparc architecture when moving PMDs.. This is because all huge pages are

Re: [PATCH v2 2/2] mm: speed up mremap by 500x on large regions

2018-10-12 Thread David Miller
From: "Kirill A. Shutemov" Date: Fri, 12 Oct 2018 14:30:56 +0300 > I looked into the code more and noticed move_pte() helper called from > move_ptes(). It changes PTE entry to suite new address. > > It is only defined in non-trivial way on Sparc. I don't know much about > Sparc and it's hard

Re: [PATCH 2/5] net: mac8390: Use standard memcpy_{from,to}io()

2018-07-02 Thread David Miller
From: Geert Uytterhoeven Date: Mon, 2 Jul 2018 15:35:29 +0200 > The mac8390 driver defines its own variants of memcpy_fromio() and > memcpy_toio(), using similar implementations, but different function > signatures. > > Remove the custom definitions of memcpy_fromio() and memcpy_toio(), and >

Re: [PATCH v4 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-19 Thread David Miller
From: Michael Schmitz Date: Thu, 19 Apr 2018 14:05:17 +1200 > This patch series adds support for the Individual Computers X-Surf 100 > network card for m68k Amiga, a network adapter based on the AX88796 chip set. Series applied, thank you. -- To unsubscribe from this list:

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-17 Thread David Miller
From: Geert Uytterhoeven Date: Tue, 17 Apr 2018 10:20:25 +0200 > BTW, I have a git alias for that: > > $ git help fixes > `git fixes' is aliased to `show --format='Fixes: %h ("%s")' -s' > $ git fixes 82533ad9a1c > Fixes: 82533ad9a1c ("net: ethernet: ax88796: don't call

Re: [PATCH net 0/4] Fixes, cleanup and modernization for mac89x0 driver

2018-03-01 Thread David Miller
From: Finn Thain Date: Thu, 1 Mar 2018 18:29:28 -0500 (EST) > Changes since v4 of combined patch series: > - Removed redundant and non-portable MACH_IS_MAC tests. > - Added acked-by tags from Geert Uytterhoeven. > - Omitted patches unrelated to mac89x0 driver.

Re: [PATCH net 0/2] Fixes, cleanup and modernization for macmace driver

2018-02-28 Thread David Miller
From: Finn Thain Date: Tue, 27 Feb 2018 23:22:32 -0500 (EST) > Changes since v4 of combined patch series: > - Removed redundant and non-portable MACH_IS_MAC tests. > - Omitted patches unrelated to macmace driver. Series applied, thank you. -- To unsubscribe from this

Re: [PATCH net 0/4] Fixes, cleanup and modernization for SONIC ethernet drivers

2018-02-26 Thread David Miller
From: Finn Thain Date: Sat, 24 Feb 2018 18:27:24 -0500 (EST) > Changes since v4 of combined patch series: > - Removed redundant and non-portable MACH_IS_MAC tests. > - Omitted patches unrelated to SONIC drivers. > - Dropped changes to the 'version_printed' logic and

Re: [PATCH] net/smc9194: Remove bogus CONFIG_MAC reference

2018-02-22 Thread David Miller
From: Finn Thain Date: Thu, 22 Feb 2018 09:24:59 +1100 (AEDT) > AFAIK the only version of smc9194.c with Mac support is the one in the > linux-mac68k CVS repo, which never made it to the mainline. > > Despite that, from v2.3.45, arch/m68k/config.in listed

Re: [PATCH net 2/4] net/8390: Fix msg_enable patch snafu

2018-02-21 Thread David Miller
Ok I applied this series, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net 2/4] net/8390: Fix msg_enable patch snafu

2018-02-19 Thread David Miller
From: Finn Thain Date: Tue, 20 Feb 2018 11:42:26 +1100 (AEDT) > If there was an unused variables I would happily remove that too but the > 'version' string is not unused. The etherh.c and mac8390.c files both > include "lib8390.c" and in there you'll find the

Re: [PATCH net 2/4] net/8390: Fix msg_enable patch snafu

2018-02-19 Thread David Miller
From: Finn Thain <fth...@telegraphics.com.au> Date: Tue, 20 Feb 2018 09:01:11 +1100 (AEDT) > On Mon, 19 Feb 2018, David Miller wrote: > >> From: Finn Thain <fth...@telegraphics.com.au> >> Date: Sun, 18 Feb 2018 21:39:17 -0500 (EST) >> >> > The lib

Re: [PATCH net 2/4] net/8390: Fix msg_enable patch snafu

2018-02-19 Thread David Miller
From: Finn Thain Date: Sun, 18 Feb 2018 21:39:17 -0500 (EST) > The lib8390 module parameter 'msg_enable' doesn't do anything useful: > it causes an ancient version string to be logged. Since you are removing the last reference to this 'version' string you should

Re: [PATCH net v4 02/13] net/8390: Fix msg_enable patch snafu

2018-02-14 Thread David Miller
From: Finn Thain <fth...@telegraphics.com.au> Date: Thu, 15 Feb 2018 09:11:13 +1100 (AEDT) > On Tue, 13 Feb 2018, David Miller wrote: > >> > I think you have overlooked those modules which offer no way to set >> > p->msg_enable, i.e. ax88796, axnet_cs, ethe

Re: [PATCH net v4 02/13] net/8390: Fix msg_enable patch snafu

2018-02-13 Thread David Miller
From: Finn Thain Date: Tue, 13 Feb 2018 16:03:09 +1100 (AEDT) > I think you have overlooked those modules which offer no way to set > p->msg_enable, i.e. ax88796, axnet_cs, etherh, hydra, mac8390, mcf8390, > pcnet_cs and zorro8390. Then that's a bug, we have a very

Re: [PATCH net v4 02/13] net/8390: Fix msg_enable patch snafu

2018-02-12 Thread David Miller
From: Finn Thain Date: Sun, 11 Feb 2018 22:08:43 -0500 (EST) > The lib8390 module parameter 'msg_enable' doesn't do anything useful: > it causes an ancient version string to be logged. Not true. You need to look at the various netif_*() et al. message logging

Re: [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big endian archs

2017-06-09 Thread David Miller
From: Babu Moger Date: Thu, 8 Jun 2017 15:17:22 -0700 > While working on enabling queued rwlock on SPARC, found > this following code in include/asm-generic/qrwlock.h > which uses CONFIG_CPU_BIG_ENDIAN to clear a byte. > > static inline u8 *__qrwlock_write_byte(struct

Re: [PATCH net-next] net: Remove usage of net_device last_rx member

2017-01-18 Thread David Miller
From: Tobias Klauser Date: Wed, 18 Jan 2017 17:45:01 +0100 > The network stack no longer uses the last_rx member of struct net_device > since the bonding driver switched to use its own private last_rx in > commit 9f242738376d ("bonding: use last_arp_rx in slave_last_rx()").

Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()

2016-05-17 Thread David Miller
From: Florian Fainelli <f.faine...@gmail.com> Date: Tue, 17 May 2016 11:27:12 -0700 > On 05/17/2016 11:20 AM, David Miller wrote: >> From: Rabin Vincent <rabin.vinc...@axis.com> >> Date: Mon, 16 May 2016 13:15:56 +0200 >> >>> From: Rabin Vincent <rab.

Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()

2016-05-17 Thread David Miller
From: Rabin Vincent Date: Mon, 16 May 2016 13:15:56 +0200 > From: Rabin Vincent > > Since e7f4dc3536a ("mdio: Move allocation of interrupts into core"), > platforms which call fixed_phy_add() before fixed_mdio_bus_init() is > called (for example,

Re: [PATCH 0/5] net: m68k: Allow modular build

2015-09-29 Thread David Miller
From: Geert Uytterhoeven Date: Tue, 29 Sep 2015 10:24:01 +0200 > This patch series makes the remaining m68k Ethernet drivers modular. > It's an alternative to the last 3 patches of Paul Gortmaker's series > "[PATCH net-next 0/6] make non-modular code explicitly

Re: [PATCH] net: smc91x: Add Atari EtherNAT support

2015-01-15 Thread David Miller
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Thu, 15 Jan 2015 14:06:15 +0100 From: Michael Schmitz schmitz...@gmail.com Add Atari specific code to the smc91x Ethernet driver. This code is used on the EtherNAT adapter card for the Atari Falcon extension port. Signed-off-by: Michael

Re: [PATCH 0/2] trivial cleanup

2014-06-05 Thread David Miller
From: Amos Kong ak...@redhat.com Date: Thu, 5 Jun 2014 11:01:20 +0800 I found the RAM size in comments isn't correct, fix it. Both patches applied, thank you. -- To unsubscribe from this list: send the line unsubscribe linux-m68k in the body of a message to majord...@vger.kernel.org More

Re: esp_scsi QTAG in FAS216

2014-04-13 Thread David Miller
From: Michael Schmitz schmitz...@gmail.com Date: Mon, 14 Apr 2014 10:38:09 +1200 That appears to be our problem if I recall correctly Tuomas' debugging report. (reselection, not selection as initiator). As esp_slave_configure() enables queue tags regardless of chip config, we'd best make

Re: esp_scsi QTAG in FAS216

2014-04-06 Thread David Miller
From: Michael Schmitz schmitz...@gmail.com Date: Mon, 7 Apr 2014 08:33:12 +1200 Hello Dave, Tuomas, Also, looking at the timeout formulae in the old NCR53C9x.c driver, the values would be different for FAS216. Why was this dropped from the modern esp_scsi? I've never seen a formula for

Re: esp_scsi QTAG in FAS216

2014-04-04 Thread David Miller
From: Tuomas Vainikka tuomas.vaini...@aalto.fi Date: Thu, 12 Sep 2013 18:36:09 +0300 Does anyone have the register descriptions for the FAS216 chip? It would seem that receiving only one byte during reconnect is perfectly normal [1] unless SCSI-2 features are explicitly enabled (which

Re: [PATCH] m68k/atari - ide: do not register interrupt if host-get_lock is set

2014-03-06 Thread David Miller
From: Michael Schmitz schmitz...@gmail.com Date: Thu, 6 Mar 2014 19:47:06 +1300 Thanks Dave, On m68k, host-get_lock is used to both lock and register the interrupt that the IDE host shares with other device drivers. Registering the IDE interrupt handler in ide-probe.c results in

Re: [PATCH] m68k/atari - ide: do not register interrupt if host-get_lock is set

2014-03-04 Thread David Miller
From: Michael Schmitz schmitz...@gmail.com Date: Sat, 1 Feb 2014 13:48:13 +1300 On m68k, host-get_lock is used to both lock and register the interrupt that the IDE host shares with other device drivers. Registering the IDE interrupt handler in ide-probe.c results in duplicating the interrupt

Re: [PATCH] net/7990: Make lance_private.name const

2013-11-14 Thread David Miller
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Thu, 14 Nov 2013 09:37:32 +0100 Sorry, I didn't get that message. I was puzzled by your request to correct the whitespace of the lines I touched only, which causes them to stand out in a block of old non-compliant whitespace. It's very hard

Re: [PATCH] net/7990: Make lance_private.name const

2013-11-13 Thread David Miller
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Wed, 13 Nov 2013 09:54:18 +0100 On Wed, Nov 13, 2013 at 12:16 AM, David Miller da...@davemloft.net wrote: And remember about checkpatch.pl which was hardly content with the patch. Only because checkpatch looks at the _new_ lines, and doesn't

Re: [PATCH] net/7990: Make lance_private.name const

2013-11-12 Thread David Miller
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Wed, 13 Nov 2013 01:04:17 +0300 @@ -100,7 +100,7 @@ struct lance_init_block { */ struct lance_private { -char *name; +const char *name; Indent with tab, not spaces, please. This whole file is %99

Re: [PATCH] net/7990: Make lance_private.name const

2013-11-12 Thread David Miller
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Wed, 13 Nov 2013 02:40:38 +0300 On 11/13/2013 12:12 AM, David Miller wrote: @@ -100,7 +100,7 @@ struct lance_init_block { */ struct lance_private { -char *name; +const char *name; Indent

Re: [PATCH] net/7990: Make lance_private.name const

2013-11-12 Thread David Miller
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Tue, 12 Nov 2013 23:44:06 +0100 On Wed, Nov 13, 2013 at 12:40 AM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: On 11/13/2013 12:12 AM, David Miller wrote: @@ -100,7 +100,7 @@ struct lance_init_block { */ struct

Re: [PATCH] net/sun3_82586: Kill array subscript above array bounds warning

2013-07-17 Thread David Miller
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Wed, 17 Jul 2013 14:25:05 +0200 drivers/net/ethernet/i825xx/sun3_82586.c: In function 'sun3_82586_timeout': drivers/net/ethernet/i825xx/sun3_82586.c:993:89: warning: array subscript is above array bounds [-Warray-bounds] Using the default

Re: [PATCH v2 0/2] net: support for NS8390 based ethernet on ColdFire CPU boards

2012-07-12 Thread David Miller
From: g...@snapgear.com Date: Thu, 5 Jul 2012 09:49:58 +1000 This is version 2 of patches that add platform support for using the NS8390 based ethernet ports used on some ColdFire CPU boards. This version incorporates only minor changes from the first. Patches to use these NS8390 devices

Re: [PATCH] irq: remove obsolete definitions in interrupt.h

2012-04-04 Thread David Miller
From: Sam Ravnborg s...@ravnborg.org Date: Wed, 4 Apr 2012 09:45:54 +0200 interrupt.h contained a small fixlet for the days when m68k and sparc32 did not use genirq. As they have both entered the modern world this fixlet can be dropped. Signed-off-by: Sam Ravnborg s...@ravnborg.org

Re: [PATCH] m68k/atari: EtherNEC - rewrite to use mainstream ne.c, take two

2012-04-03 Thread David Miller
From: Michael Schmitz schmitz...@googlemail.com Date: Sun, 01 Apr 2012 20:49:52 +1200 Hi Paul, Geert, And on re-reading the comments in the other part of the patch, i.e. ...emulates the card interrupt via a timer --perhaps the driver should be just fixed to support generic netpoll, instead

Re: [PATCH 09/11] net/ariadne: Improve debug prints

2012-03-21 Thread David Miller
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Wed, 21 Mar 2012 10:51:53 +0100 Remove casts and use proper printf()-style format specifiers instead. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org You can merge these in via the m68k tree if you want. Acked-by: David S. Miller

Re: [PATCH] net/ethernet: Move mac89x0.c from apple to cirrus

2011-11-01 Thread David Miller
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Sat, 29 Oct 2011 20:09:01 +0200 Macintosh CS89x0 based ethernet cards use a Crystal Semiconductor (Now Cirrus Logic) CS89x0 chip, so the mac89x0 driver should be in drivers/net/ethernet/cirrus instead of drivers/net/ethernet/apple. This

Re: [PATCH] macmace, macsonic: cleanup

2011-09-21 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Wed, 14 Sep 2011 03:30:25 +1000 (EST) We check ether_type before registering the platform device in arch/m68k/mac/config.c. Doing the same test again in the driver is redundant so remove it. Multiple probes should not happen since the

Re: [PATCH] mac_esp: remove redundant mutual exclusion

2011-09-10 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Sun, 11 Sep 2011 01:01:34 +1000 (EST) Mutual exclusion is redundant here because all the paths in the call graph leading to esp_driver_ops.send_dma_cmd() happen under spin_lock_irqsave/ spin_lock_irqrestore. Remove it. Tested on a Mac

Re: [PATCH] macmace: disable only the dma interrupt

2011-09-10 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Sun, 11 Sep 2011 01:02:16 +1000 (EST) Don't disable all interrupts, just disable the relevant one. Also move a couple of printk calls outside of local_irq_save/restore. Tested on a Quadra 660av. Signed-off-by: Finn Thain

Re: [PATCH] net/hplance: hplance_init() should be __devinit

2011-06-13 Thread David Miller
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Mon, 13 Jun 2011 20:17:36 +0200 WARNING: vmlinux.o(.devinit.text+0x253e): Section mismatch in reference from the function hplance_init_one() to the function .init.text:hplance_init() The forward declaration had the correct attribute, but

Re: [PATCH 1/4] sparc: _sparc_find_resource() should check for exact matches

2011-05-23 Thread David Miller
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Sat, 21 May 2011 21:39:13 +0200 The address that's passed to _sparc_find_resource() should always be the start address of a resource: - iounmap() passes a page-aligned virtual address, while the original address was created by adding

Re: [PATCH 4/4] sparc: iounmap() and *_free_coherent() - Use lookup_resource()

2011-05-23 Thread David Miller
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Sat, 21 May 2011 21:39:16 +0200 Replace a custom implementation (which doesn't lock the resource tree) by a call to lookup_resource() Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org Acked-by: David S. Miller da...@davemloft.net --

Re: [PATCH 0/3] Fix 8390 regressions

2011-05-12 Thread David Miller
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Thu, 12 May 2011 19:11:37 + These patches fix regressions in 3 8390-based network drivers: [1/3] zorro8390: Fix regression caused during net_device_ops conversion [2/3] hydra: Fix regression caused during net_device_ops conversion

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-04 Thread David Miller
From: Sven Eckelmann s...@narfation.org Date: Tue, 3 May 2011 23:30:35 +0200 Introduce an *_dec_not_zero operation. Make this a special case of *_add_unless because batman-adv uses atomic_dec_not_zero in different places like re-broadcast queue or aggregation queue management. There are

Re: [PATCH 1/3] module: deal with alignment issues in built-in module versions

2011-02-17 Thread David Miller
From: Linus Torvalds torva...@linux-foundation.org Date: Thu, 17 Feb 2011 10:06:40 -0800 David, why are you saying that regular just mark the structure alignment correctly doesn't work? Because it's been proven to not work: http://marc.info/?l=linux-kernelm=129674396021733w=2

Re: [PATCH 1/3] module: deal with alignment issues in built-in module versions

2011-02-17 Thread David Miller
From: Linus Torvalds torva...@linux-foundation.org Date: Thu, 17 Feb 2011 13:11:56 -0800 EVERY SINGLE OF YOUR ARGUMENTS WORK FOR pointer TOO! It at least will not happen at the current time, because GCC only plays these games on aggregates. Also, for exception tables, we've avoided this

Re: [PATCH 1/3] module: deal with alignment issues in built-in module versions

2011-02-17 Thread David Miller
From: Linus Torvalds torva...@linux-foundation.org Date: Thu, 17 Feb 2011 13:54:57 -0800 Is there a -fdata-align or something? Or would __attribute__((packed)) help? Something that explicitly tells gcc don't do this, instead of let's add indirection and hope gcc doesn't add alignment for

Re: [PATCH 1/3] module: deal with alignment issues in built-in module versions

2011-02-17 Thread David Miller
From: Dmitry Torokhov d...@vmware.com Date: Thu, 17 Feb 2011 14:19:57 -0800 Any pointers as to how to emit these pointers with asm? .sectionFOO_SECTION, a .align SIZEOF_POINTER .{,x}word POINTER .previous Where FOO_SECTION is your special

Re: [PATCH 1/3] module: deal with alignment issues in built-in module versions

2011-02-17 Thread David Miller
From: Linus Torvalds torva...@linux-foundation.org Date: Thu, 17 Feb 2011 15:08:52 -0800 Where in gcc is the alignment expansion logic? I'd like to see what the rules are, just for my own perverse satisfaction. The magic that overrides the alignment various cases is in the x86 specific code:

Re: Early crash

2011-02-07 Thread David Miller
From: Dmitry Torokhov d...@vmware.com Date: Mon, 7 Feb 2011 00:19:33 -0800 So here is the patch that explicitly specifies alignment for struct module_version_attribute. I tested it on i386 and x86_64 and I believe it will fix the issue with m68k but I do not have access to such a box. While

Re: Early crash

2011-02-07 Thread David Miller
From: Dmitry Torokhov d...@vmware.com Date: Mon, 7 Feb 2011 08:58:29 -0800 But, theoretically speaking, nothing stops GCC to align pointers with gaps as well? Let's say having everything (or some) aligned on quadword boundary even though arch is 32 bit? The alignment business only applies to

Re: Early crash

2011-02-07 Thread David Miller
From: Rusty Russell ru...@rustcorp.com.au Date: Tue, 8 Feb 2011 13:42:48 +1030 But OTOH, this is an old problem which was faced by module params since pre-git. And we use the-align-to-void*-size method there; I vaguely recall inserting it. You've now got me wondering whether these

Re: [PATCH 4/4] m68k/atari: ARAnyM - Add support for network access

2011-02-06 Thread David Miller
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Sun, 6 Feb 2011 11:51:09 +0100 + dev-trans_start = jiffies; Device drivers no longer make this operation, the generic code does it (see net/core/dev.c:dev_hard_start_xmit() and how it invokes txq_trans_update() on -ndo_start_xmit()

Re: [PATCH] net: atarilance - flags should be unsigned long

2010-10-28 Thread David Miller
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Thu, 28 Oct 2010 20:31:53 +0200 (CEST) drivers/net/atarilance.c: In function ‘addr_accessible’: drivers/net/atarilance.c:413: warning: comparison of distinct pointer types lacks a cast drivers/net/atarilance.c:450: warning: comparison of

Re: [PATCH] net/m68k: Hydra Ethernet - print whole resource instead of start address

2010-08-30 Thread David Miller
From: Geert Uytterhoeven ge...@linux-m68k.org Date: Mon, 30 Aug 2010 09:43:46 +0200 (CEST) resource_size_t changed from `unsigned long' to `phys_addr_t`, which is either `u32' or `u64'. Print the whole resource to remove the cast and to make it future-proof. Signed-off-by: Geert

Re: [PATCH 1/2] mac8390: propagate error code from request_irq

2010-06-02 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Tue, 1 Jun 2010 22:18:32 +1000 (EST) Use the request_irq() error code as the return value for mac8390_open(). EAGAIN doesn't make sense for Nubus slot IRQs. Only this driver can claim this IRQ (until the NIC is removed, which means

Re: [PATCH 2/2] mac8390: raise error logging priority

2010-06-02 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Tue, 1 Jun 2010 22:18:56 +1000 (EST) Log error conditions using KERN_ERR priority. Signed-off-by: Finn Thain fth...@telegraphics.com.au Applied, thank you. -- To unsubscribe from this list: send the line unsubscribe linux-m68k in the body of

Re: [PATCH] mac8390: change an error return code and some cleanup, take 4

2010-05-31 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Sat, 29 May 2010 03:29:01 +1000 (EST) @@ -662,7 +665,7 @@ static void mac8390_no_reset(struct net_ { ei_status.txing = 0; if (ei_debug 1) - pr_info(reset not supported\n); + printk(KERN_DEBUG

Re: [PATCH] mac8390: change an error return code and some cleanup, take 4

2010-05-31 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Mon, 31 May 2010 22:55:23 +1000 (EST) if (ei_debug) pr_debug(...) OR if (ei_debug) pr_info(...) Well for the printk in question, it's telling the user that a certain feature can't be enabled. And if the driver has an

Re: [PATCH] mac8390: change an error return code and some cleanup, take 4

2010-05-31 Thread David Miller
From: Joe Perches j...@perches.com Date: Mon, 31 May 2010 08:08:13 -0700 There are many uses of KERN_DEBUG that are reasonable to have always enabled. Doubtful. pr_debug() makes a ton of sense as currently implemented. It's for messages that we want both compile time and run-time control

Re: [PATCH] mac8390: change an error return code and some cleanup, take 3

2010-04-21 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Sat, 17 Apr 2010 13:16:04 +1000 (EST) Change an error return code from -EAGAIN to -EBUSY since the former is misleading. Nubus slots are geographically addressed and their irqs are equally inflexible. -EAGAIN is misleading because

Re: [PATCH] mac8390: fix pr_info() calls and change return code

2010-04-16 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Fri, 16 Apr 2010 23:57:34 +1000 (EST) On Thu, 15 Apr 2010, Joe Perches wrote: ...Why is it better to use -EBUSY? Nubus slots are geographically addressed and their irqs are equally inflexible. -EAGAIN is misleading because retrying will

Re: [PATCH] mac8390: fix pr_info() calls and change return code

2010-04-15 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Fri, 16 Apr 2010 14:21:00 +1000 (EST) @@ -668,11 +668,11 @@ { unsigned char *target = nubus_slot_addr(IRQ2SLOT(dev-irq)); if (ei_debug 1) - pr_info(Need to reset the NS8390 t=%lu..., jiffies); +

Re: sys_recvmmsg: wire up or not?

2010-01-13 Thread David Miller
From: Benjamin Herrenschmidt b...@kernel.crashing.org Date: Thu, 14 Jan 2010 15:20:33 +1100 Anything happening here ? We're getting that warning on ppc too despite the fact that we use socketcall like x86... Should checksyscall be made smarter or the syscall just removed from x86 ? :-) I

Re: [PATCH] mac_esp: fix PIO mode

2009-12-02 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Mon, 23 Nov 2009 14:57:42 +1100 (EST) The mac_esp PIO algorithm no longer works in 2.6.31 and crashes my Centris 660av. So here's a better one. One of the SCSI drives I tested still doesn't like the PIO mode and fails with esp: esp0:

Re: [PATCH] net: fix hydra printk format warning

2009-09-07 Thread David Miller
From: Randy Dunlap randy.dun...@oracle.com Date: Fri, 4 Sep 2009 17:20:37 -0700 From: Randy Dunlap randy.dun...@oracle.com m68k: drivers/net/hydra.c:178: warning: format '%08lx' expects type 'long unsigned int', but argument 3 has type 'resource_size_t' Signed-off-by: Randy Dunlap

Re: [PATCH] mac8390: fix build with NET_POLL_CONTROLLER

2009-05-29 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Thu, 28 May 2009 22:05:53 +1000 (EST) --- linux-2.6.29.orig/drivers/net/Makefile2009-05-28 15:15:13.0 +1000 +++ linux-2.6.29/drivers/net/Makefile 2009-05-28 15:15:54.0 +1000 @@ -489,7 +489,7 @@ .ndo_set_mac_address

Re: [PATCH] mac8390: use printk MAC address format

2009-05-29 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Tue, 26 May 2009 12:52:47 +1000 (EST) mac8390: use printk MAC address format Signed-off-by: Finn Thain fth...@telegraphics.com.au Applied to net-next-2.6, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-m68k in the

Re: [PATCH] mac8390: fix regression caused during net_device_ops conversion, take 2

2009-05-27 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Thu, 28 May 2009 15:26:43 +1000 (EST) Changeset ca17584bf2ad1b1e37a5c0e4386728cc5fc9dabc broke mac8390 by adding 8390.o to the link. That meant that lib8390.c was included twice, once in mac8390.c and once in 8390.c, subject to different

Re: [PATCH] mac8390: fix regression caused during net_device_ops conversion

2009-05-25 Thread David Miller
You need to post networking patches at least cc:'d to net...@vger.kernel.org so that they get properly tracked at: http://patchwork.ozlabs.org/project/netdev/list/ otherwise your patches may (read as: will) get lost. Thank you. -- To unsubscribe from this list: send the line

Re: [PATCH] mac8390: fix regression caused during net_device_ops conversion

2009-05-25 Thread David Miller
From: Finn Thain fth...@telegraphics.com.au Date: Tue, 26 May 2009 12:50:12 +1000 (EST) Changeset ca17584bf2ad1b1e37a5c0e4386728cc5fc9dabc broke mac8390 by adding 8390.o to the link. That meant that lib8390.c was included twice, once in mac8390.c and once in 8390.c, subject to different

Re: [PATCH 1/6] ariadne: convert to net_device_ops

2009-04-11 Thread David Miller
From: Alexander Beregalov a.berega...@gmail.com Date: Fri, 10 Apr 2009 07:24:07 +0400 Signed-off-by: Alexander Beregalov a.berega...@gmail.com Applied. -- To unsubscribe from this list: send the line unsubscribe linux-m68k in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/6] ariadne: convert to net_device_ops

2009-04-11 Thread David Miller
From: Alexander Beregalov a.berega...@gmail.com Date: Fri, 10 Apr 2009 21:59:24 +0400 On Fri, Apr 10, 2009 at 06:13:54PM +0200, Jan Ceuleers wrote: Alexander Beregalov wrote: Signed-off-by: Alexander Beregalov a.berega...@gmail.com ... @@ -197,13 +209,8 @@ static int __devinit

Re: Conversion of old Amiga NCR53C9x drivers to esp_scsi

2008-11-24 Thread David Miller
From: Kars de Jong [EMAIL PROTECTED] Date: Mon, 24 Nov 2008 22:01:50 +0100 What is the way to go? Revive the glue named drivers/scsi/blz1230.c? Or should it be renamed? Some of the other drivers may be a little more problematic because they had more driver operations which are not present

Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers

2008-01-04 Thread David Miller
From: Finn Thain [EMAIL PROTECTED] Date: Fri, 4 Jan 2008 22:05:20 +1100 (EST) I have a partially written replacement for mac_esp. Unlike the other NCR53C9x drivers it needs PIO or pseudo DMA depending on the machine -- so it is not as straight-forward as jazz_esp. The new esp_scsi core

Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers

2008-01-03 Thread David Miller
From: Geert Uytterhoeven [EMAIL PROTECTED] Date: Thu, 3 Jan 2008 20:05:27 +0100 (CET) On Thu, 3 Jan 2008, James Bottomley wrote: On Thu, 2008-01-03 at 17:40 +0200, Boaz Harrosh wrote: As recommended by Christoph Hellwig. There is no use of Fixing these drivers, since there is a much

Re: [PATCH 09/10] Change table chaining layout

2007-10-22 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Mon, 22 Oct 2007 14:47:38 -0700 (PDT) On Mon, 22 Oct 2007, Alan Cox wrote: Still doesn't answer the rather more important question - why not just stick a NULL on the end instead of all the nutty hacks ? You still do need one bit for the

Re: [PATCH] cg3/bw2: add Sun3/Sun3x support

2007-04-03 Thread David Miller
From: Sam Creasey [EMAIL PROTECTED] Date: Tue, 3 Apr 2007 10:32:35 -0400 This patch (re) introduces support for the CG3 driver on Sun3, and for BW2 on Sun3x. It applies cleanly to both the m68k CVS tree and the vanilla tree. Signed-off-by: Sam Creasey [EMAIL PROTECTED] If you guys want to

Re: [PATCH] cg3/bw2: add Sun3/Sun3x support

2007-04-03 Thread David Miller
From: Brad Boyer [EMAIL PROTECTED] Date: Tue, 3 Apr 2007 13:18:25 -0700 I don't know if the powerpc and sparc code are similar enough to have an exact shared version that would make everyone happy, but it might be worth investigating to save all of us some pain. A quick look at the sparc