Re: [PATCH v5 13/25] m68k: add asm/syscall.h

2018-12-10 Thread Geert Uytterhoeven
Hi Dmitry, On Mon, Dec 10, 2018 at 1:41 PM Dmitry V. Levin wrote: > On Mon, Dec 10, 2018 at 09:45:42AM +0100, Geert Uytterhoeven wrote: > > On Mon, Dec 10, 2018 at 5:30 AM Dmitry V. Levin wrote: > > > syscall_get_* functions are required to be implemented on all > >

Re: [PATCH v5 13/25] m68k: add asm/syscall.h

2018-12-10 Thread Geert Uytterhoeven
lementing all 5 syscall_get_* > functions as documented in asm-generic/syscall.h: syscall_get_nr, > syscall_get_arguments, syscall_get_error, syscall_get_return_value, > and syscall_get_arch. > > Cc: Geert Uytterhoeven > Cc: Oleg Nesterov > Cc: Andy Lutomirski > Cc: Elvira Khab

Re: [PATCH v3] m68k: Fix memblock-related crashes

2018-12-08 Thread Geert Uytterhoeven
Hi Mike, On Fri, Dec 7, 2018 at 10:02 PM Mike Rapoport wrote: > On Fri, Dec 07, 2018 at 05:50:11PM +0100, Geert Uytterhoeven wrote: > > Sun-3 must be broken before this fix, as it fills in m68k_memory[0] in > > config_sun3(), i.e. after m68k_parse_bootinfo(). > > Sun-3 is

[PATCH v3] m68k: Fix memblock-related crashes

2018-12-07 Thread Geert Uytterhoeven
bootinfo() ignores all but the first memory chunk. Fix this by moving the calls to memblock_add() from m68k_parse_bootinfo() to paging_init(), after all ignored memory chunks have been removed from m68k_memory[]. Reported-by: Andreas Schwab Fixes: 1008a11590b966b4 ("m68k: switch to MEMBLOCK + N

[PATCH v2] m68k: Fix crash in free_all_bootmem()

2018-12-04 Thread Geert Uytterhoeven
s, Zorro II RAM is ignored, and removed from the m68k_memory[] array. Fix this as well. Reported-by: Andreas Schwab Suggested-by: Mike Rapoport Tested-by: Michael Schmitz Fixes: 1008a11590b966b4 ("m68k: switch to MEMBLOCK + NO_BOOTMEM") Signed-off-by: Geert Uytterhoeven --- The Amiga

[PATCH] m68k: Fix crash in free_all_bootmem()

2018-12-04 Thread Geert Uytterhoeven
s, Zorro II RAM is ignored, and removed from the m68k_memory[] array. Fix this as well. Reported-by: Andreas Schwab Suggested-by: Mike Rapoport Tested-by: Michael Schmitz Fixes: 1008a11590b966b4 ("m68k: switch to MEMBLOCK + NO_BOOTMEM") Signed-off-by: Geert Uytterhoeven --- The Amig

Re: [PATCH] m68k: Fix crash in free_all_bootmem()

2018-12-04 Thread Geert Uytterhoeven
On Tue, Dec 4, 2018 at 2:15 PM Geert Uytterhoeven wrote: > When running the kernel in Fast RAM on Atari: > > Ignoring memory chunk at 0x0:0xe0 before the first chunk > ... > --- > The Amiga part is untested. Oops, not even compile-tested... /me hides in a brow

[PATCH] m68k: Fix crash in free_all_bootmem()

2018-12-04 Thread Geert Uytterhoeven
s, Zorro II RAM is ignored, and removed from the m68k_memory[] array. Fix this as well. Reported-by: Andreas Schwab Suggested-by: Mike Rapoport Tested-by: Michael Schmitz Fixes: 1008a11590b966b4 ("m68k: switch to MEMBLOCK + NO_BOOTMEM") Signed-off-by: Geert Uytterhoeven --- The Amig

Re: [PATCH v5 0/3] m68k: system call table generation support

2018-12-04 Thread Geert Uytterhoeven
nsertions(+), 768 deletions(-) > create mode 100644 arch/m68k/kernel/syscalls/Makefile > create mode 100644 arch/m68k/kernel/syscalls/syscall.tbl > create mode 100644 arch/m68k/kernel/syscalls/syscallhdr.sh > create mode 100644 arch/m68k/kernel/syscalls/syscalltbl.sh Thanks, applied and

Re: [PATCH v5 2/3] m68k: add system call table generation support

2018-12-03 Thread Geert Uytterhoeven
Hi Firoz, On Tue, Dec 4, 2018 at 4:22 AM Firoz Khan wrote: > On Sun, 2 Dec 2018 at 19:27, Geert Uytterhoeven wrote: > > On Tue, Nov 13, 2018 at 7:01 AM Firoz Khan wrote: > > > The system call tables are in different format in all > > > architecture and it will b

Re: [PATCH] m68k: remove redundant 'default n' from Kconfig

2018-12-03 Thread Geert Uytterhoeven
ople that a bare 'default n' is > redundant. > ... > > Signed-off-by: Bartlomiej Zolnierkiewicz Reviewed-by: Geert Uytterhoeven I.e., applied and queued for v4.21. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

Re: [PATCH] m68k: Unroll raw_outsb() loop

2018-12-03 Thread Geert Uytterhoeven
n PIO mode by 5% or 10%. (The DMA controller on the 840av/660av models is > still unsupported so PIO transfers are used.) > > Tested-by: Stan Johnson > Signed-off-by: Finn Thain Reviewed-by: Geert Uytterhoeven I.e., applied and queued for v4.21. Gr{oetje,eeting}s,

Re: m68k-v4.19 crashes in free_all_bootmem

2018-12-02 Thread Geert Uytterhoeven
8k_memory[i].size; + memblock_remove(m68k_memory[i].addr, + m68k_memory[i].size); m68k_num_memory--; for (j = i; j < m68k_num_memory; j++) m68k_memory[j] = m68k_mem

Re: [PATCH v2 06/15] m68k: define syscall_get_arch()

2018-12-02 Thread Geert Uytterhoeven
Hi Dmitry, On Mon, Dec 3, 2018 at 1:24 AM Dmitry V. Levin wrote: > On Sun, Dec 02, 2018 at 11:29:10AM +0100, Geert Uytterhoeven wrote: > > On Tue, Nov 20, 2018 at 1:15 AM Dmitry V. Levin wrote: > > > syscall_get_arch() is required to be implemented on all architectures > &

Re: [PATCH v5 2/3] m68k: add system call table generation support

2018-12-02 Thread Geert Uytterhoeven
> + printf "\n" > + printf "#endif /* %s */" "${fileguard}" The above line is lacking a "\n", causing: ./arch/m68k/include/generated/uapi/asm/unistd_32.h:370:42: warning: no newline at end of file Changing it to

Re: [PATCH v2 06/15] m68k: define syscall_get_arch()

2018-12-02 Thread Geert Uytterhoeven
Hi Dmitry, On Tue, Nov 20, 2018 at 1:15 AM Dmitry V. Levin wrote: > syscall_get_arch() is required to be implemented on all architectures > in order to extend the generic ptrace API with PTRACE_GET_SYSCALL_INFO > request. > > Signed-off-by: Dmitry V. Levin Reviewed-by: Gee

Re: m68k-v4.19 crashes in free_all_bootmem

2018-12-02 Thread Geert Uytterhoeven
> > [0.00] Built 1 zonelists, mobility grouping off. Total pages: 3549 > > Only a single memory chunk (ST-RAM), and kernel loaded there. Same here. The only memory-related option I have in my ARAnyM config is FastRAM = 256 and that works. Andreas: can you please share your AR

Re: [PATCH v5 20/21] m68k/mac: Switch to use %ptR

2018-12-02 Thread Geert Uytterhoeven
On Thu, Nov 29, 2018 at 12:04 PM Andy Shevchenko wrote: > Use %ptR instead of open coded variant to print content of > struct rtc_time in human readable format. > > Cc: Geert Uytterhoeven > Cc: linux-m68k > Signed-off-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeve

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-12-01 Thread Geert Uytterhoeven
, though; such bugs will be fixed more quickly if any interested | parties submit patches to that effect. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I

Re: [PATCH v4 20/21] mk68/mac: Switch to use %ptR

2018-11-29 Thread Geert Uytterhoeven
CC linux-m68k (now for real, stumbling to Senseo machine) On Wed, Nov 28, 2018 at 8:07 PM Andy Shevchenko wrote: > > Use %ptR instead of open coded variant to print content of > struct rtc_time in human readable format. > > Cc: Geert Uytterhoeven > Signed-off-by: Andy Shevche

Re: [RFC PATCH v2 09/14] m68k: hp300: Remove hp300_gettimeoffset()

2018-11-21 Thread Geert Uytterhoeven
Hi Finn, On Wed, Nov 21, 2018 at 10:47 AM Finn Thain wrote: > On Wed, 21 Nov 2018, Geert Uytterhoeven wrote: > > The 8520 CIA is almost identical to the 6526 CIA, as used in the C64... > > The 6526 CIA datasheet says, "In continuous mode, the timer will count > from th

Re: [RFC PATCH v2 09/14] m68k: hp300: Remove hp300_gettimeoffset()

2018-11-21 Thread Geert Uytterhoeven
Hi Finn, On Wed, Nov 21, 2018 at 9:41 AM Finn Thain wrote: > On Wed, 21 Nov 2018, Geert Uytterhoeven wrote: > > On Wed, Nov 21, 2018 at 12:13 AM Finn Thain > > wrote: > > > On atari, the 68901 counts down to 0x01 and raises an interrupt. On > > > mac, the 6522

Re: [RFC PATCH v2 09/14] m68k: hp300: Remove hp300_gettimeoffset()

2018-11-21 Thread Geert Uytterhoeven
ends on the video mode, and thus can't be used as a monotonic clock source. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking

Re: [RFC PATCH v2 07/14] m68k: atari: Convert to clocksource API

2018-11-20 Thread Geert Uytterhoeven
or use as an RTC. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" o

Re: m68k using deprecated internal APIs?

2018-11-18 Thread Geert Uytterhoeven
Hi Linus, On Fri, Nov 16, 2018 at 10:33 PM Linus Walleij wrote: > On Fri, Nov 16, 2018 at 8:44 PM Geert Uytterhoeven > wrote: > > On Fri, Nov 16, 2018 at 12:13 PM Linus Walleij > > wrote: > > > I mean that whole thing should go away by abstracting those LEDs >

Re: m68k using deprecated internal APIs?

2018-11-16 Thread Geert Uytterhoeven
ith struct led_classdev is probably doable. Going for the full monty, using leds-gpio, probably requires moving m68k to DT. Which would not be that ... uninteresting ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux

Re: [RFC PATCH 01/13] arm: Fix mutual exclusion in arch_gettimeoffset

2018-11-14 Thread Geert Uytterhoeven
rdware from the kernel" (https://lwn.net/Articles/769468/). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Re: [RFC PATCH 07/13] m68k: amiga: Convert to clocksource API

2018-11-12 Thread Geert Uytterhoeven
fset = 1; > + offset = jiffy_ticks; > > local_irq_restore(flags); > > ticks = jiffy_ticks - ticks; > - ticks = (1 * ticks) / jiffy_ticks; > > - return (ticks + offset) * 1000; > + return clk_total + ticks

Re: [RFC PATCH 06/13] m68k: Drop ARCH_USES_GETTIMEOFFSET

2018-11-12 Thread Geert Uytterhoeven
called' warnings? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

[PATCH] m68k/defconfig: Update defconfigs for v4.20-rc1

2018-11-05 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- arch/m68k/configs/amiga_defconfig| 4 arch/m68k/configs/apollo_defconfig | 4 arch/m68k/configs/atari_defconfig| 4 arch/m68k/configs/bvme6000_defconfig | 4 arch/m68k/configs/hp300_defconfig| 4 arch/m68k/configs

[git pull] m68k updates for 4.20

2018-10-28 Thread Geert Uytterhoeven
Руслан Исаев (1): m68k/sun3: Remove is_medusa and m68k_pgtable_cachemode arch/m68k/emu/nfeth.c| 4 arch/m68k/kernel/sun3-head.S | 6 -- 2 files changed, 10 deletions(-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's

Re: m68k using deprecated internal APIs?

2018-10-28 Thread Geert Uytterhoeven
[ Wow, I hadn't expected such a heated discussion, I just wanted to know which code needed fixes... ] On Sun, Oct 28, 2018 at 8:00 AM Finn Thain wrote: > On Sat, 27 Oct 2018, Arnd Bergmann wrote: > > On Sat, Oct 27, 2018 at 5:02 PM Geert Uytterhoeven > > wrote: > > >

m68k using deprecated internal APIs?

2018-10-27 Thread Geert Uytterhoeven
d supporting m68k a long time ago ;-) Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just s

Re: [PATCH v4 0/4] m68k: system call table generation support

2018-10-27 Thread Geert Uytterhoeven
ase tell the audience what has been changed in v4? When posting a new version of a patch or patch series, it is a good idea to include a changelog in the cover letter and/or patches. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge

Re: [PATCH] ata: add Buddha PATA controller driver

2018-10-18 Thread Geert Uytterhoeven
antiate 2 Buddha IDE cells, the Catweasel MFD driver can instantiate 3 Buddha IDE cells and a Catweasel floppy cell, and the X-Surf MFD driver can instantiate 2 Buddha IDE cells and a zorro8390 cell. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyon

Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines

2018-10-14 Thread Geert Uytterhoeven
; +++ b/drivers/scsi/Kconfig > @@ -42,6 +42,10 @@ config SCSI_DMA > bool > default n > > +config SCSI_ESP_PIO > + bool > + default n "default n" is the default, so please drop this line. Gr{oetje,eeting}s, G

Re: [PATCH v2 1/6] zorro_esp: Limit DMA transfers to 65535 bytes

2018-10-14 Thread Geert Uytterhoeven
gt;> 16) & 0xff, ESP_TCHI); Since all these sub-drivers seem to support 24-bit transfers, perhaps this is something to be fixed in the esp_scsi core? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Re: [PATCH v2 2/6] esp_scsi: Track residual for PIO transfers

2018-10-14 Thread Geert Uytterhoeven
> +++ b/drivers/scsi/esp_scsi.h > @@ -540,6 +540,8 @@ struct esp { > > void*dma; > int dmarev; > + > + int send_cmd_residual; unsigned int? Gr{oetje,eeting}s, Geer

Re: [PATCH v6 2/2] block: add overflow checks for Amiga partition support

2018-10-14 Thread Geert Uytterhoeven
ount. > - warn if partition CylBlocks larger than what's stored in the RDSK header. > - bail out if we were to overflow sector_t (32 or 64 bit). > > Changes from v1: > > Kars de Jong: > - use defines for magic offsets in DosEnvec struct > > Geert Uytterhoeven: > - use u6

Re: [PATCH v5 1/2] block: fix signed int overflow in Amiga partition support

2018-10-13 Thread Geert Uytterhoeven
Hi Michael, On Sat, Oct 13, 2018 at 4:46 AM Michael Schmitz wrote: > Am 12.10.2018 um 21:59 schrieb Geert Uytterhoeven: > >> Changes from v4: > >> > >> Andreas Schwab: > >> - correct cast to sector_t in sector address calculations > &

Re: [PATCH v5 2/2] block: add overflow checks for Amiga partition support

2018-10-13 Thread Geert Uytterhoeven
Hi Michael, On Sat, Oct 13, 2018 at 4:23 AM Michael Schmitz wrote: > Am 12.10.2018 um 21:54 schrieb Geert Uytterhoeven: > > Thanks for being persistent! > > > > BTW, there's another possible overflow in "blk *= blksize", but that one > > is very unlikely t

Re: [PATCH v5 1/2] block: fix signed int overflow in Amiga partition support

2018-10-12 Thread Geert Uytterhoeven
start_sect = (sector_t) be32_to_cpu(pb->pb_Environment[9]) * ... but not here? > be32_to_cpu(pb->pb_Environment[3]) * > be32_to_cpu(pb->pb_Environment[5]) * > blksize; Gr{oetje,eeting}s,

Re: [PATCH v5 2/2] block: add overflow checks for Amiga partition support

2018-10-12 Thread Geert Uytterhoeven
s, _sect)) { > + pr_err("Dev %s: partition %u (%llu-%llu) needs LBD > device support, skipping partition!\n", > + bdevname(state->bdev, b), part, > + start_sect, (u64) end_sect); The cast to u64

Re: [PATCH v3 03/24] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-10-09 Thread Geert Uytterhoeven
Hi Bart, CC debian-68k, linux-m68k On Tue, Oct 9, 2018 at 5:00 PM Bart Van Assche wrote: > On Tue, 2018-10-09 at 13:51 +, Christophe Leroy wrote: > > _PAGE_WRITETHRU is a target specific flag. Prefer generic functions. > > > > Acked-by: Geert Uytterhoeven > >

Re: [PATCH 1/7] macintosh: Use common code to access RTC

2018-10-04 Thread Geert Uytterhoeven
the problematic WARN_ON which was introduced in commit 22db552b50fa > ("powerpc/powermac: Fix rtc read/write functions"). > > Tested-by: Stan Johnson > Signed-off-by: Finn Thain Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterh

Re: m68k allmodconfig build errors

2018-09-27 Thread Geert Uytterhoeven
cause overflows, if the rest of the DM code > and the block layer code limit disk utilization to what can be > represented by 32 bit sector_t? I'm not positive about that. Needs more investigation. Or perhaps the DM people just know. > On Wed, Sep 26, 2018 at 8:56 PM, Geert Uytterhoeven &

Re: m68k allmodconfig build errors

2018-09-26 Thread Geert Uytterhoeven
Hi Michael, On Wed, Sep 26, 2018 at 10:49 AM Geert Uytterhoeven wrote: > On Wed, Sep 26, 2018 at 10:34 AM Geert Uytterhoeven > wrote: > > On Tue, Sep 25, 2018 at 10:47 PM Michael Schmitz > > wrote: > > > It's not just me - this happens when building without LBD

Re: m68k allmodconfig build errors

2018-09-26 Thread Geert Uytterhoeven
On Wed, Sep 26, 2018 at 10:34 AM Geert Uytterhoeven wrote: > On Tue, Sep 25, 2018 at 10:47 PM Michael Schmitz wrote: > > It's not just me - this happens when building without LBD support: > > > > ERROR: "__udivdi3" [drivers/md/dm-thin-pool.ko] undefined! > >

Re: m68k allmodconfig build errors

2018-09-26 Thread Geert Uytterhoeven
D support being > enabled... > > This is with gcc 8.10 from kernel.org, FWIW. I can reproduce that with other compilers as well. Will send a fix. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversat

Re: m68k allmodconfig build errors

2018-09-26 Thread Geert Uytterhoeven
are. Isn't gcc-8 just assuming that any char array must contain a valid NUL-terminated string, unless it is tagged with the nonstring attribute? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In pers

Re: [PATCH 0/7] Remove errors building drivers/DRIVERNAME

2018-09-26 Thread Geert Uytterhoeven
TEST for that. If you want to increase compile coverage, please look into adding "|| COMPILE_TEST" dependencies to subsystems and drivers that still lack it, and (if needed) modifying the code to make the result build. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterh

Re: m68k allmodconfig build errors

2018-09-25 Thread Geert Uytterhoeven
t; gcc 4.6.3, and lack __udivdi3 support, or new and shiny 8.10 with its > strncmp mess. You're not supposed to do 64-bit divisions in the kernel, except using do_div() and the other helpers in include/linux/math64.h and include/asm-generic/div64.h. Gr{oetje,eeting}s, G

Re: [PATCH v2 0/5] System call table generation support

2018-09-24 Thread Geert Uytterhoeven
--- > 12 files changed, 502 insertions(+), 790 deletions(-) > create mode 100644 arch/m68k/kernel/syscall_table.S > create mode 100644 arch/m68k/kernel/syscalls/Makefile > create mode 100644 arch/m68k/kernel/syscalls/syscall.tbl > create mode 100644 arch/m68

Re: [PATCH v2 5/5] m68k: added __IGNORE* entries in asm/unistd.h

2018-09-24 Thread Geert Uytterhoeven
must > hold information only useful for user space applications. > > Signed-off-by: Firoz Khan Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations

Re: [PATCH v2 4/5] m68k: uapi header and system call table file generation

2018-09-24 Thread Geert Uytterhoeven
nclude/uapi/asm/Kbuild > +++ b/arch/m68k/include/uapi/asm/Kbuild > @@ -21,3 +21,4 @@ generic-y += statfs.h > generic-y += termbits.h > generic-y += termios.h > generic-y += types.h > +generic-y += unistd_32.h > \ No newline at end of file Likewise. Gr{oetje,eeting}s,

Re: [PATCH v2 3/5] m68k: Added system call table generation support

2018-09-24 Thread Geert Uytterhoeven
common restart_syscall sys_restart_syscall Why the indentation by an "odd" number of spaces, instead of TABs? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

Re: [PATCH v2 2/5] m68k: Replace NR_syscalls macro from asm/unistd.h

2018-09-24 Thread Geert Uytterhoeven
On Thu, Sep 20, 2018 at 5:06 PM Firoz Khan wrote: > 1. Update NR_syscalls in asm/unistd.h manually by counting the >no.of system calls. No need to update NR_syscalls untill until (scripts/checkpatch.pl would have told you) Gr{oetje,eeting}s, Geert --

Re: [PATCH v2 2/5] m68k: Replace NR_syscalls macro from asm/unistd.h

2018-09-24 Thread Geert Uytterhoeven
istd.h. While __NR_syscalls > isn't strictly part of the uapi, having it as part of the generated > header to simplifies the implementation. So we need to enclose this > macro with #ifdef __KERNEL__ to avoid side effects. > > Signed-off-by: Firoz Khan Reviewed-by: Geert Uytterhoeven Gr{oe

Re: [PATCH v2 1/5] m68k: Rename system call table file name

2018-09-24 Thread Geert Uytterhoeven
g table file. > > In order to come up with a common naming convention across all > architecture, we need to change the file name to syscall_table.S. > This change will unify the implementation across all architecture. > > Signed-off-by: Firoz Khan Reviewed-by: Geert Uy

Re: [PATCH 2/4] m68k: Replace NR_syscalls macro from asm/unistd.h

2018-09-20 Thread Geert Uytterhoeven
Hi Firoz, On Thu, Sep 20, 2018 at 10:12 AM Firoz Khan wrote: > On 18 September 2018 at 15:34, Geert Uytterhoeven > wrote: > > On Tue, Sep 18, 2018 at 9:16 AM Firoz Khan wrote: > >> On 9 August 2018 at 13:00, Geert Uytterhoeven wrote: > >> > One first comm

Re: [PATCH 2/4] m68k: Replace NR_syscalls macro from asm/unistd.h

2018-09-18 Thread Geert Uytterhoeven
Hi Firoz, On Tue, Sep 18, 2018 at 9:16 AM Firoz Khan wrote: > On 9 August 2018 at 13:00, Geert Uytterhoeven wrote: > > One first comment below... > > > > On Thu, Aug 9, 2018 at 7:16 AM Firoz Khan wrote: > >> NR_syscalls macro holds the number of system call e

Re: Build failure with gcc 8.1

2018-09-12 Thread Geert Uytterhoeven
rror 2 > > I've checked with several other configs and it seems that CONFIG_MMU=y and > CONFIG_MMU_MOTOROLA=y are causing the trouble. > > The same configs are buildable with gcc-4.9.0. Please check https://lore.kernel.org/lkml/28ebe45d-3dbd-2a82-f537-b0725f7a2...@infradead.org/ Does th

Re: [PATCH] m68k: fix command-line parsing when passed from u-boot

2018-09-01 Thread Geert Uytterhoeven
init_mm.brk = (unsigned long) 0; > > + command_line[0] = 0; Likewise: char __initdata command_line[COMMAND_LINE_SIZE]; > + > config_BSP(_line[0], sizeof(command_line)); > > #if defined(CONFIG_BOOTPARAM) Gr{oetje,eeting}s, Geert

[git pull] m68k fixes for 4.19

2018-08-31 Thread Geert Uytterhoeven
, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or some

Re: [PATCH] m68k/mac: Use correct PMU response format

2018-08-31 Thread Geert Uytterhoeven
Hi Finn, On Fri, Aug 31, 2018 at 9:12 AM Finn Thain wrote: > On Fri, 31 Aug 2018, Geert Uytterhoeven wrote: > > On Fri, Aug 24, 2018 at 4:02 AM Finn Thain > > wrote: > > > Now that the 68k Mac port has adopted the via-pmu driver, it must decode > > > the P

Re: [PATCH] m68k: Remove is_medusa and m68k_pgtable_cachemode

2018-08-31 Thread Geert Uytterhoeven
e next two. --m > -is_medusa: > -.long 0 > -m68k_pgtable_cachemode: > -.long 0 > - > -- > 2.14.1.windows.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversation

Re: [PATCH] m68k/mac: Use correct PMU response format

2018-08-31 Thread Geert Uytterhoeven
or v4.19. I guess the proper Fixes tag is: Fixes: ebd722275f9cfc67 ("macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver") Can you please confirm? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -

Re: [PATCH v2 3/3] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

2018-08-27 Thread Geert Uytterhoeven
On Mon, Aug 27, 2018 at 6:10 PM Christophe Leroy wrote: > _PAGE_WRITETHRU is a target specific flag. Prefer generic functions. > > Signed-off-by: Christophe Leroy >From a Zorro bus point of view: Acked-by: Geert Uytterhoeven > --- a/drivers/block/z2ram.c > +++ b/dri

Re: [PATCH] Remove reference to long-deprecated MODULE_PARM

2018-08-27 Thread Geert Uytterhoeven
ff-by: Robert P. J. Day Thank you. Will apply and queue for v4.20. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking t

[PATCH] m68k/defconfig: Update defconfigs for v4.19-rc1

2018-08-27 Thread Geert Uytterhoeven
Actual changes: -CONFIG_BATMAN_ADV_DAT=y -CONFIG_NF_CONNTRACK_IPV4=m -CONFIG_NF_CONNTRACK_IPV6=m +CONFIG_CRC64=m +CONFIG_NFT_OSF=m +CONFIG_NFT_TPROXY=m +CONFIG_NFT_TUNNEL=m +CONFIG_TEST_BITFIELD=m +CONFIG_TEST_IDA=m Signed-off-by: Geert Uytterhoeven --- arch

Re: [PATCH] m68k: fix early memory reservation for ColdFire MMU systems

2018-08-21 Thread Geert Uytterhoeven
ix it. Thanks for fixing this! > Signed-off-by: Mike Rapoport > Tested-by: Angelo Dureghello Reviewed-by: Geert Uytterhoeven Greg: Do you plan to take this? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k

Re: [PATCH 2/4] m68k: Replace NR_syscalls macro from asm/unistd.h

2018-08-09 Thread Geert Uytterhoeven
I definitions can never change, while new syscalls will be added in the future, increasing the number ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I ca

[git pull] m68k updates for 4.19

2018-08-08 Thread Geert Uytterhoeven
500 series nubus: Set default dma mask for nubus_board devices Geert Uytterhoeven (6): m68k/io: Add missing ioremap define guards, fix typo net: mac8390: Use standard memcpy_{from,to}io() Input: hilkbd - Add casts to HP9000/300 I/O accessors m68k/io: Move mem*io define

Re: macsonic backtrace with 4.17 in qemu-system

2018-08-01 Thread Geert Uytterhoeven
> macsonic_init+0x6a/0x15a [macsonic] m68k: Set default dma mask for platform devices https://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git/commit/?h=for-4.18=b12c8a70643ffe2598c572cd206e4f68c524eb6f Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- The

Re: [PATCH v4 09/11] macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver

2018-07-30 Thread Geert Uytterhoeven
Hi Michael, On Mon, Jul 30, 2018 at 8:47 AM Michael Ellerman wrote: > Finn Thain writes: > > Now that the PowerMac via-pmu driver supports m68k PowerBooks, > > switch over to that driver and remove the via-pmu68k driver. > > > > Cc: Geert Uytterhoeven > > Te

Re: [PATCH v4 09/11] macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver

2018-07-30 Thread Geert Uytterhoeven
On Mon, Jul 30, 2018 at 9:26 AM Geert Uytterhoeven wrote: > On Mon, Jul 2, 2018 at 10:21 AM Finn Thain wrote: > > Now that the PowerMac via-pmu driver supports m68k PowerBooks, > > switch over to that driver and remove the via-pmu68k driver. > > > > Cc: Geert Uytter

Re: [PATCH v4 09/11] macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver

2018-07-30 Thread Geert Uytterhoeven
On Mon, Jul 2, 2018 at 10:21 AM Finn Thain wrote: > Now that the PowerMac via-pmu driver supports m68k PowerBooks, > switch over to that driver and remove the via-pmu68k driver. > > Cc: Geert Uytterhoeven > Tested-by: Stan Johnson > Signed-off-by: Finn Thain Acked-by: Geert

Re: [PATCH v4 08/11] macintosh/via-pmu68k: Don't load driver on unsupported hardware

2018-07-30 Thread Geert Uytterhoeven
On Mon, Jul 2, 2018 at 10:21 AM Finn Thain wrote: > Don't load the via-pmu68k driver on early PowerBooks. The M50753 PMU > device found in those models was never supported by this driver. > Attempting to load the driver usually causes a boot hang. > > Cc: Geert Uytterhoeven > S

Re: [PATCH] m68k/mac: Rework patch "use time64_t in RTC handling"

2018-07-29 Thread Geert Uytterhoeven
[fthain: Drop the pointless wraparound conditional in via_read_time()] Signed-off-by: Finn Thain Reviewed-by: Arnd Bergmann Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technic

Re: [PATCH] fb: amifb: fix build warnings when not builtin

2018-07-27 Thread Geert Uytterhoeven
Wunused-function] > static void __init amifb_setup_mcap(char *spec) Thanks for your patch! > Signed-off-by: Randy Dunlap Reviewed-by: Geert Uytterhoeven Ideally, amifb_setup() should be called in the modular case, too. But probably nobody cares. > Cc: Geert Uytterhoeve

[PATCH] m68k/defconfig: Update defconfigs for v4.18-rc6

2018-07-24 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- To be merged with "m68k/defconfig: Update defconfigs for v4.18-rc1" --- arch/m68k/configs/amiga_defconfig| 4 +--- arch/m68k/configs/apollo_defconfig | 4 +--- arch/m68k/configs/atari_defconfig| 4 +--- arch/m68k/configs/bvme6000_def

Re: [PATCH 2/3] [v2] m68k: mac: use time64_t in RTC handling

2018-07-23 Thread Geert Uytterhoeven
I'd really like > to resolve this before the merge window opens, since my PMU patch series > is affected. +1. If it's not resolved (a few days) before the merge window opens, I may have to revert the patch instead. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytt

Re: [PATCH v2 0/3] m68k: switch to MEMBLOCK + NO_BOOTMEM

2018-07-18 Thread Geert Uytterhoeven
e it works on Sun 3 too. Thanks a lot, applied and queued for v4.19. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking

Re: [PATCH 0/5] m68k: IO Fixes and Cleanups

2018-07-18 Thread Geert Uytterhoeven
On Tue, Jul 10, 2018 at 3:48 AM Greg Ungerer wrote: > On 09/07/18 19:30, Geert Uytterhoeven wrote: > > This patch series contains fixes and cleanups for I/O accessors on m68k > > platforms (with MMU). > > > > The first patch contains small fixes without any dependencie

Re: [PATCH 2/3] [v2] m68k: mac: use time64_t in RTC handling

2018-07-18 Thread Geert Uytterhoeven
Applied and queued for v4.19, with the WARN_ON() dropped. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journ

Re: [PATCH 3/3] [v2] m68k: remove unused set_clock_mmss() helpers

2018-07-18 Thread Geert Uytterhoeven
t callback, > which are equally unused. > > This removes all of those as well. > > Acked-by: Greg Ungerer > Signed-off-by: Arnd Bergmann Thanks, applied and queued for v4.19. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linu

Re: [PATCH 09/12] nubus: use for_each_if

2018-07-17 Thread Geert Uytterhoeven
mac8390.c:402: error: expected ‘;’ before ‘{’ token Apparently this depends on patch [01/12], which wasn't CCed to linux-m...@lists.linux-m68k.org? Please don't split CCs if all patches in the a series are not independent. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytt

[PATCH 0/5] m68k: IO Fixes and Cleanups

2018-07-09 Thread Geert Uytterhoeven
m68k tree. Thanks! Geert Uytterhoeven (5): m68k/io: Add missing ioremap define guards, fix typo net: mac8390: Use standard memcpy_{from,to}io() Input: hilkbd - Add casts to HP9000/300 I/O accessors m68k/io: Move mem*io define guards to m68k/io: Switch mmu variant to arch/m68k/includ

[PATCH 1/5] m68k/io: Add missing ioremap define guards, fix typo

2018-07-09 Thread Geert Uytterhoeven
("m68k: group io mapping definitions and functions") Signed-off-by: Geert Uytterhoeven --- v2: - Move ARCH_HAS_IOREMAP_WT to fix "ioremap_wt redefined" warnings with m5475evb defconfig. --- arch/m68k/include/asm/io_mm.h | 2 -- arch/m68k/include/asm/kmap.h | 6 +-

[PATCH 5/5] m68k/io: Switch mmu variant to

2018-07-09 Thread Geert Uytterhoeven
The dummy functions defined in can be provided by . As nommu already uses , move its inclusion to , and add/adjust include guards where appropriate. This gets rid of lots of "statement with no effect" and "unused variable" warnings when compile-testing. Signed-off-by

[PATCH 3/5] Input: hilkbd - Add casts to HP9000/300 I/O accessors

2018-07-09 Thread Geert Uytterhoeven
ut}_8(), and convert the passed addresses to pointers internally. However, the asm-generic version of {read,write}b() does not perform such conversions, and requires passing pointers instead. Hence add casts to prepare for switching m68k to the asm-generic version. Signed-off-by

[PATCH 2/5] net: mac8390: Use standard memcpy_{from,to}io()

2018-07-09 Thread Geert Uytterhoeven
The mac8390 driver defines its own variants of memcpy_fromio() and memcpy_toio(), using similar implementations, but different function signatures. Remove the custom definitions of memcpy_fromio() and memcpy_toio(), and adjust all callers to the standard signatures. Signed-off-by: Geert

[PATCH 4/5] m68k/io: Move mem*io define guards to

2018-07-09 Thread Geert Uytterhoeven
The mem*io define guards are applicable to all users of . Hence move them, and drop the #ifdef. Signed-off-by: Geert Uytterhoeven --- To avoid redefined warnings, this depends on "net: mac8390: Use standard memcpy_{from,to}io()". v2: - No changes. --- arch/m68k/include/asm/io

Re: [PATCH 2/3] [v2] m68k: mac: use time64_t in RTC handling

2018-07-08 Thread Geert Uytterhoeven
what Mathieu suggested and kept the > original Mac behavior, but added the WARN_ON(). So, is this safe to apply? Especially in light of the warnings seen by Meelis with the PPC version. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There

Re: [PATCH v2 3/3] m68k: switch to MEMBLOCK + NO_BOOTMEM

2018-07-04 Thread Geert Uytterhoeven
dering if the warning is really that unlikely on systems that support hotremove. Or is it due to the low amount of RAM on m68k boxes? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversation

Re: [PATCH v2 3/3] m68k: switch to MEMBLOCK + NO_BOOTMEM

2018-07-04 Thread Geert Uytterhoeven
Hi Michael, On Wed, Jul 4, 2018 at 9:54 AM Michal Hocko wrote: > On Wed 04-07-18 09:44:14, Geert Uytterhoeven wrote: > [...] > > [ cut here ] > > WARNING: CPU: 0 PID: 0 at mm/memblock.c:230 > > memblock_find_in_range_node+0x11c/0x1be > >

Re: [PATCH v2 3/3] m68k: switch to MEMBLOCK + NO_BOOTMEM

2018-07-04 Thread Geert Uytterhoeven
ax_addr=0x0 _I_CALL_TOP+0x660/0x1900 memblock_reserve: [0x0082c000-0x0084bfff] memblock_virt_alloc_internal+0xe4/0x156 Inode-cache hash table entries: 32768 (order: 5, 131072 bytes) Sorting __ex_table... Memory: 267988K/276480K available (3036K kernel code, 304K rwdata, 792K rodata, 152K init, 168

Re: [PATCH 1/5] m68k/io: Add missing ioremap define guards, fix typo

2018-07-03 Thread Geert Uytterhoeven
Hi Greg, On Tue, Jul 3, 2018 at 4:13 AM Greg Ungerer wrote: > On 02/07/18 23:35, Geert Uytterhoeven wrote: > >- Add missing define guard for ioremap_wt(), > >- Fix typo s/ioremap_fillcache/ioremap_fullcache/, > >- Add define guard for iounmap() for c

Re: [PATCH] block: fix Amiga partition support for disks >= 1 TB

2018-07-03 Thread Geert Uytterhoeven
Hi Michael, On Tue, Jul 3, 2018 at 1:58 AM Michael Schmitz wrote: > On Mon, Jul 2, 2018 at 8:29 PM, Geert Uytterhoeven > wrote: > >> + > >> + /* Warn user if start_sect or nr_sects overflow u32 */ > >> + if ((nr_sects &g

Re: [PATCH] m68k/mac: Enable PDMA for PowerBook 500 series

2018-07-02 Thread Geert Uytterhoeven
tje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.

  1   2   3   4   5   6   7   8   9   10   >