Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

2018-03-23 Thread Philippe Ombredanne
Tejun, On Mon, Mar 19, 2018 at 7:41 AM, Tejun Heo <t...@kernel.org> wrote: > Hello, > > On Sat, Mar 17, 2018 at 10:24:18PM -0700, Philippe Ombredanne wrote: >> > v2: >> > - clarify license version (it should be GPL 2.0) >> > - use SPDX header >> &g

Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

2018-03-17 Thread Philippe Ombredanne
il.com> > Cc: Geert Uytterhoeven <ge...@linux-m68k.org> > Cc: Philippe Ombredanne <pombreda...@nexb.com> > Cc: Andy Shevchenko <andy.shevche...@gmail.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> > --- > v3: > - fix minor is

Re: [PATCH] ata: add Amiga Gayle PATA controller driver

2018-02-12 Thread Philippe Ombredanne
ENSE("GPL"); > +MODULE_ALIAS("platform:amiga-gayle-ide"); > +MODULE_VERSION(DRV_VERSION); > and while doing it please make sure your MODULE_LICENSE matches the license. Here for instance it is not clear to me if this a GPL-2.0 or a GPL-2.0+ Thanks! [1] https://gi

Re: [PATCH v3 14/14] nubus: Add support for the driver model

2017-12-10 Thread Philippe Ombredanne
Finn, On Sun, Dec 10, 2017 at 11:03 AM, Finn Thain <fth...@telegraphics.com.au> wrote: > On Thu, 7 Dec 2017, Philippe Ombredanne wrote: > >> > diff --git a/drivers/nubus/bus.c b/drivers/nubus/bus.c >> > new file mode 100644 >> > index ..b50

Re: [PATCH v3 14/14] nubus: Add support for the driver model

2017-12-07 Thread Philippe Ombredanne
opyright (C) 2017 Finn Thain > + * > + * SPDX-License-Identifier: GPL-2.0 > + */ I think the SPDX id should be on the first line using C++-style // comments. See tglx's doc patches and Linus posts explaining why he wants it this way! -- Cordially Philippe Ombredanne -- To unsubscribe f