Re: [PATCH] net: mac8390 - Sort out memory/MMIO accesses and casts (was: Re: drivers/net/mac8390.c: Remove useless memcpy casting)

2010-06-02 Thread Geert Uytterhoeven
On Sat, May 29, 2010 at 10:03, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Fri, May 28, 2010 at 19:21, Finn Thain fth...@telegraphics.com.au wrote: On Sun, 23 May 2010, Geert Uytterhoeven wrote: But here's a better solution. I do not have the hardware to test it, though. Finn, does it

Re: [PATCH] net: mac8390 - Sort out memory/MMIO accesses and casts (was: Re: drivers/net/mac8390.c: Remove useless memcpy casting)

2010-05-29 Thread Geert Uytterhoeven
On Fri, May 28, 2010 at 19:21, Finn Thain fth...@telegraphics.com.au wrote: On Sun, 23 May 2010, Geert Uytterhoeven wrote: But here's a better solution. I do not have the hardware to test it, though. Finn, does it {look OK,work}? It looks fine. I can't test it right now, but I will do so

Re: [PATCH] net: mac8390 - Sort out memory/MMIO accesses and casts (was: Re: drivers/net/mac8390.c: Remove useless memcpy casting)

2010-05-28 Thread Finn Thain
On Sun, 23 May 2010, Geert Uytterhoeven wrote: But here's a better solution. I do not have the hardware to test it, though. Finn, does it {look OK,work}? It looks fine. I can't test it right now, but I will do so when I get the opportunity. Any news from the test front? This is

Re: [PATCH] net: mac8390 - Sort out memory/MMIO accesses and casts (was: Re: drivers/net/mac8390.c: Remove useless memcpy casting)

2010-04-15 Thread Finn Thain
On Thu, 15 Apr 2010, Geert Uytterhoeven wrote: On Mon, Mar 8, 2010 at 18:16, Joe Perches j...@perches.com wrote: Thanks, I'll submit a patch to fix it by tomorrow or so. It hasn't been fixed yet. Thanks for taking care of this, Geert. But here's a better solution. I do not have the