Re: [PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour

2018-09-18 Thread Dmitry Torokhov
Hi Michael, On Tue, Sep 18, 2018 at 02:03:29PM +1200, Michael Schmitz wrote: > Thanks Dmitry! > > I had asked Andreas' signoff for his keymap fixes only - the rewrite of the > Atari keyboard driver to the current input framework (and hence the CapsLock > toggle bug) was entirely mine, no blame

Re: [PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour

2018-09-17 Thread Michael Schmitz
Thanks Dmitry! I had asked Andreas' signoff for his keymap fixes only - the rewrite of the Atari keyboard driver to the current input framework (and hence the CapsLock toggle bug) was entirely mine, no blame attaches to Andreas there. Cheers,     Michael On 18/09/18 10:36, Dmitry

Re: [PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour

2018-09-17 Thread Dmitry Torokhov
On Mon, Sep 17, 2018 at 10:29:08PM +0200, Andreas Schwab wrote: > On Sep 17 2018, Dmitry Torokhov wrote: > > > On Fri, Sep 07, 2018 at 11:40:43AM +1200, Michael Schmitz wrote: > >> The CapsLock key on Atari keyboards is not a toggle, it does send the > >> normal make and break scancodes. > >> >

Re: [PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour

2018-09-17 Thread Andreas Schwab
On Sep 17 2018, Dmitry Torokhov wrote: > On Fri, Sep 07, 2018 at 11:40:43AM +1200, Michael Schmitz wrote: >> The CapsLock key on Atari keyboards is not a toggle, it does send the >> normal make and break scancodes. >> >> Drop the CapsLock toggle handling code, which did cause the CapsLock >>

Re: [PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour

2018-09-17 Thread Dmitry Torokhov
On Fri, Sep 07, 2018 at 11:40:43AM +1200, Michael Schmitz wrote: > The CapsLock key on Atari keyboards is not a toggle, it does send the > normal make and break scancodes. > > Drop the CapsLock toggle handling code, which did cause the CapsLock > key to merely act as a Shift key. > > Tested-by:

[PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour

2018-09-06 Thread Michael Schmitz
The CapsLock key on Atari keyboards is not a toggle, it does send the normal make and break scancodes. Drop the CapsLock toggle handling code, which did cause the CapsLock key to merely act as a Shift key. Tested-by: Michael Schmitz Signed-off-by: Michael Schmitz ---