Re: [pinctrl:devel 16/46] drivers/pinctrl/bcm/pinctrl-bcm2835.c:995:10: error: incompatible types when assigning to type 'volatile struct SHIFTER' from type 'unsigned int'

2019-08-12 Thread Geert Uytterhoeven
Hi Michael, On Sun, Aug 11, 2019 at 11:13 PM Michael Schmitz wrote: > Leaves the matter of who prepares a patch to atarihw.h and users of that > definition ... At your service... > Am 12.08.19 um 09:01 schrieb Stefan Wahren: > > Am 07.08.19 um 00:41 schrieb Michael Schmitz: > >> could be

Re: [pinctrl:devel 16/46] drivers/pinctrl/bcm/pinctrl-bcm2835.c:995:10: error: incompatible types when assigning to type 'volatile struct SHIFTER' from type 'unsigned int'

2019-08-11 Thread Michael Schmitz
Stefan, considering that such a clash could happen again, it might be prudent to use a less generic name in your driver as well? Leaves the matter of who prepares a patch to atarihw.h and users of that definition ... Cheers,     Michael Am 12.08.19 um 09:01 schrieb Stefan Wahren: > Hi, > > Am

Re: [pinctrl:devel 16/46] drivers/pinctrl/bcm/pinctrl-bcm2835.c:995:10: error: incompatible types when assigning to type 'volatile struct SHIFTER' from type 'unsigned int'

2019-08-11 Thread Stefan Wahren
Hi, Am 07.08.19 um 00:41 schrieb Michael Schmitz: > Hi Geert, > > could be renamed shifter_st, I suppose. Only used in > arch/m68k/atari/config.c and drivers/video/fbdev/atafb.c. looks like you've come to a solution. Is there any action required from my side? Regards Stefan > > Cheers, > >    

Re: [pinctrl:devel 16/46] drivers/pinctrl/bcm/pinctrl-bcm2835.c:995:10: error: incompatible types when assigning to type 'volatile struct SHIFTER' from type 'unsigned int'

2019-08-07 Thread Geert Uytterhoeven
Hi Michael, On Wed, Aug 7, 2019 at 12:41 AM Michael Schmitz wrote: > could be renamed shifter_st, I suppose. Only used in > arch/m68k/atari/config.c and drivers/video/fbdev/atafb.c. Yeah, exactly my thought. > On 6/08/19 7:33 PM, Geert Uytterhoeven wrote: > > CC linux-m68k (shifter too generic

Re: [pinctrl:devel 16/46] drivers/pinctrl/bcm/pinctrl-bcm2835.c:995:10: error: incompatible types when assigning to type 'volatile struct SHIFTER' from type 'unsigned int'

2019-08-06 Thread Michael Schmitz
Hi Geert, could be renamed shifter_st, I suppose. Only used in arch/m68k/atari/config.c and drivers/video/fbdev/atafb.c. Cheers,     Michael On 6/08/19 7:33 PM, Geert Uytterhoeven wrote: CC linux-m68k (shifter too generic a name?) On Tue, Aug 6, 2019 at 5:00 AM kbuild test robot wrote:

Re: [pinctrl:devel 16/46] drivers/pinctrl/bcm/pinctrl-bcm2835.c:995:10: error: incompatible types when assigning to type 'volatile struct SHIFTER' from type 'unsigned int'

2019-08-06 Thread Geert Uytterhoeven
CC linux-m68k (shifter too generic a name?) On Tue, Aug 6, 2019 at 5:00 AM kbuild test robot wrote: > > tree: > https://kernel.googlesource.com/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git > devel > head: d55b7fdd58ac12e76ef65979af4a13b9c15fc00d > commit: