Re: [PATCH v3 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-18 Thread Andrew Lunn
On Wed, Apr 18, 2018 at 05:10:45PM +1200, Michael Schmitz wrote: > All, > > just noticed belatedly that the Makefile hunk of patch 9 does no > longer apply cleanly in 4.17-rc1, sorry. My series was based on 4.16. > I'll resend that one, OK? Hi Michael You should be based on DaveM net-next tree:

[PATCH -next] m68k: fix return value check in mcf_pci_init()

2018-04-18 Thread Wei Yongjun
In case of error, the function ioremap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: bf114d773167 ("m68k: force use of __raw_read/__raw_write address to be iomem") Signed-off-by: Wei Yongjun

Re: [PATCH v3 1/9] net: phy: new Asix Electronics PHY driver

2018-04-18 Thread Andrew Lunn
> + > +/** > + * asix_soft_reset - software reset the PHY via BMCR_RESET bit > + * @phydev: target phy_device struct > + * > + * Description: Perform a software PHY reset using the standard > + * BMCR_RESET bit and poll for the reset bit to be cleared. > + * Toggle BMCR_RESET bit off to accomodate

Re: [PATCH v3 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-18 Thread Michael Schmitz
Hi Finn, thanks for the feedback! On Wed, Apr 18, 2018 at 5:45 PM, Finn Thain wrote: >> > 1/9 net: phy: new Asix Electronics PHY driver >> > 2/9 net: ax88796: Fix MAC address reading >> > 3/9 net: ax88796: Attach MII bus only when open >> > 4/9 net: ax88796: Do not

Re: [PATCH v3 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-18 Thread Michael Schmitz
Hi Andrew, sorry, my mistake. I didn't realize how fast DaveM's tree diverges from Linus' (and Geert's) once the merge window opens. Cheers, Michael On Thu, Apr 19, 2018 at 12:19 AM, Andrew Lunn wrote: > On Wed, Apr 18, 2018 at 05:10:45PM +1200, Michael Schmitz wrote: >>

Re: [PATCH 01/15] m68k: move *_relaxed macros into io_no.h and io_mm.h

2018-04-18 Thread Angelo Dureghello
Hi Greg, On Wed, Apr 18, 2018 at 10:01:34AM +1000, Greg Ungerer wrote: > Hi Angelo, > > On 18/04/18 06:53, Angelo Dureghello wrote: > > thanks for this great job. > > :-) > > > > On patch 10, PIC is PCI, right ? > > Yes, typo on my part. I even managed to get it wrong twice! > I'll fix that.

Re: [PATCH 10/10] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-18 Thread Geert Uytterhoeven
Hi Michael, On Wed, Apr 18, 2018 at 12:35 AM, Michael Schmitz wrote: > On Wed, Apr 18, 2018 at 1:53 AM, Geert Uytterhoeven > wrote: >> On Tue, Apr 17, 2018 at 12:04 AM, Michael Schmitz >> wrote: >>> Add platform device driver

Re: [PATCH v2 02/10] m68k/mac: Fix SWIM memory resource end address

2018-04-18 Thread Geert Uytterhoeven
Hi Finn, On Thu, Apr 12, 2018 at 2:50 AM, Finn Thain wrote: > The resource size is 0x2000 == end - start + 1. > Therefore end == start + 0x2000 - 1. > > Cc: Laurent Vivier > Cc: sta...@vger.kernel.org # v4.14+ > Tested-by: Stan Johnson

[PATCH] m68k/defconfig: Update defconfigs for v4.17-rc1

2018-04-18 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- arch/m68k/configs/amiga_defconfig| 14 +- arch/m68k/configs/apollo_defconfig | 14 +- arch/m68k/configs/atari_defconfig| 14 +- arch/m68k/configs/bvme6000_defconfig | 14 +-

Re: [PATCH v3 1/9] net: phy: new Asix Electronics PHY driver

2018-04-18 Thread John Paul Adrian Glaubitz
On 04/18/2018 06:26 AM, Michael Schmitz wrote: > The Asix Electronics PHY found on the X-Surf 100 Amiga Zorro network > card by Individual Computers is buggy, and needs the reset bit toggled > as workaround to make a PHY soft reset succed. ^^

Re: [PATCH v9] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-18 Thread Martin K. Petersen
Michael, > Anything else needed for linux-scsi? Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v3 1/9] net: phy: new Asix Electronics PHY driver

2018-04-18 Thread Michael Schmitz
Hi Andrew, I agree, that's much better. I had something like that in mind before I got distracted... /me looking for brown paper bag now. Cheers, Michael On Thu, Apr 19, 2018 at 12:13 AM, Andrew Lunn wrote: >> + >> +/** >> + * asix_soft_reset - software reset the PHY via

Re: [PATCH -next] m68k: fix return value check in mcf_pci_init()

2018-04-18 Thread Greg Ungerer
Hi Wei, On 18/04/18 23:57, Wei Yongjun wrote: > In case of error, the function ioremap() returns NULL pointer not > ERR_PTR(). The IS_ERR() test in the return value check should be > replaced with NULL test. > > Fixes: bf114d773167 ("m68k: force use of __raw_read/__raw_write address to be >

Re: [PATCH v4 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-18 Thread Michael Schmitz
Hi, messed up the subject there, sorry - this was meant to be [PATCH v4 0/9] net-next: New network driver for Amiga X-Surf 100 (m68k) Cheers, Michael Am 19.04.2018 um 14:05 schrieb Michael Schmitz: > [This is a resend of my v3 series which was based on the wrong version and > tree.

[PATCH v4 6/9] net-next: ax88796: add interrupt status callback to platform data

2018-04-18 Thread Michael Schmitz
From: Michael Karcher To be able to tell the ax88796 driver whether it is sensible to enter the 8390 interrupt handler, an "is this interrupt caused by the 88796" callback has been added to the ax_plat_data structure (with NULL being compatible to the

[PATCH v4 8/9] net-next: ax88796: release platform device drvdata on probe error and module remove

2018-04-18 Thread Michael Schmitz
The net device struct pointer is stored as platform device drvdata on module probe - clear the drvdata entry on probe fail there, as well as when unloading the module. Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |2 ++ 1 files changed, 2

[PATCH v4 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-18 Thread Michael Schmitz
[This is a resend of my v3 series which was based on the wrong version and tree. Only substantial change is to Asix AX99796B PHY driver.] This patch series adds support for the Individual Computers X-Surf 100 network card for m68k Amiga, a network adapter based on the AX88796 chip set. The

[PATCH v4 1/9] net-next: phy: new Asix Electronics PHY driver

2018-04-18 Thread Michael Schmitz
The Asix Electronics PHY found on the X-Surf 100 Amiga Zorro network card by Individual Computers is buggy, and needs the reset bit toggled as workaround to make a PHY soft reset succeed. Add workaround driver just for this special case. Suggested in xsurf100 patch series review by Andrew Lunn

[PATCH v4 3/9] net-next: ax88796: Attach MII bus only when open

2018-04-18 Thread Michael Schmitz
From: Michael Karcher Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources in ax_close(). This is needed to be able to unload the module, as the module is busy while the MII bus is attached. Signed-off-by: Michael Karcher

[PATCH v4 9/9] net-next: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-18 Thread Michael Schmitz
From: Michael Karcher Add platform device driver to populate the ax88796 platform data from information provided by the XSurf100 zorro device driver. The ax88796 module will be loaded through this module's probe function. Signed-off-by: Michael Karcher

[PATCH v4 5/9] net-next: ax88796: Add block_input/output hooks to ax_plat_data

2018-04-18 Thread Michael Schmitz
From: Michael Karcher Add platform specific hooks for block transfer reads/writes of packet buffer data, superseding the default provided ax_block_input/output. Currently used for m68k Amiga XSurf100. Signed-off-by: Michael Karcher

[PATCH v4 7/9] net-next: ax88796: set IRQF_SHARED flag when IRQ resource is marked as shareable

2018-04-18 Thread Michael Schmitz
From: Michael Karcher On the Amiga X-Surf100, the network card interrupt is shared with many other interrupt sources, so requires the IRQF_SHARED flag to register. Signed-off-by: Michael Karcher Signed-off-by: Michael

[PATCH v4 4/9] net-next: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-18 Thread Michael Schmitz
From: Michael Karcher This complements the fix in 82533ad9a1c ("net: ethernet: ax88796: don't call free_irq without request_irq first") that removed the free_irq call in the error path of probe, to also not call free_irq when remove is called to revert the

[PATCH v4 2/9] net-next: ax88796: Fix MAC address reading

2018-04-18 Thread Michael Schmitz
From: Michael Karcher To read the MAC address from the (virtual) SAprom, the remote DMA unit needs to be set up like for every other process access to card-local memory. Signed-off-by: Michael Karcher Signed-off-by: