Re: [PATCH v2 02/10] m68k/mac: Fix SWIM memory resource end address

[Geert Uytterhoeven]

Hi Finn,

On Thu, Apr 12, 2018 at 2:50 AM, Finn Thain  wrote:
> The resource size is 0x2000 == end - start + 1.
> Therefore end == start + 0x2000 - 1.
>
> Cc: Laurent Vivier 
> Cc: sta...@vger.kernel.org # v4.14+
> Tested-by: Stan Johnson 
> Signed-off-by: Finn Thain 
> Acked-by: Laurent Vivier 
> Reviewed-by: Geert Uytterhoeven 

Thanks, applied and queued for v4.18.

> --- a/arch/m68k/mac/config.c
> +++ b/arch/m68k/mac/config.c
> @@ -1011,7 +1011,7 @@ int __init mac_platform_init(void)
> struct resource swim_rsrc = {
> .flags = IORESOURCE_MEM,
> .start = (resource_size_t)swim_base,
> -   .end   = (resource_size_t)swim_base + 0x2000,
> +   .end   = (resource_size_t)swim_base + 0x1FFF,

BTW, probably you want to change swim_base from u8 * to phys_addr_t, one day.

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 02/10] m68k/mac: Fix SWIM memory resource end address

[Finn Thain]

The resource size is 0x2000 == end - start + 1.
Therefore end == start + 0x2000 - 1.

Cc: Laurent Vivier 
Cc: sta...@vger.kernel.org # v4.14+
Tested-by: Stan Johnson 
Signed-off-by: Finn Thain 
Acked-by: Laurent Vivier 
Reviewed-by: Geert Uytterhoeven 
---
 arch/m68k/mac/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/m68k/mac/config.c b/arch/m68k/mac/config.c
index 84bd9161bf23..4a544a6c72dd 100644
--- a/arch/m68k/mac/config.c
+++ b/arch/m68k/mac/config.c
@@ -1011,7 +1011,7 @@ int __init mac_platform_init(void)
struct resource swim_rsrc = {
.flags = IORESOURCE_MEM,
.start = (resource_size_t)swim_base,
-   .end   = (resource_size_t)swim_base + 0x2000,
+   .end   = (resource_size_t)swim_base + 0x1FFF,
};
 
platform_device_register_simple("swim", -1, _rsrc, 1);
-- 
2.16.1

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html