Add buffer length check to sanity checks for USERPTR QBUF
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de
---
Changes for v2:
- only check when V4L2_MEMORY_USERPTR
drivers/media/video/omap3isp/ispqueue.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git
On Tuesday, August 09, 2011 00:06:10 Laurent Pinchart wrote:
Hi Hans,
On Monday 08 August 2011 14:40:27 Hans Verkuil wrote:
On Monday, August 08, 2011 13:40:23 Laurent Pinchart wrote:
On Monday 08 August 2011 11:16:41 Hans Verkuil wrote:
On Friday, August 05, 2011 09:47:13 Guennadi
Hi,
On 08/08/2011 07:39 PM, Theodore Kilgore wrote:
On Mon, 8 Aug 2011, Mauro Carvalho Chehab wrote:
snip
Mauro,
In fact none of the currently known and supported cameras are using PTP.
All of them are proprietary. They have a rather intimidating set of
differences in functionality,
Hi,
snip
OK, another example. The cameras supported in camlibs/jl2005c do not have
webcam ability, but someone could at any time design and market a dualmode
which has in stillcam mode the same severe limitation. What limitation?
Well, the entire memory of the camera must be dumped, or else
Hi Michael,
On Tuesday 09 August 2011 08:42:20 Michael Jones wrote:
Add buffer length check to sanity checks for USERPTR QBUF
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
I'll push the patch to v3.2.
---
Changes
Hi,
On 08/08/2011 07:58 PM, Sarah Sharp wrote:
On Fri, Aug 05, 2011 at 09:45:56AM +0200, Hans de Goede wrote:
Hi,
On 08/05/2011 12:56 AM, Greg KH wrote:
On Thu, Aug 04, 2011 at 07:21:47PM -0300, Mauro Carvalho Chehab wrote:
I think it is important to separate oranges from apples here, there
Hi Laurent,
On 08/08/2011 05:44 PM, Laurent Pinchart wrote:
Hi Sylwester,
On Monday 08 August 2011 17:36:32 Sylwester Nawrocki wrote:
Hi everyone,
Nowadays many of the V4L2 camera device drivers heavily depend on the board
code to set up voltage supplies, clocks, and some control signals,
Hello,
On Monday, August 08, 2011 12:11 PM Laurent Pinchart wrote:
On Friday 05 August 2011 17:01:09 Pawel Osciak wrote:
On Fri, Aug 5, 2011 at 01:55, Laurent Pinchart wrote:
Hi Marek and Pawel,
While reviewing an OMAP3 ISP patch, I noticed that videobuf2 doesn't
verify the buffer
Hi Sakari,
I have a point with the pixel clock. During discussion we found that
pixel clock get/set is required for user space to do fine control over
the frame-rate etc. What if the user sets the pixel array clock which is
above the system/if bus clock? Suppose we are setting the pixel clock
On Sunday, July 31, 2011 14:43:44 Mauro Carvalho Chehab wrote:
Em 29-07-2011 09:10, Hans Verkuil escreveu:
Hi all,
While converting v4l2-compliance to correctly handle ENOTTY errors I found
several regressions in v4l2-ioctl.c:
1) VIDIOC_ENUM/G/S/TRY_FMT would return -ENOTTY if the
This patch implements an i2c_gate_ctrl op for the cxd2820r. Thanks to Robert
Schlabbach for identifying the register address and field to set.
The old i2c intercept code that prefixed messages with a passthrough byte has
been removed and the PCTV nanoStick T2 290e entry in em28xx-dvb has been
Acked-by: Antti Palosaari cr...@iki.fi
Tested-by: Antti Palosaari cr...@iki.fi
On 08/09/2011 01:16 PM, Steve Kerrison wrote:
This patch implements an i2c_gate_ctrl op for the cxd2820r. Thanks to Robert
Schlabbach for identifying the register address and field to set.
The old i2c intercept
Hi Harald,
Currently the controller chip on the BlackGold card is unsupported - I
don't know if there's any development work going on for that in this
arena or if perhaps BlackGold are working on something themselves.
Perhaps somebody else here knows the full story.
This TBS card has only just
On 08/09/2011 01:57 PM, Steve Kerrison wrote:
This TBS card has only just been brought to my attention. I cannot tell
what PCIe chip it uses and if it's supported. The alleged Linux driver
download for it doesn't have the cxd2820r code in it, so I can't see
that having much chance of working.
Steve Kerrison st...@stevekerrison.com writes:
This TBS card has only just been brought to my attention. I cannot tell
what PCIe chip it uses and if it's supported. The alleged Linux driver
download for it doesn't have the cxd2820r code in it, so I can't see
that having much chance of
Em 09-08-2011 07:10, Hans Verkuil escreveu:
On Sunday, July 31, 2011 14:43:44 Mauro Carvalho Chehab wrote:
Em 29-07-2011 09:10, Hans Verkuil escreveu:
Hi all,
While converting v4l2-compliance to correctly handle ENOTTY errors I found
several regressions in v4l2-ioctl.c:
1)
On Tuesday, August 09, 2011 13:22:55 Mauro Carvalho Chehab wrote:
Em 09-08-2011 07:10, Hans Verkuil escreveu:
On Sunday, July 31, 2011 14:43:44 Mauro Carvalho Chehab wrote:
Em 29-07-2011 09:10, Hans Verkuil escreveu:
Hi all,
While converting v4l2-compliance to correctly handle ENOTTY
Hi Sylwester,
On Tuesday 09 August 2011 10:10:40 Sylwester Nawrocki wrote:
On 08/08/2011 05:44 PM, Laurent Pinchart wrote:
On Monday 08 August 2011 17:36:32 Sylwester Nawrocki wrote:
Hi everyone,
Nowadays many of the V4L2 camera device drivers heavily depend on the
board code to set
Thanks all for your quick answers.
On Tue, Aug 9, 2011 at 1:10 PM, Bjørn Mork bj...@mork.no wrote:
There's a binary-only tbs62x0fe_driver for x86_{32,64} in the archive,
so it _might_ work. But I don't think anyone here will recommend
something like that...
Yes, this is what I was afraid of.
Hi Marek,
On Tuesday 09 August 2011 11:14:43 Marek Szyprowski wrote:
On Monday, August 08, 2011 12:11 PM Laurent Pinchart wrote:
On Friday 05 August 2011 17:01:09 Pawel Osciak wrote:
On Fri, Aug 5, 2011 at 01:55, Laurent Pinchart wrote:
Hi Marek and Pawel,
While reviewing an
Hello,
On Tuesday, August 09, 2011 1:52 PM Laurent Pinchart wrote:
On Tuesday 09 August 2011 11:14:43 Marek Szyprowski wrote:
On Monday, August 08, 2011 12:11 PM Laurent Pinchart wrote:
On Friday 05 August 2011 17:01:09 Pawel Osciak wrote:
On Fri, Aug 5, 2011 at 01:55, Laurent Pinchart
Hi Marek,
On Tuesday 09 August 2011 14:07:12 Marek Szyprowski wrote:
On Tuesday, August 09, 2011 1:52 PM Laurent Pinchart wrote:
On Tuesday 09 August 2011 11:14:43 Marek Szyprowski wrote:
On Monday, August 08, 2011 12:11 PM Laurent Pinchart wrote:
On Friday 05 August 2011 17:01:09 Pawel
This patch fixes the remaining -ENOTTY fallout:
- The ENUM_FMT ops form a subset of the ops used with G/S/TRY_FMT, so list those
explicitly instead of using a macro.
- Extend the G/S/TRY_FMT ops test to the full set.
- Move all prio tests down to the correct switch cases.
- Fix some 'returns
Hi Laurent,
On 08/09/2011 01:49 PM, Laurent Pinchart wrote:
...
The following is usually handled in the board files:
1) sensor/frontend power supply
2) sensor's master clock (provided by the host device)
...
For 2) I'd like to propose adding a callback to struct v4l2_device, for
instance as
On 8 August 2011 20:50, Antti Palosaari cr...@iki.fi wrote:
On 08/06/2011 08:13 AM, Alistair Buxton wrote:
On 6 August 2011 04:56, Alistair Buxton a.j.bux...@gmail.com wrote:
With the latest driver my card never gets a signal lock, not even
once. As before there are no error messages. It does
On Tue, 9 Aug 2011, Hans de Goede wrote:
I would really like to see the dual mode camera and TV tuner discussion
separated. They are 2 different issues AFAIK.
1) Dual mode cameras:
In the case of the dual mode camera we have 1 single device (both at
the hardware level and at the logical
Hi
I've been thinking about the Kernel driver side.
Mauro and others emailed requirements on Jun or July.
I'm sorry for this spam: maybe you have thought this already.
A linked list of read/write locks as the solution for these protections could be
a base for the general solution. Locks could
Subash Patel wrote:
Hi Sakari,
Hi Subash,
I have a point with the pixel clock. During discussion we found that
pixel clock get/set is required for user space to do fine control over
the frame-rate etc. What if the user sets the pixel array clock which is
above the system/if bus clock?
There were a several problems in this function:
1) Potential integer overflow in the comparison:
if (fio.write_len + fio.read_len 1028) {
2) If the user gave bogus values for write_len and read_len then
returning -EINVAL is more appropriate than returning -ENOMEM.
3) wbuf was set
nitesh moundekar wrote:
Hi all,
Hi Nitesh,
I am worried about direction v4l2 is taking. It looks against the basic
principle of driver i.e. hardware abstraction. So i think giving out pixel
clock, binning, skipping, bayer pattern, etc device varying features to user
space questionable. We
This patch modifies the way autoclusters work when the 'foo' controls are
volatile if autofoo is on.
E.g.: if autogain is true, then gain returns the gain set by the autogain
circuitry.
This patch makes the following changes:
1) The V4L2_CTRL_FLAG_VOLATILE flag is added to let userspace know
Hi,
Does the omap3isp driver implementation support rgb888 format?
Regards,
sriram
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 9 Aug 2011, Hans de Goede wrote:
Hi,
On 08/08/2011 07:39 PM, Theodore Kilgore wrote:
On Mon, 8 Aug 2011, Mauro Carvalho Chehab wrote:
snip
Mauro,
In fact none of the currently known and supported cameras are using PTP.
All of them are proprietary. They have
On Tue, Aug 09, 2011 at 09:52:44AM +0200, Hans de Goede wrote:
Hi,
On 08/08/2011 07:58 PM, Sarah Sharp wrote:
On Fri, Aug 05, 2011 at 09:45:56AM +0200, Hans de Goede wrote:
Hi,
On 08/05/2011 12:56 AM, Greg KH wrote:
On Thu, Aug 04, 2011 at 07:21:47PM -0300, Mauro Carvalho Chehab wrote:
On Tue, 9 Aug 2011, Hans de Goede wrote:
Hi,
snip
OK, another example. The cameras supported in camlibs/jl2005c do not have
webcam ability, but someone could at any time design and market a dualmode
which has in stillcam mode the same severe limitation. What limitation?
Well, the
This message is generated daily by a cron job that builds v4l-dvb for
the kernels and architectures in the list below.
Results of the daily build of v4l-dvb:
date:Tue Aug 9 19:00:33 CEST 2011
git hash:9bed77ee2fb46b74782d0d9d14b92e9d07f3df6e
gcc version: i686-linux-gcc (GCC)
On Lunes, 8 de Agosto de 2011 23:44:43 Antti Palosaari escribió:
Reviewed-by: Antti Palosaari cr...@iki.fi
It looks just fine.
regards
Antti
Forgot the Signed-off-by
Signed-off-by: Jose Alberto Reguero jaregu...@telefonica.net
Jose Alberto
On 08/08/2011 01:35 PM, Jose Alberto
Hi,
On 08/09/2011 04:19 PM, Alan Stern wrote:
On Tue, 9 Aug 2011, Hans de Goede wrote:
I would really like to see the dual mode camera and TV tuner discussion
separated. They are 2 different issues AFAIK.
1) Dual mode cameras:
In the case of the dual mode camera we have 1 single device
Em 29-07-2011 05:36, Laurent Pinchart escreveu:
Hi Mauro,
On Friday 29 July 2011 06:02:54 Mauro Carvalho Chehab wrote:
Em 28-07-2011 19:57, Sylwester Nawrocki escreveu:
On 07/28/2011 03:20 PM, Mauro Carvalho Chehab wrote:
Accumulating sub-dev controls at the video node is the right thing to
Hi,
On 08/09/2011 07:10 PM, Theodore Kilgore wrote:
On Tue, 9 Aug 2011, Hans de Goede wrote:
snip
No, but both Adam and I realized, approximately at the same time
yesterday afternoon, something which is rather important here. Gphoto is
not developed exclusively for Linux. Furthermore, it
On Tuesday 09 August 2011, Hans de Goede wrote:
Hi,
On 08/09/2011 04:19 PM, Alan Stern wrote:
Does it really make sense to combine 5 drivers into one?
Right, that is not the plan. The plan is to simply stop having 2 drivers
for 1 logical (and physical) block. So we go from 10 drivers,
Hi,
On 08/09/2011 10:31 PM, Adam Baker wrote:
On Tuesday 09 August 2011, Hans de Goede wrote:
snip
It has also just occured to me that it might be possible to solve the issues
we are facing just in the kernel. At the moment when the kernel performs a
USBDEVFS_DISCONNECT it keeps the kernel
On Tue, 9 Aug 2011, Hans de Goede wrote:
Hi,
On 08/09/2011 04:19 PM, Alan Stern wrote:
On Tue, 9 Aug 2011, Hans de Goede wrote:
I would really like to see the dual mode camera and TV tuner discussion
separated. They are 2 different issues AFAIK.
1) Dual mode cameras:
Em 09-08-2011 20:18, Sakari Ailus escreveu:
Hi Mauro,
On Tue, Aug 09, 2011 at 05:05:47PM -0300, Mauro Carvalho Chehab wrote:
Em 29-07-2011 05:36, Laurent Pinchart escreveu:
Hi Mauro,
On Friday 29 July 2011 06:02:54 Mauro Carvalho Chehab wrote:
Em 28-07-2011 19:57, Sylwester Nawrocki
On Tue, 9 Aug 2011, Hans de Goede wrote:
Hi,
On 08/09/2011 07:10 PM, Theodore Kilgore wrote:
On Tue, 9 Aug 2011, Hans de Goede wrote:
snip
No, but both Adam and I realized, approximately at the same time
yesterday afternoon, something which is rather important here. Gphoto
On Wed, Aug 10, 2011 at 4:57 AM, Hans de Goede hdego...@redhat.com wrote:
This has been discussed over and over and over again, playing clever
tricks with USBDEVFS_[DIS]CONNECT like adding a new
USBDEVFS_TRYDISCONNECT
which the v4l2 driver could intercept won't cut it. We need some central
46 matches
Mail list logo
