RE: [PATCH v2 0/8] RFC for Media Controller capture driver for DM365

2011-09-09 Thread Hadli, Manjunath
Hi Sakari, On Fri, Sep 09, 2011 at 21:49:40, Sakari Ailus wrote: > On Fri, Sep 09, 2011 at 07:10:49PM +0530, Hadli, Manjunath wrote: > > Hi Sakari, > > > > On Thu, Sep 01, 2011 at 03:00:32, Sakari Ailus wrote: > > > Hi Manju, > > > > > > Do you have the media device grap that would be typical for

Re: 3.0.1. imon locking issues?

2011-09-09 Thread Andrew Morton
(cc's added) On Sun, 04 Sep 2011 21:02:41 +0200 Anders wrote: > Found this oops produced by kdump here. It seems imon related. > > > ... > > <4>[ 278.893189] Restarting tasks ... done. > <6>[ 278.994452] usb 5-1: USB disconnect, device number 2 > <3>[ 278.995191] imon:send_packet: error subm

Re: [PATCH v2] V4L: dynamically allocate video_device nodes in subdevices

2011-09-09 Thread Laurent Pinchart
Hi Guennadi, On Friday 09 September 2011 19:45:57 Guennadi Liakhovetski wrote: > Currently only very few drivers actually use video_device nodes, embedded > in struct v4l2_subdev. Allocate these nodes dynamically for those drivers > to save memory for the rest. Thanks for the patch. > Signed-off

Re: [PATCH 08/13 v3] ov6650: convert to the control framework.

2011-09-09 Thread Guennadi Liakhovetski
On Fri, 9 Sep 2011, Janusz Krzysztofik wrote: > On Fri, 9 Sep 2011 at 20:01:14 Guennadi Liakhovetski wrote: > > Hi Janusz > > > > On Fri, 9 Sep 2011, Janusz Krzysztofik wrote: > > > > > On Thu, 8 Sep 2011 at 10:44:01 Guennadi Liakhovetski wrote: > > > > From: Hans Verkuil > > > > > > > > Signe

Re: [PATCH 08/13 v3] ov6650: convert to the control framework.

2011-09-09 Thread Janusz Krzysztofik
On Fri, 9 Sep 2011 at 20:23:38 Sylwester Nawrocki wrote: > Hi, > > On 09/09/2011 08:01 PM, Guennadi Liakhovetski wrote: [snip] > > I basically agree with all your comments apart from maybe > > > > [snip] > > > >>> @@ -1176,9 +1021,11 @@ static int ov6650_probe(struct i2c_client *client, > >>>

Re: [PATCH 08/13 v3] ov6650: convert to the control framework.

2011-09-09 Thread Janusz Krzysztofik
On Fri, 9 Sep 2011 at 20:01:14 Guennadi Liakhovetski wrote: > Hi Janusz > > On Fri, 9 Sep 2011, Janusz Krzysztofik wrote: > > > On Thu, 8 Sep 2011 at 10:44:01 Guennadi Liakhovetski wrote: > > > From: Hans Verkuil > > > > > > Signed-off-by: Hans Verkuil > > > [g.liakhovet...@gmx.de: simplified

cron job: media_tree daily build: ERRORS

2011-09-09 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Fri Sep 9 19:00:32 CEST 2011 git hash:62dd28d0c659db29bdb89cfe9f0aefe42f0adfe9 gcc version: i686-linux-gcc (GC

Re: [PATCH 08/13 v3] ov6650: convert to the control framework.

2011-09-09 Thread Sylwester Nawrocki
Hi, On 09/09/2011 08:01 PM, Guennadi Liakhovetski wrote: > Hi Janusz > > On Fri, 9 Sep 2011, Janusz Krzysztofik wrote: > >> On Thu, 8 Sep 2011 at 10:44:01 Guennadi Liakhovetski wrote: >>> From: Hans Verkuil >>> >>> Signed-off-by: Hans Verkuil >>> [g.liakhovet...@gmx.de: simplified pointer arithm

Re: [PATCH 08/13 v3] ov6650: convert to the control framework.

2011-09-09 Thread Guennadi Liakhovetski
Hi Janusz On Fri, 9 Sep 2011, Janusz Krzysztofik wrote: > On Thu, 8 Sep 2011 at 10:44:01 Guennadi Liakhovetski wrote: > > From: Hans Verkuil > > > > Signed-off-by: Hans Verkuil > > [g.liakhovet...@gmx.de: simplified pointer arithmetic] > > Signed-off-by: Guennadi Liakhovetski > > Hi, > I've

[PATCH v2] V4L: dynamically allocate video_device nodes in subdevices

2011-09-09 Thread Guennadi Liakhovetski
Currently only very few drivers actually use video_device nodes, embedded in struct v4l2_subdev. Allocate these nodes dynamically for those drivers to save memory for the rest. Signed-off-by: Guennadi Liakhovetski --- v2: Checking for NULL is not always enough, you also have to check the right

[PATCH 4/4] V4L: replace soc-camera specific soc_mediabus.h with v4l2-mediabus.h

2011-09-09 Thread Guennadi Liakhovetski
Most users of the header only need pixel code definitions, which are now located in the generic header. Switch over to reduce soc-camera dependencies. Signed-off-by: Guennadi Liakhovetski --- drivers/media/video/imx074.c |2 +- drivers/media/video/mt9m111.c|2 +- drivers/media/

[PATCH 3/4] V4L: soc-camera: make (almost) all client drivers re-usable outside of the framework

2011-09-09 Thread Guennadi Liakhovetski
The most important change in this patch is direct linking to struct soc_camera_link via the client->dev.platform_data pointer. This makes most of the soc-camera client drivers also usable outside of the soc-camera framework. After this change all what is needed for these drivers to function are inc

[PATCH 2/4] V4L: mt9m001, mt9v022: use internally cached pixel code

2011-09-09 Thread Guennadi Liakhovetski
Using the internally cached pixel code, instead of the one, provided by the soc-camera, removes one more use of struct soc_camera_device in these drivers. Also remove the no longer needed soc_camera_from_i2c() inline function. Signed-off-by: Guennadi Liakhovetski --- drivers/media/video/mt9m001.

[PATCH 1/4] V4L: soc-camera: start removing struct soc_camera_device from client drivers

2011-09-09 Thread Guennadi Liakhovetski
Remove most trivial uses of struct soc_camera_device from most client drivers, abstracting some of them inside inline functions. Next steps will eliminate remaining uses and modify inline functions to not use struct soc_camera_device. Signed-off-by: Guennadi Liakhovetski --- drivers/media/video/

[PATCH 0/4] release soc-camera client drivers into the wild V4L2 world;-)

2011-09-09 Thread Guennadi Liakhovetski
This patch set finally makes most (except for two) soc-camera client (sensor and 1 tv-decoder) drivers also usable outside of the framework. The drivers still include headers and rely on a couple of inline and out-of-line library functions, which just means you have to build and load the soc_ca

Re: [RFC] Reserved fields in v4l2_mbus_framefmt, v4l2_subdev_format alignment

2011-09-09 Thread Sylwester Nawrocki
Hi Laurent, On 09/08/2011 12:21 PM, Laurent Pinchart wrote: > On Tuesday 06 September 2011 23:07:43 Sakari Ailus wrote: >> On Tue, Sep 06, 2011 at 09:10:17PM +0200, Sylwester Nawrocki wrote: >>> On 09/05/2011 05:55 PM, Sakari Ailus wrote: Hi all, I recently came across a few issues

[PATCH] V4L: add .g_std() core V4L2 subdevice operation

2011-09-09 Thread Guennadi Liakhovetski
VIDIOC_G_STD can return the current TV-norm to the user in one of two ways: if an .vidioc_g_std() ioctl operation is provided by the driver, it is called, otherwise the value ot the .current_norm field of struct video_device is returned. Since subdevice drivers currently have no access to struct vi

[PATCH] V4L: sh_mobile_csi2: fix unbalanced pm_runtime_put()

2011-09-09 Thread Guennadi Liakhovetski
If the sh_mobile_csi2 driver didn't attach to a client, normally, because the respective device connects to the SoC over the parallel CEU interface and doesn't use the CSI-2 controller, it also shouldn't call pm_runtime_put() on attempted disconnect. Signed-off-by: Guennadi Liakhovetski --- If i

Re: [PATCH 08/13 v3] ov6650: convert to the control framework.

2011-09-09 Thread Janusz Krzysztofik
On Thu, 8 Sep 2011 at 10:44:01 Guennadi Liakhovetski wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > [g.liakhovet...@gmx.de: simplified pointer arithmetic] > Signed-off-by: Guennadi Liakhovetski Hi, I've successfully tested this one for you, to the extent possible using mplayer,

Re: [PATCH v2 4/8] davinci: vpfe: add support for CCDC hardware for dm365

2011-09-09 Thread Sylwester Nawrocki
Hi Manju, On 09/09/2011 03:30 PM, Hadli, Manjunath wrote: > Thank you for these comments too. > > My responses inlined. > -Manju Thanks for addressing my comments. > > On Fri, Sep 02, 2011 at 02:53:08, Sylwester Nawrocki wrote: ... >>> +/** >>> + * ccdc float type S8Q8/U8Q8 >>> + */ >>> +struc

Re: [PATCH v2 0/8] RFC for Media Controller capture driver for DM365

2011-09-09 Thread Sakari Ailus
On Fri, Sep 09, 2011 at 07:10:49PM +0530, Hadli, Manjunath wrote: > Hi Sakari, > > On Thu, Sep 01, 2011 at 03:00:32, Sakari Ailus wrote: > > Hi Manju, > > > > Do you have the media device grap that would be typical for this hardware > > produced by media-ctl? That can be converted to postscript

[PATCH 2/2] as3645a: Add driver for LED flash controller

2011-09-09 Thread Laurent Pinchart
This patch adds the driver for the as3645a LED flash controller. This controller supports a high power led in flash and torch modes and an indicator light, sometimes also called privacy light. Signed-off-by: Laurent Pinchart Signed-off-by: Nayden Kanchev Signed-off-by: Tuukka Toivonen Signed-of

[PATCH 1/2] v4l: Add over-current and indicator flash fault bits

2011-09-09 Thread Laurent Pinchart
Flash controllers can report over-current and indicator fault conditions. Define flash fault control bits for them. Signed-off-by: Laurent Pinchart --- Documentation/DocBook/media/v4l/controls.xml | 10 ++ include/linux/videodev2.h|2 ++ 2 files changed, 12 inse

[PATCH 0/2] as3645a flash driver

2011-09-09 Thread Laurent Pinchart
Hi everybody, Here's a driver for the as3645a flash controller. The first patch adds two new flash faults bits to the V4L2 API, and the second patch adds the driver itself. Laurent Pinchart (2): v4l: Add over-current and indicator flash fault bits as3645a: Add driver for LED flash controller

Re: [RFC][PATCH] as3645a: introduce new LED Flash driver

2011-09-09 Thread Laurent Pinchart
Hi Andy, On Friday 09 September 2011 16:59:31 Andy Shevchenko wrote: > The driver supports the AS3645A, LM3555 chips and their clones. > > Accordingly to datasheet the AS3645 chip is a "1000/720mA Ultra Small High > efficient single/dual LED Flash Driver with Safety Features". LM3555 is > similar

[PATCH] V4L: dynamically allocate video_device nodes in subdevices

2011-09-09 Thread Guennadi Liakhovetski
Currently only very few drivers actually use video_device nodes, embedded in struct v4l2_subdev. Allocate these nodes dynamically for those drivers to save memory for the rest. Signed-off-by: Guennadi Liakhovetski --- Only compile tested. Please, give it a spin on affected hardware. drivers/me

[RFC][PATCH] as3645a: introduce new LED Flash driver

2011-09-09 Thread Andy Shevchenko
The driver supports the AS3645A, LM3555 chips and their clones. Accordingly to datasheet the AS3645 chip is a "1000/720mA Ultra Small High efficient single/dual LED Flash Driver with Safety Features". LM3555 is similar one, that has following difference - the current in the torch mode is the same

RE: [PATCH v2 0/8] RFC for Media Controller capture driver for DM365

2011-09-09 Thread Hadli, Manjunath
Hi Sakari, On Thu, Sep 01, 2011 at 03:00:32, Sakari Ailus wrote: > Hi Manju, > > Do you have the media device grap that would be typical for this hardware > produced by media-ctl? That can be converted to postscript using dotfile. > > this would make it a little easier to understan this driver.

RE: [PATCH v2 4/8] davinci: vpfe: add support for CCDC hardware for dm365

2011-09-09 Thread Hadli, Manjunath
Thank you for these comments too. My responses inlined. -Manju On Fri, Sep 02, 2011 at 02:53:08, Sylwester Nawrocki wrote: > Hi Manjunath, > > few more comments below.. > > On 08/29/2011 05:07 PM, Manjunath Hadli wrote: > > add support for ccdc on dm365 SoC. ccdc is responsible for capturing >

Re: [PATCH 3/9 v7] V4L: document the new VIDIOC_CREATE_BUFS and VIDIOC_PREPARE_BUF ioctl()s

2011-09-09 Thread Laurent Pinchart
Hi Guennadi, Thank you for the patch. As discussed over jabber, we're suffering from an AB-BA deadlock that this patch could make worse. The mmap code path takes mm->mmap_sem in the kernel' mmap handler before calling the driver's mmap handler. The driver will then lock the queue mutex before

RE: [PATCH v2 1/8] davinci: vpfe: add dm3xx IPIPEIF hardware support module

2011-09-09 Thread Hadli, Manjunath
Hi Sylwester, Thank you for your comments. My responses inline. Thanks and Regards, -Manju On Fri, Sep 02, 2011 at 02:17:49, Sylwester Nawrocki wrote: > Hi Manjunath, > > A few comments below... > > On 08/29/2011 05:07 PM, Manjunath Hadli wrote: > > add support for dm3xx IPIPEIF hardware setu

Re: recursive locking problem

2011-09-09 Thread Daniel Glöckner
On Thu, Sep 08, 2011 at 07:34:32PM +0300, Antti Palosaari wrote: > I am working with AF9015 I2C-adapter lock. I need lock I2C-bus since > there is two tuners having same I2C address on same bus, demod I2C > gate is used to select correct tuner. Would it be possible to use the i2c-mux framework to

Re: [PATCH V2] gspca/zc3xx: add usb_id for HP Premium Starter Cam

2011-09-09 Thread Jean-Francois Moine
On Fri, 9 Sep 2011 11:33:15 +0200 Wolfram Sang wrote: > On Sat, Jul 02, 2011 at 02:02:00PM +0200, Wolfram Sang wrote: > > Signed-off-by: Wolfram Sang > > Cc: Jean-Francois Moine > > --- > > Ping. I can't find it in the git-repos on linuxtv.org? Hi Wolfram, I asked to pull your patch in lin

Re: recursive locking problem

2011-09-09 Thread David Waring
On 08/09/11 17:34, Antti Palosaari wrote: > [snip] > > Is there any lock can do recursive locking but unlock frees all locks? > > Like that: > gate_open > +gate_open > +gate_close > == lock is free > > AFAIK mutex can do only simple lock() + unlock(). Semaphore can do > recursive locking, like l

Re: [PATCH v2] [media] at91: add code to initialize and manage the ISI_MCK for Atmel ISI driver.

2011-09-09 Thread Nicolas Ferre
Le 06/09/2011 08:54, Guennadi Liakhovetski : > On Tue, 6 Sep 2011, Josh Wu wrote: > >> This patch enable the configuration for ISI_MCK, which is provided by >> programmable clock. >> >> Signed-off-by: Josh Wu >> --- >> drivers/media/video/atmel-isi.c | 60 >> +

Re:Hello Dear

2011-09-09 Thread Wenzhou Ourvis
Dear E-mail User, This is to immediately inform you that your email address with Micros ID: IDJT-32238-EHI-676GI-8ED has won you £ 2,485,000.00 GBP and a brand new Range Rover SUV from the Wenzhou Ourvis yearly draw promo. Use the details below to login and fill in the claim form to immediately

Re: [PATCH V2] gspca/zc3xx: add usb_id for HP Premium Starter Cam

2011-09-09 Thread Wolfram Sang
On Sat, Jul 02, 2011 at 02:02:00PM +0200, Wolfram Sang wrote: > Signed-off-by: Wolfram Sang > Cc: Jean-Francois Moine > --- Ping. I can't find it in the git-repos on linuxtv.org? > > V2: added entry in documentation > > Documentation/video4linux/gspca.txt |1 + > drivers/media/video/gspc

Re: recursive locking problem

2011-09-09 Thread Hans Petter Selasky
On Thursday 08 September 2011 18:34:32 Antti Palosaari wrote: > lock() + lock() + unlock() == free. Hi, As far as I can see the Linux kernel's mutex API doesn't have support for checking if a mutex is owned. I guess you would have to do something like: while (mutex_owned(&xxx)) mutex_un