[PATCH] [media] media/radio/tef6862: fix checking return value of i2c_master_send

2011-11-16 Thread Axel Lin
i2c_master_send returns negative errno, or else the number of bytes written. Signed-off-by: Axel Lin axel@gmail.com --- drivers/media/radio/tef6862.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/media/radio/tef6862.c b/drivers/media/radio/tef6862.c

Re: [PATCH 2/9] as3645a: print vendor and revision of the chip

2011-11-16 Thread Laurent Pinchart
Hi Andy, Thanks for the patch. On Tuesday 15 November 2011 18:49:54 Andy Shevchenko wrote: The as3645a_registered() is used to detect connected chip. It would be nice to print the detected value every time we load the module. The Vendor is probably better word to use there. For example,

Re: [PATCH 6/9] as3645a: free resources in case of error properly

2011-11-16 Thread Laurent Pinchart
Hi Andy, Thanks for the patch. On Tuesday 15 November 2011 18:49:58 Andy Shevchenko wrote: Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/as3645a.c | 23 --- 1 files changed, 12 insertions(+), 11 deletions(-) diff --git

Re: [PATCH 6/9] as3645a: free resources in case of error properly

2011-11-16 Thread Andy Shevchenko
On Wed, 2011-11-16 at 11:37 +0100, Laurent Pinchart wrote: @@ -812,13 +814,12 @@ static int as3645a_probe(struct i2c_client *client, flash-led_mode = V4L2_FLASH_LED_MODE_NONE; - ret = as3645a_init_controls(flash); - if (ret 0) { - kfree(flash); -

Re: Using MT9P031 digital sensor

2011-11-16 Thread Gary Thomas
On 2011-11-15 18:26, Laurent Pinchart wrote: Hi Gary, On Monday 14 November 2011 12:42:54 Gary Thomas wrote: On 2011-11-11 07:26, Laurent Pinchart wrote: On Wednesday 09 November 2011 17:24:26 Gary Thomas wrote: On 2011-11-09 09:18, Laurent Pinchart wrote: On Wednesday 09 November 2011

[PATCH v5 0/2] as3645a flash driver

2011-11-16 Thread Laurent Pinchart
Hi everybody, Here's the 5th (and hopefully final) version of the as3645a flash driver. Compared to v4, it incorporates Andy's patches, adds support for the V4L2_CID_FLASH_STROBE_STATUS control and removes the minimum limits from platform data. Laurent Pinchart (2): v4l: Add over-current and

[PATCH v5 1/2] v4l: Add over-current and indicator flash fault bits

2011-11-16 Thread Laurent Pinchart
Flash controllers can report over-current and indicator fault conditions. Define flash fault control bits for them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Sakari Ailus

[PATCH v5 2/2] as3645a: Add driver for LED flash controller

2011-11-16 Thread Laurent Pinchart
This patch adds the driver for the as3645a LED flash controller. This controller supports a high power led in flash and torch modes and an indicator light, sometimes also called privacy light. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Andy Shevchenko

Re: [PATCH v5 2/2] as3645a: Add driver for LED flash controller

2011-11-16 Thread Andy Shevchenko
On Wed, 2011-11-16 at 15:10 +0100, Laurent Pinchart wrote: This patch adds the driver for the as3645a LED flash controller. This controller supports a high power led in flash and torch modes and an indicator light, sometimes also called privacy light. Just few nitpicks. diff --git

Re: [RFCv1 PATCH 1/3] V4L2: Add per-device-node capabilities

2011-11-16 Thread Hans Verkuil
On Tuesday 15 November 2011 21:18:12 Sylwester Nawrocki wrote: Hello Hans, On 11/07/2011 11:37 AM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com If V4L2_CAP_DEVICE_CAPS is set, then the new device_caps field is filled with the capabilities of the opened device node.

[PATCH] em28xx: Add Terratec Cinergy HTC Stick

2011-11-16 Thread Andreas Oberritter
- Can receive DVB-C and DVB-T. No analogue television or radio yet. - For now it's a copy of the Terratec H5 code with a different name. Signed-off-by: Andreas Oberritter o...@linuxtv.org --- linux/drivers/media/video/em28xx/em28xx-cards.c | 15 +++

RE: [PATCH] omap_vout: fix crash if no driver for a display

2011-11-16 Thread Hiremath, Vaibhav
-Original Message- From: Valkeinen, Tomi Sent: Monday, November 14, 2011 1:59 PM To: linux-media@vger.kernel.org; Hiremath, Vaibhav Cc: Taneja, Archit; Valkeinen, Tomi Subject: [PATCH] omap_vout: fix crash if no driver for a display omap_vout crashes on start if a corresponding

Re: [PATCH v5 2/2] as3645a: Add driver for LED flash controller

2011-11-16 Thread Sakari Ailus
On Wed, Nov 16, 2011 at 03:10:57PM +0100, Laurent Pinchart wrote: This patch adds the driver for the as3645a LED flash controller. This controller supports a high power led in flash and torch modes and an indicator light, sometimes also called privacy light. Signed-off-by: Laurent Pinchart

Re: [RFCv1 PATCH 1/3] V4L2: Add per-device-node capabilities

2011-11-16 Thread Mauro Carvalho Chehab
Em 16-11-2011 12:41, Hans Verkuil escreveu: On Tuesday 15 November 2011 21:18:12 Sylwester Nawrocki wrote: Hello Hans, On 11/07/2011 11:37 AM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com If V4L2_CAP_DEVICE_CAPS is set, then the new device_caps field is filled with the

[PATCH] MEM2MEM: Add support for eMMa-PrP mem2mem operations.

2011-11-16 Thread Javier Martin
i.MX2x SoCs have a PrP which is capable of resizing and format conversion of video frames. This driver provides support for resizing and format conversion from YUYV to YUV420. This operation is of the utmost importance since some of these SoCs like i.MX27 include an H.264 video codec which only

Re: [RFC] SUBDEV_S/G_SELECTION IOCTLs

2011-11-16 Thread Laurent Pinchart
Hi Sakari, On Thursday 10 November 2011 23:29:34 Sakari Ailus wrote: On Thu, Nov 10, 2011 at 04:23:19PM +0100, Tomasz Stanislawski wrote: On 11/08/2011 10:55 PM, Sakari Ailus wrote: Hi all, This RFC discusses the SUBDEV_S_SELECTION/SUBDEV_G_SELECTION API which is intended to amend and

Cleanup proposal for media/gspca

2011-11-16 Thread Ezequiel GarcĂ­a
Hi folks, In 'media/video/gspca/gspca.c' I really hated this cast (maybe because I am too dumb to understand it): gspca_dev = (struct gspca_dev *) video_devdata(file); wich is only legal because a struct video_device is the first member of gspca_dev. IMHO, this is 'unnecesary obfuscation'.

cron job: media_tree daily build: ERRORS

2011-11-16 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Wed Nov 16 19:00:16 CET 2011 git hash:e9eb0dadba932940f721f9d27544a7818b2fa1c5 gcc version: i686-linux-gcc

[PATCH] media: vb2: fix queueing of userptr buffers with null buffer pointer

2011-11-16 Thread Marek Szyprowski
Heuristic that checks if the memory pointer has been changed lacked a check if the pointer was actually provided by the userspace, what allowed one to queue a NULL pointer which was accepted without further checking. This patch fixes this issue. Reported-by: Sylwester Nawrocki

[PATCH 0/4] Miscellaneous omap3-isp patches

2011-11-16 Thread Laurent Pinchart
Hi everybody, The subject says it all. Two of the patches fix crashes, while the other two are minor modifications with no impact on the compiled code. I'll push them for v3.3. Laurent Pinchart (4): omap3isp: preview: Rename max output sizes defines omap3isp: ccdc: Fix crash in HS/VS

[PATCH 1/4] omap3isp: preview: Rename max output sizes defines

2011-11-16 Thread Laurent Pinchart
The maximum preview engine output size depends on the ISP revision, not the OMAP revision. Rename the macros accordingly. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/omap3isp/isppreview.c | 16 1 files changed, 8 insertions(+), 8

[PATCH 2/4] omap3isp: ccdc: Fix crash in HS/VS interrupt handler

2011-11-16 Thread Laurent Pinchart
The HS/VS interrupt handler needs to access the pipeline object. It erronously tries to get it from the CCDC output video node, which isn't necessarily included in the pipeline. This leads to a NULL pointer dereference. Fix the bug by getting the pipeline object from the CCDC subdev entity.

[PATCH 3/4] omap3isp: Fix crash caused by subdevs now having a pointer to devnodes

2011-11-16 Thread Laurent Pinchart
Commit 3e0ec41c5c5ee14e27f65e28d4a616de34f59a97 (V4L: dynamically allocate video_device nodes in subdevices) makes the v4l2_subdev::devnode field a pointer to a struct video_device instead of embedding video_device directly. Fix accesses to the devnode accordingly. Signed-off-by: Laurent

[PATCH 4/4] omap3isp: Clarify the clk_pol field in platform data

2011-11-16 Thread Laurent Pinchart
The field is used to select the polarity of the pixel clock signal. Inverted and non inverted are bad descriptions, specify instead on which clock edge the signals are sampled. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/media/omap3isp.h |2 +- 1 files

Re: [PATCH 0/4] Miscellaneous omap3-isp patches

2011-11-16 Thread Sakari Ailus
Laurent Pinchart wrote: Hi everybody, The subject says it all. Two of the patches fix crashes, while the other two are minor modifications with no impact on the compiled code. I'll push them for v3.3. Laurent Pinchart (4): omap3isp: preview: Rename max output sizes defines omap3isp:

[PATCH] media/staging: fix allyesconfig build error

2011-11-16 Thread Randy Dunlap
From: Randy Dunlap rdun...@xenotime.net Fix x86 allyesconfig builds. Builds fail due to a non-static variable named 'debug' in drivers/staging/media/as102/. arch/x86/built-in.o:arch/x86/kernel/entry_32.S:1296: first defined here ld: Warning: size of symbol `debug' changed from 90 in

Re: good programm for FM radio

2011-11-16 Thread Dmitri Belimov
Hi kradio from Debian Squeeze 0.1.1.1-20061112-4 with KDE 4.4.5 doesn't work. It wants V4L1 API. I think the tm6000-alsa has some problem with alsa compatibility. This log when start gnomeradio with arecord helper [ 2198.067414] pcm_open start [ 2198.067417] pcm_open stop [ 2198.067554]