Re: [PATCH v2 1/4] media i.MX27 camera: migrate driver to videobuf2

2012-01-30 Thread javier Martin
Hi Guennadi, thank you for your time. On 27 January 2012 16:25, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: A general question for mx2-camera: does it now after removal of legacy i.MX27 support only support i.MX25 (state: unknown) and i.MX27 in eMMA mode? I understand so. I'll send a

Re: [PATCH v2 2/4] media i.MX27 camera: add start_stream and stop_stream callbacks.

2012-01-30 Thread javier Martin
Hi, On 27 January 2012 16:53, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Thu, 26 Jan 2012, Javier Martin wrote: Add start_stream and stop_stream callback in order to enable and disable the eMMa-PrP properly and save CPU usage avoiding IRQs when the device is not streaming. This

Re: [Linaro-mm-sig] [PATCH 12/15] drivers: add Contiguous Memory Allocator

2012-01-30 Thread Ohad Ben-Cohen
Hi Marek, On Mon, Jan 30, 2012 at 9:43 AM, Marek Szyprowski m.szyprow...@samsung.com wrote: Did you managed to fix this issue? Yes -- the recent increase in the vmalloc region triggered a bigger truncation in the system RAM than we had before, and therefore conflicted with the previous

[PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-30 Thread Sachin Kamat
This patch adds support for flipping the image horizontally and vertically. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-g2d/g2d-hw.c |5 +++ drivers/media/video/s5p-g2d/g2d.c| 47 +++-- drivers/media/video/s5p-g2d/g2d.h

Re: [RFC] Format and frame rate configuration in subdev video and pad ops

2012-01-30 Thread Laurent Pinchart
Hi Sakari, On Sunday 29 January 2012 11:28:16 Sakari Ailus wrote: Hi all, We have now two type of subdev drivers, those which use the Media controller framework and those which do not. The former group implements v4l2_subdev_pad_ops for the purpose whereas the latter uses

Re: [PATCH 01/15] mm: page_alloc: remove trailing whitespace

2012-01-30 Thread Mel Gorman
On Thu, Jan 26, 2012 at 10:00:43AM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz min...@mina86.com Signed-off-by: Michal Nazarewicz min...@mina86.com Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Ordinarily, I do not like these sort of patches because they can interfere

Re: [PATCH 02/15] mm: page_alloc: update migrate type of pages on pcp when isolating

2012-01-30 Thread Mel Gorman
On Thu, Jan 26, 2012 at 10:00:44AM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz min...@mina86.com This commit changes set_migratetype_isolate() so that it updates migrate type of pages on pcp list which is saved in their page_private. Signed-off-by: Michal Nazarewicz

Re: [PATCH 03/15] mm: compaction: introduce isolate_migratepages_range().

2012-01-30 Thread Mel Gorman
On Thu, Jan 26, 2012 at 10:00:45AM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz min...@mina86.com This commit introduces isolate_migratepages_range() function which extracts functionality from isolate_migratepages() so that it can be used on arbitrary PFN ranges.

Re: [PATCH 04/15] mm: compaction: introduce isolate_freepages_range()

2012-01-30 Thread Mel Gorman
On Thu, Jan 26, 2012 at 10:00:46AM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz min...@mina86.com This commit introduces isolate_freepages_range() function which generalises isolate_freepages_block() so that it can be used on arbitrary PFN ranges. isolate_freepages_block() is

[GIT PULL FOR v3.3] OMAP3 ISP fix

2012-01-30 Thread Laurent Pinchart
Hi Mauro, Here's one patch for v3.3 that fixes a regression. The patch was included in v3.2, but a merge conflict coupled with a bad conflict resolution removed it from v3.3. The following changes since commit dcd6c92267155e70a94b3927bce681ce74b80d1f: Linux 3.3-rc1 (2012-01-19 15:04:48

Re: [PATCH 04/15] mm: compaction: introduce isolate_freepages_range()

2012-01-30 Thread Mel Gorman
On Mon, Jan 30, 2012 at 11:48:20AM +, Mel Gorman wrote: + if (!zone) + zone = page_zone(pfn_to_page(pfn)); + else if (zone != page_zone(pfn_to_page(pfn))) + break; + So what you are checking for here is if you straddle zones.

Re: [PATCH 05/15] mm: compaction: export some of the functions

2012-01-30 Thread Mel Gorman
On Thu, Jan 26, 2012 at 10:00:47AM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz min...@mina86.com This commit exports some of the functions from compaction.c file outside of it adding their declaration into internal.h header file so that other mm related code can use them. This

[PATCH] [media] omap3isp: ccdc: Fix crash in HS/VS interrupt handler

2012-01-30 Thread Laurent Pinchart
The HS/VS interrupt handler needs to access the pipeline object. It erronously tries to get it from the CCDC output video node, which isn't necessarily included in the pipeline. This leads to a NULL pointer dereference. Fix the bug by getting the pipeline object from the CCDC subdev entity.

Re: [RFC] More on subdev selections API: composition

2012-01-30 Thread Sylwester Nawrocki
Hi Sakari, On 01/29/2012 07:06 PM, Sakari Ailus wrote: The problem with multiple sink pads is that which one you're referring to when you're configuring the first processing step on the source. Without composition there are no issues. What I can think of is to create a special composition

Re: [PATCH 3/4] media i.MX27 camera: improve discard buffer handling.

2012-01-30 Thread javier Martin
Hi Guennadi, On 27 January 2012 19:02, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: (removing bar...@tkos.co.il - it bounces) On Thu, 26 Jan 2012, javier Martin wrote: Hi Guennadi, On 25 January 2012 13:12, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 20 Jan 2012,

Re: [PATCH v2 3/4] media i.MX27 camera: improve discard buffer handling.

2012-01-30 Thread javier Martin
On 27 January 2012 19:13, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Thu, 26 Jan 2012, Javier Martin wrote: The way discard buffer was previously handled lead to possible races that made a buffer that was not yet ready to be overwritten by new video data. This is easily detected

Re: [PATCH v2 4/4] media i.MX27 camera: handle overflows properly.

2012-01-30 Thread javier Martin
On 27 January 2012 19:16, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: (removed bar...@tkos.co.il - it bounces) On Thu, 26 Jan 2012, Javier Martin wrote: Signed-off-by: Javier Martin javier.mar...@vista-silicon.com ---  Changes since v1:  - Make ifs in irq callback mutually

Re: [PATCH 06/15] mm: page_alloc: introduce alloc_contig_range()

2012-01-30 Thread Mel Gorman
On Thu, Jan 26, 2012 at 10:00:48AM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz min...@mina86.com This commit adds the alloc_contig_range() function which tries to allocate given range of pages. It tries to migrate all already allocated pages that fall in the range thus freeing

Re: [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-30 Thread Laurent Pinchart
Hi Sashin, Thanks for the patch. On Monday 30 January 2012 10:58:43 Sachin Kamat wrote: This patch adds support for flipping the image horizontally and vertically. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-g2d/g2d-hw.c |5 +++

Re: [PATCH 07/15] mm: page_alloc: change fallbacks array handling

2012-01-30 Thread Mel Gorman
On Thu, Jan 26, 2012 at 10:00:49AM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz min...@mina86.com This commit adds a row for MIGRATE_ISOLATE type to the fallbacks array which was missing from it. It also, changes the array traversal logic a little making MIGRATE_RESERVE an end

[PATCH v3 1/4] media i.MX27 camera: migrate driver to videobuf2

2012-01-30 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- Changes since v2: - Return ENOTTY for VIDIOC_CREATE_BUFS - Check buffer size properly. - Do not remove unfixed FIXME. - Remove mx25 queued buffers from the queue list at release. --- drivers/media/video/mx2_camera.c | 289

[PATCH v3 2/4] media i.MX27 camera: add start_stream and stop_stream callbacks.

2012-01-30 Thread Javier Martin
Add start_stream and stop_stream callback in order to enable and disable the eMMa-PrP properly and save CPU usage avoiding IRQs when the device is not streaming. This also makes the driver return 0 as the sequence number of the first frame. Signed-off-by: Javier Martin

[PATCH v3 3/4] media i.MX27 camera: improve discard buffer handling.

2012-01-30 Thread Javier Martin
The way discard buffer was previously handled lead to possible races that made a buffer that was not yet ready to be overwritten by new video data. This is easily detected at 25fps just adding #define DEBUG to enable the memset check and seeing how the image is corrupted. A new discard queue and

[PATCH v3 4/4] media i.MX27 camera: handle overflows properly.

2012-01-30 Thread Javier Martin
Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- Changes since v2: - Use true and false for bool variables. --- drivers/media/video/mx2_camera.c | 38 -- 1 files changed, 16 insertions(+), 22 deletions(-) diff --git

[PATCH v3] omap3isp: Prevent pipelines that contain a crashed entity from starting

2012-01-30 Thread Laurent Pinchart
The OMAP3 ISP preview engine will violate the L4 bus protocol if we try to write some of its internal registers after it failed to stop properly. This generates an external abort on non-linefetch fault, triggering a fatal kernel oops. We can't always prevent preview engine stop failures (they can

[PATCH] mt9p031: Remove unused xskip and yskip fields in struct mt9p031

2012-01-30 Thread Laurent Pinchart
The fields are set but never used, remove them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9p031.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/mt9p031.c b/drivers/media/video/mt9p031.c index

Re: [PATCH 05/15] mm: compaction: export some of the functions

2012-01-30 Thread Michal Nazarewicz
On Thu, Jan 26, 2012 at 10:00:47AM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz min...@mina86.com --- a/mm/compaction.c +++ b/mm/compaction.c @@ -16,30 +16,11 @@ #include linux/sysfs.h #include internal.h +#if defined CONFIG_COMPACTION || defined CONFIG_CMA + On Mon, 30 Jan 2012

Re: [PATCH 08/15] mm: mmzone: MIGRATE_CMA migration type added

2012-01-30 Thread Mel Gorman
On Thu, Jan 26, 2012 at 10:00:50AM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz min...@mina86.com The MIGRATE_CMA migration type has two main characteristics: (i) only movable pages can be allocated from MIGRATE_CMA pageblocks and (ii) page allocator will never change migration

Re: [PATCH 10/15] mm: extract reclaim code from __alloc_pages_direct_reclaim()

2012-01-30 Thread Mel Gorman
On Thu, Jan 26, 2012 at 10:00:52AM +0100, Marek Szyprowski wrote: This patch extracts common reclaim code from __alloc_pages_direct_reclaim() function to separate function: __perform_reclaim() which can be later used by alloc_contig_range(). Signed-off-by: Marek Szyprowski

Re: [PATCH 03/15] mm: compaction: introduce isolate_migratepages_range().

2012-01-30 Thread Michal Nazarewicz
On Thu, Jan 26, 2012 at 10:00:45AM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz min...@mina86.com @@ -313,7 +316,7 @@ static isolate_migrate_t isolate_migratepages(struct zone *zone, } else if (!locked) spin_lock_irq(zone-lru_lock); -

Re: [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-30 Thread Sylwester Nawrocki
On 01/30/2012 01:11 PM, Laurent Pinchart wrote: static int g2d_open(struct file *file) @@ -564,6 +591,8 @@ static void device_run(void *prv) g2d_set_dst_addr(dev, vb2_dma_contig_plane_dma_addr(dst, 0)); g2d_set_rop4(dev, ctx-rop); +g2d_set_flip(dev, ctx-hflip | ctx-vflip); +

Re: [PATCH 11/15] mm: trigger page reclaim in alloc_contig_range() to stabilize watermarks

2012-01-30 Thread Mel Gorman
On Thu, Jan 26, 2012 at 10:00:53AM +0100, Marek Szyprowski wrote: alloc_contig_range() performs memory allocation so it also should keep track on keeping the correct level of memory watermarks. This commit adds a call to *_slowpath style reclaim to grab enough pages to make sure that the final

Re: [PATCH 08/15] mm: mmzone: MIGRATE_CMA migration type added

2012-01-30 Thread Michal Nazarewicz
On Thu, Jan 26, 2012 at 10:00:50AM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz min...@mina86.com @@ -875,10 +895,15 @@ struct page *__rmqueue_smallest(struct zone *zone, unsigned int order, * This array describes the order lists are fallen back to when * the free lists for the

Re: [PATCHv19 00/15] Contiguous Memory Allocator

2012-01-30 Thread Mel Gorman
On Fri, Jan 27, 2012 at 04:26:24PM -0800, Andrew Morton wrote: On Thu, 26 Jan 2012 15:31:40 + Arnd Bergmann a...@arndb.de wrote: On Thursday 26 January 2012, Marek Szyprowski wrote: Welcome everyone! Yes, that's true. This is yet another release of the Contiguous Memory

Re: [PATCH 03/15] mm: compaction: introduce isolate_migratepages_range().

2012-01-30 Thread Mel Gorman
On Mon, Jan 30, 2012 at 01:42:50PM +0100, Michal Nazarewicz wrote: On Thu, Jan 26, 2012 at 10:00:45AM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz min...@mina86.com @@ -313,7 +316,7 @@ static isolate_migrate_t isolate_migratepages(struct zone *zone, } else if (!locked)

RE: [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-30 Thread Kamil Debski
Hi Laurent and Sachin, Thanks for the patch and for your comments. From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: 30 January 2012 13:12 Hi Sashin, Thanks for the patch. On Monday 30 January 2012 10:58:43 Sachin Kamat wrote: This patch adds support for

Re: [PATCH v2 1/1] omap3isp: Prevent crash at module unload

2012-01-30 Thread Laurent Pinchart
Hi Sakari, Thanks for the patch. On Friday 27 January 2012 11:18:51 Sakari Ailus wrote: iommu_domain_free() was called in isp_remove() before omap3isp_put(). omap3isp_put() must not save the context if the IOMMU no longer is there. Fix this. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi

Re: [Linaro-mm-sig] [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-30 Thread Laurent Pinchart
Hi Subash, On Friday 27 January 2012 14:40:34 Subash Patel wrote: On 01/24/2012 05:36 PM, Tomasz Stanislawski wrote: On 01/24/2012 12:07 PM, Subash Patel wrote: Instead of adding another IOCTL to query the file-descriptor in user-space, why dont we extend the existing ones in v4l2/vb2?

Re: [PATCH] dma-buf: add dma_data_direction to unmap dma_buf_op

2012-01-30 Thread Laurent Pinchart
Hi Sumit, On Friday 27 January 2012 10:43:28 Sumit Semwal wrote: Some exporters may use DMA map/unmap APIs in dma-buf ops, which require enum dma_data_direction for both map and unmap operations. Thus, the unmap dma_buf_op also needs to have enum dma_data_direction as a parameter.

Re: [RFCv1 2/4] v4l:vb2: add support for shared buffer (dma_buf)

2012-01-30 Thread Laurent Pinchart
Hi Daniel, On Sunday 29 January 2012 14:03:40 Daniel Vetter wrote: On Sun, Jan 29, 2012 at 01:03:39PM +0200, Sakari Ailus wrote: Daniel Vetter wrote: On Thu, Jan 26, 2012 at 01:28:16AM +0200, Sakari Ailus wrote: Why you should not hang onto mappings forever? This is currently done by

Re: [RFCv1 2/4] v4l:vb2: add support for shared buffer (dma_buf)

2012-01-30 Thread Laurent Pinchart
Hi Daniel, On Tuesday 24 January 2012 14:03:22 Daniel Vetter wrote: On Mon, Jan 23, 2012 at 11:54:20AM +0100, Laurent Pinchart wrote: On Monday 23 January 2012 11:35:01 Daniel Vetter wrote: See my other mail, dma_buf v1 does not support cpu access. v1 is in the kernel now, let's start

Re: [PATCH 08/15] mm: mmzone: MIGRATE_CMA migration type added

2012-01-30 Thread Mel Gorman
On Mon, Jan 30, 2012 at 02:06:50PM +0100, Michal Nazarewicz wrote: @@ -1017,11 +1049,14 @@ __rmqueue_fallback(struct zone *zone, int order, int start_migratetype) rmv_page_order(page); /* Take ownership for orders = pageblock_order */ -

Re: [PATCH 02/15] mm: page_alloc: update migrate type of pages on pcp when isolating

2012-01-30 Thread Michal Nazarewicz
On Mon, 30 Jan 2012 12:15:22 +0100, Mel Gorman m...@csn.ul.ie wrote: On Thu, Jan 26, 2012 at 10:00:44AM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz min...@mina86.com @@ -139,3 +139,27 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn)

Re: [PATCHv19 00/15] Contiguous Memory Allocator

2012-01-30 Thread Michal Nazarewicz
On Mon, 30 Jan 2012 14:25:12 +0100, Mel Gorman m...@csn.ul.ie wrote: I reviewed the core MM changes and I've acked most of them so the next release should have a few acks where you expect them. I did not add a reviewed-by because I did not build and test the thing. Thanks! I've either replied

Re: [PATCH 02/15] mm: page_alloc: update migrate type of pages on pcp when isolating

2012-01-30 Thread Mel Gorman
On Mon, Jan 30, 2012 at 04:41:22PM +0100, Michal Nazarewicz wrote: On Mon, 30 Jan 2012 12:15:22 +0100, Mel Gorman m...@csn.ul.ie wrote: On Thu, Jan 26, 2012 at 10:00:44AM +0100, Marek Szyprowski wrote: From: Michal Nazarewicz min...@mina86.com @@ -139,3 +139,27 @@ int

Re: [RFCv1 2/4] v4l:vb2: add support for shared buffer (dma_buf)

2012-01-30 Thread Daniel Vetter
On Mon, Jan 30, 2012 at 03:44:20PM +0100, Laurent Pinchart wrote: Hi Daniel, On Tuesday 24 January 2012 14:03:22 Daniel Vetter wrote: On Mon, Jan 23, 2012 at 11:54:20AM +0100, Laurent Pinchart wrote: On Monday 23 January 2012 11:35:01 Daniel Vetter wrote: See my other mail, dma_buf v1

Re: [PATCH] Adding YUV input support for OMAP3ISP driver

2012-01-30 Thread Gary Thomas
On 2012-01-20 05:19, Laurent Pinchart wrote: Hi Enrico, On Thursday 19 January 2012 15:17:57 Enrico wrote: On Thu, Jan 19, 2012 at 2:52 PM, Gary Thomasg...@mlbassoc.com wrote: On 2012-01-19 06:35, Gary Thomas wrote: My camera init code is attached. In the previous kernel, the I2C bus was

Please tag proof-of-concept patches as RFC

2012-01-30 Thread Pawel Osciak
Hi All, There's been a lot of proof-of-concept patch series posted recently. I think it's great, but I would just like to suggest the RFC tag is used in the topic of such patches. I feel this would be helpful not only for Mauro, but for all of us. Thanks! Pawel -- To unsubscribe from this list:

cron job: media_tree daily build: WARNINGS

2012-01-30 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Mon Jan 30 19:00:18 CET 2012 git hash:59b30294e14fa6a370fdd2bc2921cca1f977ef16 gcc version: i686-linux-gcc

Re: [RFCv1 2/4] v4l:vb2: add support for shared buffer (dma_buf)

2012-01-30 Thread Sakari Ailus
Hi Daniel, On Sun, Jan 29, 2012 at 02:03:40PM +0100, Daniel Vetter wrote: On Sun, Jan 29, 2012 at 01:03:39PM +0200, Sakari Ailus wrote: Daniel Vetter wrote: On Thu, Jan 26, 2012 at 01:28:16AM +0200, Sakari Ailus wrote: Why you should not hang onto mappings forever? This is currently done

[PATCH 05/16] cx18: fix handling of 'radio' module parameter

2012-01-30 Thread Danny Kukawka
Fixed handling of 'radio' module parameter from module_param_array to module_param_named to fix these compiler warnings in cx18-driver.c: In function ‘__check_radio’: 113:1: warning: return from incompatible pointer type [enabled by default] At top level: 113:1: warning: initialization from

[PATCH v2 02/16] max2165: trival fix for some -Wuninitialized warning

2012-01-30 Thread Danny Kukawka
Fix for some -Wuninitialized compiler warnings. Signed-off-by: Danny Kukawka danny.kuka...@bisect.de --- drivers/media/common/tuners/max2165.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/media/common/tuners/max2165.c

Re: [RFC PATCH 0/4] Add some new camera controls

2012-01-30 Thread Sakari Ailus
Hi Sylwester, On Sat, Jan 28, 2012 at 06:01:59PM +0100, Sylwester Nawrocki wrote: On 01/04/2012 10:07 PM, Sakari Ailus wrote: On Fri, Dec 30, 2011 at 12:18:40PM +0100, Sylwester Nawrocki wrote: Thus we would three levels of controls for camera, 1) image source class (lowest possible

Re: [PATCH][media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-30 Thread Sachin Kamat
Hi Laurent, Sylwester and Kamil, Thank you for your comments and suggestions. I will re-send the patch with the following 2 changes: 1. Error checking done only once at the end of the init call. 2. Modification in switch case as suggested by Kamil. Regards Sachin On 30 January 2012 19:09,

[PATCH v2] [media] s5p-g2d: Add HFLIP and VFLIP support

2012-01-30 Thread Sachin Kamat
This patch adds support for flipping the image horizontally and vertically. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/media/video/s5p-g2d/g2d-hw.c |5 + drivers/media/video/s5p-g2d/g2d.c| 25 - drivers/media/video/s5p-g2d/g2d.h|