Re: [PATCH 0/3] em28xx: Improve compatiblity with the Terratec Cinergy HTC Stick HD

2012-06-13 Thread Martin Blumenstingl
Hi Sven, I tested the patchset on linux-3.4.2, unfortunately DVB-C is not working here (DVB-T not tested). If you have further patches or other suggestions what to test, I would be happy to try it. That's sad. I guess it was also not working with the old version, right? Do you get any errors

SV: stv0297 signal issues on QAM256

2012-06-13 Thread Fontana
Hello, After some further digging i found a post with attached patch. http://www.linuxtv.org/pipermail/linux-dvb/attachments/20080731/de8768ed/att achment.diff Dunno why there were no followup on this one? http://linuxtv.org/pipermail/linux-dvb/2008-July/027517.html Applied cleanly to kernel

[PATCH] [media] stradis: remove unused V4L1 headers

2012-06-13 Thread Paul Bolle
Commit 39c3d488452ae206cfc8afda0db041ee55d01c3c ([media] cpia, stradis: remove deprecated V4L1 drivers) removed the last file including these five headers. Apparently it was just an oversight to keep them in the tree. They can safely be removed now. Signed-off-by: Paul Bolle pebo...@tiscali.nl

RE: [PATCH] [media] s5p-mfc: Fix checkpatch error in s5p_mfc_shm.h file

2012-06-13 Thread Kamil Debski
Hi, Thanks for the patch. Best wishes, Kamil Debski From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: 11 June 2012 12:59 Fixes the following error: ERROR: open brace '{' following enum go on the same line +enum MFC_SHM_OFS +{ Signed-off-by: Sachin Kamat

RE: [PATCH 2/3] [media] s5p-mfc: Replace printk with pr_* functions

2012-06-13 Thread Kamil Debski
Hi Sachin, I am afraid that I have to NACK this patch. pr_debug/pr_err/etc. is useful when you want to add some data in front of the debug message. So if you really insist then you could try to add something like this +#define pr_fmt(fmt) :%s:%d: fmt, __func__, __LINE__ +#define mfc_err

[PATCH] tvp5150: fix kernel crash if chip is unavailable

2012-06-13 Thread Dmitry Lifshitz
tvp5150 driver probe function doesn't check if the chip is present. Thus the driver can be loaded without having a device. This is dangerous and can cause kernel crash like this: Kernel BUG at c03c0964 [verbose debug info unavailable] Internal error: Oops - BUG: 0 [#1] PREEMPT ARM Modules linked

Re: extend v4l2_mbus_framefmt

2012-06-13 Thread Hans Verkuil
On Wed 13 June 2012 07:31:37 Scott Jiang wrote: Hi Hans, I would expect that the combination of v4l2_mbus_framefmt + v4l2_dv_timings gives you the information you need. I can solve this problem in HD, but how about SD? Add a fake dv_timings ops in SD decoder driver? No, you add

Hauppauge WinTV Nova S Plus Composite IN

2012-06-13 Thread shacky
Hi. I'm trying to record some video using the composite input of the Hauppauge WinTV Nova S Plus, which is indicated as supported on http://linuxtv.org/wiki/index.php/DVB-S_PCI_Cards. I tried playing video from the input with VLC and mplayer, but I'm getting a black screen. I checked all cables

Re: Hauppauge WinTV Nova S Plus Composite IN

2012-06-13 Thread Andre
On 13 Jun 2012, at 14:55, shacky wrote: Hi. I'm trying to record some video using the composite input of the Hauppauge WinTV Nova S Plus, which is indicated as supported on http://linuxtv.org/wiki/index.php/DVB-S_PCI_Cards. I tried playing video from the input with VLC and mplayer, but

[PATCH] media: typo, change ctruct to struct in comment

2012-06-13 Thread Peter Meerwald
From: Peter Meerwald p.meerw...@bct-electronic.com Signed-off-by: Peter Meerwald p.meerw...@bct-electronic.com --- drivers/media/video/mt9m001.c |2 +- drivers/media/video/mt9v022.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/mt9m001.c

Re: Hauppauge WinTV Nova S Plus Composite IN

2012-06-13 Thread shacky
mencoder -oac lavc -ovc lavc -of mpeg -mpegopts format=dvd:tsaf   -vf scale=720:576,harddup -srate 48000 -af lavcresample=48000   -lavcopts vcodec=mpeg2video:vrc_buf_size=1835:vrc_maxrate=9800:vbitrate=8000:keyint=15:vstrict=0:acodec=ac3:abitrate=192:aspect=4/3 -ofps 25   -o johntest1.mpg

Re: Hauppauge WinTV Nova S Plus Composite IN

2012-06-13 Thread Andre
On 13 Jun 2012, at 15:56, shacky wrote: mencoder -oac lavc -ovc lavc -of mpeg -mpegopts format=dvd:tsaf -vf scale=720:576,harddup -srate 48000 -af lavcresample=48000 -lavcopts

Re: Hauppauge WinTV Nova S Plus Composite IN

2012-06-13 Thread shacky
Only to play with the volume= parameter, I'm sure you tried that, maybe there are some audio controls but I haven't found them. The VCR tapes I have to transfer have very quiet and muffled audio, old home videos so I thought the audio sounded ok. Thank you very much. I tried with the

cx88-alsa and alsamixer

2012-06-13 Thread shacky
Hi. I'm using the cx88-alsa module on Ubuntu 11.04 on kernel 2.6.38-12-server. It is correctly loaded and it recognizes my DVB-S PCI card (Hauppauge WinTV Nova-S Plus): dvr@LV1:~$ arecord -l Lista di CAPTURE dispositivi hardware scheda 0: NVidia [HDA NVidia], dispositivo 0: VT1708S

[PATCH v2 1/3] radio: Add Sanyo LM7000 tuner driver

2012-06-13 Thread Ondrej Zary
Add very simple driver for Sanyo LM7000 AM/FM tuner chip. Only FM is supported as there is no known HW with AM implemented. This will be used by radio-aimslab and radio-sf16fmi. Signed-off-by: Ondrej Zary li...@rainbow-software.org diff --git a/drivers/media/radio/lm7000.h

[PATCH v2 2/3] radio-aimslab: Use LM7000 driver

2012-06-13 Thread Ondrej Zary
Convert radio-aimslab to use generic LM7000 driver. Tested with Reveal RA300. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- a/drivers/media/radio/radio-aimslab.c +++ b/drivers/media/radio/radio-aimslab.c @@ -37,6 +37,7 @@ #include media/v4l2-ioctl.h #include media/v4l2-ctrls.h

[PATCH v2 3/3] radio-sf16fmi: Use LM7000 driver

2012-06-13 Thread Ondrej Zary
Convert radio-sf16fmi to use generic LM7000 driver. Tested with SF16-FMI, SF16-FMP and SF16-FMD. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- a/drivers/media/radio/radio-sf16fmi.c +++ b/drivers/media/radio/radio-sf16fmi.c @@ -27,6 +27,7 @@ #include linux/io.h /* outb,

[PATCH v2 0/6] V4L2 and V4L2 subdev selection target and flag changes

2012-06-13 Thread Sakari Ailus
Hi, Compared to the previous version of the patchset, I've addressed Sylwester's comments on the 3th patch, and made a few other changes: - Selection flags have also been unified (patches 5 and 6), - Documentation had references to old subdev targets (which are now fixed) and - The common

[PATCH v2 1/6] V4L: Remove _ACTIVE from the selection target name definitions

2012-06-13 Thread Sakari Ailus
From: Sylwester Nawrocki sylvester.nawro...@gmail.com This patch drops the _ACTIVE part from the selection target names as a prerequisite to unify the selection target names across the subdev and regular video node API. The meaning of V4L2_SEL_TGT_*_ACTIVE and V4L2_SUBDEV_SEL_TGT_*_ACTUAL

[PATCH v2 2/6] v4l: Remove _ACTUAL from subdev selection API target definition names

2012-06-13 Thread Sakari Ailus
The string _ACTUAL does not say anything more about the target names. Drop it. V4L2 selection API was changed by V4L: Rename V4L2_SEL_TGT_[CROP/COMPOSE]_ACTIVE to V4L2_SEL_TGT_[CROP/COMPOSE] by Sylwester Nawrocki. This patch does the same for the V4L2 subdev API. Signed-off-by: Sakari Ailus

[PATCH v2 3/6] v4l: Unify selection targets across V4L2 and V4L2 subdev interfaces

2012-06-13 Thread Sakari Ailus
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media/video/omap3isp/ispccdc.c |6 ++-- drivers/media/video/omap3isp/isppreview.c |6 ++-- drivers/media/video/omap3isp/ispresizer.c |6 ++--

[PATCH v2 5/6] v4l: Unify selection flags

2012-06-13 Thread Sakari Ailus
Unify flags on the selection interfaces on V4L2 and V4L2 subdev. Flags are very similar to targets in this case: there are more similarities than differences between the two interfaces. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispccdc.c|2 +-

[PATCH v2 6/6] v4l: Unify selection flags documentation

2012-06-13 Thread Sakari Ailus
As for the selection targets, the selection flags are now the same on V4L2 and V4L2 subdev interfaces. Also document them so. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/DocBook/media/v4l/dev-subdev.xml |6 +- Documentation/DocBook/media/v4l/selection-api.xml |

[PATCH v2 4/6] v4l: Common documentation for selection targets

2012-06-13 Thread Sakari Ailus
Both V4L2 and V4L2 subdev interface have very similar selection APIs with differences foremost related to in-memory and media bus formats. However, the selection targets are the same for both. Most targets are and in the future will likely continue to be more the same than with any differences.

Re: [PATCH v2 1/3] radio: Add Sanyo LM7000 tuner driver

2012-06-13 Thread Hans Verkuil
On Wed June 13 2012 23:25:32 Ondrej Zary wrote: Add very simple driver for Sanyo LM7000 AM/FM tuner chip. Only FM is supported as there is no known HW with AM implemented. This will be used by radio-aimslab and radio-sf16fmi. Signed-off-by: Ondrej Zary li...@rainbow-software.org For all

Re: [PATCH 3/4] v4l: Unify selection targets across V4L2 and V4L2 subdev interfaces

2012-06-13 Thread Sylwester Nawrocki
Hi Sakari :) On 06/13/2012 11:11 PM, Sakari Ailus wrote: Hi Sylwester, Thanks for the comments!! Sylwester Nawrocki wrote: Hi Sakari, On 06/10/2012 09:34 PM, Sakari Ailus wrote: Signed-off-by: Sakari Ailussakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispccdc.c|6 ++--

Re: [PATCH v2 2/6] v4l: Remove _ACTUAL from subdev selection API target definition names

2012-06-13 Thread Sylwester Nawrocki
On 06/13/2012 11:30 PM, Sakari Ailus wrote: The string _ACTUAL does not say anything more about the target names. Drop it. V4L2 selection API was changed by V4L: Rename V4L2_SEL_TGT_[CROP/COMPOSE]_ACTIVE to V4L2_SEL_TGT_[CROP/COMPOSE] by Sylwester Nawrocki. This patch does the same The new

Re: [PATCH v2 2/6] v4l: Remove _ACTUAL from subdev selection API target definition names

2012-06-13 Thread Sakari Ailus
Hi Sylwester, Sylwester Nawrocki wrote: On 06/13/2012 11:30 PM, Sakari Ailus wrote: The string _ACTUAL does not say anything more about the target names. Drop it. V4L2 selection API was changed by V4L: Rename V4L2_SEL_TGT_[CROP/COMPOSE]_ACTIVE to V4L2_SEL_TGT_[CROP/COMPOSE] by Sylwester

Re: [PATCH 3/4] v4l: Unify selection targets across V4L2 and V4L2 subdev interfaces

2012-06-13 Thread Sakari Ailus
Hi Sylwester, Sylwester Nawrocki wrote: Hi Sakari :) On 06/13/2012 11:11 PM, Sakari Ailus wrote: Hi Sylwester, Thanks for the comments!! Sylwester Nawrocki wrote: Hi Sakari, On 06/10/2012 09:34 PM, Sakari Ailus wrote: Signed-off-by: Sakari Ailussakari.ai...@iki.fi ---

Re: [PATCH v2 4/6] v4l: Common documentation for selection targets

2012-06-13 Thread Sylwester Nawrocki
Hi Sakari, two minor comments below.. On 06/13/2012 11:30 PM, Sakari Ailus wrote: Both V4L2 and V4L2 subdev interface have very similar selection APIs with differences foremost related to in-memory and media bus formats. However, the selection targets are the same for both. Most targets are

[PATCH 1/2] [BUG] dvb_usb_v2: return the download ret in dvb_usb_download_firmware

2012-06-13 Thread Malcolm Priestley
Hi antti There some issues with dvb_usb_v2 with the lmedm04 driver. The first being this patch, no return value from dvb_usb_download_firmware causes system wide dead lock with COLD disconnect as system attempts to continue to warm state. The second is to do with d-props.bInterfaceNumber in

[PATCH 2/2] dvb_usb_v2 Allow d-props.bInterfaceNumber to set the correct interface.

2012-06-13 Thread Malcolm Priestley
Although the interface could be set in identify state, ideally it should be done in the probe. Allow d-props.bInterfaceNumber try to set the correct interface rather than return error. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/media/dvb/dvb-usb/dvb_usb_init.c | 11

[PATCH] dvb_usb_v2 [RFC] draft use delayed work.

2012-06-13 Thread Malcolm Priestley
dvb_usb_v2 [RFC] use delayed work. The problem with an ordinary work queue it executes immediately. changes made 1. Three extra states added DVB_USB_STATE_PROBE, DVB_USB_STATE_COLD and DVB_USB_STATE_WARM. 2. Initialise of priv moved to probe this shouldn't really be done in the

Re: [PATCH 3/4] v4l: Unify selection targets across V4L2 and V4L2 subdev interfaces

2012-06-13 Thread Sylwester Nawrocki
On 06/13/2012 11:49 PM, Sakari Ailus wrote: In case you wanted to compile test those changes, I've attached kernel config file for exynos4. Compile testing? What is that? :-) I don't practise it myself, but it's still better than making random changes in the kernel and not checking if

Re: [PATCH v2 4/6] v4l: Common documentation for selection targets

2012-06-13 Thread Sakari Ailus
Hi Sylwester, Sylwester Nawrocki wrote: Hi Sakari, two minor comments below.. Thanks for your comments. On 06/13/2012 11:30 PM, Sakari Ailus wrote: Both V4L2 and V4L2 subdev interface have very similar selection APIs with differences foremost related to in-memory and media bus formats.

[PATCH v3 0/6] V4L2 and V4L2 subdev selection target and flag changes

2012-06-13 Thread Sakari Ailus
Hi, Compared to the previous version of the patchset, I've addressed more comments from Sylwester. The fixes are simple but yet important, plus I added back a missing reference from the selection API to the target reference. The resulting HTML documentation is available here (same location as

[PATCH v3 2/6] v4l: Remove _ACTUAL from subdev selection API target definition names

2012-06-13 Thread Sakari Ailus
The string _ACTUAL does not say anything more about the target names. Drop it. V4L2 selection API was changed by V4L: Remove _ACTIVE from the selection target name definitions by Sylwester Nawrocki. This patch does the same for the V4L2 subdev API. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi

[PATCH v3 1/6] V4L: Remove _ACTIVE from the selection target name definitions

2012-06-13 Thread Sakari Ailus
From: Sylwester Nawrocki sylvester.nawro...@gmail.com This patch drops the _ACTIVE part from the selection target names as a prerequisite to unify the selection target names across the subdev and regular video node API. The meaning of V4L2_SEL_TGT_*_ACTIVE and V4L2_SUBDEV_SEL_TGT_*_ACTUAL

[PATCH v3 3/6] v4l: Unify selection targets across V4L2 and V4L2 subdev interfaces

2012-06-13 Thread Sakari Ailus
Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media/video/omap3isp/ispccdc.c |6 ++-- drivers/media/video/omap3isp/isppreview.c |6 ++-- drivers/media/video/omap3isp/ispresizer.c |6 ++--

[PATCH v3 5/6] v4l: Unify selection flags

2012-06-13 Thread Sakari Ailus
Unify flags on the selection interfaces on V4L2 and V4L2 subdev. Flags are very similar to targets in this case: there are more similarities than differences between the two interfaces. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/omap3isp/ispccdc.c|2 +-

[PATCH v3 4/6] v4l: Common documentation for selection targets

2012-06-13 Thread Sakari Ailus
Both V4L2 and V4L2 subdev interface have very similar selection APIs with differences foremost related to in-memory and media bus formats. However, the selection targets are the same for both. Most targets are and in the future will likely continue to be more the same than with any differences.

Re: [PATCH 2/2] dvb_usb_v2 Allow d-props.bInterfaceNumber to set the correct interface.

2012-06-13 Thread Antti Palosaari
On 06/14/2012 01:26 AM, Malcolm Priestley wrote: Although the interface could be set in identify state, ideally it should be done in the probe. Allow d-props.bInterfaceNumber try to set the correct interface rather than return error. Signed-off-by: Malcolm Priestleytvbox...@gmail.com ---

Re: [PATCH 1/2] [BUG] dvb_usb_v2: return the download ret in dvb_usb_download_firmware

2012-06-13 Thread Antti Palosaari
Hi Malcolm, I was really surprised someone has had interest to test that stuff at that phase as I did not even advertised it yet :) It is likely happen next Monday or so as there is some issues I would like to check / solve. On 06/14/2012 01:24 AM, Malcolm Priestley wrote: Hi antti There

Re: [PATCH] dvb_usb_v2 [RFC] draft use delayed work.

2012-06-13 Thread Antti Palosaari
On 06/14/2012 01:27 AM, Malcolm Priestley wrote: dvb_usb_v2 [RFC] use delayed work. The problem with an ordinary work queue it executes immediately. changes made 1. Three extra states added DVB_USB_STATE_PROBE, DVB_USB_STATE_COLD and DVB_USB_STATE_WARM. 2. Initialise of priv moved to

Re: [PATCH 1/2] [BUG] dvb_usb_v2: return the download ret in dvb_usb_download_firmware

2012-06-13 Thread Malcolm Priestley
On Thu, 2012-06-14 at 02:29 +0300, Antti Palosaari wrote: Hi Malcolm, I was really surprised someone has had interest to test that stuff at that phase as I did not even advertised it yet :) It is likely happen next Monday or so as there is some issues I would like to check / solve. On

Re: [PATCH 1/2] [BUG] dvb_usb_v2: return the download ret in dvb_usb_download_firmware

2012-06-13 Thread Antti Palosaari
On 06/14/2012 03:44 AM, Malcolm Priestley wrote: On Thu, 2012-06-14 at 02:29 +0300, Antti Palosaari wrote: Hi Malcolm, I was really surprised someone has had interest to test that stuff at that phase as I did not even advertised it yet :) It is likely happen next Monday or so as there is some

Re: extend v4l2_mbus_framefmt

2012-06-13 Thread Scott Jiang
I would expect that the combination of v4l2_mbus_framefmt + v4l2_dv_timings gives you the information you need. I can solve this problem in HD, but how about SD? Add a fake dv_timings ops in SD decoder driver? No, you add g/s_std instead. SD timings are set through that API. It is not

[PATCH v3 6/6] v4l: Unify selection flags documentation

2012-06-13 Thread Sakari Ailus
As for the selection targets, the selection flags are now the same on V4L2 and V4L2 subdev interfaces. Also document them so. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- Documentation/DocBook/media/v4l/dev-subdev.xml |6 +- Documentation/DocBook/media/v4l/selection-api.xml |