Re: [PATCH v2 01/01] media: gscaler: Add new driver for generic scaler

2012-07-22 Thread Shaik Ameer Basha
Hi Sylwester, thanks for your review comments... I will update the Gscaler driver code with the other two set of review comments you posted earlier... however, i have some doubts in this set of review comments. please find my comments inline... On Fri, Jul 13, 2012 at 12:39 AM, Sylwester Nawrock

Re: [PATCH 2/2] kthread_worker: reimplement flush_kthread_work() to allow freeing the work item being executed

2012-07-22 Thread Andy Walls
On Sun, 2012-07-22 at 09:49 -0700, Tejun Heo wrote: > Hello, > > On Sat, Jul 21, 2012 at 02:20:06PM -0400, Andy Walls wrote: > > > + worker->current_work = work; > > > spin_unlock_irq(&worker->lock); > > > > > > if (work) { > > > __set_current_state(TASK_RUNNING); > > > w

Re: [PATCH 1/2] kthread_worker: reorganize to prepare for flush_kthread_work() reimplementation

2012-07-22 Thread Andy Walls
On Sun, 2012-07-22 at 09:46 -0700, Tejun Heo wrote: > Hello, > > On Sat, Jul 21, 2012 at 01:13:27PM -0400, Andy Walls wrote: > > > +/* insert @work before @pos in @worker */ > > > > Hi Tejun, > > > > Would a comment that the caller should be holding worker->lock be useful > > here? Anyway, comm

[PATCH v1] v4l2-ctl: Add support for VIDIOC_G/S_SELECTION ioctls

2012-07-22 Thread Sylwester Nawrocki
This patch adds following commands for the selection API ioctls: --get-selection, --set-selection, --get-selection-output, --set-selection-output. All supported selection rectangles at a video node are now also displayed in case of --all command. Signed-off-by: Sylwester Nawrocki --- utils/v4l

Re: [PATCH 2/2] kthread_worker: reimplement flush_kthread_work() to allow freeing the work item being executed

2012-07-22 Thread Andy Walls
Hi Tejun, Thanks for responding to my previous questions. I have one more. On Sat, 2012-07-21 at 14:20 -0400, Andy Walls wrote: > On Thu, 2012-07-19 at 14:16 -0700, Tejun Heo wrote: > > From 06f9a06f4aeecdb9d07014713ab41b548ae219b5 Mon Sep 17 00:00:00 2001 > > From: Tejun Heo > > Date: Thu, 19

[PATCH] v4l2-compliance: Add commas to increase readability of displayed result

2012-07-22 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki --- utils/v4l2-compliance/v4l2-compliance.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/utils/v4l2-compliance/v4l2-compliance.cpp b/utils/v4l2-compliance/v4l2-compliance.cpp index 10b06f6..8083051 100644 --- a/utils/v4l2-complianc

tda18271 driver power consumption

2012-07-22 Thread Antti Palosaari
Moi Michael, I just realized tda18271 driver eats 160mA too much current after attach. This means, there is power management bug. When I plug my nanoStick it eats total 240mA, after tda18271 sleep is called it eats only 80mA total which is reasonable. If I use Digital Devices tda18271c2dd dri

cron job: media_tree daily build: ERRORS

2012-07-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sun Jul 22 19:00:23 CEST 2012 git hash:931efdf58bd83af8d0578a6cc53421675daf6d41 gcc version: i686-linux-gcc (GC

[PATCH] it913x (test) - add support for AVerMedia A373

2012-07-22 Thread Malcolm Priestley
Initial test support for IT9137/IT9133 dual. This test patch uses IT9135 firmware sets just in case they are version 2 chips. dvb-usb-it9135-01.fw dvb-usb-it9135-02.fw Signed-off-by: Malcolm Priestley --- drivers/media/dvb/dvb-usb/dvb-usb-ids.h |1 + drivers/media/dvb/dvb-usb/it913x.c

Re: AVerMedia A373 PCIe MiniCard Dual DVB-T - ITE IT913x Tuners

2012-07-22 Thread Malcolm Priestley
On Sun, 2012-07-22 at 17:34 +0100, John Layt wrote: > Hi, > > I have recently purchased an Acer Aspire Revo RL70 HTPC which comes > with a built-in "AVerMedia A373 MiniCard Dual DVB-T" which uses two > ITE T913x tuners. This card is currently unsupported in Linux and I > have documented some deta

[PATCH UPDATED 1/2] kthread_worker: reorganize to prepare for flush_kthread_work() reimplementation

2012-07-22 Thread Tejun Heo
>From 9a2e03d8ed518a61154f18d83d6466628e519f94 Mon Sep 17 00:00:00 2001 From: Tejun Heo Date: Thu, 19 Jul 2012 13:52:53 -0700 Make the following two non-functional changes. * Separate out insert_kthread_work() from queue_kthread_work(). * Relocate struct kthread_flush_work and kthread_flush_wor

Re: [PATCH 2/2] kthread_worker: reimplement flush_kthread_work() to allow freeing the work item being executed

2012-07-22 Thread Tejun Heo
Hello, On Sat, Jul 21, 2012 at 02:20:06PM -0400, Andy Walls wrote: > > + worker->current_work = work; > > spin_unlock_irq(&worker->lock); > > > > if (work) { > > __set_current_state(TASK_RUNNING); > > work->func(work); > > If the call to 'work->func(work);' fre

Re: [PATCH 1/2] kthread_worker: reorganize to prepare for flush_kthread_work() reimplementation

2012-07-22 Thread Tejun Heo
Hello, On Sat, Jul 21, 2012 at 01:13:27PM -0400, Andy Walls wrote: > > +/* insert @work before @pos in @worker */ > > Hi Tejun, > > Would a comment that the caller should be holding worker->lock be useful > here? Anyway, comment or not: > > Acked-by: Andy Walls Will add lockdep_assert_held()

AVerMedia A373 PCIe MiniCard Dual DVB-T - ITE IT913x Tuners

2012-07-22 Thread John Layt
Hi, I have recently purchased an Acer Aspire Revo RL70 HTPC which comes with a built-in "AVerMedia A373 MiniCard Dual DVB-T" which uses two ITE T913x tuners. This card is currently unsupported in Linux and I have documented some details on the wiki at http://linuxtv.org/wiki/index.php/AVerMedia_A

Re: Firmware in da wonderland

2012-07-22 Thread Antti Palosaari
On 07/21/2012 09:04 PM, poma wrote: On 07/21/2012 05:35 PM, Antti Palosaari wrote: On 07/21/2012 06:32 PM, poma wrote: This one speak for itself; … usb 1-1: new high-speed USB device number 8 using ehci_hcd usb 1-1: New USB device found, idVendor=0ccd, idProduct=0097 usb 1-1: New USB device st