[PATCH 1/1] v4l: Remove experimental tag from certain API elements

2012-09-01 Thread Sakari Ailus
Remove experimantal tag from the following API elements: V4L2_BUF_TYPE_VIDEO_OUTPUT_OVERLAY buffer type. V4L2_CAP_VIDEO_OUTPUT_OVERLAY capability flag. VIDIOC_ENUM_FRAMESIZES IOCTL. VIDIOC_G_ENC_INDEX IOCTL. VIDIOC_ENCODER_CMD and VIDIOC_TRY_ENCODER_CMD IOCTLs. VIDIOC_DECODER_CMD and VIDIOC_TRY_DE

Re: [PATCH] [media] mceusb: Optimize DIV_ROUND_CLOSEST call

2012-09-01 Thread Guenter Roeck
On Sat, Sep 01, 2012 at 08:53:57PM +0200, Jean Delvare wrote: > DIV_ROUND_CLOSEST is faster if the compiler knows it will only be > dealing with unsigned dividends. > > Signed-off-by: Jean Delvare > Cc: Andrew Morton > Cc: Guenter Roeck > Cc: Mauro Carvalho Chehab Tested-by: Guenter Roeck >

Re: [PATCH] [media] davinci: vpfe: Add documentation

2012-09-01 Thread Laurent Pinchart
On Saturday 01 September 2012 19:11:56 Sakari Ailus wrote: > Hi Prabhakar, > > On Sat, Sep 01, 2012 at 08:23:58PM +0530, Prabhakar Lad wrote: > > On Sat, Sep 1, 2012 at 7:52 PM, Laurent Pinchart > > > > wrote: > > > Hi Sakari, > > > > > > On Saturday 01 September 2012 12:57:07 Sakari Ailus wrot

[PATCH 2/2] rtl28xxu: add support for Elonics E4000 tuner

2012-09-01 Thread Antti Palosaari
Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/Kconfig| 1 + drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 17 +++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/Kconfig b/drivers/media/usb/dvb-usb-v2/Kconfig index 967

[PATCH 1/2] Elonics E4000 silicon tuner driver

2012-09-01 Thread Antti Palosaari
Signed-off-by: Antti Palosaari --- drivers/media/tuners/Kconfig | 7 + drivers/media/tuners/Makefile | 1 + drivers/media/tuners/e4000.c | 408 ++ drivers/media/tuners/e4000.h | 52 + drivers/media/tuners/e4000_priv.h | 147 +

Re: [PATCH] rtl28xxu: correct usb_clear_halt() usage

2012-09-01 Thread Antti Palosaari
On 09/02/2012 01:58 AM, poma wrote: On 09/01/2012 07:37 PM, poma wrote: On 09/01/2012 05:48 PM, Antti Palosaari wrote: On 09/01/2012 06:35 PM, poma wrote: On 09/01/2012 03:54 PM, Antti Palosaari wrote: It is not allowed to call usb_clear_halt() after urbs are submitted. That causes oops somet

Re: [PATCH] rtl28xxu: correct usb_clear_halt() usage

2012-09-01 Thread poma
On 09/01/2012 07:37 PM, poma wrote: > On 09/01/2012 05:48 PM, Antti Palosaari wrote: >> On 09/01/2012 06:35 PM, poma wrote: >>> On 09/01/2012 03:54 PM, Antti Palosaari wrote: It is not allowed to call usb_clear_halt() after urbs are submitted. That causes oops sometimes. Move whole stream

cron job: media_tree daily build: WARNINGS

2012-09-01 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sat Sep 1 19:00:19 CEST 2012 git hash:79e8c7bebb467bbc3f2514d75bba669a3f354324 gcc version: i686-linux-gcc (GC

[PATCH] [media] mceusb: Optimize DIV_ROUND_CLOSEST call

2012-09-01 Thread Jean Delvare
DIV_ROUND_CLOSEST is faster if the compiler knows it will only be dealing with unsigned dividends. Signed-off-by: Jean Delvare Cc: Andrew Morton Cc: Guenter Roeck Cc: Mauro Carvalho Chehab --- drivers/media/rc/mceusb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-3.6-rc

Re: [PATCH] rtl28xxu: correct usb_clear_halt() usage

2012-09-01 Thread poma
On 09/01/2012 05:48 PM, Antti Palosaari wrote: > On 09/01/2012 06:35 PM, poma wrote: >> On 09/01/2012 03:54 PM, Antti Palosaari wrote: >>> It is not allowed to call usb_clear_halt() after urbs are submitted. >>> That causes oops sometimes. Move whole streaming_ctrl() logic to >>> power_ctrl() in or

Re: [PATCH] [media] davinci: vpfe: Add documentation

2012-09-01 Thread Sakari Ailus
On Sat, Sep 01, 2012 at 08:25:30PM +0300, Sakari Ailus wrote: > That would be against the V4L2 spec. It's explicitly defined that the source > compose rectangle defines the output size of the scaler. This should be sink, not source. -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@re

Re: [PATCH] [media] davinci: vpfe: Add documentation

2012-09-01 Thread Sakari Ailus
Hi Manju, My apologies for the delayed answer. On Wed, Aug 22, 2012 at 02:26:50PM +0530, Manjunath Hadli wrote: > On Thursday 16 August 2012 09:53 PM, Sakari Ailus wrote: > > On Thu, Aug 09, 2012 at 09:13:52AM +0530, Manjunath Hadli wrote: > >> On Thursday 02 August 2012 05:37 AM, Sakari Ailus wr

Re: [PATCHv3 9/9] ir-rx51: Add missing quote mark in Kconfig text

2012-09-01 Thread Sakari Ailus
Moi, On Thu, Aug 30, 2012 at 08:54:31PM +0300, Timo Kokkonen wrote: > This trivial fix cures the following warning message: > > drivers/media/rc/Kconfig:275:warning: multi-line strings not supported > > Signed-off-by: Timo Kokkonen > --- > drivers/media/rc/Kconfig | 2 +- > 1 file changed, 1 i

Re: [PATCHv3 2/9] ir-rx51: Handle signals properly

2012-09-01 Thread Sakari Ailus
Moi, On Thu, Aug 30, 2012 at 08:54:24PM +0300, Timo Kokkonen wrote: > @@ -273,9 +281,18 @@ static ssize_t lirc_rx51_write(struct file *file, const > char *buf, > > /* >* Don't return back to the userspace until the transfer has > - * finished > + * finished. However, we

Re: Fwd: [PATCH, RFC] Fix DVB ioctls failing if frontend open/closed too fast

2012-09-01 Thread Antti Palosaari
On 09/01/2012 07:26 PM, Devin Heitmueller wrote: On Sat, Sep 1, 2012 at 12:13 PM, Antti Palosaari wrote: Is there anyone caring to review that carefully? I am quite out with semaphores (up/down_interruptible) and also frontend is so complex... I would rather design / write whole dvb-frontend f

Re: Fwd: [PATCH, RFC] Fix DVB ioctls failing if frontend open/closed too fast

2012-09-01 Thread Devin Heitmueller
On Sat, Sep 1, 2012 at 12:13 PM, Antti Palosaari wrote: > Is there anyone caring to review that carefully? > > I am quite out with semaphores (up/down_interruptible) and also frontend is > so complex... I would rather design / write whole dvb-frontend from the > scratch :] (not doing that as no ti

Re: Fwd: [PATCH, RFC] Fix DVB ioctls failing if frontend open/closed too fast

2012-09-01 Thread Antti Palosaari
On 09/01/2012 06:51 PM, poma wrote: On 08/12/2012 04:15 AM, Mauro Carvalho Chehab wrote: Devin/Antti, As Juergen mentioned your help on this patch, do you mind helping reviewing and testing it? Touching on those semaphores can be very tricky, as anything wrong may cause a driver hangup. So, it

Re: [PATCH] [media] davinci: vpfe: Add documentation

2012-09-01 Thread Sakari Ailus
Hi Prabhakar, On Sat, Sep 01, 2012 at 08:23:58PM +0530, Prabhakar Lad wrote: > On Sat, Sep 1, 2012 at 7:52 PM, Laurent Pinchart > wrote: > > Hi Sakari, > > > > On Saturday 01 September 2012 12:57:07 Sakari Ailus wrote: > >> On Wed, Aug 29, 2012 at 08:11:50PM +0530, Prabhakar Lad wrote: > > > > [s

Re: Fwd: [PATCH, RFC] Fix DVB ioctls failing if frontend open/closed too fast

2012-09-01 Thread poma
On 08/12/2012 04:15 AM, Mauro Carvalho Chehab wrote: > Devin/Antti, > > As Juergen mentioned your help on this patch, do you mind helping reviewing > and testing it? > > Touching on those semaphores can be very tricky, as anything wrong may cause > a driver hangup. So, it is great to have more pa

Re: [PATCH] rtl28xxu: correct usb_clear_halt() usage

2012-09-01 Thread Antti Palosaari
On 09/01/2012 06:35 PM, poma wrote: On 09/01/2012 03:54 PM, Antti Palosaari wrote: It is not allowed to call usb_clear_halt() after urbs are submitted. That causes oops sometimes. Move whole streaming_ctrl() logic to power_ctrl() in order to avoid wrong usb_clear_halt() use. Also, configuring st

Re: [PATCH] rtl28xxu: correct usb_clear_halt() usage

2012-09-01 Thread poma
On 09/01/2012 03:54 PM, Antti Palosaari wrote: > It is not allowed to call usb_clear_halt() after urbs are submitted. > That causes oops sometimes. Move whole streaming_ctrl() logic to > power_ctrl() in order to avoid wrong usb_clear_halt() use. Also, > configuring streaming endpoint in streaming_c

Re: [PATCH] [media] davinci: vpfe: Add documentation

2012-09-01 Thread Prabhakar Lad
Hi Laurent, On Sat, Sep 1, 2012 at 7:52 PM, Laurent Pinchart wrote: > Hi Sakari, > > On Saturday 01 September 2012 12:57:07 Sakari Ailus wrote: >> On Wed, Aug 29, 2012 at 08:11:50PM +0530, Prabhakar Lad wrote: > > [snip] > >> > For test pattern you meant control to enable/disable it ? >> >> There

Re: [PATCH] [media] davinci: vpfe: Add documentation

2012-09-01 Thread Laurent Pinchart
Hi Sakari, On Saturday 01 September 2012 12:57:07 Sakari Ailus wrote: > On Wed, Aug 29, 2012 at 08:11:50PM +0530, Prabhakar Lad wrote: [snip] > > For test pattern you meant control to enable/disable it ? > > There are two approaches I can think of. > > One is a menu control which can be used t

[PATCH] rtl28xxu: correct usb_clear_halt() usage

2012-09-01 Thread Antti Palosaari
It is not allowed to call usb_clear_halt() after urbs are submitted. That causes oops sometimes. Move whole streaming_ctrl() logic to power_ctrl() in order to avoid wrong usb_clear_halt() use. Also, configuring streaming endpoint in streaming_ctrl() sounds like a little bit wrong as it is aimed for

Re: [PATCH 2/5] rtl28xxu: fix rtl2832u module reload fails bug

2012-09-01 Thread poma
On 08/22/2012 01:56 AM, Antti Palosaari wrote: > This is workaround / partial fix. > > rtl2832u_power_ctrl() and rtl2832u_frontend_attach() needs to > be go through carefully and fix properly. There is clearly > some logical errors when handling power-management ang GPIOs... > > Signed-off-by: An

Re: [PATCH 1/5] rtl28xxu: stream did not start after stop on USB3.0

2012-09-01 Thread Antti Palosaari
On 09/01/2012 04:33 PM, poma wrote: On 08/22/2012 01:56 AM, Antti Palosaari wrote: Stream did not start anymore after stream was stopped once. Following error can be seen, xhci_hcd WARN Set TR Deq Ptr cmd failed due to incorrect slot or ep state. usb_clear_halt for streaming endpoint helps. S

Re: [PATCH 1/5] rtl28xxu: stream did not start after stop on USB3.0

2012-09-01 Thread poma
On 08/22/2012 01:56 AM, Antti Palosaari wrote: > Stream did not start anymore after stream was stopped once. > > Following error can be seen, xhci_hcd > WARN Set TR Deq Ptr cmd failed due to incorrect slot or ep state. > > usb_clear_halt for streaming endpoint helps. > > Signed-off-by: Antti Pal

Re: [PATCH] [media] davinci: vpfe: Add documentation

2012-09-01 Thread Sakari Ailus
Hi Prabhakar, On Wed, Aug 29, 2012 at 08:11:50PM +0530, Prabhakar Lad wrote: ... > >> >> +unsigned short len; > >> >> +void *config; > >> >> +}; > >> >> + > >> >> +5: IOCTL: VPFE_CMD_S_CCDC_RAW_PARAMS/VPFE_CMD_G_CCDC_RAW_PARAMS > >> >> +Description: > >> >> +Sets/Gets the C