Hi Sylwester,
On Sat, Jan 26, 2013 at 1:24 AM, Sylwester Nawrocki
wrote:
> Hi Prahakar,
>
>
> On 01/25/2013 08:01 AM, Prabhakar Lad wrote:
>>
>> From: Manjunath Hadli
>>
>> A lot of SOCs including Texas Instruments Davinci family mainly use
>> video decoders as input devices. Here the initial sub
Found with coccicheck.
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Peter Huewe
---
drivers/staging/media/go7007/go7007-driver.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/go700
Found with coccicheck.
The semantic patch that makes this change is available
in scripts/coccinelle/api/ptr_ret.cocci.
Signed-off-by: Peter Huewe
---
drivers/staging/media/solo6x10/v4l2.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/solo6x10
This patch should pass at least one test case of this bug.
Signed-off-by: Thomas Schorpp
y
tom
8043-Jan 24 18:33:14 tom3 kernel: [ 457.636878] BUG: unable to handle kernel
NULL pointer dereference at 002c
8044:Jan 24 18:33:14 tom3 kernel: [ 457.637016] IP: []
crystalhd_dioq_fet
Hi Mauro,
This change set includes the Omnivision OV9650/52 sensor driver and a
couple
related patches, adding v4l2 core helper functions and a header defining
standard image sizes. Please pull.
The following changes since commit a32f7d1ad3744914273c6907204c2ab3b5d496a0:
Merge branch 'v4l_f
Hi Prahakar,
On 01/25/2013 08:01 AM, Prabhakar Lad wrote:
From: Manjunath Hadli
A lot of SOCs including Texas Instruments Davinci family mainly use
video decoders as input devices. Here the initial subdevice node
from where the input really comes is this decoder, for which support
is needed as
Document that monotonic timestamps are taken after the corresponding frame
has been received, not when the reception has begun. This corresponds to the
reality of current drivers: the timestamp is naturally taken when the
hardware triggers an interrupt to tell the driver to handle the received
fram
Avoids registering a VBI device and streaming in VBI-mode if the device is a
camera.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-core.c |5 +
1 Datei geändert, 5 Zeilen hinzugefügt(+)
diff --git a/drivers/media/usb/em28xx/em28xx-core.c
b/drivers/media/usb/em28xx/em
v4l2_device_disconnect() is called when the device is disconnected, so that the
v4l2-core rejects all ioctl calls.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 43 ---
1 Datei geändert, 43 Zeilen entfernt(-)
diff --git a/drivers/media/
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c |1 +
1 Datei geändert, 1 Zeile hinzugefügt(+)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers/media/usb/em28xx/em28xx-video.c
index dd05cfb..e97b095 100644
--- a/drivers/media/usb/em28xx/em28xx-video.c
The tuner type is set by the v4l2-core based on the device type.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c |1 -
1 Datei geändert, 1 Zeile entfernt(-)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c
b/drivers/media/usb/em28xx/em28xx-video.c
index af3e70a
The em28xx driver doesn't support the VIDIOC_G_CROP and VIDIOC_S_CROP ioctls,
so VIDIOC_CROPCAP is useless and has the potential to confuse applications,
because it can be interpreted as indicator for cropping support.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c |
vidioc_s_fmt_vbi_cap() is a 100% duplicate of vidioc_g_fmt_vbi_cap() and
therefore can be removed.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 31 +--
1 Datei geändert, 1 Zeile hinzugefügt(+), 30 Zeilen entfernt(-)
diff --git a/driver
With the current code V4L2_BUF_TYPE_VIDEO_CAPTURE is accepted only, but for VBI
devices only buffer type V4L2_BUF_TYPE_VBI_CAPTURE is used/valid.
Remove the buffer type check entirely, because this is already done by the
v4l2-core.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28
VIDIOC_S_PARM doesn't make sense for VBI device nodes, because we don't support
selecting the number of read buffers to use.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c |1 +
1 Datei geändert, 1 Zeile hinzugefügt(+)
diff --git a/drivers/media/usb/em28xx/em28xx-v
Instead of checking the device type and returning -ENOTTY inside the ioctl
functions, use v4l2_disable_ioctl() to disable the ioctls VIDIOC_QUERYSTD,
VIDIOC_G_STD and VIDIOC_S_STD if the device is a camera.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 13 +++--
Instead of checking the device type and returning -ENOTTY inside the ioctl
function, use v4l2_disable_ioctl() to disable the ioctl VIDIOC_S_PARM if the
device is not a camera.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c |5 ++---
1 Datei geändert, 2 Zeilen hinzug
Instead of checking the device type and returning -EINVAL inside the ioctl
functions, use v4l2_disable_ioctl() to disable the ioctls VIDIOC_G_AUDIO and
VIDIOC_S_AUDIO if the device doesn't support audio.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 15
Disable the ioctls VIDIOC_G_TUNER, VIDIOC_S_TUNER, VIDIOC_G_FREQUENCY and
VIDIOC_S_FREQUENCY for video and VBI devices without tuner.
Signed-off-by: Frank Schäfer
---
drivers/media/usb/em28xx/em28xx-video.c | 14 ++
1 Datei geändert, 14 Zeilen hinzugefügt(+)
diff --git a/drivers/m
This patch series addresses some issues with the ioctl code of the em28xx
driver:
Patches 1-5 and 11 fix and clean up the enabling/disabling of the ioctls
depending on the device type and equipment.
Patches 6-10 remove some obsolete/useless code.
Patch 12 improves the VBI support detection and de
Am 24.01.2013 08:51, schrieb Hans Verkuil:
> From: Hans Verkuil
>
> Signed-off-by: Hans Verkuil
> ---
> drivers/media/i2c/mt9v011.c | 223
> +--
> 1 file changed, 67 insertions(+), 156 deletions(-)
>
> diff --git a/drivers/media/i2c/mt9v011.c b/drivers/m
On Fri January 25 2013 14:40:45 Hans de Goede wrote:
> Hi,
>
> On 01/25/2013 11:40 AM, Hans Verkuil wrote:
>
>
>
> >> What I did notice is that pwc_vidioc_try_fmt returns EINVAL when
> >> an unsupported pixelformat is requested. IIRC we agreed that the
> >> correct behavior in this case is to i
Hi,
On 01/25/2013 11:40 AM, Hans Verkuil wrote:
What I did notice is that pwc_vidioc_try_fmt returns EINVAL when
an unsupported pixelformat is requested. IIRC we agreed that the
correct behavior in this case is to instead just change the
pixelformat to a default format, so I'll write a patch
On Fri, Jan 25, 2013 at 11:29:55AM +0100, Kamil Debski wrote:
> Hi,
>
> This is the third version of the patch posted earlier this month.
> After the discussion a WARN_ON was added to inform if the driver is not
> setting
> timestamp type when initialising the videobuf2 queue. Small correction to
Hi Kamil,
Thanks for the patches.
On Friday 25 January 2013 11:29:55 Kamil Debski wrote:
> Hi,
>
> This is the third version of the patch posted earlier this month.
> After the discussion a WARN_ON was added to inform if the driver is not
> setting timestamp type when initialising the videobuf2
Hi Prabhakar,
As mentioned in my review of your ths7353 driver we (Cisco) have a driver
for this device as well. Below is our driver so you can take the best bits
of both.
However, I wonder if instead the ths7353 driver and the already existing
ths7303 driver should just be merged. They are awful
On Fri January 25 2013 11:29:57 Kamil Debski wrote:
> Not all drivers use monotonic timestamps. This patch adds a way to set the
> timestamp type per every queue.
>
> In addition, set proper timestamp type in drivers that I am sure that use
> either MONOTONIC or COPY timestamps. Other drivers will
Hi Prabhakar,
Some comments below:
On Fri January 25 2013 11:36:07 Prabhakar Lad wrote:
> From: Manjunath Hadli
>
> The patch adds support for THS7353 video amplifier. Enable
> dv_preset support for THS7353 so that setting a HD mode on the
> host device makes sure appropriate mode in the amplif
On Fri January 25 2013 11:29:56 Kamil Debski wrote:
> Define video buffer flag for the COPY timestamp. In this case the timestamp
> value is copied from the OUTPUT to the corresponding CAPTURE buffer.
>
> Signed-off-by: Kamil Debski
> Signed-off-by: Kyungmin Park
Acked-by: Hans Verkuil
Regard
On Fri January 25 2013 10:51:57 Hans de Goede wrote:
>
>
> Hi,
>
> On 12/25/2012 05:56 AM, Mauro Carvalho Chehab wrote:
>
> > The pwc driver can currently return -ENOENT at VIDIOC_S_FMT ioctl. This
> > doesn't seem right. Instead, it should be getting the closest format to
> > the requested one
From: Lad, Prabhakar
This patch series adds driver for THS7353 video amplifier.
The first patch of the series adds the chip-id for THS7353 and
the second patch adds the driver.
Manjunath Hadli (2):
media: add chip id for THS7353
media: add support for THS7353 video amplifier
drivers/media/
From: Manjunath Hadli
add chip id for THS7353 amplifier.
Signed-off-by: Manjunath Hadli
Signed-off-by: Lad, Prabhakar
---
include/media/v4l2-chip-ident.h |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/media/v4l2-chip-ident.h b/include/media/v4l2-chip-ident.
Hi Mauro,
Please pull from my gspca tree for the gspca IS_ENABLED patches + 1 pwc fix
The following changes since commit a32f7d1ad3744914273c6907204c2ab3b5d496a0:
Merge branch 'v4l_for_linus' into staging/for_v3.9 (2013-01-24 18:49:18 -0200)
are available in the git repository at:
git://
From: Manjunath Hadli
The patch adds support for THS7353 video amplifier. Enable
dv_preset support for THS7353 so that setting a HD mode on the
host device makes sure appropriate mode in the amplifier is enabled.
Signed-off-by: Manjunath Hadli
Signed-off-by: Lad, Prabhakar
---
drivers/media/i
Not all drivers use monotonic timestamps. This patch adds a way to set the
timestamp type per every queue.
In addition, set proper timestamp type in drivers that I am sure that use
either MONOTONIC or COPY timestamps. Other drivers will correctly report
UNKNOWN timestamp type instead of assuming t
Define video buffer flag for the COPY timestamp. In this case the timestamp
value is copied from the OUTPUT to the corresponding CAPTURE buffer.
Signed-off-by: Kamil Debski
Signed-off-by: Kyungmin Park
---
Documentation/DocBook/media/v4l/io.xml |6 ++
include/uapi/linux/videodev2.h
Hi,
This is the third version of the patch posted earlier this month.
After the discussion a WARN_ON was added to inform if the driver is not setting
timestamp type when initialising the videobuf2 queue. Small correction to the
documentation was also made and two patche were squashed to avoid prob
Hi Sakari,
> From: Sakari Ailus [mailto:sakari.ai...@iki.fi]
> Sent: Thursday, January 24, 2013 8:12 PM
>
[snip]
> > >
> > > Do you have a list of those other drivers using vb2 that will
> report
> > > an unknown timestamp type ?
> >
> > Here are the drivers:
> >
> > drivers/media/platform/coda
This patch adds device tree based discovery support to G2D driver
Signed-off-by: Sachin Kamat
---
drivers/media/platform/s5p-g2d/g2d.c | 17 -
1 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/drivers/media/platform/s5p-g2d/g2d.c
b/drivers/media/platform/s5p-g2d/
From: Ajay Kumar
This patch adds device tree match table for Exynos G2D controller.
Signed-off-by: Ajay Kumar
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exyno
From: Manjunath Hadli
add support for TVP514x as a media entity and support for
pad operations. The decoder supports 1 output pad.
The default format code was V4L2_MBUS_FMT_YUYV10_2X10
changed it to V4L2_MBUS_FMT_UYVY8_2X8.
Signed-off-by: Manjunath Hadli
Signed-off-by: Lad, Prabhakar
---
This
Hi,
On 12/25/2012 05:56 AM, Mauro Carvalho Chehab wrote:
The pwc driver can currently return -ENOENT at VIDIOC_S_FMT ioctl. This
doesn't seem right. Instead, it should be getting the closest format to
the requested one and return 0, passing the selected format back to
userspace, just like the
Add conversion from videomode to drm_display_mode
Signed-off-by: Steffen Trumtrar
Reviewed-by: Thierry Reding
Acked-by: Thierry Reding
Tested-by: Thierry Reding
Tested-by: Philipp Zabel
Reviewed-by: Laurent Pinchart
Acked-by: Laurent Pinchart
Tested-by: Afzal Mohammed
Tested-by: Rob Clark
The struct display_timing is specific to the via subsystem. The naming leads to
collisions with the new struct display_timing, which is supposed to be a shared
struct between different subsystems.
To clean this up, prepend the existing struct with the subsystem it is specific
to.
Signed-off-by: St
Hi!
This is basically just a resend of v16 that was rebased onto v3.8-rc4 and has
two new "tested-by"s from Rob and Leela.
The patches were tested with:
- v15 on Tegra by Thierry
- sh-mobile-lcdcfb by Laurent
- MX53QSB by Marek
- Exynos: smdk5250 by Leela
Add display_timing structure and the according helper functions. This allows
the description of a display via its supported timing parameters.
Also, add helper functions to convert from display timings to a generic
videomode
structure.
The struct display_timing specifies all needed parameters to
Add a function to convert from the generic videomode to a fb_videomode.
Signed-off-by: Steffen Trumtrar
Reviewed-by: Thierry Reding
Acked-by: Thierry Reding
Tested-by: Thierry Reding
Tested-by: Philipp Zabel
Reviewed-by: Laurent Pinchart
Acked-by: Laurent Pinchart
Tested-by: Afzal Mohammed
This adds support for reading display timings from DT into a struct
display_timings. The of_display_timing implementation supports multiple
subnodes. All children are read into an array, that can be queried.
If no native mode is specified, the first subnode will be used.
For cases where the graph
Add helper to get fb_videomode from devicetree.
Signed-off-by: Steffen Trumtrar
Reviewed-by: Thierry Reding
Acked-by: Thierry Reding
Tested-by: Thierry Reding
Tested-by: Philipp Zabel
Reviewed-by: Laurent Pinchart
Acked-by: Laurent Pinchart
Tested-by: Afzal Mohammed
Tested-by: Rob Clark
T
Add helper to get drm_display_mode from devicetree.
Signed-off-by: Steffen Trumtrar
Reviewed-by: Thierry Reding
Acked-by: Thierry Reding
Tested-by: Thierry Reding
Tested-by: Philipp Zabel
Reviewed-by: Laurent Pinchart
Acked-by: Laurent Pinchart
Tested-by: Afzal Mohammed
Tested-by: Rob Clar
Hi Afzal,
On Thu, Jan 24, 2013 at 08:47:02AM +, Mohammed, Afzal wrote:
> Hi Steffen,
>
> On Thu, Jan 24, 2013 at 13:49:58, Steffen Trumtrar wrote:
>
> > Thanks. I'll use that opportunity for a v17 that is rebased onto 3.8-rc4.
>
> As you are going to have a v17, if you can fold the diff[1]
51 matches
Mail list logo
