Re: [PATCH v6 3/7] media: soc-camera: switch I2C subdevice drivers to use v4l2-clk

2013-03-18 Thread Hans Verkuil
On Fri March 15 2013 22:27:49 Guennadi Liakhovetski wrote: Instead of centrally enabling and disabling subdevice master clocks in soc-camera core, let subdevice drivers do that themselves, using the V4L2 clock API and soc-camera convenience wrappers. Signed-off-by: Guennadi Liakhovetski

Re: [RFC V1 2/8] smi2021: Add smi2021_main.c

2013-03-18 Thread Hans Verkuil
Hi Jon Arne, Here is my review of this driver. Regards, Hans On Thu March 14 2013 15:06:58 Jon Arne Jørgensen wrote: This is the core of the smi2021 module. It will register the module with the kernel, and register the usb probe function. Signed-off-by: Jon Arne Jørgensen

Re: [RFC V1 3/8] smi2021: Add smi2021_i2c.c

2013-03-18 Thread Hans Verkuil
On Thu March 14 2013 15:06:59 Jon Arne Jørgensen wrote: This file is responsible for registering the device with the kernel i2c subsystem. v4l2 talks to the saa7113 chip of the device via i2c. Signed-off-by: Jon Arne Jørgensen jona...@jonarne.no --- drivers/media/usb/smi2021/smi2021_i2c.c

Re: [RFC V1 4/8] smi2021: Add smi2021_v4l2.c

2013-03-18 Thread Hans Verkuil
On Thu March 14 2013 15:07:00 Jon Arne Jørgensen wrote: This file is responsible for registering the device with the v4l2 subsystem, and the communication with v4l2. Most of the v4l2 ioctls are just passed on to vidbuf2. Signed-off-by: Jon Arne Jørgensen jona...@jonarne.no ---

Re: [RFC V1 5/8] smi2021: Add smi2021_video.c

2013-03-18 Thread Hans Verkuil
On Thu March 14 2013 15:07:01 Jon Arne Jørgensen wrote: This file is responsible for all communication with the video hardware and also starting and stopping the capture. It also contains the setup and handling of the usb ISOCHRONOUS transfers. Signed-off-by: Jon Arne Jørgensen

Re: [RFC V1 4/8] smi2021: Add smi2021_v4l2.c

2013-03-18 Thread Hans Verkuil
On Thu March 14 2013 15:07:00 Jon Arne Jørgensen wrote: This file is responsible for registering the device with the v4l2 subsystem, and the communication with v4l2. Most of the v4l2 ioctls are just passed on to vidbuf2. Signed-off-by: Jon Arne Jørgensen jona...@jonarne.no ---

Re: [RFC V1 2/8] smi2021: Add smi2021_main.c

2013-03-18 Thread Hans Verkuil
On Thu March 14 2013 15:06:58 Jon Arne Jørgensen wrote: This is the core of the smi2021 module. It will register the module with the kernel, and register the usb probe function. Signed-off-by: Jon Arne Jørgensen jona...@jonarne.no --- drivers/media/usb/smi2021/smi2021_main.c | 339

Re: [PATCH v3] media: davinci: kconfig: fix incorrect selects

2013-03-18 Thread Sekhar Nori
On 3/16/2013 2:06 PM, Prabhakar Lad wrote: Hi Sekhar, Thanks for the patch! On Tue, Mar 12, 2013 at 2:44 PM, Sekhar Nori nsek...@ti.com wrote: drivers/media/platform/davinci/Kconfig uses selects where it should be using 'depends on'. This results in warnings of the following sort when

Re: [RFC V1 5/8] smi2021: Add smi2021_video.c

2013-03-18 Thread Bjørn Mork
Hans Verkuil hverk...@xs4all.nl writes: +/* + * + * The device delivers data in chunks of 0x400 bytes. + * The four first bytes is a magic header to identify the chunks. + * 0xaa 0xaa 0x00 0x00 = saa7113 Active Video Data + * 0xaa 0xaa 0x00 0x01 = PCM - 24Bit 2 Channel audio data + */

Re: [RFC V1 7/8] smi2021: Add smi2021_bl.c

2013-03-18 Thread Bjørn Mork
Jon Arne Jørgensen jona...@jonarne.no writes: This is the smi2021-bootloader module. This module will upload the firmware for the different somagic devices. I really don't understand why you want to make that a separate module. Building both the bootlader driver and the real driver into the

[PATCH] [media] mx2_camera: use module_platform_driver_probe()

2013-03-18 Thread Fabio Porcedda
The commit 39793c6 [media] mx2_camera: Convert it to platform driver used module_platform_driver() to make code smaller, but since the driver used platform_driver_probe is more appropriate to use module_platform_driver_probe(). Signed-off-by: Fabio Porcedda fabio.porce...@gmail.com Cc: Fabio

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-18 Thread Fabio Porcedda
On Fri, Mar 15, 2013 at 9:18 PM, Arnd Bergmann a...@arndb.de wrote: On Friday 15 March 2013, H Hartley Sweeten wrote: Arnd, Ill look at converting the ep93xx pwm driver to the PWM subsystem. The only issue is the current driver exposes a sysfs interface that I think is not available in

Re: [PATCH v6 3/7] media: soc-camera: switch I2C subdevice drivers to use v4l2-clk

2013-03-18 Thread Guennadi Liakhovetski
On Mon, 18 Mar 2013, Hans Verkuil wrote: On Fri March 15 2013 22:27:49 Guennadi Liakhovetski wrote: Instead of centrally enabling and disabling subdevice master clocks in soc-camera core, let subdevice drivers do that themselves, using the V4L2 clock API and soc-camera convenience

Re: [PATCH] [media] mx2_camera: use module_platform_driver_probe()

2013-03-18 Thread Guennadi Liakhovetski
Hi Fabio On Mon, 18 Mar 2013, Fabio Porcedda wrote: The commit 39793c6 [media] mx2_camera: Convert it to platform driver used module_platform_driver() to make code smaller, but since the driver used platform_driver_probe is more appropriate to use module_platform_driver_probe().

Re: [PATCH v6 3/7] media: soc-camera: switch I2C subdevice drivers to use v4l2-clk

2013-03-18 Thread Hans Verkuil
On Mon March 18 2013 11:08:16 Guennadi Liakhovetski wrote: On Mon, 18 Mar 2013, Hans Verkuil wrote: On Fri March 15 2013 22:27:49 Guennadi Liakhovetski wrote: Instead of centrally enabling and disabling subdevice master clocks in soc-camera core, let subdevice drivers do that

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-18 Thread Arnd Bergmann
On Monday 18 March 2013, Fabio Porcedda wrote: Since by using platform_driver_probe() the function ep93xx_pwm_probe() is freed after initialization, is better to use module_platform_drive_probe(). IMHO i don't see any good reason to use module_platform_driver() for this driver. As I

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-18 Thread Fabio Porcedda
On Mon, Mar 18, 2013 at 11:58 AM, Arnd Bergmann a...@arndb.de wrote: On Monday 18 March 2013, Fabio Porcedda wrote: Since by using platform_driver_probe() the function ep93xx_pwm_probe() is freed after initialization, is better to use module_platform_drive_probe(). IMHO i don't see any good

Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()

2013-03-18 Thread Arnd Bergmann
On Monday 18 March 2013, Fabio Porcedda wrote: On Mon, Mar 18, 2013 at 11:58 AM, Arnd Bergmann a...@arndb.de wrote: On Monday 18 March 2013, Fabio Porcedda wrote: Since by using platform_driver_probe() the function ep93xx_pwm_probe() is freed after initialization, is better to use

[PATCH v2] soc_camera: Add RGB666 RGB888 formats

2013-03-18 Thread Phil Edworthy
Based on work done by Katsuya Matsubara. Signed-off-by: Phil Edworthy phil.edwor...@renesas.com --- v2: - Added documentation. - Added SOCAM_DATAWIDTH_12 definition. Documentation/DocBook/media/v4l/subdev-formats.xml | 206 +++- Documentation/DocBook/media_api.tmpl

[REVIEW PATCH 00/19] solo6x10: driver overhaul

2013-03-18 Thread Hans Verkuil
Hi all, This is my second attempt. This time I sync to the latest code from Bluecherry first before applying my patches. Remaining open issues: 1) Most importantly, the video from video0 is broken: it is supposed to be either one of the four inputs or a 2x2 image of all four inputs, instead

[REVIEW PATCH 02/19] solo6x10: fix querycap and update driver version.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Setup correct bus_info, let the v4l2 core set the version and add device_caps support. Also update the module version to 3.0.0 since this is a major upgrade. Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

[REVIEW PATCH 05/19] solo6x10: fix various format-related compliancy issues.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com - try_fmt should never return -EBUSY. - invalid pix-field values were not mapped to a valid value. - the priv field of struct v4l2_pix_format wasn't zeroed. - the try_fmt error code was not checked in set_fmt. - enum_framesizes/intervals is valid for both

[REVIEW PATCH 06/19] solo6x10: add support for prio and control event handling.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/solo6x10/v4l2-enc.c | 19 +-- drivers/staging/media/solo6x10/v4l2.c | 17 - 2 files changed, 33 insertions(+), 3 deletions(-) diff --git

[REVIEW PATCH 07/19] solo6x10: move global fields in solo_dev_fh to solo_dev.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com All fields in solo_dev_fh do not belong there since they refer to global properties. After moving all these fields to solo_dev the solo_dev_fh struct can be removed completely. Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

[REVIEW PATCH 03/19] solo6x10: add v4l2_device.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Add support for struct v4l2_device. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/solo6x10/core.c |8 ++-- drivers/staging/media/solo6x10/solo6x10.h |2 ++ drivers/staging/media/solo6x10/v4l2-enc.c |2

[REVIEW PATCH 04/19] solo6x10: add control framework.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Note that the MOTION_THRESHOLD functionality has been temporarily reduced: only the global threshold can be set, not the per-block. This will be addressed in a later patch: controls are not the proper way to do this. Signed-off-by: Hans Verkuil

[REVIEW PATCH 13/19] solo6x10: drop video_type and add proper s_std support.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/solo6x10/core.c | 19 drivers/staging/media/solo6x10/disp.c |8 + drivers/staging/media/solo6x10/solo6x10.h |6 +++-

[REVIEW PATCH 10/19] solo6x10: convert the display node to vb2.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com As a consequence the ioctl op has been replaced by unlocked_ioctl. Since we are now using the core lock the locking scheme has been simplified as well. The main reason for converting this driver to vb2 was that the locking scheme in v4l2.c was hopeless.

[REVIEW PATCH 09/19] solo6x10: convert encoder nodes to vb2.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com As a consequence the ioctl op has been replaced by unlocked_ioctl. Since we are now using the core lock the locking scheme has been simplified as well. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/solo6x10/Kconfig|

[REVIEW PATCH 17/19] solo6x10: fix sequence handling.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/solo6x10/solo6x10.h |2 ++ drivers/staging/media/solo6x10/v4l2-enc.c |3 ++- drivers/staging/media/solo6x10/v4l2.c |3 ++- 3 files changed, 6 insertions(+), 2

[REVIEW PATCH 18/19] solo6x10: disable the 'priv' abuse.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/solo6x10/v4l2-enc.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/staging/media/solo6x10/v4l2-enc.c b/drivers/staging/media/solo6x10/v4l2-enc.c index

[REVIEW PATCH 15/19] solo6x10: small big-endian fix.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/solo6x10/disp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/solo6x10/disp.c b/drivers/staging/media/solo6x10/disp.c index

[REVIEW PATCH 16/19] solo6x10: use V4L2_PIX_FMT_MPEG4, not _FMT_MPEG

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com FMT_MPEG is for multiplexed streams, not elementary streams. The same is true for the V4L2_CID_MPEG_VIDEO_ENCODING control. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/solo6x10/v4l2-enc.c | 18 ++ 1

[REVIEW PATCH 14/19] solo6x10: also stop DMA if the SOLO_PCI_ERR_P2M_DESC is raised.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Otherwise the computer will hang. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/solo6x10/p2m.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/solo6x10/p2m.c

[REVIEW PATCH 12/19] solo6x10: add call to pci_dma_mapping_error.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Check the result of the dma mapping. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/solo6x10/p2m.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/media/solo6x10/p2m.c

[REVIEW PATCH 19/19] solo6x10: clean up motion detection handling.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com An earlier patch temporarily disabled regional motion detection. This patch adds it back: the 'Motion Detection Enable' control is now a 'Motion Detection Mode'. And to set/get the regional thresholds two new ioctls were added to get/set those

[REVIEW PATCH 11/19] solo6x10: fix 'BUG: key ffff88081a2a9b58 not in .data!'

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Caused by a missing sysfs_attr_init(). Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/staging/media/solo6x10/core.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/solo6x10/core.c

[REVIEW PATCH 08/19] solo6x10: move global fields in solo_enc_fh to solo_enc_dev.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com All fields in solo_enc_fh do not belong there since they refer to global properties. After moving all these fields to solo_enc_dev the solo_dev_fh struct can be removed completely. Note that this also kills the 'listener' feature of this driver. This

Re: [RFC PATCH 5/8] s5p-fimc: Add ISP video capture driver stubs

2013-03-18 Thread Hans Verkuil
On Sun March 17 2013 22:03:38 Sylwester Nawrocki wrote: On 03/12/2013 03:44 PM, Hans Verkuil wrote: On Mon 11 March 2013 20:44:49 Sylwester Nawrocki wrote: [...] +static int isp_video_capture_open(struct file *file) +{ + struct fimc_isp *isp = video_drvdata(file); + int ret = 0; +

Re: Fw: [patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio

2013-03-18 Thread Jiri Kosina
On Fri, 15 Mar 2013, Alexey Klimov wrote: indeed your patch breaks Atmega applications which using V-USB (http://www.obdev.at/products/vusb/index.html), because 0x16c0, 0x05df are the default Ids of V-USB. Have a look at this FAQ

Re: [REVIEW PATCH 5/5] v4l2-ioctl: simplify debug code.

2013-03-18 Thread Hans Verkuil
On Fri March 15 2013 13:25:21 Laurent Pinchart wrote: Hi Hans, Thanks for the patch. On Friday 15 March 2013 11:27:25 Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com The core debug code can now be simplified since all the write-only ioctls are now const and will not

[REVIEWv2 PATCH 0/6] v4l2: constify _IOW ioctls

2013-03-18 Thread Hans Verkuil
This is the second version of this patch series. Two changes: - fixed the handling of a frequency of 0 in the radio-keene driver (thanks to Laurent for spotting that special case) - added a sixth patch that prevents the v4l2 core from printing more than the size of the buffer containing the

[REVIEWv2 PATCH 2/6] v4l2: add const to argument of write-only s_tuner ioctl.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This ioctl is defined as IOW, so pass the argument as const. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Alexey Klimov klimov.li...@gmail.com ---

[REVIEWv2 PATCH 4/6] v4l2: add const to argument of write-only s_register ioctl.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This ioctl is defined as IOW, so pass the argument as const. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com ---

[REVIEWv2 PATCH 1/6] v4l2: add const to argument of write-only s_frequency ioctl.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This ioctl is defined as IOW, so pass the argument as const. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/i2c/cx25840/cx25840-core.c |2 +- drivers/media/i2c/msp3400-driver.c |2 +-

[REVIEWv2 PATCH 5/6] v4l2-ioctl: simplify debug code.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The core debug code can now be simplified since all the write-only ioctls are now const and will not modify the data they pass to the drivers. So instead of logging write-only ioctls before the driver is called this can now be done afterwards, which is

[REVIEWv2 PATCH 6/6] v4l2-ioctl: add precision when printing names.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Never print more than the size of the buffer containing the name. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/v4l2-ioctl.c | 60 +++--- 1 file changed, 34 insertions(+), 26 deletions(-)

[REVIEWv2 PATCH 3/6] v4l2: pass std by value to the write-only s_std ioctl.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This ioctl is defined as IOW, so pass the argument by value instead of by reference. I could have chosen to add const instead, but this is 1) easier to handle in drivers and 2) consistent with the s_std subdev operation. Signed-off-by: Hans Verkuil

Re: [REVIEW PATCH 0/6] s5p-tv: replace dv_preset by dv_timings

2013-03-18 Thread Hans Verkuil
On Mon March 4 2013 14:02:00 Hans Verkuil wrote: Hi Tomasz, Here is what I hope is the final patch series for this. I've incorporated your suggestions and it's split off from the davinci/blackfin changes into its own patch series to keep things better organized. The changes since the

[RFC PATCH 0/6] Add VIDIOC_DBG_G_CHIP_NAME ioctl.

2013-03-18 Thread Hans Verkuil
This is a patch series implementing this proposal: http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/61539 It keeps the old CHIP_IDENT around for now. My plan is to start removing support for VIDIOC_G_CHIP_IDENT and the match types V4L2_CHIP_MATCH_I2C_DRIVER,

[RFC PATCH 2/6] v4l2: add new VIDIOC_DBG_G_CHIP_NAME ioctl.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Simplify the debugging ioctls by creating the VIDIOC_DBG_G_CHIP_NAME ioctl. This will eventually replace VIDIOC_DBG_G_CHIP_IDENT. Chip matching is done by the name or index of subdevices or an index to a bridge chip. Most of this can all be done

[RFC PATCH 1/6] v4l2-common: remove obsolete check for ' at the end of a driver name.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com During the transition to sub-devices several years ago non-subdev drivers had a ' at the end of their driver name to tell them apart from already converted drivers. This check was a left-over from that time and can be removed. Signed-off-by: Hans Verkuil

[RFC PATCH 4/6] em28xx: add support for g_chip_name.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Add support for vidioc_g_chip_name, allowing AC97 to be implemented as a second chip on the bridge with the name ac97. v4l2-dbg can just match the name with that string in order to detect a ac97-compliant set of registers. Signed-off-by: Hans Verkuil

[RFC PATCH 5/6] DocBook media: fix syntax problems in dvbproperty.xml

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Caught by xmllint. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- Documentation/DocBook/media/dvb/dvbproperty.xml | 46 +++ 1 file changed, 22 insertions(+), 24 deletions(-) diff --git

[RFC PATCH 3/6] stk1160: remove V4L2_CHIP_MATCH_AC97 placeholder.

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com It was just a placeholder and we want to get rid of the AC97 matching define. Also replace MATCH_HOST with MATCH_BRIDGE since we are here anyway. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/stk1160/stk1160-v4l.c |7

[RFC PATCH 6/6] DocBook media: add VIDIOC_DBG_G_CHIP_NAME documentation

2013-03-18 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com And update the other debug ioctls accordingly. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- Documentation/DocBook/media/v4l/v4l2.xml |4 +- .../DocBook/media/v4l/vidioc-dbg-g-chip-ident.xml | 14 +-

[PATCH v2] drivers: staging: davinci_vpfe: use resource_size()

2013-03-18 Thread Silviu-Mihai Popescu
This uses the resource_size() function instead of explicit computation. Signed-off-by: Silviu-Mihai Popescu silviupopescu1...@gmail.com --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c |2 +- drivers/staging/media/davinci_vpfe/dm365_isif.c|4 ++--

Re: [PATCH] drivers: staging: davinci_vpfe: use resource_size()

2013-03-18 Thread Silviu Popescu
On Sun, Mar 17, 2013 at 3:38 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Hi, Thanks for the patch! did you build test this patch ? the above header file(ioport.h) is not required in all the above files which you included. Cheers, --Prabhakar Lad Hi, It would seem I was a bit

[PATCH 1/2] dvb-frontend: split set_delivery_system()

2013-03-18 Thread Mauro Carvalho Chehab
This function is complex, and has different workflows, one for DVBv3 calls, and another one for DVBv5 calls. Break it into 3 functions, in order to make easier to understand what each block does. No functional changes so far. A few comments got improved. Signed-off-by: Mauro Carvalho Chehab

[PATCH 2/2] dvb_frontend: Simplify the emulation logic

2013-03-18 Thread Mauro Carvalho Chehab
The current logic was broken and too complex; while it works fine for DVB-S2/DVB-S, it is broken for ISDB-T. Make the logic simpler, fixes it for ISDB-T and make it clearer. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com --- drivers/media/dvb-core/dvb_frontend.c | 219

cron job: media_tree daily build: WARNINGS

2013-03-18 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Mar 18 19:00:23 CET 2013 git branch: test git hash: 4d35435d3ffb853b491f5bb21a62529cd925d660 gcc

[GIT PULL] IT913X

2013-03-18 Thread Antti Palosaari
That patch serie adds new silicon RF-tuner driver named IT913X and IT9135 support for existing AF9035/AF9033 drivers. IT913X driver is split out from the existing IT9135 driver. IT913X serie is successor of AF903X serie. Difference is integrated RF-tuner. Also those two letters has changed

[PATCH] [media] Add a V4L2 OF parser

2013-03-18 Thread Sylwester Nawrocki
From: Guennadi Liakhovetski g.liakhovet...@gmx.de Add a V4L2 OF parser, implementing bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de [s.nawro...@samsung.com: various corrections and improvements since

Re: [PATCH 2/2] dvb_frontend: Simplify the emulation logic

2013-03-18 Thread Fabio Estevam
Hi Mauro, On Mon, Mar 18, 2013 at 4:25 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: -static int emulate_delivery_system(struct dvb_frontend *fe, - enum dvbv3_emulation_type type, - u32 delsys, u32 desired_system) +/**

Re: [PATCH v7 1/9] mfd: Add commands abstraction layer for SI476X MFD

2013-03-18 Thread Mauro Carvalho Chehab
Em Tue, 26 Feb 2013 22:06:45 -0800 Andrey Smirnov andrew.smir...@gmail.com escreveu: This patch adds all the functions used for exchanging commands with the chip. Please run checkpatch.pl over those patches. There are a number of compliants on those patches: WARNING: externs should be avoided

[GIT PULL] dvb_usb_v2: PID filter and streaming ctrl related changes

2013-03-18 Thread Antti Palosaari
This fix one bug where sync lock is hold over the userspace. Also it changes dvb_usb_v2 PID filter logic a little bit. regards Antti The following changes since commit 4ca286610f664acf3153634f3930acd2de993a9f: [media] radio-rtrack2: fix mute bug (2013-03-05 15:20:07 -0300) are available

Re: [GIT PULL] IT913X

2013-03-18 Thread Antti Palosaari
I rebased it as Mauro just committed some stuff that causes merge conflict! Antti On 03/18/2013 09:50 PM, Antti Palosaari wrote: That patch serie adds new silicon RF-tuner driver named IT913X and IT9135 support for existing AF9035/AF9033 drivers. IT913X driver is split out from the existing

Re: [PATCH 0/3] em28xx: add support for two buses on em2874 and upper

2013-03-18 Thread Mauro Carvalho Chehab
Em Tue, 5 Mar 2013 10:43:10 -0500 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: 2013/3/5 Mauro Carvalho Chehab mche...@redhat.com: The em2874 chips and upper have 2 buses. On all known devices, bus 0 is currently used only by eeprom, and bus 1 for the rest. Add support to

Re: [PATCH 0/3] em28xx: add support for two buses on em2874 and upper

2013-03-18 Thread Mauro Carvalho Chehab
Em Wed, 06 Mar 2013 18:44:07 +0100 Frank Schäfer fschaefer@googlemail.com escreveu: Am 05.03.2013 16:43, schrieb Devin Heitmueller: 2013/3/5 Mauro Carvalho Chehab mche...@redhat.com: The em2874 chips and upper have 2 buses. On all known devices, bus 0 is currently used only by eeprom,

Re: [PATCH 2/3] em28xx: Add a separate config dir for secondary bus

2013-03-18 Thread Mauro Carvalho Chehab
Em Wed, 06 Mar 2013 17:40:44 +0100 Frank Schäfer fschaefer@googlemail.com escreveu: Am 05.03.2013 11:55, schrieb Mauro Carvalho Chehab: Prepare to register a separate bus for the second bus. For now, just add a new field. A latter patch will add the bits to make it work. This

Re: [PATCH v6 1/7] media: V4L2: add temporary clock helpers

2013-03-18 Thread Sylwester Nawrocki
Hi Guennadi, On 03/15/2013 10:27 PM, Guennadi Liakhovetski wrote: Typical video devices like camera sensors require an external clock source. Many such devices cannot even access their hardware registers without a running clock. These clock sources should be controlled by their consumers. This

Re: [PATCH 3/3] em28xx: add support for registering multiple i2c buses

2013-03-18 Thread Mauro Carvalho Chehab
Em Wed, 06 Mar 2013 17:53:19 +0100 Frank Schäfer fschaefer@googlemail.com escreveu: Hi Mauro, I'm basically fine this patch, just a few comments/thoughts: Am 05.03.2013 11:55, schrieb Mauro Carvalho Chehab: Register both buses 0 and 1 via I2C API. For now, bus 0 is used only by

Re: [GIT PULL] IT913X

2013-03-18 Thread Mauro Carvalho Chehab
Em Mon, 18 Mar 2013 23:04:17 +0200 Antti Palosaari cr...@iki.fi escreveu: I rebased it as Mauro just committed some stuff that causes merge conflict! Well, if the conflicts are trivial, there's no need to rebase. There are several patches that I use rebase when merging. Of course, rebasing it

Re: [PATCH v6 3/7] media: soc-camera: switch I2C subdevice drivers to use v4l2-clk

2013-03-18 Thread Sylwester Nawrocki
On 03/18/2013 11:23 AM, Hans Verkuil wrote: On Mon March 18 2013 11:08:16 Guennadi Liakhovetski wrote: On Mon, 18 Mar 2013, Hans Verkuil wrote: On Fri March 15 2013 22:27:49 Guennadi Liakhovetski wrote: [...] @@ -431,6 +434,7 @@ static int imx074_probe(struct i2c_client *client,

Re: [REVIEWv2 PATCH 1/6] v4l2: add const to argument of write-only s_frequency ioctl.

2013-03-18 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Monday 18 March 2013 15:12:00 Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com This ioctl is defined as IOW, so pass the argument as const. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- [snip] diff --git

Re: [REVIEWv2 PATCH 4/6] v4l2: add const to argument of write-only s_register ioctl.

2013-03-18 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Monday 18 March 2013 15:12:03 Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com This ioctl is defined as IOW, so pass the argument as const. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Guennadi Liakhovetski

Re: [PATCH 2/2] dvb_frontend: Simplify the emulation logic

2013-03-18 Thread Mauro Carvalho Chehab
Em Mon, 18 Mar 2013 17:05:12 -0300 Fabio Estevam feste...@gmail.com escreveu: Hi Mauro, On Mon, Mar 18, 2013 at 4:25 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: -static int emulate_delivery_system(struct dvb_frontend *fe, - enum

Re: [PATCH RFC] [media] add Aptina mt9m114 HD digital image sensor driver

2013-03-18 Thread Mauro Carvalho Chehab
Hi Scott, Em Fri, 18 Jan 2013 17:00:44 -0500 Scott Jiang scott.jiang.li...@gmail.com escreveu: This driver support parallel data output mode and QVGA/VGA/WVGA/720P resolution. You can select YCbCr and RGB565 output format. There are a few checkpatch warnings, due to recent API changes at

Re: Fw: [patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio

2013-03-18 Thread Alexey Klimov
On Mon, Mar 18, 2013 at 5:51 PM, Jiri Kosina jkos...@suse.cz wrote: On Fri, 15 Mar 2013, Alexey Klimov wrote: indeed your patch breaks Atmega applications which using V-USB (http://www.obdev.at/products/vusb/index.html), because 0x16c0, 0x05df are the default Ids of V-USB. Have a look

Re: [PATCH 3/3] dma-buf: restore args on failure of dma_buf_mmap

2013-03-18 Thread Mauro Carvalho Chehab
Em Thu, 07 Feb 2013 15:54:52 +0530 Sumit Semwal sumit.sem...@linaro.org escreveu: Hi John, On Thursday 07 February 2013 05:33 AM, John Sheu wrote: From: John Sheu s...@chromium.org Callers to dma_buf_mmap expect to fput() the vma struct's vm_file themselves on failure. Not restoring

Re: [PATCH] [media] ir: IR_RX51 only works on OMAP2

2013-03-18 Thread Mauro Carvalho Chehab
Em Thu, 14 Mar 2013 22:56:44 +0100 Arnd Bergmann a...@arndb.de escreveu: This driver can be enabled on OMAP1 at the moment, which breaks allyesconfig for that platform. Let's mark it OMAP2PLUS-only in Kconfig, since that is the only thing it builds on. Signed-off-by: Arnd Bergmann

Re: [PATCH v6 7/7] ARM: shmobile: convert ap4evb to asynchronously register camera subdevices

2013-03-18 Thread Simon Horman
On Fri, Mar 15, 2013 at 10:27:53PM +0100, Guennadi Liakhovetski wrote: Register the imx074 camera I2C and the CSI-2 platform devices directly in board platform data instead of letting the sh_mobile_ceu_camera driver and the soc-camera framework register them at their run-time. This uses the