Re: [PATCH RFC] [media] blackfin: add video display driver

2013-04-17 Thread Scott Jiang
Hi Sylwester , @@ -9,7 +9,18 @@ config VIDEO_BLACKFIN_CAPTURE To compile this driver as a module, choose M here: the module will be called bfin_capture. +config VIDEO_BLACKFIN_DISPLAY + tristate Blackfin Video Display Driver + depends on VIDEO_V4L2 BLACKFIN

[REVIEW PATCH for v3.10] mem2mem_testdev: set timestamp_type and add debug param

2013-04-17 Thread Hans Verkuil
While testing v4l2-ctl I noticed that this m2m driver didn't set timestamp_type and that it spammed the kernel log with debug messages. Set timestamp_type correctly and add debug module option to enable debug messages. Signed-off-by: Hans Verkuil hans.verk...@cisco.com diff --git

Re: [PATCH v4 1/2] v4l2-ctl: add is_compressed_format() helper

2013-04-17 Thread Hans Verkuil
On Thu April 11 2013 21:46:54 Tzu-Jung Lee wrote: To bypass precalculate_bars() for OUTPUT device that takes encoded bitstreams. I haven't forgotten your patches, but I want to clean up the streaming code some more first. I hope to have finished with that this weekend. Regards, Hans

[patch] [media] dvb-frontends: lg2160: dubious one-bit signed bitfield

2013-04-17 Thread Dan Carpenter
Sparse complains that these are dubious one-bit signed bitfields and the comment says it was intended to be 1 and 0 instead of -1 and 0. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/media/dvb-frontends/lg2160.h b/drivers/media/dvb-frontends/lg2160.h index

[patch] [media] go7007: dubious one-bit signed bitfields

2013-04-17 Thread Dan Carpenter
Because they're signed, is_video and is_audio can be 0 and -1 instead of 0 and 1 as intended. It doesn't cause a bug, but it makes Sparse complain: drivers/staging/media/go7007/go7007-priv.h:94:31: error: dubious one-bit signed bitfield drivers/staging/media/go7007/go7007-priv.h:95:31: error:

Re: [PATCH v4 1/2] v4l2-ctl: add is_compressed_format() helper

2013-04-17 Thread Tzu-Jung Lee
On Wed, Apr 17, 2013 at 3:09 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Thu April 11 2013 21:46:54 Tzu-Jung Lee wrote: To bypass precalculate_bars() for OUTPUT device that takes encoded bitstreams. I haven't forgotten your patches, but I want to clean up the streaming code some more

Re: [patch] [media] go7007: dubious one-bit signed bitfields

2013-04-17 Thread Hans Verkuil
On Wed 17 April 2013 09:20:30 Dan Carpenter wrote: Because they're signed, is_video and is_audio can be 0 and -1 instead of 0 and 1 as intended. It doesn't cause a bug, but it makes Sparse complain: drivers/staging/media/go7007/go7007-priv.h:94:31: error: dubious one-bit signed bitfield

Anyone working on supporting sdio cams under Linux

2013-04-17 Thread Hans de Goede
Hi, Yes I mean camaras which connect to the computer / tablet through an sdio connector, ie the hp one shown here: http://en.wikipedia.org/wiki/Secure_Digital#SDIO A college asked me if I wanted one for the webcam driver work I do, but since it does not have a usb plug I'm not interested. But

Re: Device driver memory 'mmap()' function helper cleanup

2013-04-17 Thread Mauro Carvalho Chehab
Em Tue, 16 Apr 2013 20:12:32 -0700 Linus Torvalds torva...@linux-foundation.org escreveu: Guys, I just pushed out a new helper function intended for cleaning up various device driver mmap functions, because they are rather messy, and at least part of the problem was the bad impedance between

Re: [PATCH 1/1] [media] exynos4-is: Fix potential null pointer dereferencing

2013-04-17 Thread Sylwester Nawrocki
Hi Sachin, On 04/16/2013 08:16 AM, Sachin Kamat wrote: Hi Sylwester, On 15 April 2013 20:51, Sylwester Nawrocki s.nawro...@samsung.com wrote: - if (!fimc-drv_data || fimc-id = fimc-drv_data-num_entities || - fimc-id 0) { - dev_err(dev, Invalid driver data or

Re: Patchwork and em28xx delegates

2013-04-17 Thread Michael Krufky
I see this https://patchwork.linuxtv.org/patch/17834/ is delegated to me. If I took ownership myself then it may have been a mistake. Either way, the patch looks good to me and makes sense, but I am not maintaining em28xx. Mauro, if you want to go ahead and merge his patch then it's fine with

Re: [PATCH 1/1] [media] exynos4-is: Fix potential null pointer dereferencing

2013-04-17 Thread Sachin Kamat
Hi Sylwester, On 17 April 2013 16:33, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi Sachin, On 04/16/2013 08:16 AM, Sachin Kamat wrote: Hi Sylwester, On 15 April 2013 20:51, Sylwester Nawrocki s.nawro...@samsung.com wrote: - if (!fimc-drv_data || fimc-id =

[GIT-PULL] lg2160: dubious one-bit signed bitfield

2013-04-17 Thread Michael Krufky
The following changes since commit 33a31edd4a4b7d26b962b32decfd8ea2377eaa0d: Revert [media] mfd: Add header files and Kbuild plumbing for SI476x MFD core (2013-04-17 06:08:00 -0300) are available in the git repository at: git://linuxtv.org/mkrufky/dvb demods for you to fetch changes up

Re: [RFC] [media] dvb-core: check -msg_len for diseqc_send_master_cmd()

2013-04-17 Thread Dan Carpenter
Any feedback on this? I forgot to CC Steven Toth last time because he would know about the cx24116 driver. I've looked at it again and it still looks like cx24116_send_diseqc_msg() is copying garbage into the state-dsec_cmd.args[] array. regards, dan carpenter On Tue, Apr 02, 2013 at

[PATCH 2/2] [media] videobuf-dma-contig: use vm_iomap_memory()

2013-04-17 Thread Mauro Carvalho Chehab
vm_iomap_memory() provides a better end user interface than remap_pfn_range(), as it does the needed tests before doing mmap. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com --- drivers/media/v4l2-core/videobuf-dma-contig.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-)

[PATCH 1/2] [media] videobuf-dma-contig: remove support for cached mem

2013-04-17 Thread Mauro Carvalho Chehab
videobuf_queue_dma_contig_init_cached() is not used anywhere. Drop support for it, cleaning up the code a little bit. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com --- drivers/media/v4l2-core/videobuf-dma-contig.c | 130 +++--- include/media/videobuf-dma-contig.h

[PATCH] soc_camera: Add V4L2_MBUS_FMT_YUYV10_2X10 format

2013-04-17 Thread Phil Edworthy
The V4L2_MBUS_FMT_YUYV10_2X10 format has already been added to mediabus, so this patch just adds SoC camera support. Signed-off-by: Phil Edworthy phil.edwor...@renesas.com --- drivers/media/platform/soc_camera/soc_mediabus.c | 15 +++ include/media/soc_mediabus.h

Re: [PATCH 1/2] [media] videobuf-dma-contig: remove support for cached mem

2013-04-17 Thread Hans Verkuil
On Wed 17 April 2013 14:22:15 Mauro Carvalho Chehab wrote: videobuf_queue_dma_contig_init_cached() is not used anywhere. Drop support for it, cleaning up the code a little bit. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com Nice! Acked-by: Hans Verkuil hans.verk...@cisco.com ---

Re: [PATCH 2/2] [media] videobuf-dma-contig: use vm_iomap_memory()

2013-04-17 Thread Mauro Carvalho Chehab
Em Wed, 17 Apr 2013 09:22:16 -0300 Mauro Carvalho Chehab mche...@redhat.com escreveu: vm_iomap_memory() provides a better end user interface than remap_pfn_range(), as it does the needed tests before doing mmap. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com ---

Re: [PATCH RFC] s5k5baf: add camera sensor driver

2013-04-17 Thread Sylwester Nawrocki
Hi Andrzej, On 04/16/2013 03:38 PM, Andrzej Hajda wrote: Driver for Samsung S5K5BAF UXGA 1/5 2M CMOS Image Sensor with embedded SoC ISP. The driver exposes the sensor as two V4L2 subdevices: - S5K5BAF-CIS - pure CMOS Image Sensor, fixed 1600x1200 format, no controls. - S5K5BAF-ISP - Image

Re: [GIT PULL FOR v3.10] Camera sensors patches

2013-04-17 Thread Mark Brown
On Tue, Apr 16, 2013 at 08:04:52PM +0200, Sylwester Nawrocki wrote: It's probably more clean to provide a dummy clock/regulator in a host driver (platform) than to add something in a sub-device drivers that would resolve which resources should be requested and which not. Yes, that's the

Re: [PATCH] DT: export of_get_next_parent() for use by modules: fix modular V4L2

2013-04-17 Thread Guennadi Liakhovetski
Hi all On Tue, 2 Apr 2013, Guennadi Liakhovetski wrote: On Tue, 2 Apr 2013, Arnd Bergmann wrote: On Tuesday 02 April 2013, Guennadi Liakhovetski wrote: Currently modular V4L2 build with enabled OF is broken dur to the of_get_next_parent() function being unavailable to modules. Export

Re: mt9v034 driver

2013-04-17 Thread Guennadi Liakhovetski
Hi Igor (forwarding to the real media Mailing List) On Wed, 17 Apr 2013, Igor Kugasyan wrote: Dear Mr. Guennadi, Please tell me can I use the soc_camera_ (soc_camera.h, soc_camera.c) interface for a mt9v034 driver as a mt9v022 driver or not? I don't know anything about mt9v034. It might

Re: [GIT PULL FOR v3.10] Camera sensors patches

2013-04-17 Thread Mauro Carvalho Chehab
Em Wed, 17 Apr 2013 14:55:03 +0100 Mark Brown broo...@kernel.org escreveu: On Tue, Apr 16, 2013 at 08:04:52PM +0200, Sylwester Nawrocki wrote: It's probably more clean to provide a dummy clock/regulator in a host driver (platform) than to add something in a sub-device drivers that would

Compilation breakage on drivers/media due to OF patches - was: Re: [PATCH] DT: export of_get_next_parent() for use by modules: fix modular V4L2

2013-04-17 Thread Mauro Carvalho Chehab
Hi Grant/Rob, Our tree is currently _broken_ with OT, because of the lack of exporting of_get_next_parent. The developer that submitted the patches that added V4L2 OF support forgot to test to compilation with MODULES support enabled. So, we're now having: ERROR: of_get_next_parent

Re: Compilation breakage on drivers/media due to OF patches - was: Re: [PATCH] DT: export of_get_next_parent() for use by modules: fix modular V4L2

2013-04-17 Thread Grant Likely
On Wed, 17 Apr 2013 11:53:57 -0300, Mauro Carvalho Chehab mche...@redhat.com wrote: Hi Grant/Rob, Our tree is currently _broken_ with OT, because of the lack of exporting of_get_next_parent. The developer that submitted the patches that added V4L2 OF support forgot to test to compilation

[RFC 00/10] Versatile Express CLCD DVI output support

2013-04-17 Thread Pawel Moll
Hello All, This series implements support for the Versatile Express video output pipeline, which is not the simplest one available... It is meant as a RFC only and I'm hoping to attract all possible feedback (*including* naming ;-). The VE's MultiMedia Bus [1] comprises three video signal

[RFC 01/10] video: Add generic display entity core

2013-04-17 Thread Pawel Moll
From: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/video/Kconfig|1 + drivers/video/Makefile |1 + drivers/video/display/Kconfig|4 +

[RFC 03/10] video: display: Add Device Tree bindings

2013-04-17 Thread Pawel Moll
Modelled after the common clock solution, the bindings are based on the idea of display entity providers and consumers. Signed-off-by: Pawel Moll pawel.m...@arm.com --- .../devicetree/bindings/video/display-bindings.txt | 75 + drivers/video/display/display-core.c

[RFC 05/10] fbmon: Add extra video helper

2013-04-17 Thread Pawel Moll
This function converts the fb_var_screeninfo to the videomode structure, to be used in fbdev drivers working with the Common Display Framework. Signed-off-by: Pawel Moll pawel.m...@arm.com --- drivers/video/fbmon.c | 29 + include/linux/fb.h|3 +++ 2 files

[RFC 02/10] video: display: Update the display with the video mode data

2013-04-17 Thread Pawel Moll
The display entity (sink) may need to know about the mode being changed, eg. to update timings. Alternatively there could be a separate set_mode() operation... Signed-off-by: Pawel Moll pawel.m...@arm.com --- drivers/video/display/display-core.c |5 +++-- include/video/display.h

[RFC 10/10] ARM: vexpress: Add CLCD Device Tree properties

2013-04-17 Thread Pawel Moll
Signed-off-by: Pawel Moll pawel.m...@arm.com --- arch/arm/boot/dts/vexpress-v2m-rs1.dtsi | 17 + arch/arm/boot/dts/vexpress-v2m.dtsi | 17 + arch/arm/boot/dts/vexpress-v2p-ca9.dts |5 + 3 files changed, 31 insertions(+), 8 deletions(-) diff --git

[RFC 09/10] video: Versatile Express DVI mode driver

2013-04-17 Thread Pawel Moll
Versatile Express DVI output is driven by a Sii9022 chip. It can be controller to a limited extend by the Motherboard Config Controller, and that's what the driver is doing now. It is a temporary measure till there's a full I2C driver for the chip. Signed-off-by: Pawel Moll pawel.m...@arm.com ---

[RFC 04/10] video: display: Add generic TFT display type

2013-04-17 Thread Pawel Moll
TFT panels may be interfaced via a simple parallel interface carrying RGB data, pixel clock and synchronisation signals. From the video generator point of view the width of the data channels (number of bits per R/G/B components) may be an important factor in setting up the display model. Above

[RFC 06/10] video: ARM CLCD: Add DT CDF support

2013-04-17 Thread Pawel Moll
This patch adds basic DT bindings for the PL11x CLCD cells and make their fbdev driver use them, together with the Common Display Framework. The DT provides information about the hardware configuration and limitations (eg. the largest supported resolution) but the video modes come exclusively

[RFC 07/10] mfd: vexpress: Allow external drivers to parse site ids

2013-04-17 Thread Pawel Moll
... by providing a function translating the MASTER value into the currently valid site number and a _LAST constant providing all possible site id values. Signed-off-by: Pawel Moll pawel.m...@arm.com --- drivers/mfd/vexpress-sysreg.c |5 + include/linux/vexpress.h |2 ++ 2 files

[RFC 08/10] video: Versatile Express MUXFPGA driver

2013-04-17 Thread Pawel Moll
Versatile Express' DVI video output can be connected to one the three sources - motherboard's CLCD controller or a video signal generated by one of the daughterboards. This driver provides a Common Display Framework driver for the muxer FPGA, which acts as a switch selecting one of the video data

Re: Compilation breakage on drivers/media due to OF patches - was: Re: [PATCH] DT: export of_get_next_parent() for use by modules: fix modular V4L2

2013-04-17 Thread Mauro Carvalho Chehab
Em Wed, 17 Apr 2013 16:08:43 +0100 Grant Likely grant.lik...@secretlab.ca escreveu: On Wed, 17 Apr 2013 11:53:57 -0300, Mauro Carvalho Chehab mche...@redhat.com wrote: Hi Grant/Rob, Our tree is currently _broken_ with OT, because of the lack of exporting of_get_next_parent. The

Re: [PATCH] [media] uvcvideo: quirk PROBE_DEF for Dell Studio / OmniVision webcam

2013-04-17 Thread Kamal Mostafa
On Wed, 2013-04-17 at 01:05 +0200, Laurent Pinchart wrote: Hi Kamal, On Monday 15 April 2013 12:01:51 Kamal Mostafa wrote: BugLink: https://bugs.launchpad.net/bugs/1168430 OminiVision webcam 0x05a9:0x264a (in Dell Studio Hybrid 140g) needs the same UVC_QUIRK_PROBE_DEF as other

cron job: media_tree daily build: ERRORS

2013-04-17 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Apr 17 19:00:22 CEST 2013 git branch: test git hash: 6695be6863b75620ffa6d422965680ce785cb7c8 gcc

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-17 Thread Daniel Vetter
On Wed, Apr 10, 2013 at 12:28 AM, Steven Rostedt rost...@goodmis.org wrote: On Thu, Apr 04, 2013 at 06:41:02PM +0200, Peter Zijlstra wrote: On Thu, 2013-04-04 at 15:31 +0200, Daniel Vetter wrote: The thing is now that you're not expected to hold these locks for a long time - if you need to

Re: [RFC] [media] dvb-core: check -msg_len for diseqc_send_master_cmd()

2013-04-17 Thread Antti Palosaari
On 04/17/2013 03:03 PM, Dan Carpenter wrote: Any feedback on this? I forgot to CC Steven Toth last time because he would know about the cx24116 driver. I've looked at it again and it still looks like cx24116_send_diseqc_msg() is copying garbage into the state-dsec_cmd.args[] array. It looks

Re: Keene

2013-04-17 Thread Antti Palosaari
On 04/15/2013 09:55 AM, Hans Verkuil wrote: On Fri April 12 2013 02:11:41 Antti Palosaari wrote: Hello Hans, That device is working very, thank you for it. Anyhow, I noticed two things. 1) it does not start transmitting just after I plug it - I have to retune it! Output says it is tuned to

[PATCH] media: ir-rc5-decoder: improve responsiveness by 100ms to 250ms

2013-04-17 Thread Stephane Chauveau
Hello, Here is a patch to improve the responsiveness of the rc5 decoder when using the ite-cir driver. Most of the information below should also be applicable to other decoders and ir drivers (e.g. rc6 for sure). The problem is that the current decoder is subject to a double timeout: (a)

[PATCH 0/4] R-Car VIN driver with R8A7779/Marzen support

2013-04-17 Thread Sergei Shtylyov
Hello. Here's the set of 4 patches against the Simon Horman's 'renesas.git' repo, 'renesas-next-20130417' tag and my recent yet unapplied patches. Here we add the VIN (Video In) driver and its platform code working on the R8A7779/ Marzen with ADV7180 I2C camera sensor. The driver patch also

[PATCH 1/4] V4L2: soc_camera: Renesas R-Car VIN driver

2013-04-17 Thread Sergei Shtylyov
From: Vladimir Barinov vladimir.bari...@cogentembedded.com Add Renesas R-Car VIN (Video In) V4L2 driver. Based on the patch by Phil Edworthy phil.edwor...@renesas.com. Signed-off-by: Vladimir Barinov vladimir.bari...@cogentembedded.com [Sergei: some formatting cleanup] Signed-off-by: Sergei

[PATCH 2/4] ARM: shmobile: r8a7779: add VIN support

2013-04-17 Thread Sergei Shtylyov
From: Vladimir Barinov vladimir.bari...@cogentembedded.com Add VIN clocks and platform devices for R8A7779 SoC; add function to register the VIN platform devices. Signed-off-by: Vladimir Barinov vladimir.bari...@cogentembedded.com [Sergei: renamed some variables] Signed-off-by: Sergei Shtylyov

[PATCH 3/4] ARM: shmobile: Marzen: add VIN and ADV7180 support

2013-04-17 Thread Sergei Shtylyov
From: Vladimir Barinov vladimir.bari...@cogentembedded.com Add ADV7180 platform devices on the Marzen board, configure VIN1/3 pins, and register VIN1/3 devices with the ADV7180 specific platform data. Signed-off-by: Vladimir Barinov vladimir.bari...@cogentembedded.com Signed-off-by: Sergei

[PATCH 4/4] ARM: shmobile: Marzen: enable VIN and ADV7180 in defconfig

2013-04-17 Thread Sergei Shtylyov
From: Vladimir Barinov vladimir.bari...@cogentembedded.com Add the VIN and ADV7180 drivers to 'marzen_defconfig'. Signed-off-by: Vladimir Barinov vladimir.bari...@cogentembedded.com Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com --- arch/arm/configs/marzen_defconfig |7

Re: [PATCH] media: ir-rc5-decoder: improve responsiveness by 100ms to 250ms

2013-04-17 Thread Stephane Chauveau
Here is a more detailed analysis of the problems my patch is supposed to solve. I added a few printk in the module to obtain some detailed timings. - DECODE is emited once at the begining of each call of ir_rc5_decode() to describe the blank or pulse event reported by ite_cir - FINISHED is

Re: [PATCH 3/4] ARM: shmobile: Marzen: add VIN and ADV7180 support

2013-04-17 Thread Sergei Shtylyov
Hello. On 04/18/2013 02:15 AM, Sergei Shtylyov wrote: From: Vladimir Barinov vladimir.bari...@cogentembedded.com Add ADV7180 platform devices on the Marzen board, configure VIN1/3 pins, and register VIN1/3 devices with the ADV7180 specific platform data. Signed-off-by: Vladimir Barinov

Re: [PATCH] media: ir-rc5-decoder: improve responsiveness by 100ms to 250ms

2013-04-17 Thread Stephane Chauveau
And here are two small patches to obtain timings on the original decoder. --- linux/drivers/media/rc/ir-rc5-decoder.c.orig2013-04-17 20:40:41.939326236 +0200 +++ linux/drivers/media/rc/ir-rc5-decoder.c2013-04-18 00:42:11.386539568 +0200 @@ -64,6 +64,8 @@ static int

Re: [PATCH 2/4] ARM: shmobile: r8a7779: add VIN support

2013-04-17 Thread Kuninori Morimoto
Hi Sergei From: Vladimir Barinov vladimir.bari...@cogentembedded.com Add VIN clocks and platform devices for R8A7779 SoC; add function to register the VIN platform devices. Signed-off-by: Vladimir Barinov vladimir.bari...@cogentembedded.com [Sergei: renamed some variables]

Re: [PATCH] media: vb2: add length check for mmap

2013-04-17 Thread 김승우
Oops, there is a issue. vb2-core does not PAGE_ALIGN to length of buffer, but mmap() always do PAGE_ALIGN to its length. So non PAGE_ALIGN length of buffer from driver side can not mmaped with this patch. On 2013년 04월 12일 15:03, Marek Szyprowski wrote: On 4/12/2013 5:57 AM, Seung-Woo Kim

[PATCH -next] [media] s5p-mfc: fix error return code in s5p_mfc_probe()

2013-04-17 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 3 ++- 1 file changed, 2

Re: [PATCH v2] media: davinci: vpif: align the buffers size to page page size boundary

2013-04-17 Thread Prabhakar Lad
Hi Marek, On Tue, Apr 16, 2013 at 4:48 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, (CC'ing Marek) On Tuesday 16 April 2013 16:24:30 Prabhakar lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com with recent commit with id