Re: [RFC PATCH 01/14] adv7183: fix querystd

2013-05-31 Thread Scott Jiang
2013/5/29 Hans Verkuil hverk...@xs4all.nl: From: Hans Verkuil hans.verk...@cisco.com If no signal is detected, return V4L2_STD_UNKNOWN. Otherwise AND the standard with the detected standards. Note that the v4l2 core initializes the std with tvnorms before calling the querystd ioctl.

Re: [PATCHv1 02/38] v4l2: remove g_chip_ident from bridge drivers where it is easy to do so.

2013-05-31 Thread Scott Jiang
2013/5/29 Hans Verkuil hverk...@xs4all.nl: From: Hans Verkuil hans.verk...@cisco.com VIDIOC_DBG_G_CHIP_IDENT has been replaced by VIDIOC_DBG_G_CHIP_INFO. Remove g_chip_ident support from bridge drivers since it is no longer needed. This patch takes care of all the trivial cases.

Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-05-31 Thread Hans Verkuil
On Fri May 31 2013 03:08:33 Sakari Ailus wrote: Hi Hans, Hans Verkuil wrote: On Fri 17 May 2013 00:34:51 Sakari Ailus wrote: Hi Andrzej, Thanks for the patchset! On Thu, May 16, 2013 at 10:14:33AM +0200, Andrzej Hajda wrote: This patch adds managed version of initialization

Re: Keene

2013-05-31 Thread Hans Verkuil
On Thu May 30 2013 01:52:02 Antti Palosaari wrote: On 05/29/2013 08:58 PM, Antti Palosaari wrote: On 05/29/2013 05:26 PM, Hans Verkuil wrote: On Fri April 19 2013 11:11:27 Antti Palosaari wrote: On 04/19/2013 10:12 AM, Hans Verkuil wrote: On Wed April 17 2013 21:45:24 Antti Palosaari

Re: [PATCH v6] V4L2: I2C: ML86V7667 video decoder driver

2013-05-31 Thread Hans Verkuil
Hi! On Wed May 29 2013 20:52:28 Sergei Shtylyov wrote: From: Vladimir Barinov vladimir.bari...@cogentembedded.com Add OKI Semiconductor ML86V7667 video decoder driver. I've accepted this patch, but I've added a patch to fix this function: +static int ml86v7667_querystd(struct v4l2_subdev

[RFC PATCH v2] [media] mem2mem: add support for hardware buffered queue

2013-05-31 Thread Philipp Zabel
On mem2mem decoders with a hardware bitstream ringbuffer, to drain the buffer at the end of the stream, remaining frames might need to be decoded from the bitstream buffer without additional input buffers being provided. To achieve this, allow a queue to be marked as buffered by the driver, and

[RFC PATCH v3] [media] mem2mem: add support for hardware buffered queue

2013-05-31 Thread Philipp Zabel
On mem2mem decoders with a hardware bitstream ringbuffer, to drain the buffer at the end of the stream, remaining frames might need to be decoded from the bitstream buffer without additional input buffers being provided. To achieve this, allow a queue to be marked as buffered by the driver, and

Re: [PATCH v2 1/4] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata

2013-05-31 Thread Prabhakar Lad
Hi Sekhar, On Sat, May 25, 2013 at 11:13 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Hi Sekhar, On Sat, May 25, 2013 at 11:09 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com remove init_enable from ths7303 pdata as it is being

[GIT PULL FOR v3.10] Two fixes

2013-05-31 Thread Hans Verkuil
The following changes since commit 7eac97d7e714429f7ef1ba5d35f94c07f4c34f8e: [media] media: pci: remove duplicate checks for EPERM (2013-05-27 09:34:56 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v3.10c for you to fetch changes up to

Re: [RFC PATCH v3] [media] mem2mem: add support for hardware buffered queue

2013-05-31 Thread Sylwester Nawrocki
Hi Philipp, On 05/31/2013 10:33 AM, Philipp Zabel wrote: +void v4l2_m2m_queue_set_buffered(struct vb2_queue *vq, bool buffered) How about making it a 'static inline' function in include/media/v4l2-mem2mem.h instead ? +{ + struct v4l2_m2m_queue_ctx *q_ctx = container_of(vq, struct

[RFC][PATCH 0/2] dma-buf: add importer private data for reimporting

2013-05-31 Thread Seung-Woo Kim
importer private data in dma-buf attachment can be used by importer to reimport same dma-buf. Seung-Woo Kim (2): dma-buf: add importer private data to attachment drm/prime: find gem object from the reimported dma-buf drivers/base/dma-buf.c | 31

[RFC][PATCH 2/2] drm/prime: find gem object from the reimported dma-buf

2013-05-31 Thread Seung-Woo Kim
Reimported dma-buf can reuse same gem object only when prime import is done with same drm open context. So prime import is done with other drm open context, gem object is newly created and mapped even there is already mapped gem object. To avoid recreating gem object, importer private data can be

[RFC][PATCH 1/2] dma-buf: add importer private data to attachment

2013-05-31 Thread Seung-Woo Kim
dma-buf attachment has only exporter private data, but importer private data can be useful for importer especially to re-import the same dma-buf. To use importer private data in attachment of the device, the function to search attachment in the attachment list of dma-buf is also added.

Re: [RFC][PATCH 0/2] dma-buf: add importer private data for reimporting

2013-05-31 Thread Daniel Vetter
On Fri, May 31, 2013 at 10:54 AM, Seung-Woo Kim sw0312@samsung.com wrote: importer private data in dma-buf attachment can be used by importer to reimport same dma-buf. Seung-Woo Kim (2): dma-buf: add importer private data to attachment drm/prime: find gem object from the reimported

Re: [RFC PATCH v3] [media] mem2mem: add support for hardware buffered queue

2013-05-31 Thread Philipp Zabel
Hi Sylwester, Am Freitag, den 31.05.2013, 10:52 +0200 schrieb Sylwester Nawrocki: Hi Philipp, On 05/31/2013 10:33 AM, Philipp Zabel wrote: +void v4l2_m2m_queue_set_buffered(struct vb2_queue *vq, bool buffered) How about making it a 'static inline' function in include/media/v4l2-mem2mem.h

[PATCH 04/21] radio-tea5764: add support for struct v4l2_device.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Fabio Belavenuto belaven...@gmail.com --- drivers/media/radio/radio-tea5764.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git

[PATCH 08/21] radio-tea5764: add device_caps support.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Fabio Belavenuto belaven...@gmail.com --- drivers/media/radio/radio-tea5764.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/radio/radio-tea5764.c

Re: [PATCH 09/13] media: Change media device link_notify behaviour

2013-05-31 Thread Sylwester Nawrocki
Hi Laurent, On 05/30/2013 04:02 AM, Laurent Pinchart wrote: Hi Sylwester, Thank you for the patch, and sorry for the late reply. Thank you for review, the timing is just fine. :-) On Thursday 09 May 2013 17:36:41 Sylwester Nawrocki wrote: Currently the media device link_notify callback is

[PATCH 05/21] radio-tea5764: embed struct video_device.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com This simplifies the code as it removes a memory allocation check. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Fabio Belavenuto belaven...@gmail.com --- drivers/media/radio/radio-tea5764.c | 27 ++- 1 file changed, 10

[PATCH 01/21] saa7706h: convert to the control framework.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Richard Röjfors richard.rojf...@pelagicore.com --- drivers/media/radio/saa7706h.c | 58 +--- 1 file changed, 30 insertions(+), 28 deletions(-) diff --git

[PATCH 03/21] saa6752hs: convert to the control framework.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/pci/saa7134/saa6752hs.c | 457 + 1 file changed, 122 insertions(+), 335 deletions(-) diff --git a/drivers/media/pci/saa7134/saa6752hs.c

[PATCH 06/21] radio-tea5764: convert to the control framework.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Fabio Belavenuto belaven...@gmail.com --- drivers/media/radio/radio-tea5764.c | 79 --- 1 file changed, 26 insertions(+), 53 deletions(-) diff --git

[PATCH 07/21] radio-tea5764: audio and input ioctls do not apply to radio devices.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Deleted those ioctls from this driver. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Fabio Belavenuto belaven...@gmail.com --- drivers/media/radio/radio-tea5764.c | 37 --- 1 file changed, 37 deletions(-) diff

[PATCH 02/21] sr030pc30: convert to the control framework.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Sylwester Nawrocki sylvester.nawro...@gmail.com --- drivers/media/i2c/sr030pc30.c | 276 + 1 file changed, 88 insertions(+), 188 deletions(-) diff --git

[PATCH 10/21] radio-tea5764: some cleanups and clamp frequency when out-of-range

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Some small cleanups and when setting the frequency it is now clamped to the valid frequency range instead of returning an error. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Fabio Belavenuto belaven...@gmail.com ---

[PATCH 17/21] radio-sf16fmi: remove audio/input ioctls.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The audio and input ioctls do not apply to radio devices. Remove them. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Ondrej Zary li...@rainbow-software.org --- drivers/media/radio/radio-sf16fmi.c | 30 -- 1 file

[PATCH 09/21] radio-tea5764: add prio and control event support.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Fabio Belavenuto belaven...@gmail.com --- drivers/media/radio/radio-tea5764.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/media/radio/radio-tea5764.c

[PATCH 14/21] radio-timb: add control events and prio support.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Richard Röjfors richard.rojf...@pelagicore.com --- drivers/media/radio/radio-timb.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/radio/radio-timb.c

[PATCH 13/21] radio-timb: actually load the requested subdevs

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com For some reason the tuner and dsp subdevs were never actually loaded. Added the relevant code to do that. Also remove bogus calls to video_device_release_empty(). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Richard Röjfors

[PATCH 20/21] radio-sf16fmi: convert to the control framework.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Ondrej Zary li...@rainbow-software.org --- drivers/media/radio/radio-sf16fmi.c | 56 --- 1 file changed, 25 insertions(+), 31 deletions(-) diff --git

[PATCH 16/21] timblogiw: fix querycap.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Don't set version (the core does that for you), fill in device_caps and prefix bus_info with platform:. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Richard Röjfors richard.rojf...@pelagicore.com --- drivers/media/platform/timblogiw.c |7

[PATCH 18/21] radio-sf16fmi: add device_caps support to querycap.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Ondrej Zary li...@rainbow-software.org --- drivers/media/radio/radio-sf16fmi.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/radio/radio-sf16fmi.c

[PATCH 12/21] radio-timb: convert to the control framework.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Richard Röjfors richard.rojf...@pelagicore.com --- drivers/media/radio/radio-timb.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/media/radio/radio-timb.c

[PATCH 15/21] tef6862: clamp frequency.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Clamp the frequency to the valid frequency range as per the V4L2 specification. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Richard Röjfors richard.rojf...@pelagicore.com --- drivers/media/radio/tef6862.c | 10 ++ 1 file changed, 6

[PATCH 11/21] radio-timb: add device_caps support, remove input/audio ioctls.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The audio and input ioctls are not applicable for radio devices, remove them. Also set the device_caps field in v4l2_querycap. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Richard Röjfors richard.rojf...@pelagicore.com ---

[PATCH 19/21] radio-sf16fmi: clamp frequency.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Ondrej Zary li...@rainbow-software.org --- drivers/media/radio/radio-sf16fmi.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/media/radio/radio-sf16fmi.c

[PATCH 21/21] radio-sf16fmi: add control event and prio support.

2013-05-31 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Ondrej Zary li...@rainbow-software.org --- drivers/media/radio/radio-sf16fmi.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/media/radio/radio-sf16fmi.c

Re: [RFC][PATCH 0/2] dma-buf: add importer private data for reimporting

2013-05-31 Thread 김승우
Hello Daniel, Thanks for your comment. On 2013년 05월 31일 18:14, Daniel Vetter wrote: On Fri, May 31, 2013 at 10:54 AM, Seung-Woo Kim sw0312@samsung.com wrote: importer private data in dma-buf attachment can be used by importer to reimport same dma-buf. Seung-Woo Kim (2): dma-buf:

Re: [PATCH RFC v2] media: OF: add sync-on-green endpoint property

2013-05-31 Thread Sylwester Nawrocki
On 05/30/2013 05:21 AM, Laurent Pinchart wrote: Hi Sylwester, On Saturday 25 May 2013 16:11:52 Sylwester Nawrocki wrote: On 05/25/2013 11:17 AM, Prabhakar Lad wrote: [...] And for synchronisation method on the analog part we could perhaps define 'component-sync' or similar property that

Re: [PATCH 02/21] sr030pc30: convert to the control framework.

2013-05-31 Thread Sylwester Nawrocki
On 05/31/2013 12:02 PM, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Sylwester Nawrocki sylvester.nawro...@gmail.com Acked-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media/i2c/sr030pc30.c | 276

[PATCH for v3.10] v4l2-ioctl: don't print the clips list.

2013-05-31 Thread Hans Verkuil
The clips pointer is a userspace pointer, not a kernelspace pointer. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/v4l2-ioctl.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c

[RFC v2 0/2] saa7115: Implement i2c_board_info.platform_data

2013-05-31 Thread Jon Arne Jørgensen
This patch set adds handling of the i2c_board_info struct to the saa7115 driver. The main goal of this patch is to give the different devices with the gm7113c chip an opportunity to configure the chip to their needs. I've only implemented the overrides I know are necessary to get the stk1160 and

[RFC v2 1/2] saa7115: Implement i2c_board_info.platform_data

2013-05-31 Thread Jon Arne Jørgensen
Implement i2c_board_info.platform_data handling in the driver so we can make device specific changes to the chips we support. Signed-off-by: Jon Arne Jørgensen jona...@jonarne.no --- drivers/media/i2c/saa7115.c | 101 +-- drivers/media/i2c/saa711x_regs.h

[RFC v2 2/2] saa7115: Remove gm7113c video_std register change

2013-05-31 Thread Jon Arne Jørgensen
On video std change, the driver would disable the automatic field detection on the gm7113c chip, and force either 50Hz or 60Hz. Don't do this any more. Signed-off-by: Jon Arne Jørgensen jona...@jonarne.no --- drivers/media/i2c/saa7115.c | 26 ++ 1 file changed, 2

Re: [patch] [media] media: info leak in __media_device_enum_links()

2013-05-31 Thread Dan Carpenter
Ping? regards, dan carpenter On Sat, Apr 13, 2013 at 12:32:15PM +0300, Dan Carpenter wrote: These structs have holes and reserved struct members which aren't cleared. I've added a memset() so we don't leak stack information. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff

[RFC v2 00/10] Exynos5 FIMC-IS driver

2013-05-31 Thread Arun Kumar K
Changes from v1 --- - Addressed all review comments from Sylwester - Made sensor subdevs as independent i2c devices - Lots of cleanup - Debugfs support added - Removed PMU global register access Description --- This patchset adds a new driver for the FIMC-IS IP available in

[RFC v2 01/10] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation

2013-05-31 Thread Arun Kumar K
Signed-off-by: Arun Kumar K arun...@samsung.com --- .../devicetree/bindings/media/exynos5-fimc-is.txt | 41 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/exynos5-fimc-is.txt diff --git

[PATCH 2/3] exynos4-is: Ensure fimc-is clocks are not enabled until properly configured

2013-05-31 Thread Sylwester Nawrocki
Use clk_prepare_enable/clk_unprepare_disable instead of preparing the clocks during the driver initalization and then using just clk_disable/ clk_enable. The clock framework doesn't guarantee a clock will not get enabled during e.g. clk_set_parent if clk_prepare has been called on it. So we ensure

[PATCH 3/3] exynos4-is: Fix reported colorspace at FIMC-IS-ISP subdev

2013-05-31 Thread Sylwester Nawrocki
The FIMC-IS-ISP handles only Bayer formats thus V4L2_COLORSPACE_SRGB should be used. This change applies to the code first added in v3.10. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH 0/3] exynos4-is fixes for 3.10

2013-05-31 Thread Sylwester Nawrocki
This includes fixes for couple issues found during further testing of the exynos4-is driver I'd like to queue for 3.10 Sylwester Nawrocki (3): exynos4-is: Prevent NULL pointer dereference when firmware isn't loaded exynos4-is: Ensure fimc-is clocks are not enabled until properly

[PATCH 1/3] exynos4-is: Prevent NULL pointer dereference when firmware isn't loaded

2013-05-31 Thread Sylwester Nawrocki
Ensure the firmware isn't accessed in the driver when the firmware loading routine has not completed. This fixes a potential kernel crash: [ 96.51] Unable to handle kernel NULL pointer dereference at virtual address [ 96.52] pgd = ee604000 [ 96.52] []

[RFC v2 02/10] exynos5-fimc-is: Adds fimc-is driver core files

2013-05-31 Thread Arun Kumar K
This driver is for the FIMC-IS IP available in Samsung Exynos5 SoC onwards. This patch adds the core files for the new driver. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kilyeon Im kilyeon...@samsung.com --- drivers/media/platform/exynos5-is/fimc-is-core.c | 304

[RFC v2 04/10] exynos5-fimc-is: Adds the register definition and context header

2013-05-31 Thread Arun Kumar K
This patch adds the register definition file for the fimc-is driver and also the header file containing the main context for the driver. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kilyeon Im kilyeon...@samsung.com --- drivers/media/platform/exynos5-is/fimc-is-regs.h | 107

[RFC v2 05/10] exynos5-fimc-is: Adds the sensor subdev

2013-05-31 Thread Arun Kumar K
FIMC-IS uses certain sensors which are exclusively controlled from the IS firmware. This patch adds the sensor subdev for the fimc-is sensors. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kilyeon Im kilyeon...@samsung.com --- drivers/media/platform/exynos5-is/fimc-is-sensor.c |

[RFC v2 06/10] exynos5-fimc-is: Adds isp subdev

2013-05-31 Thread Arun Kumar K
fimc-is driver takes video data input from the ISP video node which is added in this patch. This node accepts Bayer input buffers which is given from the IS sensors. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kilyeon Im kilyeon...@samsung.com ---

[RFC v2 07/10] exynos5-fimc-is: Adds scaler subdev

2013-05-31 Thread Arun Kumar K
FIMC-IS has two hardware scalers named as scaler-codec and scaler-preview. This patch adds the common code handling the video nodes and subdevs of both the scalers. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kilyeon Im kilyeon...@samsung.com ---

[RFC v2 09/10] exynos5-fimc-is: Adds the hardware interface module

2013-05-31 Thread Arun Kumar K
The hardware interface module finally sends the commands to the FIMC-IS firmware and runs the interrupt handler for getting the responses. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kilyeon Im kilyeon...@samsung.com --- .../media/platform/exynos5-is/fimc-is-interface.c |

[RFC v2 10/10] exynos5-fimc-is: Adds the Kconfig and Makefile

2013-05-31 Thread Arun Kumar K
Modifies the exynos5-is Makefile and Kconfig to include the new fimc-is driver. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kilyeon Im kilyeon...@samsung.com --- drivers/media/platform/exynos5-is/Kconfig | 12 drivers/media/platform/exynos5-is/Makefile |3

Re: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet

2013-05-31 Thread Mauro Carvalho Chehab
Em Thu, 30 May 2013 21:00:01 +0200 Jon Arne Jørgensen jona...@jonarne.no escreveu: On Thu, May 30, 2013 at 08:33:32AM +0300, Timo Teras wrote: On Thu, 30 May 2013 07:21:36 +0200 Jon Arne Jørgensen jona...@jonarne.no wrote: On Wed, May 29, 2013 at 10:19:49PM -0400, Andy Walls wrote:

Re: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet

2013-05-31 Thread Timo Teras
On Fri, 31 May 2013 10:08:27 -0300 Mauro Carvalho Chehab mche...@redhat.com wrote: Em Thu, 30 May 2013 21:00:01 +0200 Jon Arne Jørgensen jona...@jonarne.no escreveu: On Thu, May 30, 2013 at 08:33:32AM +0300, Timo Teras wrote: I would rather have the platform_data provide the new table.

Re: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet

2013-05-31 Thread Jon Arne Jørgensen
On Fri, May 31, 2013 at 10:08:27AM -0300, Mauro Carvalho Chehab wrote: Em Thu, 30 May 2013 21:00:01 +0200 Jon Arne Jørgensen jona...@jonarne.no escreveu: On Thu, May 30, 2013 at 08:33:32AM +0300, Timo Teras wrote: On Thu, 30 May 2013 07:21:36 +0200 Jon Arne Jørgensen jona...@jonarne.no

Re: stk1160: cannot alloc 196608 bytes

2013-05-31 Thread a b
Hi Ezequiel, Just to report that i haven't seen any recurrence of the issue since applying the suggested keep_buffers option. Many thanks for your help. On Mon, May 13, 2013 at 9:33 AM, a b genericgroupm...@gmail.com wrote: Hi Ezequiel, Sorry, just saw your suggestion RE: keep_buffers, i

[REVIEW PATCH v2 00/11] Media link_notify behaviour change and exynos4-is updates

2013-05-31 Thread Sylwester Nawrocki
Hi All, This is an updated version of a patch set [1], main changes include: - In patch media: Change media device link_notify behaviour - fixed link flags handling in __media_entity_setup_link(), - swapped MEDIA_DEV_NOTIFY_PRE_LINK_CH and MEDIA_DEV_NOTIFY_POST_LINK_CH at the

[REVIEW PATCH v2 01/11] exynos4-is: Move common functions to a separate module

2013-05-31 Thread Sylwester Nawrocki
Create a common module (exynos4-is-common.ko) which will hold the common functions used across video device and subdev drivers contained in .../exynos4-is directory. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since

[REVIEW PATCH v2 03/11] exynos4-is: Preserve state of controls between /dev/video open/close

2013-05-31 Thread Sylwester Nawrocki
This patch moves the code for inheriting subdev v4l2 controls on the FIMC video capture nodes from open()/close() fops to the link setup notification callback. This allows for the state of the FIMC controls to be always kept, in opposite to the current situation when it is lost when last process

[REVIEW PATCH v2 02/11] exynos4-is: Add struct exynos_video_entity

2013-05-31 Thread Sylwester Nawrocki
This patch introduces common structure for the video entities to handle all video nodes and media pipelines associated with them in more generic way. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[REVIEW PATCH v2 06/11] exynos4-is: Use common exynos_media_pipeline data structure

2013-05-31 Thread Sylwester Nawrocki
This enumeration is now private to exynos4-is and the exynos5 camera subsystem driver may have the subdevs handling designed differently. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v1: - corrected description

[REVIEW PATCH v2 09/11] exynos4-is: Add locking at fimc(-lite) subdev unregistered handler

2013-05-31 Thread Sylwester Nawrocki
Protect the fimc/fimc-lite video nodes unregistration with their video lock. This prevents a kernel crash when e.g. udev opens a video node right after the driver registers it and then the driver tries to unregister it and defers its probing. Using video_is_unregistered() together with the video

[REVIEW PATCH v2 05/11] exynos4-is: Do not use asynchronous runtime PM in release fop

2013-05-31 Thread Sylwester Nawrocki
Use pm_runtime_put_sync() instead of pm_runtime_put() to avoid races in handling the 'state' bit flags when the fimc-capture drivers' runtime_resume callback is called from the PM workqueue. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park

[REVIEW PATCH v2 07/11] exynos4-is: Remove WARN_ON() from __fimc_pipeline_close()

2013-05-31 Thread Sylwester Nawrocki
It's not a critical error to call __fimc_pipeline_close() with missing sensor subdev entity. Replace WARN_ON() with pr_warn() and return 0 instead of -EINVAL to fix control flow in some conditions. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park

[REVIEW PATCH v2 08/11] exynos4-is: Fix sensor subdev - FIMC notification setup

2013-05-31 Thread Sylwester Nawrocki
Ensure the v4l2_device notifications from sensor subdev works also after the media links reconfiguration. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/media-dev.c | 47

[REVIEW PATCH v2 04/11] exynos4-is: Media graph/video device locking rework

2013-05-31 Thread Sylwester Nawrocki
Remove driver private video node reference counters and use entity-use_count instead. This makes the video pipelines power handling more similar to the method used in omap3isp driver. Now the graph mutex is taken always after the video mutex, as it is not possible to ensure apposite order at the

[REVIEW PATCH v2 10/11] media: Change media device link_notify behaviour

2013-05-31 Thread Sylwester Nawrocki
Currently the media device link_notify callback is invoked before the actual change of state of a link when the link is being enabled, and after the actual change of state when the link is being disabled. This doesn't allow a media device driver to perform any operations on a full graph before a

[REVIEW PATCH v2 11/11] exynos4-is: Extend link_notify handler to support fimc-is/lite pipelines

2013-05-31 Thread Sylwester Nawrocki
This patch corrects the link_notify handler to support more complex pipelines, including fimc-lite and fimc-is entities. After the FIMC-IS driver addition the assumptions made in the link_notify callback are no longer valid, e.g. the link between fimc-lite subdev and its video node is not

[PATCH RFC] exynos4-is: Add support for Exynos5250 MIPI-CSIS

2013-05-31 Thread Sylwester Nawrocki
Add compatible property for the Exynos5250 and enable the frame start and frame end interrupts. These interrupts are needed for the Exynos5 FIMC-IS firmware. The driver enables those interrupts only where they are available, depending on the 'compatible' property. This can be optimized further, by

Re: stk1160: cannot alloc 196608 bytes

2013-05-31 Thread Ezequiel Garcia
Hello! I'm glad it helped. So we have *at least* one happy user for the keep_buffers option :-) In that case, it seems you had a memory fragmentation issue after all. Regards, Ezequiel On Fri, May 31, 2013 at 11:20 AM, a b genericgroupm...@gmail.com wrote: Hi Ezequiel, Just to report that i

[PATCH RFC v2] exynos4-is: Add support for Exynos5250 MIPI-CSIS

2013-05-31 Thread Sylwester Nawrocki
Add compatible property for the Exynos5250 and enable the frame start and frame end interrupts. These interrupts are needed for the Exynos5 FIMC-IS firmware. The driver enables those interrupt only where available, depending on the 'compatible' property. This can be optimized further, by exposing

Re: Unrecognized decoder chip (not gm7113c)

2013-05-31 Thread Greg Horvath
I am not sure how much work it would take to upgrade this particular kernel to 3.7+. The code for it came from https://github.com/olegk0/rk3066-kernel but I think it differs significantly from the main line structure and has several custom drivers. I will try and get a 3.7 kernel running on an x86

Re: Unrecognized decoder chip (not gm7113c)

2013-05-31 Thread Ezequiel Garcia
On Fri, May 31, 2013 at 12:23 PM, Greg Horvath horvath@gmail.com wrote: I will try and get a 3.7 kernel running on an x86 machine and see if I can get it to run though. Thanks for taking the time to investigate. That sounds like a good plan! Please try with a v3.7+ kernel on x86 and

Re: [RFC][PATCH 0/2] dma-buf: add importer private data for reimporting

2013-05-31 Thread Daniel Vetter
On Fri, May 31, 2013 at 07:22:24PM +0900, 김승우 wrote: Hello Daniel, Thanks for your comment. On 2013년 05월 31일 18:14, Daniel Vetter wrote: On Fri, May 31, 2013 at 10:54 AM, Seung-Woo Kim sw0312@samsung.com wrote: importer private data in dma-buf attachment can be used by importer

Re: [RFC][PATCH 0/2] dma-buf: add importer private data for reimporting

2013-05-31 Thread Lucas Stach
Am Freitag, den 31.05.2013, 17:29 +0200 schrieb Daniel Vetter: On Fri, May 31, 2013 at 07:22:24PM +0900, 김승우 wrote: Hello Daniel, Thanks for your comment. On 2013년 05월 31일 18:14, Daniel Vetter wrote: On Fri, May 31, 2013 at 10:54 AM, Seung-Woo Kim sw0312@samsung.com wrote:

[REVIEW PATCH 1/7] exynos4-is: Remove leftovers of non-dt FIMC-LITE support

2013-05-31 Thread Sylwester Nawrocki
FIMC-LITE devices are never looked up by iterating over all platform devices with bus_for_each_device() as these IP blocks are available only on dt-only Exynos SoC platforms. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[REVIEW PATCH 4/7] exynos4-is: Refactor vidioc_s_fmt, vidioc_try_fmt handlers

2013-05-31 Thread Sylwester Nawrocki
Remove duplicated code in the vidioc_try_fmt and vidioc_s_fmt handlers. This is a pre-requsite to allow successful fimc.capture video open even if its corresponding media entities are not linked into a complete pipeline. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by:

[REVIEW PATCH 5/7] exynos4-is: Move __fimc_videoc_querycap() function to the common module

2013-05-31 Thread Sylwester Nawrocki
Move __fimc_videoc_querycap() function to the common exynos4-is-common.ko module so it don't need to be reimplemented in multiple video node drivers of the exynos4-is. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[REVIEW PATCH 6/7] exynos4-is: Add isp_dbg() macro

2013-05-31 Thread Sylwester Nawrocki
This patch adds a debug trace macro for the FIMC-IS ISP subdev and video node drivers. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/fimc-isp.c | 16

[REVIEW PATCH 2/7] exynos4-is: Simplify bitmask usage

2013-05-31 Thread Sylwester Nawrocki
From: Phil Carmody phil.carm...@partner.samsung.com Merge the two sets of flags into one array to simplify accessing arbitrary bits from them. Signed-off-by: Phil Carmody phil.carm...@partner.samsung.com --- drivers/media/platform/exynos4-is/fimc-is-param.c | 80 ++---

[REVIEW PATCH 3/7] exynos4-is: Remove unused code

2013-05-31 Thread Sylwester Nawrocki
Remove unused macros and fields of struct fimc_is_video. Signed-off-by: Sylwester Nawrocki sylvester.nawro...@gmail.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/fimc-isp.h | 13 + drivers/media/platform/exynos4-is/media-dev.h |

[REVIEW PATCH 7/7] exynos4-is: Add the FIMC-IS ISP capture DMA driver

2013-05-31 Thread Sylwester Nawrocki
Add a video capture node for the FIMC-IS ISP IP block. The Exynos4x12 FIMC-IS ISP IP block has 2 DMA interfaces that allow to capture raw Bayer and YUV data to memory. Currently only the DMA2 output is and raw Bayer data capture is supported. Signed-off-by: Sylwester Nawrocki

[REVIEW PATCH 0/7] exynos4-is cleanup and ISP capture video driver addition

2013-05-31 Thread Sylwester Nawrocki
This is an initial version of the output DMA driver of the Exynos4x12 FIMC-IS ISP IP block. First 6 patches are mostly cleanups, the actual driver is added in the last patch. There is one issue in those DMA interfaces - the DMA addresses of all buffers need to be preconfigured before streaming is

cron job: media_tree daily build: WARNINGS

2013-05-31 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri May 31 19:00:20 CEST 2013 git branch: test git hash: 7eac97d7e714429f7ef1ba5d35f94c07f4c34f8e gcc

Re: [RFC][PATCH 0/2] dma-buf: add importer private data for reimporting

2013-05-31 Thread Daniel Vetter
On Fri, May 31, 2013 at 06:21:09PM +0200, Lucas Stach wrote: Am Freitag, den 31.05.2013, 17:29 +0200 schrieb Daniel Vetter: On Fri, May 31, 2013 at 07:22:24PM +0900, 김승우 wrote: Hello Daniel, Thanks for your comment. On 2013년 05월 31일 18:14, Daniel Vetter wrote: On Fri, May

[GIT PULL FOR v3.10] exynos4-is fixes

2013-05-31 Thread Sylwester Nawrocki
Hi Mauro, This includes couple bug fixes for the exynos imaging subsystem driver. Please pull for v3.10. The following changes since commit 6719a4974600fdaa4a3ac2ea2aed819a35d06605: [media] staging/solo6x10: select the desired font (2013-05-27 09:38:57 -0300) are available in the git

[PATCH 00/15] Linux-3.10 ARM randconfig fixes

2013-05-31 Thread Arnd Bergmann
Hi subsystem maintainers, These are a few patches left over from doing randconfig tests a couple of weeks ago. Please apply them directly into your trees unless you see problems. All patches can theoretically be seen as bug fixes for 3.10, but they are not critical, so applying them for 3.11 is

[PATCH 13/15] [media] omap3isp: include linux/mm_types.h

2013-05-31 Thread Arnd Bergmann
The ispqueue.h file uses vm_flags_t, which is defined in linux/mm_types.h, so we must include that header in order to build in all configurations. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Mauro Carvalho Chehab mche...@redhat.com Cc: linux-media@vger.kernel.org Cc: Konstantin Khlebnikov