Re: [REVIEW PATCH v3 1/2] media: Change media device link_notify behaviour

2013-06-10 Thread Laurent Pinchart
Hi Sylwester, Should I take the series in my tree, or would you like to push it yourself to avoid conflicts with other Exynos patches ? On Monday 10 June 2013 01:10:30 Sakari Ailus wrote: Hi Sylwester, Thanks for the update. Sylwester Nawrocki wrote: ... diff --git

Re: [PATCH] mt9p031: Use bulk regulator API

2013-06-10 Thread Laurent Pinchart
Hi Fabio, On Saturday 08 June 2013 10:20:42 Fabio Estevam wrote: On Sat, Jun 8, 2013 at 4:55 AM, Laurent Pinchart wrote: - if (IS_ERR(mt9p031-vaa) || IS_ERR(mt9p031-vdd) || - IS_ERR(mt9p031-vdd_io)) { + ret = devm_regulator_bulk_get(client-dev, 3,

Re: [PATCH] mt9p031: Use bulk regulator API

2013-06-10 Thread Laurent Pinchart
Hi Fabio, On Saturday 08 June 2013 10:24:58 Fabio Estevam wrote: On Sat, Jun 8, 2013 at 10:20 AM, Fabio Estevam wrote: On Sat, Jun 8, 2013 at 4:55 AM, Laurent Pinchart wrote: - if (IS_ERR(mt9p031-vaa) || IS_ERR(mt9p031-vdd) || - IS_ERR(mt9p031-vdd_io)) { + ret =

[PATCH] mt9p031: Use bulk regulator API

2013-06-10 Thread Laurent Pinchart
The sensor is powered by three supplies. Use the bulk regulator API to enable and disable them instead of performing the operations manually. This fixes a warning caused by ignoring the return value of regulator_enable(). Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

[GIT PULL FOR v3.11] Updates for 3.11

2013-06-10 Thread Hans Verkuil
Besides various fixes and two new drivers (ths8200, ML86V7667) this merges also some long patch series of mine: Control framework conversions: http://www.mail-archive.com/linux-media@vger.kernel.org/msg62772.html QUERYSTD fixes (particularly in the case of 'no signal'):

[GIT PULL FOR v3.11] OMAP3 ISP patches

2013-06-10 Thread Laurent Pinchart
Hi Mauro, This should be the last set of OMAP3 ISP patches for v3.11. The following changes since commit ab5060cdb8829c0503b7be2b239b52e9a25063b4: [media] drxk_hard: Remove most 80-cols checkpatch warnings (2013-06-08 22:11:39 -0300) are available in the git repository at:

[GIT PULL FOR v3.11] media core fix

2013-06-10 Thread Laurent Pinchart
Hi Mauro, Here's a small fix for the media controller core, targetted at v3.11. The following changes since commit ab5060cdb8829c0503b7be2b239b52e9a25063b4: [media] drxk_hard: Remove most 80-cols checkpatch warnings (2013-06-08 22:11:39 -0300) are available in the git repository at:

Re: [patch] [media] media: info leak in __media_device_enum_links()

2013-06-10 Thread Laurent Pinchart
Hi Dan, On Friday 31 May 2013 15:24:45 Dan Carpenter wrote: Ping? Oops, sorry for having missed the patch. On Sat, Apr 13, 2013 at 12:32:15PM +0300, Dan Carpenter wrote: These structs have holes and reserved struct members which aren't cleared. I've added a memset() so we don't leak

[PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-10 Thread Lubomir Rintel
Reverse-engineered driver for cheapo video digitizer, made from observations of Windows XP driver. The protocol is not yet completely understood, so far we don't provide any controls, only support a single format out of three and don't support the audio device. Signed-off-by: Lubomir Rintel

Re: [REVIEW PATCH v3 1/2] media: Change media device link_notify behaviour

2013-06-10 Thread Sylwester Nawrocki
Hi Laurent, On 06/10/2013 11:46 AM, Laurent Pinchart wrote: Hi Sylwester, Should I take the series in my tree, or would you like to push it yourself to avoid conflicts with other Exynos patches ? My plan was to handle this series together with the other Exynos patches it depends on. I

Re: [REVIEW PATCH v3 1/2] media: Change media device link_notify behaviour

2013-06-10 Thread Laurent Pinchart
On Monday 10 June 2013 12:20:15 Sylwester Nawrocki wrote: On 06/10/2013 11:46 AM, Laurent Pinchart wrote: Hi Sylwester, Should I take the series in my tree, or would you like to push it yourself to avoid conflicts with other Exynos patches ? My plan was to handle this series together

Re: stv0297 signal issues on QAM256

2013-06-10 Thread Daniel Glöckner
Hi, sorry for resurrecting this thread after a year and for my lengthy mail. On Sun, Jun 10, 2012 at 02:25:09PM +0200, Fredrik wrote: Unfortunatly my cable provider Comhem moved almost all channels to QAM256. The results are terrible on my two cards. Blocky picture and skipping audio. On

Re: [RFC PATCH v2 1/2] media: Add function removing all media entity links

2013-06-10 Thread Sylwester Nawrocki
Hi Sakari, On 06/10/2013 12:15 AM, Sakari Ailus wrote: Sylwester Nawrocki wrote: ... diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c index e1cd132..bd85dc3 100644 --- a/drivers/media/media-entity.c +++ b/drivers/media/media-entity.c @@ -429,6 +429,57 @@

Re: [RFC PATCH v2 1/2] media: Add function removing all media entity links

2013-06-10 Thread Sylwester Nawrocki
On 06/10/2013 12:26 PM, Sylwester Nawrocki wrote: Hi Sakari, On 06/10/2013 12:15 AM, Sakari Ailus wrote: Sylwester Nawrocki wrote: ... diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c index e1cd132..bd85dc3 100644 --- a/drivers/media/media-entity.c +++

Re: [REVIEW PATCH v3 1/2] media: Change media device link_notify behaviour

2013-06-10 Thread Sylwester Nawrocki
Hi Sakari, On 06/10/2013 12:10 AM, Sakari Ailus wrote: Sylwester Nawrocki wrote: ... diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 1d7dbd5..1a2d25c 100644 --- a/drivers/media/platform/omap3isp/isp.c +++

Re: [REVIEW PATCH v3 1/2] media: Change media device link_notify behaviour

2013-06-10 Thread Laurent Pinchart
On Monday 10 June 2013 12:47:02 Sylwester Nawrocki wrote: On 06/10/2013 12:10 AM, Sakari Ailus wrote: Sylwester Nawrocki wrote: ... diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 1d7dbd5..1a2d25c 100644 ---

Re: [REVIEW PATCH v3 1/2] media: Change media device link_notify behaviour

2013-06-10 Thread Sylwester Nawrocki
On 06/10/2013 12:49 PM, Laurent Pinchart wrote: -static int isp_pipeline_link_notify(struct media_pad *source, - struct media_pad *sink, u32 flags) +static int isp_pipeline_link_notify(struct media_link *link, u32 flags, +

Re: [PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-10 Thread Hans Verkuil
Hi Lubomir! Thanks for working on this. I've got some review comments below... On Mon June 10 2013 11:52:11 Lubomir Rintel wrote: Reverse-engineered driver for cheapo video digitizer, made from observations of Windows XP driver. The protocol is not yet completely understood, so far we

Re: [PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-10 Thread Hans Verkuil
Just as I sent my reply I realized that my notes w.r.t. field handling were incomplete. So I'll try to clarify it below. On Mon June 10 2013 13:05:04 Hans Verkuil wrote: Hi Lubomir! Thanks for working on this. I've got some review comments below... On Mon June 10 2013 11:52:11 Lubomir

Re: [PATCH v2 1/1] v4l: Document timestamp behaviour to correspond to reality

2013-06-10 Thread Hans Verkuil
On Mon June 10 2013 00:35:44 Sakari Ailus wrote: Hi Laurent, Laurent Pinchart wrote: ... @@ -745,13 +718,9 @@ applications when an output stream./entry byte was captured, as returned by the functionclock_gettime()/function function for the relevant

[REVIEW PATCH 1/9] soc_camera: replace vdev-parent by vdev-v4l2_dev.

2013-06-10 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com The parent field will eventually disappear to be replaced by v4l2_dev. soc_camera does provide a v4l2_device struct but did not point to it in struct video_device. This is now fixed. Now the video nodes can be found under the correct platform bus, and

[REVIEW PATCH 2/9] cx23885-417: use v4l2_dev instead of the deprecated parent field.

2013-06-10 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/pci/cx23885/cx23885-417.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx23885/cx23885-417.c b/drivers/media/pci/cx23885/cx23885-417.c index

[REVIEW PATCH 7/9] pvrusb2: use v4l2_dev instead of the deprecated parent field.

2013-06-10 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c |4 drivers/media/usb/pvrusb2/pvrusb2-hdw.h |4 drivers/media/usb/pvrusb2/pvrusb2-v4l2.c |7 --- 3 files changed, 12 insertions(+),

[REVIEW PATCH 9/9] v4l2: remove parent from v4l2 core.

2013-06-10 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/v4l2-dev.c | 34 +++--- drivers/media/v4l2-core/v4l2-ioctl.c |7 +-- include/media/v4l2-dev.h |2 -- 3 files changed,

[REVIEW PATCH 0/9] Use v4l2_dev instead of parent.

2013-06-10 Thread Hans Verkuil
This patch series converts the last set of drivers still using the parent field of video_device to using v4l2_dev instead and at the end the parent field is removed altogether. A proper pointer to v4l2_dev is necessary otherwise the advanced debugging ioctls will not work when addressing

[REVIEW PATCH 5/9] saa7164: use v4l2_dev instead of the deprecated parent field.

2013-06-10 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/pci/saa7164/saa7164-core.c|6 ++ drivers/media/pci/saa7164/saa7164-encoder.c |2 +- drivers/media/pci/saa7164/saa7164-vbi.c |2 +-

[REVIEW PATCH 3/9] zoran: use v4l2_dev instead of the deprecated parent field.

2013-06-10 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/pci/zoran/zoran_card.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/zoran/zoran_card.c b/drivers/media/pci/zoran/zoran_card.c index

[REVIEW PATCH 6/9] omap24xxcam: use v4l2_dev instead of the deprecated parent field.

2013-06-10 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/platform/omap24xxcam.c |9 - drivers/media/platform/omap24xxcam.h |3 +++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git

[REVIEW PATCH 4/9] sn9c102: use v4l2_dev instead of the deprecated parent field.

2013-06-10 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/sn9c102/sn9c102.h |3 +++ drivers/media/usb/sn9c102/sn9c102_core.c | 12 +++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git

[REVIEW PATCH 8/9] f_uvc: use v4l2_dev instead of the deprecated parent field.

2013-06-10 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/usb/gadget/f_uvc.c |8 +++- drivers/usb/gadget/uvc.h |2 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/f_uvc.c b/drivers/usb/gadget/f_uvc.c

[PATCH 0/6] s5p-mfc: Add support for MFC v7 firmware

2013-06-10 Thread Arun Kumar K
This patch series adds MFC v7 firmware support to the Exynos MFC driver. MFC v7 is present in 5420 SoC which has support for VP8 encoding and many other features. Arun Kumar K (6): [media] s5p-mfc: Update v6 encoder buffer sizes [media] s5p-mfc: Add register definition file for MFC v7

[PATCH 1/6] [media] s5p-mfc: Update v6 encoder buffer sizes

2013-06-10 Thread Arun Kumar K
The patch updates few encoder buffer sizes for MFC v6.5 as per the udpdated user manual. The same buffer sizes holds good for v7 firmware also. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h |4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 2/6] [media] s5p-mfc: Add register definition file for MFC v7

2013-06-10 Thread Arun Kumar K
The patch adds the register definition file for new firmware version v7 for MFC. New firmware supports VP8 encoding along with many other features. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v7.h | 58 ++ 1 file changed,

[PATCH 3/6] [media] s5p-mfc: Core support for MFC v7

2013-06-10 Thread Arun Kumar K
Adds variant data and core support for the MFC v7 firmware Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c| 32 +++ drivers/media/platform/s5p-mfc/s5p_mfc_common.h |2 ++ 2 files changed, 34 insertions(+) diff --git

[PATCH 4/6] [media] s5p-mfc: Update driver for v7 firmware

2013-06-10 Thread Arun Kumar K
Firmware version v7 is mostly similar to v6 in terms of hardware specific controls and commands. So the hardware specific opr_v6 and cmd_v6 are re-used for v7 also. This patch updates the v6 files to handle v7 version also. Signed-off-by: Arun Kumar K arun...@samsung.com ---

[PATCH 5/6] [media] V4L: Add VP8 encoder controls

2013-06-10 Thread Arun Kumar K
This patch adds new V4L controls for VP8 encoding. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kiran AVND avnd.ki...@samsung.com --- Documentation/DocBook/media/v4l/controls.xml | 145 ++ drivers/media/v4l2-core/v4l2-ctrls.c | 38 +++

[PATCH 6/6] [media] s5p-mfc: Add support for VP8 encoder

2013-06-10 Thread Arun Kumar K
MFC v7 supports VP8 encoding and this patch adds support for it in the driver. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_cmd_v6.c |3 + drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 19 - drivers/media/platform/s5p-mfc/s5p_mfc_enc.c

[GIT PULL FOR 3.11] Samsung SoC media driver updates

2013-06-10 Thread Sylwester Nawrocki
Hi Mauro, This includes mostly cleanups and non-critical bug fixes for The Samsung S3C/S5P/Exynos SoC media drivers, and some prerequisite patches to add support for more DMA interfaces of the Exynos4x12 Imaging Subsystem. There is also included a patch modifying the media link setup notifier,

Re: [PATCH 5/6] [media] V4L: Add VP8 encoder controls

2013-06-10 Thread Hans Verkuil
Hi Arun, Some review comments below... On Mon June 10 2013 15:23:05 Arun Kumar K wrote: This patch adds new V4L controls for VP8 encoding. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kiran AVND avnd.ki...@samsung.com --- Documentation/DocBook/media/v4l/controls.xml |

Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-06-10 Thread Hans Verkuil
On Sun June 9 2013 20:05:33 Sylwester Nawrocki wrote: Hi Sakari, On 06/06/2013 11:41 PM, Sakari Ailus wrote: ... diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index ebb8e48..f47ccfa 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls.c +++

Re: Are there any high fps camera available?

2013-06-10 Thread Hans Verkuil
On Fri June 7 2013 16:51:23 Peter Senna Tschudin wrote: Any one know any linux-media compatible camera capable of recording at 480 fps or more? Not to my knowledge. Note that there is no technical reason why such cameras couldn't be supported by linux. Regards, Hans -- To unsubscribe

Re: [PATCH 5/6] [media] V4L: Add VP8 encoder controls

2013-06-10 Thread Sylwester Nawrocki
Hi Arun, On 06/10/2013 03:23 PM, Arun Kumar K wrote: diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index fccd08b..2cf17d4 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls.c +++ b/drivers/media/v4l2-core/v4l2-ctrls.c @@ -456,6 +456,23 @@ const char

Re: [PATCH 2/2] Print parser position on error

2013-06-10 Thread Laurent Pinchart
Hi Sascha, I'm sorry for the late reply. Great patch set, thank you. It's very helpful. On Wednesday 08 May 2013 15:27:54 Sascha Hauer wrote: Most parser functions take a **endp argument to indicate the caller where parsing has stopped. This is currently only used after parsing something

Re: [RFC PATCH v2 0/2] Media entity links handling

2013-06-10 Thread Sylwester Nawrocki
Hi Laurent, On 06/09/2013 10:23 PM, Laurent Pinchart wrote: Hi Sylwester, On Sunday 09 June 2013 21:41:37 Sylwester Nawrocki wrote: Hi All, This small patch set adds a function for removing all links at a media entity. I found out such a function is needed when media entites that belong

[RFC PATCH v3 0/2] Media entity links handling

2013-06-10 Thread Sylwester Nawrocki
Hi, This is an updated version of the patch set http://www.spinics.net/lists/linux-media/msg64536.html Comparing to v2 it includes improvements of the __media_entity_remove_links() function, thanks to Sakari. The cover letter of v2 is included below. This small patch set adds a function for

[RFC PATCH v3 1/2] media: Add a function removing all links of a media entity

2013-06-10 Thread Sylwester Nawrocki
This function allows to remove all media entity's links to other entities, leaving no references to a media entity's links array at its remote entities. Currently, when a driver of some entity is removed it will free its media entities links[] array, leaving dangling pointers at other entities

[RFC PATCH v3 2/2] V4L: Remove all links of a media entity when unregistering subdev

2013-06-10 Thread Sylwester Nawrocki
Remove all links of the subdev's media entity after internal_ops 'unregistered' call and right before unregistering the entity from a media device. It is assumed here that an unregistered (orphan) media entity cannot have links to other entities registered to a media device. It is also assumed

[RFC PATCH v3 0/2] Media entity links handling

2013-06-10 Thread Sylwester Nawrocki
This is an updated version of the patch set http://www.spinics.net/lists/linux-media/msg64536.html Comparing to v2 it includes improvements of the __media_entity_remove_links() function, thanks to Sakari. The cover letter of v2 is included below. This small patch set adds a function for

Re: rtl28xxu IR remote

2013-06-10 Thread marco caminati
Hi, I just compiled and tested Antti Palosaari branch and can confirm the remote works for my RTL2832U. I have updated the wiki[1] entry with the steps necessary to configure the remote control. Please confirm if these fixes your problem. Thanks, but I can't confirm if this fixes my

Re: [PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-10 Thread Lubomir Rintel
On Mon, 2013-06-10 at 13:05 +0200, Hans Verkuil wrote: Also, I the hardware uses V4L2_FIELD_ALTERNATE interlacing, but I couldn't make it work, What didn't work exactly? Both mplayer and gstream v4l2src displayed only half of an image. Not sure which combinations of flags did I use

[PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-10 Thread Lubomir Rintel
Reverse-engineered driver for cheapo video digitizer, made from observations of Windows XP driver. The protocol is not yet completely understood, so far we don't provide any controls, only support a single format out of three and don't support the audio device. Signed-off-by: Lubomir Rintel

Re: rtl28xxu IR remote

2013-06-10 Thread Antti Palosaari
On 06/10/2013 06:09 PM, marco caminati wrote: Hi, I just compiled and tested Antti Palosaari branch and can confirm the remote works for my RTL2832U. I have updated the wiki[1] entry with the steps necessary to configure the remote control. Please confirm if these fixes your problem.

cron job: media_tree daily build: WARNINGS

2013-06-10 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Jun 10 19:00:18 CEST 2013 git branch: test git hash: ab5060cdb8829c0503b7be2b239b52e9a25063b4 gcc

Re: [REVIEW PATCH 8/9] f_uvc: use v4l2_dev instead of the deprecated parent field.

2013-06-10 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Monday 10 June 2013 14:48:37 Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/usb/gadget/f_uvc.c |8 +++- drivers/usb/gadget/uvc.h |2 ++ 2 files changed, 9

Re: [REVIEW PATCH 9/9] v4l2: remove parent from v4l2 core.

2013-06-10 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Monday 10 June 2013 14:48:38 Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/v4l2-core/v4l2-dev.c | 34

[PATCH] [media] ttusb-budget: fix memory leak in ttusb_probe()

2013-06-10 Thread Alexey Khoroshilov
If something goes wrong starting from i2c_add_adapter(), ttusb-iso_urb[] and ttusb itself are not deallocated. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c | 2 ++ 1

[PATCH] [media] usbvision-video: fix memory leak of alt_max_pkt_size

2013-06-10 Thread Alexey Khoroshilov
1. usbvision-alt_max_pkt_size is not deallocated anywhere. 2. if allocation of usbvision-alt_max_pkt_size fails, there is no proper deallocation of already acquired resources. The patch adds kfree(usbvision-alt_max_pkt_size) to usbvision_release() as soon as other deallocations happen there. It