From: Jassi Brar jaswinder.si...@linaro.org
'xt' points to a dma_interleaved_template and not a dma_async_tx_descriptor.
Signed-off-by: Jassi Brar jaswinder.si...@linaro.org
---
drivers/media/platform/m2m-deinterlace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Congratulations! You are receiving this email from Mr. Tom Crist, the Canadian
CEO who won $40 million in the Calgary Lotto, i am writing to inform you that
Google have submitted your Email upon my request to receive a check for $1.2
million from me, as I am giving all my winnings away to
On 11.01.2014 21:53, Mauro Carvalho Chehab wrote:
Em Sat, 11 Jan 2014 14:37:30 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 10.01.2014 19:45, schrieb Mauro Carvalho Chehab:
Just filling urb-interval with 1 is wrong, and causes a different
behaviour with xHCI.
With EHCI, the
On 11.01.2014 21:10, Mauro Carvalho Chehab wrote:
Em Sat, 11 Jan 2014 13:29:49 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 10.01.2014 09:33, schrieb Mauro Carvalho Chehab:
Follow the error codes for I2C as described at Documentation/i2c/fault-codes.
In the case of the I2C
On 11.01.2014 21:22, Mauro Carvalho Chehab wrote:
Em Sat, 11 Jan 2014 14:09:44 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 10.01.2014 09:33, schrieb Mauro Carvalho Chehab:
The I2C output messages is too polluted. Clean it a little
bit, by:
- use the proper core
On 11.01.2014 21:27, Mauro Carvalho Chehab wrote:
Em Sat, 11 Jan 2014 14:14:38 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 10.01.2014 09:33, schrieb Mauro Carvalho Chehab:
If i2c_debug is enabled, we splicitly want to know when a
device fails with timeout.
If i2c_debug==2,
Pulseaudio has the bad habit of stopping a streaming audio if
a device, opened in non-block mode, waits.
It is impossible to avoid em28xx to wait, as it will send commands
via I2C, and other I2C operations may be happening (firmware
transfers, Remote Controller polling, etc). Yet, as each em28xx
That fixes the audio bug :) I can listen netradio using Rhythmbox and it
does not lose audio anymore when em28xx device is plugged.
Tested-by: Antti Palosaari cr...@iki.fi
regards
Antti
On 12.01.2014 14:25, Mauro Carvalho Chehab wrote:
Pulseaudio has the bad habit of stopping a streaming
When the usb device is disconnected, the resources are no longer available,
so there is no reason to keep them registered.
This will also fix the various sysfs group removal warnings which we can see
since kernel 3.13.
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
Remove some dead code from em28xx_v4l2_fini() and fix the leaking of the video,
vbi and radio video_device struct memories.
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-video.c | 56 +--
1 Datei geändert, 30 Zeilen
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 21 -
drivers/media/usb/em28xx/em28xx-dvb.c | 23 +++
2 Dateien geändert, 23 Zeilen hinzugefügt(+), 21 Zeilen entfernt(-)
diff --git
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-cards.c |4 +---
drivers/media/usb/em28xx/em28xx-video.c |2 ++
2 Dateien geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-)
diff --git a/drivers/media/usb/em28xx/em28xx-cards.c
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-cards.c |3 ---
drivers/media/usb/em28xx/em28xx-video.c |6 ++
2 Dateien geändert, 6 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-)
diff --git a/drivers/media/usb/em28xx/em28xx-cards.c
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 10 --
drivers/media/usb/em28xx/em28xx-video.c |5 +
2 Dateien geändert, 5 Zeilen hinzugefügt(+), 10 Zeilen entfernt(-)
diff --git a/drivers/media/usb/em28xx/em28xx-cards.c
Patch 1 is fix for the analog device initialization on the first open() call.
Patches 2-7 move some dvb and v4l specific code from the core module to the
extension modules and fix the resources releasing logic/order in the core and
the v4l2 module. This will also fix the various sysfs group
- bail out on unsupported VFL_TYPE
- em28xx_set_mode() needs to be called for VBI and radio mode, too
- em28xx_wake_i2c() needs to be called for VBI and radio mode, too
- em28xx_resolution_set() also needs to be called for VBI
Signed-off-by: Frank Schäfer fschaefer@googlemail.com
---
v4l2_ctrl_handler_free() and v4l2_device_unregister() are currently only called
when the last user closes the device and the device is already disconnected.
But that's wrong, we need to call these functions whenever the em28xx-v4l
extension is closed and we can already do this if the device is
On 10.01.2014 05:08, Chris Lee wrote:
Im not sure exactly when it broke but alot of changes have happened in
em28xx lately and they've broken my Kworld 330u. The issue is that
ctl-demod = XC3028_FE_CHINA;
ctl-fname = XC2028_DEFAULT_FIRMWARE;
cfg.ctrl = ctl;
are no longer being set, this
Em Sun, 12 Jan 2014 16:29:26 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
On 11.01.2014 21:27, Mauro Carvalho Chehab wrote:
Em Sat, 11 Jan 2014 14:14:38 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 10.01.2014 09:33, schrieb Mauro Carvalho Chehab:
If
Em Sun, 12 Jan 2014 17:43:28 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
On 10.01.2014 05:08, Chris Lee wrote:
Im not sure exactly when it broke but alot of changes have happened in
em28xx lately and they've broken my Kworld 330u. The issue is that
ctl-demod =
On 09.01.2014 02:02, Keith Lawson wrote:
Hello,
I sent the following message to the linux-usb mailing list and they
suggested I try here.
I'm trying to get a Dazzle Video Capture USB V1.0 video capture card
working on a Linux device but it doesn't look like the chip set is
supported yet. I
If em28xx is disconnected, return -ENODEV to all PCM callbacks.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-audio.c | 43 +++--
1 file changed, 41 insertions(+), 2 deletions(-)
diff --git
The URB calculus code may eventually be moved to some other
place, like at pcm open, if it ends by needing more setups, like
working with different bit rates, or different audio latency.
So, move it into a separate routine. That also makes the code
more readable.
No functional changes.
Now that em28xx can be compiled without V4L support, we should
call em28xx_setup_xc3028() on both em28xx-v4l and em28xx-dvb
modules.
Reported-by: Chris Lee update...@gmail.com
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 49
Em Sat, 11 Jan 2014 14:42:29 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
The current code assumes that the analog + digital video endpoints are always
at
interface number 0 when changing the alternate setting.
This seems to work fine for most existing devices.
However, at
Em Sat, 11 Jan 2014 14:42:30 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Previously, we've been assuming that the video endpoints are always at usb
interface 0. Hence, if vendor audio endpoints are provided at a separate
interface, they were supposed to be at interface number
Em Sun, 12 Jan 2014 09:53:43 -0700
Chris Lee update...@gmail.com escreveu:
Thanks guys, appreciate it :) As soon as I see the patch fly by I'll
test it out, or you can email me directly if you want it tested before
it goes to the list. Either way Im flexible.
UDL
On Sun, Jan 12, 2014 at
Em Sun, 12 Jan 2014 17:24:17 +0100
Frank Schäfer fschaefer@googlemail.com escreveu:
Patch 1 is fix for the analog device initialization on the first open() call.
Patches 2-7 move some dvb and v4l specific code from the core module to the
extension modules and fix the resources releasing
Alsa has an special non-negative return code to indicate device removal
at snd_em28xx_capture_pointer(). Use it, instead of an error code.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
URBs might be in usage. Disconnect the device before freeing
them.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-audio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/usb/em28xx/em28xx-audio.c
Alsa has an special non-negative return code to indicate device removal
at snd_em28xx_capture_pointer(). Use it, instead of an error code.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
We can't free struct em28xx while one of the extensions is still
using it.
So, add a kref() to control it, freeing it only after the
extensions fini calls.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-audio.c | 5 -
Cleanup the error handling code at em28xx-audio init.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-audio.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx-audio.c
Even after Frank's series, there are several issues with device module
removal.
This series fix those issues, by use kref to deallocate the common
data (struct em28xx *dev).
It also fixes a circular deppendency inside em28xx-audio.
Mauro Carvalho Chehab (7):
em28xx-audio: fix return code on
That helps to identify if something fails and explain why em28xx
struct is not freed (if it ever happens).
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-audio.c | 2 ++
drivers/media/usb/em28xx/em28xx-dvb.c | 2 ++
Now that everything is extension, the usb disconnect logic should
be the same.
While here, fix the device name.
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/usb/em28xx/em28xx-cards.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git
We can't lock at pcm close, as it causes circular dependency
lock issues with .init and .fini callbacks. So, move the code
that puts the device on mute to the kthread.
[ 322.026316] ==
[ 322.026356] [ INFO: possible circular locking
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Mon Jan 13 04:00:17 CET 2014
git branch: test
git hash: 8b1fa5798dec77d9d2cd81751772a580474aa17f
gcc
38 matches
Mail list logo
