[PATCH] media: i2c: mt9p031: Check return value of clk_prepare_enable/clk_set_rate

2014-01-17 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com clk_set_rate(), clk_prepare_enable() functions can fail, so check the return values to avoid surprises. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media/i2c/mt9p031.c | 12 +--- 1 file changed, 9 insertions(+),

Re: [RFC PATCH 3/6] DocBook media: partial rewrite of Opening and Closing Devices

2014-01-17 Thread Hans Verkuil
Hi Mauro, On 01/13/2014 06:23 PM, Mauro Carvalho Chehab wrote: Em Mon, 13 Jan 2014 17:15:40 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: On 01/13/2014 04:20 PM, Mauro Carvalho Chehab wrote: Em Tue, 7 Jan 2014 14:06:54 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: From: Hans Verkuil

[PATCH] media: i2c: mt9v032: Check return value of clk_prepare_enable/clk_set_rate

2014-01-17 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com clk_set_rate(), clk_prepare_enable() functions can fail, so check the return values to avoid surprises. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media/i2c/mt9v032.c | 10 -- 1 file changed, 8 insertions(+), 2

[RFCv2 PATCH 3/6] DocBook media: partial rewrite of Opening and Closing Devices

2014-01-17 Thread Hans Verkuil
This section was horribly out of date. A lot of references to old and obsolete behavior have been dropped. Updated as per Mauro's suggestions (well, most of them anyway :-) ). Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- Documentation/DocBook/media/v4l/common.xml | 192

Re: [PATCH 6/6] v4l: disable lockdep on vb2_fop_mmap()

2014-01-17 Thread Hans Verkuil
Hi Antti, Is this still needed after this commit was merged? http://git.linuxtv.org/media_tree.git/commit/b18a8ff29d80b132018d33479e86ab8ecaee6b46 Regards, Hans On 12/29/2013 05:51 AM, Antti Palosaari wrote: Avoid that lockdep warning: [ INFO: possible circular locking dependency

Re: [PATCH] media: rc: only turn on LED if keypress generated

2014-01-17 Thread Sean Young
On Thu, Jan 16, 2014 at 10:56:22PM +, James Hogan wrote: Since v3.12, specifically 153a60bb0fac ([media] rc: add feedback led trigger for rc keypresses), an LED trigger is activated on IR keydown whether or not a keypress is generated (i.e. even if there's no matching keycode). However the

Re: [PATCH, RFC 05/30] [media] omap_vout: avoid sleep_on race

2014-01-17 Thread Hans Verkuil
Hi Arnd, On 01/02/2014 01:07 PM, Arnd Bergmann wrote: sleep_on and its variants are broken and going away soon. This changes the omap vout driver to use interruptible_sleep_on_timeout instead, I assume you mean wait_event_interruptible_timeout here :-) Reviewed-by: Hans Verkuil

Re: [PATCH, RFC 06/30] [media] usbvision: remove bogus sleep_on_timeout

2014-01-17 Thread Hans Verkuil
On 01/02/2014 01:07 PM, Arnd Bergmann wrote: There is no reason to use sleep_on_timeout here, and we want to get rid of that interface. Use the simpler msleep_interruptible instead. Since this define is unused anyway, lets just remove it completely. I'll post a patch for this. Regards,

[PATCH] usbvision: drop unused define USBVISION_SAY_AND_WAIT

2014-01-17 Thread Hans Verkuil
This define uses the deprecated interruptible_sleep_on_timeout function. Since this define is unused anyway we just remove it. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Arnd Bergmann a...@arndb.de --- drivers/media/usb/usbvision/usbvision.h | 8 1 file changed, 8

Re: [PATCH, RFC 07/30] [media] radio-cadet: avoid interruptible_sleep_on race

2014-01-17 Thread Hans Verkuil
Hi Arnd! On 01/02/2014 01:07 PM, Arnd Bergmann wrote: interruptible_sleep_on is racy and going away. This replaces one use in the radio-cadet driver with an open-coded wait loop that lets us check the condition under the mutex but sleep without it. Signed-off-by: Arnd Bergmann

Re: [PATCH, RFC 08/30] [media] arv: fix sleep_on race

2014-01-17 Thread Hans Verkuil
On 01/02/2014 01:07 PM, Arnd Bergmann wrote: interruptible_sleep_on is racy and going away. In the arv driver that race has probably never caused problems since it would require a whole video frame to be captured before the read function has a chance to go to sleep, but using

[GIT PULL FOR v3.14/3.15] usbtv: add audio support

2014-01-17 Thread Hans Verkuil
The following changes since commit 587d1b06e07b4a079453c74ba9edf17d21931049: [media] rc-core: reuse device numbers (2014-01-15 11:46:37 -0200) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v3.14d for you to fetch changes up to

[GIT PULL FOR v3.14] Repost: various v4l2 fixes

2014-01-17 Thread Hans Verkuil
For some reason this didn't appear in patchwork, so I repost this pull request. Regards, Hans The following changes since commit d20e4ed6d30c6ecee315eea0efb3449c3591d09e: [media] em28xx: use a better value for I2C timeouts (2014-01-10 06:10:07 -0200) are available in the git

[PATCH v2 03/15] media: rc: add raw decoder for Sharp protocol

2014-01-17 Thread James Hogan
Add a raw decoder for the Sharp protocol. It uses a pulse distance modulation with a pulse of 320us and a bit period of 2ms for a logical 1 and 1ms for a logical 0. The first part of the message consists of a 5-bit address, an 8-bit command, and two other bits, followed by a 40ms gap before the

[PATCH v2 05/15] media: rc: change 32bit NEC scancode format

2014-01-17 Thread James Hogan
Change 32bit NEC scancode format (used by Apple and TiVo remotes) to encode the data with the correct bit order. Previously the raw bits were used without being bit reversed, now each 16bit half is bit reversed compared to before. So for the raw NEC data: (LSB/First) 0xAAaaCCcc (MSB/Last)

[PATCH v2 04/15] media: rc: add sysfs scancode filtering interface

2014-01-17 Thread James Hogan
Add and document a generic sysfs based scancode filtering interface for making use of IR data matching hardware to filter out uninteresting scancodes. Two filters exist, one for normal operation and one for filtering scancodes which are permitted to wake the system from suspend. The following

[PATCH v2 01/15] media: rc: document rc class sysfs API

2014-01-17 Thread James Hogan
Briefly document /sys/class/rc/ API for remote controller devices in Documentation/ABI/teting. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org Cc: Rob Landley r...@landley.net Cc: linux-...@vger.kernel.org --- v2: -

[PATCH v2 11/15] media: rc: img-ir: add NEC decoder module

2014-01-17 Thread James Hogan
Add an img-ir module for decoding the NEC and extended NEC infrared protocols. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- v2: - Update scancode and filter callbacks to handle 32-bit NEC as used by Apple

[PATCH v2 12/15] media: rc: img-ir: add JVC decoder module

2014-01-17 Thread James Hogan
Add an img-ir module for decoding the JVC infrared protocol. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic

[PATCH v2 13/15] media: rc: img-ir: add Sony decoder module

2014-01-17 Thread James Hogan
Add an img-ir module for decoding the Sony infrared protocol. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic

[PATCH v2 15/15] media: rc: img-ir: add Sanyo decoder module

2014-01-17 Thread James Hogan
Add an img-ir module for decoding the Sanyo infrared protocol. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic

[PATCH v2 06/15] dt: binding: add binding for ImgTec IR block

2014-01-17 Thread James Hogan
Add device tree binding for ImgTec Consumer Infrared block, specifically major revision 1 of the hardware. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll

[PATCH v2 08/15] media: rc: img-ir: add raw driver

2014-01-17 Thread James Hogan
Add raw IR remote control input driver for the ImgTec Infrared decoder block's raw edge interrupts. Generic software protocol decoders are used to allow multiple protocols to be supported at a time, including those not supported by the hardware decoder. Signed-off-by: James Hogan

[PATCH v2 07/15] media: rc: img-ir: add base driver

2014-01-17 Thread James Hogan
Add base driver for the ImgTec Infrared decoder block. The driver is split into separate components for raw (software) decode and hardware decoder which are in following commits. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc:

[PATCH v2 09/15] media: rc: img-ir: add hardware decoder driver

2014-01-17 Thread James Hogan
Add remote control input driver for the ImgTec Infrared block hardware decoder, which is set up with timings for a specific protocol and supports mask/value filtering and wake events. The hardware decoder timing values, raw data to scan code conversion function and scan code filter to raw data

[PATCH v2 14/15] media: rc: img-ir: add Sharp decoder module

2014-01-17 Thread James Hogan
Add an img-ir module for decoding the Sharp infrared protocol. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic

[PATCH v2 10/15] media: rc: img-ir: add to build

2014-01-17 Thread James Hogan
Add ImgTec IR decoder driver to the build system. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- drivers/media/rc/Kconfig | 2 ++ drivers/media/rc/Makefile| 1 +

[PATCH v2 00/15] media: rc: ImgTec IR decoder driver

2014-01-17 Thread James Hogan
A few generic changes (patches 1-5) and then add a driver for the ImgTec Infrared decoder block (patches 6-15). Two separate rc input devices are exposed depending on kernel configuration. One uses the hardware decoder which is set up with timings for a specific protocol and supports mask/value

Re: [PATCH] usbvision: drop unused define USBVISION_SAY_AND_WAIT

2014-01-17 Thread Arnd Bergmann
On Friday 17 January 2014, Hans Verkuil wrote: This define uses the deprecated interruptible_sleep_on_timeout function. Since this define is unused anyway we just remove it. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Arnd Bergmann a...@arndb.de Acked-by: Arnd Bergmann

Re: [PATCH, RFC 07/30] [media] radio-cadet: avoid interruptible_sleep_on race

2014-01-17 Thread Arnd Bergmann
On Friday 17 January 2014, Hans Verkuil wrote: @@ -323,25 +324,32 @@ static ssize_t cadet_read(struct file *file, char __user *data, size_t count, lo struct cadet *dev = video_drvdata(file); unsigned char readbuf[RDS_BUFFER]; int i = 0; + DEFINE_WAIT(wait);

Re: ov3640 sensor - CCDC won't become idle!

2014-01-17 Thread Peter Meerwald
Hello, as the subject says I got a problem with the ccdc. My pipeline is: sensor - ccdc - memory By doing some research I found a appropriate answer from Laurent: The OMAP3 ISP is quite picky about its input signals and doesn't gracefully handle missing or extra sync pulses for

Re: Regression inside omap3isp/resizer

2014-01-17 Thread Florian Vaussard
Hi Laurent and Sakari, On 01/17/2014 08:15 AM, Sakari Ailus wrote: Hi Laurent and Florian, Laurent Pinchart wrote: Hi Florian, On Thursday 09 January 2014 19:09:48 Florian Vaussard wrote: On 12/31/2013 09:51 AM, Laurent Pinchart wrote: Hi Florian, Sorry for the late reply. Now it is

Re: [PATCH 6/6] v4l: disable lockdep on vb2_fop_mmap()

2014-01-17 Thread Antti Palosaari
Hi Hans On 17.01.2014 12:04, Hans Verkuil wrote: Hi Antti, Is this still needed after this commit was merged? http://git.linuxtv.org/media_tree.git/commit/b18a8ff29d80b132018d33479e86ab8ecaee6b46 It didn't fix the problem. I could reproduce that issue easily using vivi and Cheese (webcam

Re: ov3640 sensor - CCDC won't become idle!

2014-01-17 Thread Tom
Peter Meerwald pmeerw at pmeerw.net writes: Hello Peter, Many thanks for posting your solution. Your idea sounds great and I'll give it a try on next monday. Thanks again. Best Regards, Tom -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to

[PATCH] [media] hdpvr: Fix memory leak in debug

2014-01-17 Thread Masanari Iida
cppcheck reported memory leak in device_authorizatio() within hdpvr-core.c. When the debug option is specified and the code jump to unlock: label, print_buf was not freed. Confirm the module succesfully compiled without error. Signed-off-by: Masanari Iida standby2...@gmail.com ---

Re: [RFT PATCH] em28xx-audio: don't overwrite the usb alt setting made by the video part

2014-01-17 Thread Frank Schäfer
Am 16.01.2014 00:11, schrieb Mauro Carvalho Chehab: Em Wed, 15 Jan 2014 22:36:25 +0100 Frank Schäferfschaefer@googlemail.com escreveu: Am 15.01.2014 22:31, schrieb Frank Schäfer: em28xx-audio currently switches to usb alternate setting #7 in case of a mixed interface. This may overwrite

[PATCH 2/2] em28xx-audio: make sure audio is unmuted on open()

2014-01-17 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-audio.c | 42 --- 1 Datei geändert, 22 Zeilen hinzugefügt(+), 20 Zeilen entfernt(-) diff --git a/drivers/media/usb/em28xx/em28xx-audio.c

[PATCH 1/2] em28xx-audio: fix user counting in snd_em28xx_capture_open()

2014-01-17 Thread Frank Schäfer
dev-adev.users always needs to be increased when snd_em28xx_capture_open() is called and succeeds. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-audio.c | 22 +++--- 1 Datei geändert, 11 Zeilen hinzugefügt(+), 11 Zeilen

[PATCH 2/3] em28xx-camera: fix return value checks on sensor probing

2014-01-17 Thread Frank Schäfer
Since commit e63b009d6e the returned error code in case of not connected/responding i2c clients is ENXIO isntead of ENODEV, which causes several error messages on sensor probing. Fix the i2c return value checks on sensor probing to silence these warnings. Signed-off-by: Frank Schäfer

[PATCH 3/3] em28xx-v4l: do not call em28xx_init_camera() if the device has no sensor

2014-01-17 Thread Frank Schäfer
This avoids the unnecessary temporary registration of a dummy V4L2 clock. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c |3 ++- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git

[PATCH 1/3] em28xx-video: do not unregister the v4l2 dummy clock before v4l2_device_unregister() has been called

2014-01-17 Thread Frank Schäfer
Otherwiese the core refuses to unregister the clock and the following warning appears in the system log: WARNING: ... at drivers/media/v4l2-core/v4l2-clk.c:231 v4l2_clk_unregister+0x8a/0x90 [videodev]() v4l2_clk_unregister(): Refusing to unregister ref-counted 11-0030:mclk clock!

Re: Regression inside omap3isp/resizer

2014-01-17 Thread Laurent Pinchart
Hi Florian, On Friday 17 January 2014 15:45:12 Florian Vaussard wrote: On 01/17/2014 08:15 AM, Sakari Ailus wrote: Laurent Pinchart wrote: On Thursday 09 January 2014 19:09:48 Florian Vaussard wrote: On 12/31/2013 09:51 AM, Laurent Pinchart wrote: On Monday 23 December 2013 22:47:45

Re: dvb-usb-dib0700-1.20.fw Issues.

2014-01-17 Thread Ray Image
I have tried this now on Debian 32 and 64 bit versions with no joy. The sticks are fine as they work on Windows 7 perfectly. Any advice? On 15 January 2014 20:02, Ray Image imagemagi...@gmail.com wrote: I have tried a couple of USB sticks which use the dvb-usb-dib0700-1.20.fw firmware in a

[PATCH] [media] omap3isp: preview: Fix the crop margins

2014-01-17 Thread Florian Vaussard
Commit 3fdfedaaa [media] omap3isp: preview: Lower the crop margins accidentally changed the previewer's cropping, causing the previewer to miss four pixels on each line, thus corrupting the final image. Restored the removed setting. Signed-off-by: Florian Vaussard florian.vauss...@epfl.ch

cron job: media_tree daily build: WARNINGS

2014-01-17 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Jan 18 04:00:22 CET 2014 git branch: test git hash: 587d1b06e07b4a079453c74ba9edf17d21931049 gcc