Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-17 Thread Tomi Valkeinen
On 18/03/14 01:30, Laurent Pinchart wrote: > I agree with you. I know that DT bindings review takes too much time, slows > development down and is just generally painful. I'm trying to reply to this e- > mail thread as fast as possible, but I'm also busy with other tasks :-/ > > The lack of form

cron job: media_tree daily build: OK

2014-03-17 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 18 04:00:15 CET 2014 git branch: test git hash: ed97a6fe5308e5982d118a25f0697b791af5ec50 gcc versio

Updated DVB-T tables - where to send them?

2014-03-17 Thread Chris Rankin
Hi, The DVB-T initial tuning information for Crystal Palace in the UK is completely obsolete - despite my two attempts to submit an updated version over the YEARS. Where is the best place to send this information, please? Thanks, Chris -- To unsubscribe from this list: send the line "unsubsc

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-17 Thread Laurent Pinchart
Hi Philipp, On Friday 14 March 2014 13:19:39 Philipp Zabel wrote: > Am Donnerstag, den 13.03.2014, 18:13 +0100 schrieb Laurent Pinchart: > > On Thursday 13 March 2014 12:08:16 Philipp Zabel wrote: > > > Am Montag, den 10.03.2014, 14:37 + schrieb Grant Likely: > > > > > > Nak. I made comments t

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-17 Thread Laurent Pinchart
Hi Robert, On Friday 14 March 2014 08:05:05 Robert Schwebel wrote: > On Thu, Mar 13, 2014 at 04:13:08PM +0100, Sylwester Nawrocki wrote: > > My experience and feelings are similar, I started to treat mainline > > kernel much less seriously after similar DT related blocking issues. > > So how do w

Re: [PATCH v2 0/9] rc: Add IR encode based wakeup filtering

2014-03-17 Thread James Hogan
On Monday 17 March 2014 19:01:51 Antti Seppälä wrote: > On 17 March 2014 00:41, James Hogan wrote: > > Yeh I'm in two minds about this now. It's actually a little awkward since > > some of the protocols have multiple variants (i.e. "rc-5" = RC5+RC5X), > > but an encoded message is only ever a sing

Do you need a Loan? Contact Santander Finance

2014-03-17 Thread Santander Finance
We offer all purpose loan at 3% interest rate. Contact Us for more details by Email:santanderfinancegr...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordo

Re: [PATCH 1/9] mm: Provide new get_vaddr_pfns() helper

2014-03-17 Thread Dave Hansen
On 03/17/2014 12:49 PM, Jan Kara wrote: > +int get_vaddr_pfns(unsigned long start, int nr_pfns, int write, int force, > +struct pinned_pfns *pfns) > +{ ... > + if (!(vma->vm_flags & (VM_IO | VM_PFNMAP))) { > + pfns->got_ref = 1; > + pfns->is_pages = 1; >

[RFC] Helper to abstract vma handling in media layer

2014-03-17 Thread Jan Kara
Hello, The following patch series is my first stab at abstracting vma handling from the various media drivers. After this patch set drivers have to know much less details about vmas, their types, and locking. My motivation for the series is that I want to change get_user_pages() locking and I

[PATCH 7/9] media: vb2: Remove unused functions

2014-03-17 Thread Jan Kara
Conversion to the use of pinned pfns made some functions unused. Remove them. Also there's no need to lock mmap_sem in __buf_prepare() anymore. Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-core.c | 8 +- drivers/media/v4l2-core/videobuf2-memops.c | 114 --

[PATCH 2/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns()

2014-03-17 Thread Jan Kara
Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() instead of hand made mapping of virtual address to physical address. Also the function leaked page reference from get_user_pages() so fix that by properly release the reference when omap_vout_buffer_release() is called. Signed-off-by: Ja

[PATCH 8/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_pfn()

2014-03-17 Thread Jan Kara
Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_pfn(). This removes the knowledge about vmas and mmap_sem locking from exynos driver. Also it fixes a problem that the function has been mapping user provided address without holding mmap_sem. Signed-off-by: Jan Kara --- drivers/gpu

[PATCH 4/9] media: vb2: Convert vb2_dma_sg_get_userptr() to use pinned pfns

2014-03-17 Thread Jan Kara
Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-sg.c | 85 ++ 1 file changed, 15 insertions(+), 70 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c b/drivers/media/v4l2-core/videobuf2-dma-sg.c index ef0b3f765d8e..a37ee0fa84d3 100

[PATCH 6/9] media: vb2: Convert vb2_dc_get_userptr() to use pfns vector

2014-03-17 Thread Jan Kara
Convert vb2_dc_get_userptr() to use passed vector of pfns. When we are doing that there's no need to allocate page array and some code can be simplified. Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 203 - 1 file changed, 30 insertions(+),

[PATCH 9/9] staging: tidspbridge: Convert to get_vaddr_pfns()

2014-03-17 Thread Jan Kara
Convert the driver to use get_vaddr_pfns() instead of get_user_pages() or a hand made page table walk. This removes knowledge about vmas and mmap_sem locking from the driver. Signed-off-by: Jan Kara --- drivers/staging/tidspbridge/core/tiomap3430.c | 261 - .../staging/t

[PATCH 5/9] media: vb2: Convert vb2_vmalloc_get_userptr() to use pfns vector

2014-03-17 Thread Jan Kara
Convert vb2_vmalloc_get_userptr() to use passed vector of pfns. When we are doing that there's no need to allocate page array and some code can be simplified. Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-vmalloc.c | 86 +++-- 1 file changed, 33 insertions

[PATCH 1/9] mm: Provide new get_vaddr_pfns() helper

2014-03-17 Thread Jan Kara
Provide new function get_vaddr_pfns(). This function maps virtual addresses from given start and fills given array with page frame numbers of the corresponding pages. If given start belongs to a normal vma, the function grabs reference to each of the pages to pin them in memory. If start belongs t

[PATCH 3/9] media: vb2: Teach vb2_queue_or_prepare_buf() to get pfns for user buffers

2014-03-17 Thread Jan Kara
Teach vb2_queue_or_prepare_buf() to get pfns underlying these buffers and propagate them down to get_userptr callback. Thus each buffer mapping method doesn't have to get pfns independently. Also this will remove the knowledge about mmap_sem locking from videobuf2 core. Signed-off-by: Jan Kara --

Re: [PATCH] gspca_gl860: Clean up idxdata structs

2014-03-17 Thread Hans de Goede
Hi, On 03/17/2014 02:21 PM, Hans Verkuil wrote: > On 03/15/2014 11:08 AM, Hans de Goede wrote: >> Hi, >> >> Some better commit msg would be nice, otherwise this patch is: >> >> Acked-by: Hans de Goede >> >> Hans Verkuil has mailed me that he would like to pick this up through >> his tree. Hans V.

blackgold bgt3620 (saa7231 + cxd2820)

2014-03-17 Thread wab bit
Hi! After giving up on my PCTV 340e usb stick, got myself a blackgold bgt3620, as, supposedly, had a fully functional linux support. Unfortunately, I'm using kernel 3.12 (and 3.13). This means that the driver supplied by manufacturer doesn't compile as it does in kubuntu 13.10 (haven't confirmed n

Re: [PATCH v2 0/9] rc: Add IR encode based wakeup filtering

2014-03-17 Thread Antti Seppälä
Hi James, On 17 March 2014 00:41, James Hogan wrote: > > Yeh I'm in two minds about this now. It's actually a little awkward since some > of the protocols have multiple variants (i.e. "rc-5" = RC5+RC5X), but an > encoded message is only ever a single variant, so technically if you're going > to d

Re: [PATCH v2 6/9] rc: ir-rc5-sz-decoder: Add ir encoding support

2014-03-17 Thread Antti Seppälä
On 16 March 2014 23:18, James Hogan wrote: > Fair enough. So changing the minimum rc5-sz masks to 0x3fff sounds reasonable > to allow toggle to be controlled. > > Just to clarify though, so you mean that the remote uses toggle=1 first (and > in repeat codes) unless you press it a second time (new

Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags

2014-03-17 Thread Laurent Pinchart
Hi Lothar, On Monday 17 March 2014 16:14:36 Lothar Waßmann wrote: > Laurent Pinchart wrote: > > On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote: > > > On 03/13/2014 06:17 PM, Denis Carikli wrote: > > > > We need a way to pass signal polarity informations > > > > between DRM panels, and the di

Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags

2014-03-17 Thread Lothar Waßmann
Hi, Laurent Pinchart wrote: > Hello, > > On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote: > > On 03/13/2014 06:17 PM, Denis Carikli wrote: > > > We need a way to pass signal polarity informations > > > between DRM panels, and the display drivers. > > > > > > To do that, a pol_flags field wa

[GIT PULL FOR v3.16] saa7134: convert to vb2

2014-03-17 Thread Hans Verkuil
This patch series adds videobuf2-dvb support to vb2 (this was missing until now) and converts saa7134 to vb2. These patches are unchanged from the review patch series posted before: http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/75376 except for being rebased to the lat

Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags

2014-03-17 Thread Laurent Pinchart
Hello, On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote: > On 03/13/2014 06:17 PM, Denis Carikli wrote: > > We need a way to pass signal polarity informations > > between DRM panels, and the display drivers. > > > > To do that, a pol_flags field was added to drm_display_mode. > > > > Signed-

Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags

2014-03-17 Thread Andrzej Hajda
Hi Denis, Thanks for the patch. On 03/13/2014 06:17 PM, Denis Carikli wrote: > We need a way to pass signal polarity informations > between DRM panels, and the display drivers. > > To do that, a pol_flags field was added to drm_display_mode. > > Signed-off-by: Denis Carikli > --- > ChangeLog

Re: [REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Hans Verkuil
On 03/17/2014 02:27 PM, Laurent Pinchart wrote: > Hi Hans, > > On Monday 17 March 2014 13:47:35 Hans Verkuil wrote: >> On 03/17/2014 01:41 PM, Laurent Pinchart wrote: >>> On Monday 17 March 2014 13:32:44 Hans Verkuil wrote: On 03/17/2014 01:26 PM, Laurent Pinchart wrote: > On Monday 17 Ma

Re: [REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Laurent Pinchart
Hi Hans, On Monday 17 March 2014 14:30:51 Hans Verkuil wrote: > On 03/17/2014 02:27 PM, Laurent Pinchart wrote: > > On Monday 17 March 2014 13:47:35 Hans Verkuil wrote: > >> On 03/17/2014 01:41 PM, Laurent Pinchart wrote: > >>> On Monday 17 March 2014 13:32:44 Hans Verkuil wrote: > On 03/17/2

[GIT PULL FOR v3.15] Two fixes

2014-03-17 Thread Hans Verkuil
The following changes since commit ed97a6fe5308e5982d118a25f0697b791af5ec50: [media] af9033: Don't export functions for the hardware filter (2014-03-14 20:26:59 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v3.15f for you to fetch changes up t

Re: [REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Laurent Pinchart
Hi Hans, On Monday 17 March 2014 13:47:35 Hans Verkuil wrote: > On 03/17/2014 01:41 PM, Laurent Pinchart wrote: > > On Monday 17 March 2014 13:32:44 Hans Verkuil wrote: > >> On 03/17/2014 01:26 PM, Laurent Pinchart wrote: > >>> On Monday 17 March 2014 11:58:08 Hans Verkuil wrote: > (Fixed typ

Re: [PATCH] gspca_gl860: Clean up idxdata structs

2014-03-17 Thread Hans Verkuil
On 03/15/2014 11:08 AM, Hans de Goede wrote: > Hi, > > Some better commit msg would be nice, otherwise this patch is: > > Acked-by: Hans de Goede > > Hans Verkuil has mailed me that he would like to pick this up through > his tree. Hans V. , I say go for it :) I noticed that these sparse warni

Re: [REVIEWv3 PATCH for v3.15 0/5] v4l2 core sparse error/warning fixes

2014-03-17 Thread Hans Verkuil
On 03/17/2014 01:54 PM, Hans Verkuil wrote: > These five patches fix sparse errors and warnings coming from the v4l2 > core. There are more, but those seem to be problems with sparse itself (see > my posts from Saturday on that topic). > > Please take a good look at patch 3/5 in particular: that f

[REVIEWv3 PATCH for v3.15 0/5] v4l2 core sparse error/warning fixes

2014-03-17 Thread Hans Verkuil
These five patches fix sparse errors and warnings coming from the v4l2 core. There are more, but those seem to be problems with sparse itself (see my posts from Saturday on that topic). Please take a good look at patch 3/5 in particular: that fixes sparse errors introduced by my vb2 changes, and r

[REVIEWv3 PATCH for v3.15 4/5] v4l2-common.h: remove __user annotation in struct v4l2_edid

2014-03-17 Thread Hans Verkuil
From: Hans Verkuil The edid array is copied to kernelspace by the v4l2 core, so drivers shouldn't see the __user annotation. This conforms to other structs like v4l2_ext_controls where the data pointed to is copied to from user to kernelspace. Signed-off-by: Hans Verkuil --- include/uapi/linux

[REVIEWv3 PATCH for v3.15 1/5] v4l2-subdev.h: fix sparse error with v4l2_subdev_notify

2014-03-17 Thread Hans Verkuil
From: Hans Verkuil The notify function is a void function, yet the v4l2_subdev_notify define uses it in a ? : construction, which causes sparse warnings. Replace the define by a static inline function and move it to v4l2-device.h, which is where it belongs since it needs to know the v4l2_device

[REVIEWv3 PATCH for v3.15 5/5] v4l2-ioctl.c: fix sparse __user-related warnings

2014-03-17 Thread Hans Verkuil
From: Hans Verkuil Fix the use of __user in the check_array_args() prototype: instead of using 'void * __user *' you should use 'void __user **' for sparse to understand this correctly. This also required the use of __force in the '*kernel_ptr = user_ptr' assignment. Also replace a wrong cast (

[REVIEWv3 PATCH for v3.15 3/5] videobuf2-core: fix sparse errors.

2014-03-17 Thread Hans Verkuil
From: Hans Verkuil Sparse generated a bunch of errors like this: drivers/media/v4l2-core/videobuf2-core.c:2045:25: error: incompatible types in conditional expression (different base types) drivers/media/v4l2-core/videobuf2-core.c:136:17: error: incompatible types in conditional expression (di

[REVIEWv3 PATCH for v3.15 2/5] vb2: use IS_ERR_OR_NULL() instead of IS_ERR() in __qbuf_dmabuf

2014-03-17 Thread Hans Verkuil
From: Hans Verkuil In __qbuf_dmabuf the result of the memop call attach_dmabuf() is checked by IS_ERR() instead of IS_ERR_OR_NULL(). Since the a NULL pointer makes no sense and in other places in videobuf2-core the IS_ERR_OR_NULL macro is always used, I've changed the IS_ERR to IS_ERR_OR_NULL to

Re: [REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Hans Verkuil
On 03/17/2014 01:41 PM, Laurent Pinchart wrote: > Hi Hans, > > On Monday 17 March 2014 13:32:44 Hans Verkuil wrote: >> On 03/17/2014 01:26 PM, Laurent Pinchart wrote: >>> On Monday 17 March 2014 11:58:08 Hans Verkuil wrote: (Fixed typo pointed out by Pawel, but more importantly made an additi

Re: [REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Laurent Pinchart
Hi Hans, On Monday 17 March 2014 13:32:44 Hans Verkuil wrote: > On 03/17/2014 01:26 PM, Laurent Pinchart wrote: > > On Monday 17 March 2014 11:58:08 Hans Verkuil wrote: > >> (Fixed typo pointed out by Pawel, but more importantly made an additional > >> change to __qbuf_dmabuf. See last paragraph i

Re: [REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Hans Verkuil
On 03/17/2014 01:26 PM, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Monday 17 March 2014 11:58:08 Hans Verkuil wrote: >> (Fixed typo pointed out by Pawel, but more importantly made an additional >> change to __qbuf_dmabuf. See last paragraph in the commit log) > > [sni

Re: [REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Monday 17 March 2014 11:58:08 Hans Verkuil wrote: > (Fixed typo pointed out by Pawel, but more importantly made an additional > change to __qbuf_dmabuf. See last paragraph in the commit log) [snip] > I made one other change: in __qbuf_dmabuf the result of th

Re: [PATCH] bttv: Add support for PCI-8604PW

2014-03-17 Thread Hans Verkuil
On 03/17/2014 12:59 PM, Daniel Glöckner wrote: > Hi Hans, > > On Mon, Mar 17, 2014 at 10:44:29AM +0100, Hans Verkuil wrote: >>> + switch (state) { >>> + case 1: >>> + case 5: >>> + case 6: >>> + case 4: >>> + pr_debug("PCI-8604PW

Re: [PATCH] bttv: Add support for PCI-8604PW

2014-03-17 Thread Daniel Glöckner
Hi Hans, On Mon, Mar 17, 2014 at 10:44:29AM +0100, Hans Verkuil wrote: > > + switch (state) { > > + case 1: > > + case 5: > > + case 6: > > + case 4: > > + pr_debug("PCI-8604PW in state %i, toggling pin\n", > > +

Re: [REVIEW PATCH for v3.15 4/4] v4l2-ioctl.c: fix sparse __user-related warnings

2014-03-17 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Saturday 15 March 2014 14:08:03 Hans Verkuil wrote: > From: Hans Verkuil > > Drop the use of __user in the user_ptr variable since the v4l2 structs are > actually defined without __user, instead cast to a __user pointer only > there where it is really needed

Re: [REVIEW PATCH for v3.15 1/4] v4l2-subdev.h: fix sparse error with v4l2_subdev_notify

2014-03-17 Thread Laurent Pinchart
Hi Hans, On Monday 17 March 2014 12:45:16 Hans Verkuil wrote: > On 03/17/2014 12:44 PM, Laurent Pinchart wrote: > > On Saturday 15 March 2014 14:08:00 Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> The notify function is a void function, yet the v4l2_subdev_notify > >> define uses it in a

Re: [REVIEW PATCH for v3.15 1/4] v4l2-subdev.h: fix sparse error with v4l2_subdev_notify

2014-03-17 Thread Hans Verkuil
On 03/17/2014 12:44 PM, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Saturday 15 March 2014 14:08:00 Hans Verkuil wrote: >> From: Hans Verkuil >> >> The notify function is a void function, yet the v4l2_subdev_notify >> define uses it in a ? : construction, which causes

Re: [REVIEW PATCH for v3.15 1/4] v4l2-subdev.h: fix sparse error with v4l2_subdev_notify

2014-03-17 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Saturday 15 March 2014 14:08:00 Hans Verkuil wrote: > From: Hans Verkuil > > The notify function is a void function, yet the v4l2_subdev_notify > define uses it in a ? : construction, which causes sparse warnings. > > Signed-off-by: Hans Verkuil > --- > i

[REVIEWv2 PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Hans Verkuil
(Fixed typo pointed out by Pawel, but more importantly made an additional change to __qbuf_dmabuf. See last paragraph in the commit log) Sparse generated a bunch of errors like this: drivers/media/v4l2-core/videobuf2-core.c:2045:25: error: incompatible types in conditional expression (different

Re: [REVIEW PATCH for v3.15 2/4] videobuf2-core: fix sparse errors.

2014-03-17 Thread Pawel Osciak
Hi Hans, No issues with the patch, apart from one typo in a comment, but it may not be worth the reupload. On Sat, Mar 15, 2014 at 10:08 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Sparse generated a bunch of errors like this: > > drivers/media/v4l2-core/videobuf2-core.c:2045:25: error: inc

Re: [PATCH] bttv: Add support for PCI-8604PW

2014-03-17 Thread Hans Verkuil
Hi Daniel, Looks good for the most part, but I have two comments, see below... On 03/16/2014 11:33 AM, Daniel Glöckner wrote: > This patch adds support for the PCI-8604PW card equipped with four 878A. > It is unknown who the manufacturer of this card is and no drivers were > available during deve