Re: 1d6b:0001 [MSI A55M-P33] No webcam functionality with Zoran Microelectronics, Ltd Digital Camera EX-20 DSC

2014-05-30 Thread Hans Verkuil
On 05/29/2014 08:23 PM, Richie Gress wrote: Date: Wed, 28 May 2014 10:56:51 +0200 From: hverk...@xs4all.nl To: searchfgold67...@live.com; linux-...@vger.kernel.org; linux-media@vger.kernel.org Subject: Re: 1d6b:0001 [MSI A55M-P33] No webcam functionality with Zoran Microelectronics, Ltd

[PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread abdoulaye berthe
This avoids handling gpiochip remove error in device remove handler. Signed-off-by: abdoulaye berthe berthe...@gmail.com --- drivers/gpio/gpiolib.c | 24 +++- include/linux/gpio/driver.h | 2 +- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread Geert Uytterhoeven
On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe berthe...@gmail.com wrote: --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1263,10 +1263,9 @@ static void gpiochip_irqchip_remove(struct gpio_chip *gpiochip); * * A gpio_chip with any GPIOs still requested may not be

Re: [PATCH v3 1/3] v4l: Add test pattern colour component controls

2014-05-30 Thread Hans Verkuil
On 05/29/2014 05:01 PM, Laurent Pinchart wrote: On Thursday 29 May 2014 17:58:59 Sakari Ailus wrote: Laurent Pinchart wrote: On Thursday 29 May 2014 17:40:46 Sakari Ailus wrote: In many cases the test pattern has selectable values for each colour component. Implement controls for raw bayer

v4l2_device_register_subdev_nodes() clean_up code

2014-05-30 Thread Krzysztof Czarnowski
Hi, In clean_up: section of v4l2_device_register_subdev_nodes() we have: if (!sd-devnode) break; Maybe I miss something, but shouldn't it be rather continue instead of break? Regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a

Re: v4l2_device_register_subdev_nodes() clean_up code

2014-05-30 Thread Sakari Ailus
Hi Krzysztof, On Fri, May 30, 2014 at 02:44:26PM +0200, Krzysztof Czarnowski wrote: Hi, In clean_up: section of v4l2_device_register_subdev_nodes() we have: if (!sd-devnode) break; Maybe I miss something, but shouldn't it be rather continue instead of break? I believer

Re: v4l2_device_register_subdev_nodes() clean_up code

2014-05-30 Thread Sakari Ailus
On Fri, May 30, 2014 at 03:27:27PM +0200, Krzysztof Czarnowski wrote: Sure, a moment :-) One additional thing: I think sd-devnode should also be set as NULL since sub-devices are no longer created by the driver owning the media device. This isn't done in the error path or in

Re: v4l2_device_register_subdev_nodes() clean_up code

2014-05-30 Thread Krzysztof Czarnowski
One additional thing: I think sd-devnode should also be set as NULL since sub-devices are no longer created by the driver owning the media device. Yes, I think you're right. But there are also other issues with v4l2_device_register_subdev_nodes(). I think after checking

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread Ralf Baechle
On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote: + if (test_bit(FLAG_REQUESTED, chip-desc[id].flags)) + panic(gpio: removing gpiochip with gpios still requested\n); panic? Is this likely to happen? And while we're at it -

[GIT PULL 3.16 v2] soc-camera for 3.16: one driver removal, a fix and more

2014-05-30 Thread Guennadi Liakhovetski
Hi Mauro, This time based on your media-next tree. Also using git 1.9.3 instead of 2.0.0 solved my pull-request problem. The following changes since commit 656111f4b9cbc5a9b86cc2d6ac54dea0855209f0: Merge branch 'topic/omap3isp' into to_next (2014-05-25 18:38:38 -0300) are available in the

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread David Daney
On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe berthe...@gmail.com wrote: --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1263,10 +1263,9 @@ static void gpiochip_irqchip_remove(struct gpio_chip *gpiochip); * * A gpio_chip

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-05-30 Thread Lars-Peter Clausen
On 05/30/2014 07:33 PM, David Daney wrote: On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe berthe...@gmail.com wrote: --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1263,10 +1263,9 @@ static void gpiochip_irqchip_remove(struct

WG: Patch pctv452e.c: Suppress annoying dmesg-SPAM

2014-05-30 Thread Daniel Mayer
Hi, attached micro-patch removes the text output of an error-message of the PCTV452e-driver. The error messages I2C error: [.] do not help any user of the kernel, so whatever causes the error, it does not hamper the function of my TT-3600 USB receiver. So: Just remove the entries in the dmesg, for

[PATCH] [media] tlg2300: fix leak at failure path in poseidon_probe()

2014-05-30 Thread Alexey Khoroshilov
Error handling code in poseidon_probe() misses usb_put_intf() and usb_put_dev(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/media/usb/tlg2300/pd-main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH] V4L2: fix VIDIOC_CREATE_BUFS 32-bit compatibility mode data copy-back

2014-05-30 Thread Guennadi Liakhovetski
Similar to an earlier patch, fixing reading user-space data for the VIDIOC_CREATE_BUFS ioctl() in 32-bit compatibility mode, this patch fixes writing back of the possibly modified struct to the user. However, unlike the former bug, this one is much less harmful, because it only results in the

Re: [PATCH] V4L2: fix VIDIOC_CREATE_BUFS 32-bit compatibility mode data copy-back

2014-05-30 Thread Laurent Pinchart
Hi Guennadi, Thank you for the patch. On Saturday 31 May 2014 01:26:38 Guennadi Liakhovetski wrote: Similar to an earlier patch, Could you please mention the commit ID in the commit message ? fixing reading user-space data for the VIDIOC_CREATE_BUFS ioctl() in 32-bit compatibility mode,

cron job: media_tree daily build: OK

2014-05-30 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat May 31 04:00:25 CEST 2014 git branch: test git hash: 2d7e62f4101c6a5c0bf6c2727df3cbca17381393 gcc