cron job: media_tree daily build: ERRORS

2014-08-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Aug 23 04:00:36 CEST 2014 git branch: test git hash: b250392f7b5062cf026b1423e27265e278fd6b30 gcc versi

Re: [PATCH] Kconfig: do not select SPI bus on sub-driver auto-select

2014-08-22 Thread Jeff Mahoney
On Fri Aug 22 19:34:12 2014, Randy Dunlap wrote: > On 08/22/14 10:04, Jeff Mahoney wrote: >> On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote: >>> We should not select SPI bus when sub-driver auto-select is >>> selected. That option is meant for auto-selecting all possible >>> ancillary drivers u

Re: [PATCH] Kconfig: do not select SPI bus on sub-driver auto-select

2014-08-22 Thread Randy Dunlap
On 08/22/14 10:04, Jeff Mahoney wrote: > On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote: >> We should not select SPI bus when sub-driver auto-select is >> selected. That option is meant for auto-selecting all possible >> ancillary drivers used for selected board driver. Ancillary >> drivers sho

[PATCHv2] videobuf2-core: take mmap_sem before calling __qbuf_userptr

2014-08-22 Thread Hans Verkuil
(Changes since v1: fix the embarrassing bug where mmap_sem wasn't initialized) Commit f035eb4e976ef5a059e30bc91cfd310ff030a7d3 (videobuf2: fix lockdep warning) unfortunately removed the mmap_sem lock that is needed around the call to __qbuf_userptr. Amazingly nobody noticed this (especially me as

Re: [PATCH] videobuf2-core: take mmap_sem before calling __qbuf_userptr

2014-08-22 Thread Hans Verkuil
On 08/22/2014 07:34 PM, Jan Kara wrote: > On Fri 22-08-14 18:01:09, Hans Verkuil wrote: >> Commit f035eb4e976ef5a059e30bc91cfd310ff030a7d3 (videobuf2: fix lockdep >> warning) >> unfortunately removed the mmap_sem lock that is needed around the call to >> __qbuf_userptr. Amazingly nobody noticed th

HONDA AUTO-MOBILE COMPANY

2014-08-22 Thread info
YOUR E-MAIL HAS WON 750,000.00 FROM HONDA AUTO-MOBILE COMPANY, TO RECEIVE YOUR AWARD SEND YOUR NAME, ADDS AND TEL TO SIR.PETER TOUCH ON E-MAIL: hondacl...@outlook.jp -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH] videobuf2-core: take mmap_sem before calling __qbuf_userptr

2014-08-22 Thread Jan Kara
On Fri 22-08-14 18:01:09, Hans Verkuil wrote: > Commit f035eb4e976ef5a059e30bc91cfd310ff030a7d3 (videobuf2: fix lockdep > warning) > unfortunately removed the mmap_sem lock that is needed around the call to > __qbuf_userptr. Amazingly nobody noticed this until Jan Kara pointed this out > to me. >

HVR 900 (USB ID 2040:6500) no analogue sound reloaded

2014-08-22 Thread Oravecz Csaba
I reported this issue earlier but for some reason it went pretty much unnoticed. The essence is that with the newest em28xx drivers now present in 3.14 kernels (i'm on stock fedora 3.14.15-100.fc19.i686.PAE) I can't get analogue sound from this card. I see that the code snippet that produced this

Re: [PATCH] videobuf2-core: take mmap_sem before calling __qbuf_userptr

2014-08-22 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 22 August 2014 18:01:09 Hans Verkuil wrote: > Commit f035eb4e976ef5a059e30bc91cfd310ff030a7d3 (videobuf2: fix lockdep > warning) unfortunately removed the mmap_sem lock that is needed around the > call to __qbuf_userptr. Amazingly nobody noticed this un

[PATCH] videobuf2-core: take mmap_sem before calling __qbuf_userptr

2014-08-22 Thread Hans Verkuil
Commit f035eb4e976ef5a059e30bc91cfd310ff030a7d3 (videobuf2: fix lockdep warning) unfortunately removed the mmap_sem lock that is needed around the call to __qbuf_userptr. Amazingly nobody noticed this until Jan Kara pointed this out to me. Signed-off-by: Hans Verkuil Reported-by: Jan Kara --- d

Re: [GIT PULL FOR v3.18] Various fixes

2014-08-22 Thread Hans Verkuil
On 08/14/2014 10:43 AM, Hans Verkuil wrote: > Hi Mauro, > > Various fixes for v3.18. > > Please take a good look at the 'videobuf2: fix lockdep warning'. Locking > issues > are always complex and an extra pair of eyeballs doesn't hurt. I also have > been > in two minds whether it should go into

Re: [PATCH] Kconfig: do not select SPI bus on sub-driver auto-select

2014-08-22 Thread Jeff Mahoney
On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote: > We should not select SPI bus when sub-driver auto-select is > selected. That option is meant for auto-selecting all possible > ancillary drivers used for selected board driver. Ancillary > drivers should define needed dependencies itself. > > I2

Re: [PATCH 1/6] V4L2: Add Renesas R-Car JPEG codec driver.

2014-08-22 Thread Hans Verkuil
On 08/22/2014 01:39 PM, Mikhail Ulianov wrote: > Hi Hans, > > Thanks for your comments. > > I have a question on default width, height and sizeimage values > m2m driver should return in case when we try to run G_FMT on just > opened device. Is there any preferable values? v4l2-compliance tool > w

[PATCH] Kconfig: do not select SPI bus on sub-driver auto-select

2014-08-22 Thread Antti Palosaari
We should not select SPI bus when sub-driver auto-select is selected. That option is meant for auto-selecting all possible ancillary drivers used for selected board driver. Ancillary drivers should define needed dependencies itself. I2C and I2C_MUX are still selected here for a reason described on

[PATCH] MAINTAINERS: add sp2 entry

2014-08-22 Thread Olli Salonen
Add a maintainer for the new CIMaX SP2 driver. Signed-off-by: Olli Salonen --- MAINTAINERS |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4cdf24c..6139b66 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8451,6 +8451,14 @@ F: i

[PATCH] drivers: media: i2c: adv7343_regs.h: Fix typo in #ifndef

2014-08-22 Thread Rasmus Villemoes
Test for definedness of the macro which is actually defined, and which matches the name of the file. Signed-off-by: Rasmus Villemoes --- drivers/media/i2c/adv7343_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/adv7343_regs.h b/drivers/media/i2c/adv73

[PATCH] drivers: media: b2c2: flexcop.h: Fix typo in include guard

2014-08-22 Thread Rasmus Villemoes
Three trailing underscores is one too many. Signed-off-by: Rasmus Villemoes --- drivers/media/common/b2c2/flexcop.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/common/b2c2/flexcop.h b/drivers/media/common/b2c2/flexcop.h index 897b10c..8942bda 100644 --- a/d

Re: Autoselecting SPI for MEDIA_SUBDRV_AUTOSELECT?

2014-08-22 Thread Mauro Carvalho Chehab
Em Fri, 22 Aug 2014 18:17:22 +0300 Antti Palosaari escreveu: > Moikka! > > On 08/22/2014 06:00 PM, Jeff Mahoney wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > Hi Antti - > > > > Commit e4462ffc160 ([media] Kconfig: sub-driver auto-select SPI bus) > > enables CONFIG_SPI glob

[PATCH] [media] dvb_frontend: estimate bandwidth also for DVB-S/S2/Turbo

2014-08-22 Thread Mauro Carvalho Chehab
The needed bandwidth can be estimated using the symbol rate and the rolloff factor. This could be useful for the frontend drivers, as they don't need to calculate it themselves. Reported-by: Antti Palosaari Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.c | 17

Re: Autoselecting SPI for MEDIA_SUBDRV_AUTOSELECT?

2014-08-22 Thread Antti Palosaari
On 08/22/2014 06:24 PM, Jeff Mahoney wrote: On Fri Aug 22 11:17:22 2014, Antti Palosaari wrote: Moikka! On 08/22/2014 06:00 PM, Jeff Mahoney wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Antti - Commit e4462ffc160 ([media] Kconfig: sub-driver auto-select SPI bus) enables CONFIG_SPI

Re: Autoselecting SPI for MEDIA_SUBDRV_AUTOSELECT?

2014-08-22 Thread Jeff Mahoney
On Fri Aug 22 11:17:22 2014, Antti Palosaari wrote: > Moikka! > > On 08/22/2014 06:00 PM, Jeff Mahoney wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Hi Antti - >> >> Commit e4462ffc160 ([media] Kconfig: sub-driver auto-select SPI bus) >> enables CONFIG_SPI globally for a driver t

Re: Autoselecting SPI for MEDIA_SUBDRV_AUTOSELECT?

2014-08-22 Thread Antti Palosaari
Moikka! On 08/22/2014 06:00 PM, Jeff Mahoney wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Antti - Commit e4462ffc160 ([media] Kconfig: sub-driver auto-select SPI bus) enables CONFIG_SPI globally for a driver that won't even be enabled in many cases. Is there a reason USB_MSI2500 do

Re: [PATCH 6/6] devicetree: bindings: Document Renesas JPEG Processing Unit.

2014-08-22 Thread Mikhail Ulianov
Hi Laurent, Thanks for your comments. On Thu, 21 Aug 2014 01:01:43 +0200 Laurent Pinchart wrote: > Hi Mikhail, > > Thank you for the patch. > > On Tuesday 19 August 2014 16:50:53 Mikhail Ulyanov wrote: > > Signed-off-by: Mikhail Ulyanov > > --- > > .../devicetree/bindings/media/renesas,jp

Re: [GIT PULL FINAL 01/21] si2168: clean logging

2014-08-22 Thread Mauro Carvalho Chehab
Em Fri, 22 Aug 2014 15:50:03 +0300 Antti Palosaari escreveu: > > > On 08/22/2014 03:28 PM, Mauro Carvalho Chehab wrote: > > Em Fri, 22 Aug 2014 15:13:47 +0300 > > Antti Palosaari escreveu: > > > >> On 08/22/2014 02:47 PM, Mauro Carvalho Chehab wrote: > >>> Hi Antti, > >>> > >>> Please don't ad

Re: [PATCH 1/6] V4L2: Add Renesas R-Car JPEG codec driver.

2014-08-22 Thread Mikhail Ulianov
Hi Hans, Thanks for your comments. I have a question on default width, height and sizeimage values m2m driver should return in case when we try to run G_FMT on just opened device. Is there any preferable values? v4l2-compliance tool want it to be non zero, but at that moment we have no informatio

Re: [ANNOUNCE] Linux Kernel Media mini-summit on Oct, 16-17 in Düsseldorf, Germany

2014-08-22 Thread Philipp Zabel
Hi Mauro, Am Mittwoch, den 13.08.2014, 10:14 -0300 schrieb Mauro Carvalho Chehab: > Hi, > > As there are still too things to be discussed in order to improve media > stuff, and most of the developers nowadays are located in Europe and > usually go to ELCE, we're scheduling a two day mini-summit i

Re: [GIT PULL FINAL 01/21] si2168: clean logging

2014-08-22 Thread Antti Palosaari
On 08/22/2014 03:28 PM, Mauro Carvalho Chehab wrote: Em Fri, 22 Aug 2014 15:13:47 +0300 Antti Palosaari escreveu: On 08/22/2014 02:47 PM, Mauro Carvalho Chehab wrote: Hi Antti, Please don't add "GIT PULL" on patches. That breaks my scripts, as they will run a completely different logic whe

Re: [GIT PULL FINAL 01/21] si2168: clean logging

2014-08-22 Thread Mauro Carvalho Chehab
Em Fri, 22 Aug 2014 15:13:47 +0300 Antti Palosaari escreveu: > On 08/22/2014 02:47 PM, Mauro Carvalho Chehab wrote: > > Hi Antti, > > > > Please don't add "GIT PULL" on patches. That breaks my scripts, as they > > will run a completely different logic when those magic words are there > > on a mes

Re: [GIT PULL FINAL 01/21] si2168: clean logging

2014-08-22 Thread Antti Palosaari
On 08/22/2014 02:47 PM, Mauro Carvalho Chehab wrote: Hi Antti, Please don't add "GIT PULL" on patches. That breaks my scripts, as they will run a completely different logic when those magic words are there on a message at patchwork. Also, the word "FINAL" makes me nervous... That means that you

Re: [PATCH 5/8] of: Add of_graph_get_port_by_id function

2014-08-22 Thread Philipp Zabel
Hi Laurent, Thank you for the comments. Am Mittwoch, den 20.08.2014, 22:13 +0200 schrieb Laurent Pinchart: [...] > > + struct device_node *port = NULL; > > + int port_id; > > + > > + while (true) { > > + port = of_get_next_child(node, port); > > + if (!port) > > +

Re: [GIT PULL FINAL 01/21] si2168: clean logging

2014-08-22 Thread Mauro Carvalho Chehab
Hi Antti, Please don't add "GIT PULL" on patches. That breaks my scripts, as they will run a completely different logic when those magic words are there on a message at patchwork. Also, the word "FINAL" makes me nervous... That means that you sent me a non-final pull request? I'll tag all patche

Re: [GIT PULL FINAL 00/21] misc DTV stuff for 3.18

2014-08-22 Thread Antti Palosaari
Oops, cut a pull message wrongly and actual tree was missing: The following changes since commit 1baa466e84975a595b2c3cd10af1100c807ebab5: [media] media: ttpci: fix av7110 build to be compatible with CONFIG_INPUT_EVDEV (2014-08-15 21:26:26 -0300) are available in the git repository at: g

[GIT PULL 3.18] misc DTV changes

2014-08-22 Thread Antti Palosaari
A lot of DTV changes related to drivers I maintain. There is one new driver from Olli: sp2: Add I2C driver for CIMaX SP2 common interface module regards Antti The following changes since commit 1baa466e84975a595b2c3cd10af1100c807ebab5: [media] media: ttpci: fix av7110 build to be compatible

[GIT PULL FINAL 01/21] si2168: clean logging

2014-08-22 Thread Antti Palosaari
From: Olli Salonen Same thing for si2168 as Antti did earlier for tda18212: There is no need to print module name nor function name as those are done by kernel logging system when dev_xxx logging is used and driver is proper I2C driver. Signed-off-by: Olli Salonen Reviewed-by: Antti Palosaari

[GIT PULL FINAL 07/21] sp2: Add I2C driver for CIMaX SP2 common interface module

2014-08-22 Thread Antti Palosaari
From: Olli Salonen Driver for the CIMaX SP2 common interface chip. It is very much based on the existing cimax2 driver for cx23885, but should be more reusable. The product has been sold with name Atmel T90FJR as well and the data sheets for that chip seem to be publicly available. It seems that

[GIT PULL FINAL 00/21] misc DTV stuff for 3.18

2014-08-22 Thread Antti Palosaari
Moikka I picked these from patchwork and this is just final review before PULL request I will send very shortly. I don't expect any change requests at this late, without a very good reason :) However, I could add some tags until Mauro PULLs to master. regards Antti Antti Palosaari (10): dvb-us

[GIT PULL FINAL 09/21] cxusb: Add read_mac_address for TT CT2-4400 and CT2-4650

2014-08-22 Thread Antti Palosaari
From: Olli Salonen Read MAC address from the EEPROM. This version two corrects a flaw in the result code returning that did exist in the first version. Signed-off-by: Olli Salonen Reviewed-by: Antti Palosaari Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb/cxusb.c | 35

[GIT PULL FINAL 11/21] si2157: Add support for delivery system SYS_ATSC

2014-08-22 Thread Antti Palosaari
From: Olli Salonen Set the property for delivery system also in case of SYS_ATSC. This behaviour is observed in the sniffs taken with Hauppauge HVR-955Q Windows driver. Signed-off-by: Olli Salonen Reviewed-by: Antti Palosaari Signed-off-by: Antti Palosaari --- drivers/media/tuners/si2157.c |

[GIT PULL FINAL 21/21] m88ds3103: fix coding style issues

2014-08-22 Thread Antti Palosaari
Fix coding style issues pointed out by checkpatch.pl. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/m88ds3103.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c index 25d9d97..6eae

[GIT PULL FINAL 17/21] m88ts2022: clean up logging

2014-08-22 Thread Antti Palosaari
There is no need to print module name nor function name as those are done by kernel logging system when dev_xxx logging is used and driver is proper I2C driver. Signed-off-by: Antti Palosaari --- drivers/media/tuners/m88ts2022.c | 51 +++- 1 file changed, 24 i

[GIT PULL FINAL 16/21] m88ts2022: rename device state (priv => s)

2014-08-22 Thread Antti Palosaari
I like short names for things which are used everywhere overall the driver. Due to that rename device state pointer from 'priv' to 's'. Signed-off-by: Antti Palosaari --- drivers/media/tuners/m88ts2022.c | 190 +- drivers/media/tuners/m88ts2022_priv.h | 2 +

[GIT PULL FINAL 10/21] si2168: DVB-T2 PLP selection implemented

2014-08-22 Thread Antti Palosaari
From: CrazyCat DVB-T2 PLP selection implemented for Si2168 demod. Tested with PCTV 292e. Signed-off-by: Evgeny Plehov Reviewed-by: Antti Palosaari Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/si2168.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-)

[GIT PULL FINAL 14/21] m88ts2022: fix 32bit overflow on filter calc

2014-08-22 Thread Antti Palosaari
Maximum satellite symbol rate used is 4500Sps which overflows when multiplied by 135. As final calculation result is fraction, we could use mult_frac macro in order to keep calculation inside 32 bit number limits and prevent overflow. Original bug and fix was provided by Nibble Max. I decided

[GIT PULL FINAL 02/21] si2157: clean logging

2014-08-22 Thread Antti Palosaari
From: Olli Salonen Same thing for si2157 as Antti did earlier for tda18212: There is no need to print module name nor function name as those are done by kernel logging system when dev_xxx logging is used and driver is proper I2C driver. While here, fix a typo ("unknown") in si2157_init. Signed

[GIT PULL FINAL 03/21] m88ds3103: implement set voltage and TS clock

2014-08-22 Thread Antti Palosaari
From: "nibble.max" Implement set voltage operation. Separate TS clock as a own configuration parameter. Add TS clock polarity parameter. [cr...@iki.fi: merge em28xx driver m88ds3103 config change patch to that one, in order to keep build unbroken] Signed-off-by: Nibble Max Reviewed-by: Antti P

[GIT PULL FINAL 15/21] m88ts2022: fix coding style issues

2014-08-22 Thread Antti Palosaari
Fix coding style issues pointed out by checkpatch.pl. Signed-off-by: Antti Palosaari --- drivers/media/tuners/m88ts2022.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/tuners/m88ts2022.c b/drivers/media/tuners/m88ts2022.c index 7a62097..f51b107 100644 --- a/drivers/medi

[GIT PULL FINAL 04/21] si2168: add ts_mode setting and move to si2168_init

2014-08-22 Thread Antti Palosaari
From: Olli Salonen Luis Alves submitted a TS mode patch to si2168 earlier, but the patch was rejected due to a small issue. Here is a working version. Also, setting of TS mode is moved from si2168_set_frontend to si2168_init. This patch adds the TS mode as a config option for the si2168 demod: -

[GIT PULL FINAL 19/21] m88ts2022: change parameter type of m88ts2022_cmd

2014-08-22 Thread Antti Palosaari
It is driver internal function and does not need anything from frontend structure. Due to that change parameter type to driver state which is better for driver internal functions. Also remove one unused variable from state itself. Signed-off-by: Antti Palosaari --- drivers/media/tuners/m88ts202

[GIT PULL FINAL 18/21] m88ts2022: convert to RegMap I2C API

2014-08-22 Thread Antti Palosaari
Use RegMap to cover I2C register routines. Signed-off-by: Antti Palosaari --- drivers/media/tuners/Kconfig | 1 + drivers/media/tuners/m88ts2022.c | 231 ++ drivers/media/tuners/m88ts2022_priv.h | 2 + 3 files changed, 69 insertions(+), 165 delet

[GIT PULL FINAL 08/21] cxusb: Add support for TechnoTrend TT-connect CT2-4650 CI

2014-08-22 Thread Antti Palosaari
From: Olli Salonen TechnoTrend TT-connect CT2-4650 CI (0b48:3012) is an USB DVB-T2/C tuner with the following components: USB interface: Cypress CY7C68013A-56LTXC Demodulator: Silicon Labs Si2168-A20 Tuner: Silicon Labs Si2158-A20 CI chip: CIMaX SP2HF The firmware for the tuner is the same

[GIT PULL FINAL 12/21] dvb-usb-v2: remove dvb_usb_device NULL check

2014-08-22 Thread Antti Palosaari
Reported by Dan Carpenter: The patch d10d1b9ac97b: "[media] dvb_usb_v2: use dev_* logging macros" from Jun 26, 2012, leads to the following Smatch complaint: drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c:31 dvb_usb_v2_generic_io() error: we previously assumed 'd' could be null (see line 29)

[GIT PULL FINAL 20/21] m88ds3103: change .set_voltage() implementation

2014-08-22 Thread Antti Palosaari
Add some error checking and implement functionality a little bit differently. Cc: Nibble Max Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/m88ds3103.c | 50 ++--- 1 file changed, 34 insertions(+), 16 deletions(-) diff --git a/drivers/media/dvb-front

[GIT PULL FINAL 06/21] cxusb: add ts mode setting for TechnoTrend CT2-4400

2014-08-22 Thread Antti Palosaari
From: Olli Salonen TS mode must be set in the existing TechnoTrend CT2-4400 driver. Signed-off-by: Olli Salonen Reviewed-by: Antti Palosaari Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb/cxusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/dvb-usb/cxus

[GIT PULL FINAL 13/21] msi2500: remove unneeded local pointer on msi2500_isoc_init()

2014-08-22 Thread Antti Palosaari
There is no need to keep local copy of usb_device pointer as we have same pointer stored and available easily from device state. Signed-off-by: Antti Palosaari --- drivers/media/usb/msi2500/msi2500.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/media/usb/m

[GIT PULL FINAL 05/21] em28xx: add ts mode setting for PCTV 292e

2014-08-22 Thread Antti Palosaari
From: Olli Salonen TS mode must be set in the existing PCTV 292e driver. Signed-off-by: Olli Salonen Reviewed-by: Antti Palosaari Signed-off-by: Antti Palosaari --- drivers/media/usb/em28xx/em28xx-dvb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c

[PATCH] m88ds3103: change .set_voltage() implementation

2014-08-22 Thread Antti Palosaari
Add some error checking and implement functionality a little bit differently. Cc: Nibble Max Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/m88ds3103.c | 50 ++--- 1 file changed, 34 insertions(+), 16 deletions(-) diff --git a/drivers/media/dvb-front

Re: [PATCH 6/6] m88ds3103: change .set_voltage() implementation

2014-08-22 Thread Antti Palosaari
Moikka Sure I can change that flag from voltage_en to voltage_dis. Mostly I just wanted to get rid of those if () statements and bit operations when handling boolean type flags. regards Antti On 08/22/2014 06:19 AM, Nibble Max wrote: > > It is easier to understand for using "voltage_dis" to keep