Hi Kamil,
Can you make a patch to fix this sparse error?
/home/hans/work/build/media-git/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c:1178:25:
error: incompatible types in conditional expression (different base types)
s5p_mfc_hw_call should probably be s5p_mfc_hw_call_void.
Regards,
v3:
-reconstruct the codes in set_frontend to keep the same logic for M88RS6000
and M88DS3103.
-remove calling set_config of tuner to set demod mclk.
-demod mclk will be set in set_params of tuner call back.
v2:
-make demod mclk selection logic simple.
-merge demod mclk and ts mclk into one call
v3:
-config demod mclk in set_params call back.
-remove set_config.
v2:
-make demod mclk selection logic simple.
-merge demod mclk and ts mclk into one call back.
-make code clean.
M88RS6000 is the integrated chip, which includes tuner and demod.
Here splite its tuner as a standalone driver.
Em Thu, 30 Oct 2014 08:04:29 +0200
Olli Salonen olli.salo...@iki.fi escreveu:
Hi Mauro,
No, for ClearQAM the delivery_system should be set to 0x10 and this
patch does not include that. At the time of submission of that patch I
only had the trace from the ATSC case.
Ah, ok. Are you planning
changeset e87b540be2dd broke RC5-SZ decoding, as it forgot to add
the extra bit check for the enabled protocols at the beginning of
the logic.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/rc/ir-rc5-decoder.c
b/drivers/media/rc/ir-rc5-decoder.c
index
Hello.
I have:
Bus 001 Device 004: ID 048d:9135 Integrated Technology Express, Inc.
Zolid Mini DVB-T Stick
This is well supported DVB-T USB card - used successfully with
dvb-usb-af9035 module.
Till now.
After every kernel update I have to rebuild v4l driver.
After last time (with kernel
on avr32 arch, those warnings happen:
drivers/media/firewire/firedtv-fw.c: In function 'node_update':
drivers/media/firewire/firedtv-fw.c:329: warning: comparison is always
true due to limited range of data type
In this particular case, the signal is desired, as the isochannel
On Thu, 30 Oct 2014, Mauro Carvalho Chehab wrote:
Ah, ok. Are you planning to submit a patch for it, and the patches adding
support for HVR-955Q?
I can submit a patch for that, no problem. However, I'm not working with
HVR-955Q at the moment. I don't have access to ATSC/ClearQAM signal.
If
On 2014-10-30 10:54, Mauro Carvalho Chehab wrote:
changeset e87b540be2dd broke RC5-SZ decoding, as it forgot to add
the extra bit check for the enabled protocols at the beginning of
the logic.
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
Acked-by: David Härdeman
Set the property for delivery system also in case of SYS_DVBC_ANNEX_B. This
behaviour is observed in the sniffs taken with Hauppauge HVR-955Q Windows
driver.
Signed-off-by: Olli Salonen olli.salo...@iki.fi
---
drivers/media/tuners/si2157.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
There are several Auvitek au0828 listed at sound quirks. However,
the table there is incomplete. Simplify the table using a macro
for au0828 devices and update it to reflect the devices currently
supported at the Linux Kernel by drivers/media/usb/au0828 driver.
Mauro Carvalho Chehab (2):
From: Mauro Carvalho Chehab m.che...@samsung.com
The au0828 quirks table is currently not in sync with the au0828
media driver.
Syncronize it and put them on the same order as found at au0828
driver, as all the au0828 devices with analog TV need the
same quirks.
Cc: sta...@vger.kernel.org
From: Mauro Carvalho Chehab m.che...@samsung.com
Add a macro to simplify au0828 quirk table. That makes easier
to check it against the USB IDs at drivers/media/usb/au0828-card.c
Cc: sta...@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com
Signed-off-by: Mauro Carvalho
Hi Olli,
Em Thu, 30 Oct 2014 12:32:33 +0200
Olli Salonen olli.salo...@iki.fi escreveu:
On Thu, 30 Oct 2014, Mauro Carvalho Chehab wrote:
Ah, ok. Are you planning to submit a patch for it, and the patches adding
support for HVR-955Q?
I can submit a patch for that, no problem.
Yes,
At Thu, 30 Oct 2014 08:53:04 -0200,
Mauro Carvalho Chehab wrote:
From: Mauro Carvalho Chehab m.che...@samsung.com
Add a macro to simplify au0828 quirk table. That makes easier
to check it against the USB IDs at drivers/media/usb/au0828-card.c
Cc: sta...@vger.kernel.org
Signed-off-by:
Em Thu, 30 Oct 2014 12:09:07 +0100
Takashi Iwai ti...@suse.de escreveu:
At Thu, 30 Oct 2014 08:53:04 -0200,
Mauro Carvalho Chehab wrote:
From: Mauro Carvalho Chehab m.che...@samsung.com
Add a macro to simplify au0828 quirk table. That makes easier
to check it against the USB IDs at
Mauro Carvalho Chehab wrote:
Add a macro to simplify au0828 quirk table. That makes easier
to check it against the USB IDs at drivers/media/usb/au0828-card.c
+++ b/sound/usb/quirks-table.h
...
+ * This should be kept in sync with drivers/media/usb/au0828-card.c
The file does not exist in
Em Thu, 30 Oct 2014 12:16:13 +0100
Clemens Ladisch clem...@ladisch.de escreveu:
Mauro Carvalho Chehab wrote:
Add a macro to simplify au0828 quirk table. That makes easier
to check it against the USB IDs at drivers/media/usb/au0828-card.c
+++ b/sound/usb/quirks-table.h
...
+ * This
There are several Auvitek au0828 listed at sound quirks. However,
the table there is incomplete. Simplify the table using a macro
for au0828 devices and update it to reflect the devices currently
-
v2: Fix SOB, au0828 driver reference and add a warning at au0828-cards.c.
Mauro Carvalho Chehab
The au0828 quirks table is currently not in sync with the au0828
media driver.
Syncronize it and put them on the same order as found at au0828
driver, as all the au0828 devices with analog TV need the
same quirks.
Cc: sta...@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab
Em Fri, 26 Sep 2014 18:11:45 -0700
Behan Webster beh...@converseincode.com escreveu:
Replace the use of nested functions where a normal function will suffice.
Nested functions are not liked by upstream kernel developers in general. Their
use breaks the use of clang as a compiler, and doesn't
Hi Mauro,
Syncronize it and put them on the same order as found at au0828
driver, as all the au0828 devices with analog TV need the
same quirks.
The MXL and Woodbury boards don't support analog under Linux, so
probably shouldn't be included in the list of quirks.
That said, the MXL and
Well, perhaps you could add a printk message warning the user that
the driver is not using the latest firmware and performance/quality
could be badly affected.
I wouldn't use the term badly affected. There are tens of thousands
of units out there for which users are quite happy with the
On Sat, Oct 25, 2014 at 4:17 PM, Michael Krufky mkru...@hotmail.com wrote:
From: Richard Vollkommer li...@hauppauge.com
Adds control of the IF output level to the xc5000 tuner
configuration structure. Increases the IF level to the
demodulator to fix failure to lock and picture breakup
On Oct 30 Mauro Carvalho Chehab wrote:
on avr32 arch, those warnings happen:
drivers/media/firewire/firedtv-fw.c: In function 'node_update':
drivers/media/firewire/firedtv-fw.c:329: warning: comparison is always
true due to limited range of data type
In this particular case,
Hi Devin,
Em Thu, 30 Oct 2014 09:15:31 -0400
Devin Heitmueller dheitmuel...@kernellabs.com escreveu:
Hi Mauro,
Syncronize it and put them on the same order as found at au0828
driver, as all the au0828 devices with analog TV need the
same quirks.
The MXL and Woodbury boards don't
Now that all platforms instantiate the VSP1 through DT, platform data
support isn't needed anymore.
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
---
drivers/media/platform/Kconfig | 2 +-
drivers/media/platform/vsp1/vsp1.h | 14 +-
On Thu, Oct 30, 2014 at 9:37 AM, Mauro Carvalho Chehab
mche...@osg.samsung.com wrote:
Yeah, if nobody is using such devices, then we should get rid of them,
but I prefer to have this on a separate patch, in order to give
people the opportunity to complain.
Yes, I would definitely suggest a
As pointed by smatch:
drivers/media/pci/cx23885/cx23885-dvb.c:1066 dvb_register() error: we
previously assumed 'fe0-dvb.frontend' could be null (see line 1060)
drivers/media/pci/cx23885/cx23885-dvb.c:1990 cx23885_dvb_register()
error: we previously assumed 'fe0' could be null
Acked-by: Antti Palosaari cr...@iki.fi
Reviewed-by: Antti Palosaari cr...@iki.fi
Antti
On 10/30/2014 12:43 PM, Olli Salonen wrote:
Set the property for delivery system also in case of SYS_DVBC_ANNEX_B. This
behaviour is observed in the sniffs taken with Hauppauge HVR-955Q Windows
driver.
On 10/30/2014 06:38 AM, Nibble Max wrote:
- if (tab_len 83) {
+ if (tab_len 86) {
That is not nice, but I could try find better solution and fix it later.
What is the reason to check this parameter?
How about remove this check?
It is just to check you will not overwrite
Dear Purchasing Manage,
Good morning., How are you?
As knowing that you are in the LED lighting market . Now I am writing to
establish business relationship with you . The following RGB flood light,
sensor flood lighting has been shipped to Germany , Switzerland, Romania ,
Russian , France ,
Em Thu, 2 Oct 2014 07:21:02 +0200
Matthias Schwarzott z...@gentoo.org escreveu:
change almost all instances of I2C_1 to I2C_1_MUX_3
So far, this is likely the most dangerous patch on this series ;)
Only these cases are changed to I2C_1_MUX_1:
* All that have dont_use_port_3 set.
*
Reviewed-by: Olli Salonen olli.salo...@iki.fi
On Thu, 23 Oct 2014, Nibble Max wrote:
DVBSky s950ci dvb-s/s2 ci PCIe card:
1dvb frontend: M88TS2022(tuner),M88DS3103(demod)
2ci controller: CIMAX SP2 or its clone.
3PCIe bridge: CX23885
The patchs are based on the following patchs.
Olli Salonen
Reviewed-by: Olli Salonen olli.salo...@iki.fi
On Thu, 23 Oct 2014, Nibble Max wrote:
DVBSky s950ci dvb-s/s2 ci PCIe card:
1dvb frontend: M88TS2022(tuner),M88DS3103(demod)
2ci controller: CIMAX SP2 or its clone.
3PCIe bridge: CX23885
The patchs are based on the following patchs.
Olli Salonen
On Thu, Oct 30, 2014 at 9:37 AM, Mauro Carvalho Chehab
mche...@osg.samsung.com wrote:
Hi Devin,
Em Thu, 30 Oct 2014 09:15:31 -0400
Devin Heitmueller dheitmuel...@kernellabs.com escreveu:
Hi Mauro,
Syncronize it and put them on the same order as found at au0828
driver, as all the au0828
On Thu, Oct 30, 2014 at 3:52 PM, Michael Ira Krufky mkru...@linuxtv.org wrote:
On Thu, Oct 30, 2014 at 9:37 AM, Mauro Carvalho Chehab
mche...@osg.samsung.com wrote:
Hi Devin,
Em Thu, 30 Oct 2014 09:15:31 -0400
Devin Heitmueller dheitmuel...@kernellabs.com escreveu:
Hi Mauro,
Syncronize
Hi!
This time the series got only small updates from Antti's review.
Additionally I added a patch to no longer directly modify
the content of the port3 switch bit in PWR_CTL_EN (from function
cx231xx_set_power_mode).
Now there are two places where I wonder what happens:
1.
This is a preparation for deleting the otherwise useless i2c_clients
that are allocated for all the i2c master adapters.
Signed-off-by: Matthias Schwarzott z...@gentoo.org
Reviewed-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/cx231xx/cx231xx-cards.c | 24 +---
1
For each i2c master there is a i2c_client allocated that could be
deleted now that its only two users have been changed to use their
own i2c_client.
Signed-off-by: Matthias Schwarzott z...@gentoo.org
Reviewed-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/cx231xx/cx231xx-i2c.c | 7
The only remaining place that modifies the relevant bit is in function
cx231xx_set_Colibri_For_LowIF
Signed-off-by: Matthias Schwarzott z...@gentoo.org
---
drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
All switching should be done by i2c mux adapters.
Drop explicit dont_use_port_3 flag.
Drop info message about switch.
Only the removed code in start_streaming is questionable:
It did switch the port_3 flag without accessing i2c in between.
Signed-off-by: Matthias Schwarzott z...@gentoo.org
This is a preparation for mapping I2C_1_MUX_1 and I2C_1_MUX_3 later to the
seperate
muxed i2c adapters.
Map mux adapters to I2C_1 for now.
Add local variables for i2c_adapters in dvb_init to get line lengths
shorter.
Signed-off-by: Matthias Schwarzott z...@gentoo.org
Reviewed-by: Antti
V2: Use snprintf to construct the complete name
V3: Remove unneeded variable.
Signed-off-by: Matthias Schwarzott z...@gentoo.org
Reviewed-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/cx231xx/cx231xx-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Signed-off-by: Matthias Schwarzott z...@gentoo.org
Reviewed-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/cx231xx/Kconfig| 1 +
drivers/media/usb/cx231xx/cx231xx-core.c | 5
drivers/media/usb/cx231xx/cx231xx-i2c.c | 44 +++-
The scanning itself just fails (as before this series) but now the correct
busses are scanned.
V2: Changed to symbolic names where muxed adapters can be seen directly.
V3: Comment about scanning busses ordered by physical port numbers.
Signed-off-by: Matthias Schwarzott z...@gentoo.org
This is used later for is_tuner function that switches i2c behaviour for
some tuners.
V2: Add comments about possible improvements for port_3 switch function.
V3: Fix coding style.
Signed-off-by: Matthias Schwarzott z...@gentoo.org
---
drivers/media/usb/cx231xx/cx231xx-avcore.c | 12
Get used i2c port from bus_nr and status of port_3 switch.
Signed-off-by: Matthias Schwarzott z...@gentoo.org
---
drivers/media/usb/cx231xx/cx231xx-i2c.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c
This is a preparation for deleting the otherwise useless i2c_clients
that are allocated for all the i2c master adapters.
Signed-off-by: Matthias Schwarzott z...@gentoo.org
Reviewed-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/cx231xx/cx231xx-i2c.c | 17 +++--
Change to I2C_0 ... I2C_2 for the master ports
and add I2C_1_MUX_1 and I2C_1_MUX_3 for the muxed ones.
V2: Renamed mux adapters to seperate them from master adapters.
Signed-off-by: Matthias Schwarzott z...@gentoo.org
Reviewed-by: Antti Palosaari cr...@iki.fi
---
Replace numbers by the constants of same value and same meaning.
Signed-off-by: Matthias Schwarzott z...@gentoo.org
Reviewed-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/cx231xx/cx231xx-cards.c | 62 +++
1 file changed, 31 insertions(+), 31 deletions(-)
change almost all instances of I2C_1 to I2C_1_MUX_3
Only these cases are changed to I2C_1_MUX_1:
* All that have dont_use_port_3 set.
* CX231XX_BOARD_HAUPPAUGE_EXETER, old code did explicitly not switch to port3.
* eeprom access for 930C
Signed-off-by: Matthias Schwarzott z...@gentoo.org
Em Thu, 30 Oct 2014 21:12:21 +0100
Matthias Schwarzott z...@gentoo.org escreveu:
Hi!
This time the series got only small updates from Antti's review.
Oh, no! I just merged the v3 patch series. I manually fixed the
points that Antti has made.
I'm also testing it already.
Could you, instead,
TechnoTrend CT2-4500 CI is a PCIe device with DVB-T2/C tuner. It is similar to
DVBSky T980C, just with different PCI ID and remote controller.
Signed-off-by: Olli Salonen olli.salo...@iki.fi
---
drivers/media/pci/cx23885/cx23885-cards.c | 14 ++
On Thu, 30 Oct 2014, Olli Salonen wrote:
TechnoTrend CT2-4500 CI is a PCIe device with DVB-T2/C tuner. It is
similar to DVBSky T980C, just with different PCI ID and remote
controller.
Additional note, this should be applied on top of Max Nibble's commits:
Is there any update on DVB-C support? It seems that the patch that
ZZram made, works on lower versions, but not on the current branch.
I have looked in the media_tree.git branch, and see that the (needed)
flags are their, but still it says 'DVB-C not supported'. Would be
great if you guys could
The only remaining place that modifies the relevant bit is in function
cx231xx_set_Colibri_For_LowIF
Signed-off-by: Matthias Schwarzott z...@gentoo.org
---
drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
Hi Mauro,
this one is now based on your cx231xx branch.
Regards
Matthias
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Antti,
On 2014-10-31 01:36:14, Antti Palosaari wrote:
On 10/30/2014 06:38 AM, Nibble Max wrote:
- if (tab_len 83) {
+ if (tab_len 86) {
That is not nice, but I could try find better solution and fix it later.
What is the reason to check this parameter?
How about remove this
On 10/31/2014 04:34 AM, Nibble Max wrote:
Hello Antti,
On 2014-10-31 01:36:14, Antti Palosaari wrote:
On 10/30/2014 06:38 AM, Nibble Max wrote:
- if (tab_len 83) {
+ if (tab_len 86) {
That is not nice, but I could try find better solution and fix it later.
What is the
tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3a2f22b7d0cc64482a91529e23c2570aa0602fa6
commit: 7b34be71db533f3e0cf93d53cf62d036cdb5418a [media] use IS_ENABLED() macro
date: 1 year, 9 months ago
config: x86_64-randconfig-iv0-10311039 (attached as .config)
On 10/31/2014 04:55 AM, Antti Palosaari wrote:
On 10/31/2014 04:34 AM, Nibble Max wrote:
Hello Antti,
On 2014-10-31 01:36:14, Antti Palosaari wrote:
On 10/30/2014 06:38 AM, Nibble Max wrote:
-if (tab_len 83) {
+if (tab_len 86) {
That is not nice, but I could try find
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Oct 31 04:00:17 CET 2014
git branch: test
git hash: 37fa8716e2d4c4155205aa4a904835de09edbb88
gcc
Hello Antti,
On 2014-10-31 11:13:59, Antti Palosaari wrote:
On 10/31/2014 04:55 AM, Antti Palosaari wrote:
On 10/31/2014 04:34 AM, Nibble Max wrote:
Hello Antti,
On 2014-10-31 01:36:14, Antti Palosaari wrote:
On 10/30/2014 06:38 AM, Nibble Max wrote:
-if (tab_len 83) {
+if
64 matches
Mail list logo
