Re: [PATCH] Add LVDS RGB media bus formats

Hi Sakari, Am Samstag, den 13.12.2014, 01:07 +0200 schrieb Sakari Ailus: [...] diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml index 0d6f731..6d59a0e 100644 --- a/Documentation/DocBook/media/v4l/subdev-formats.xml +++

[PATCH 2/6] Vivid sine gen: Optimization for sine LUT size

Exploiting the symmetry and repetitive nature of sine waveform to reduce size of sine LUT. Values up to phase = pi/4, can be used to calculate sine for remaining phases. Cc: Hans Verkuil hans.verk...@cisco.com Cc: Antti Palosaari cr...@iki.fi Signed-off-by: Prashant Laddha prlad...@cisco.com ---

[PATCH 4/6] Vivid sine gen: Renamed SIN_TAB_SIZE to SIN_LUT_SIZE

Cc: Hans Verkuil hans.verk...@cisco.com Cc: Antti Palosaari cr...@iki.fi Signed-off-by: Prashant Laddha prlad...@cisco.com --- drivers/media/platform/vivid/vivid-sin.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/vivid/vivid-sin.c

[PATCH 3/6] Vivid sine gen: Refactor get_sin_val ()

Removed recursion. Also reduced few if() checks. Cc: Hans Verkuil hans.verk...@cisco.com Cc: Antti Palosaari cr...@iki.fi Signed-off-by: Prashant Laddha prlad...@cisco.com --- drivers/media/platform/vivid/vivid-sin.c | 28 +--- 1 file changed, 13 insertions(+), 15

[PATCH 6/6] Vivid SDR: Modified equation used for generating FM

FM (frequency modulated) signal for SDR is generated by varying the phase. The phase variation is proportional to input signal. It was observed that, the larger phase increments leads to discontinuties in the signal recovered after demodulation. This was one of the reason for broken (cracky) sine

[PATCH 5/6] Vivid: Increased precision for (co)sine computation

1.sin LUT is recomputed with precision of 16 bits to represent fractional part. (lowest fraction that can be represented now is 1/2^16, that is 0.15). 2.Instead of using PI = 22/7 in intermediate calculation, use precomputed value for 2PI 3 To avoid overflows, use 64 bit variables for

[PATCH 1/6] Use LUT based implementation for (co)sine functions

Replaced Taylor series calculation for (co)sine with a look up table (LUT) for sine values. Also reworked fixed point implementation to reduce rounding errors. Cc: Hans Verkuil hans.verk...@cisco.com Cc: Antti Palosaari cr...@iki.fi Cc: Mauro Carvalho Chehab mche...@osg.samsung.com

Re: [v3][PATCH 3/5] media: ov2640: add primary dt support

Hi, Laurent On 12/11/2014 4:10 PM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. I only have three minor comments. After fixing them, Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Thanks for the review. On Thursday 11 December 2014 15:35:37 Josh Wu wrote: Add

Re: [v3][PATCH 5/5] media: ov2640: dt: add the device tree binding document

Hi, Laurent On 12/12/2014 10:17 AM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Thursday 11 December 2014 15:35:39 Josh Wu wrote: Add the document for ov2640 dt. Cc: devicet...@vger.kernel.org Signed-off-by: Josh Wu josh...@atmel.com --- v2 - v3: 1. fix incorrect

Re: [PATCH 08/10] s5k4ecgx: fix sparse warnings

On 13/12/14 12:52, Hans Verkuil wrote: The get_unaligned_le*() functions return the value using cpu endianness, so calling le*_to_cpu is wrong. It hasn't been not noticed because this code has only been run on little endian systems, so le*_to_cpu doesn't do anything. Signed-off-by: Hans

Re: [PATCH 09/10] s5k6aa: fix sparse warnings

On 13/12/14 12:52, Hans Verkuil wrote: drivers/media/i2c/s5k6aa.c:351:16: warning: cast to restricted __be16 Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the

Re: [PATCH 10/10] s5k5baf: fix sparse warnings

On 13/12/14 12:53, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com drivers/media/i2c/s5k5baf.c:1796:33: warning: duplicate const drivers/media/i2c/s5k5baf.c:379:24: warning: cast to restricted __le16 drivers/media/i2c/s5k5baf.c:437:11: warning: incorrect type in assignment

Re: [PATCH v3] Add LVDS RGB media bus formats

Hi Philipp, On Mon, Dec 15, 2014 at 10:26:04AM +0100, Philipp Zabel wrote: This patch adds three new RGB media bus formats that describe 18-bit or 24-bit samples transferred over an LVDS bus with three or four differential data pairs, serialized into 7 time slots, using standard

Re: [PATCH 1/6] Use LUT based implementation for (co)sine functions

On 12/15/2014 03:13 PM, Mauro Carvalho Chehab wrote: Em Mon, 15 Dec 2014 14:49:17 +0530 Prashant Laddha prlad...@cisco.com escreveu: Replaced Taylor series calculation for (co)sine with a look up table (LUT) for sine values. Kernel has already a LUT for sin/cos at:

[PATCH] [media] vb2-vmalloc: Protect DMA-specific code by #ifdef CONFIG_HAS_DMA

If NO_DMA=y: drivers/built-in.o: In function `vb2_vmalloc_dmabuf_ops_detach': videobuf2-vmalloc.c:(.text+0x6f11b0): undefined reference to `dma_unmap_sg' drivers/built-in.o: In function `vb2_vmalloc_dmabuf_ops_map': videobuf2-vmalloc.c:(.text+0x6f1266): undefined reference to `dma_unmap_sg'

[PATCH/RESEND] [media] VIDEO_CAFE_CCIC should select VIDEOBUF2_DMA_SG

If VIDEO_CAFE_CCIC=y, but VIDEOBUF2_DMA_SG=m: drivers/built-in.o: In function `mcam_v4l_open': mcam-core.c:(.text+0x1c2e81): undefined reference to `vb2_dma_sg_memops' mcam-core.c:(.text+0x1c2eb0): undefined reference to `vb2_dma_sg_init_ctx' drivers/built-in.o: In function `mcam_v4l_release':

Re: [PATCH/RESEND] [media] VIDEO_CAFE_CCIC should select VIDEOBUF2_DMA_SG

On Mon, 15 Dec 2014 14:55:37 +0100 Geert Uytterhoeven ge...@linux-m68k.org wrote: If VIDEO_CAFE_CCIC=y, but VIDEOBUF2_DMA_SG=m: drivers/built-in.o: In function `mcam_v4l_open': mcam-core.c:(.text+0x1c2e81): undefined reference to `vb2_dma_sg_memops' mcam-core.c:(.text+0x1c2eb0): undefined

Re: [PATCH/RESEND] [media] VIDEO_CAFE_CCIC should select VIDEOBUF2_DMA_SG

Hi Jon, On Mon, Dec 15, 2014 at 3:04 PM, Jonathan Corbet cor...@lwn.net wrote: On Mon, 15 Dec 2014 14:55:37 +0100 Geert Uytterhoeven ge...@linux-m68k.org wrote: If VIDEO_CAFE_CCIC=y, but VIDEOBUF2_DMA_SG=m: drivers/built-in.o: In function `mcam_v4l_open': mcam-core.c:(.text+0x1c2e81):

Re: [PATCH/RESEND] [media] VIDEO_CAFE_CCIC should select VIDEOBUF2_DMA_SG

On Mon, 15 Dec 2014 15:10:38 +0100 Geert Uytterhoeven ge...@linux-m68k.org wrote: If the driver cannot do SG, perhaps this block should be removed from drivers/media/platform/marvell-ccic/mcam-core.h? #if IS_ENABLED(CONFIG_VIDEOBUF2_DMA_SG) #define MCAM_MODE_DMA_SG 1 #endif

[PATCH 1/1] yavta: Set plane size for mplane buffers in qbuf

The plane size was left zero for mplane buffers when queueing a buffer. Fix this. Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com --- yavta.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/yavta.c b/yavta.c index 7f9e814..77e5a41 100644 --- a/yavta.c +++

[GIT PULL FOR v3.20] 10-bit packed raw bayer format support

Hi Mauro, These patches make minor cleanups in raw bayer format documentation and finally add a definition for 10-bit packed raw bayer formats. Please pull. The following changes since commit e272d95f8c0544cff55c485a10828b063c8e417c: [media] rcar_vin: Fix interrupt enable in progressive

[RFC] video support for Samsung SUR40

Hi everyone, I'm currently working on adding raw sensor video support for the Samsung SUR40 touchscreen. I've finally found some useful documentation about videobuf2, and added the required functions to the driver (without actually delivering data so far, I just wanted to try and stream empty

Re: LibV4L2 and CREATE_BUFS issues

Hi, On 14-12-14 15:24, Nicolas Dufresne wrote: Le 2014-12-14 04:49, Hans de Goede a écrit : Ah yes I see, so I assume that if libv4l where to return a failure for CREATE_BUFS when conversion is used, that gstreamer will then fallback to a regular REQUEST_BUFS call ? Then that indeed seems

Re: [RFC] video support for Samsung SUR40

Hi Florian, On 12/15/2014 04:47 PM, Florian Echtler wrote: Hi everyone, I'm currently working on adding raw sensor video support for the Samsung SUR40 touchscreen. I've finally found some useful documentation about videobuf2, and added the required functions to the driver (without actually

[yavta PATCH 1/2] yavta: Implement data_offset support for single and multi plane buffers

Support data_offset for single and multi plane buffers. Also add an option to write the data in the buffer before data offset (--buffer-prefix). Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com --- yavta.c | 24 1 file changed, 20 insertions(+), 4 deletions(-)

[yavta PATCH 2/2] yavta: Add support for 10-bit packed raw bayer formats

Add support for these pixel formats: V4L2_PIX_FMT_SBGGR10P V4L2_PIX_FMT_SGBRG10P V4L2_PIX_FMT_SGRBG10P V4L2_PIX_FMT_SRGGB10P Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com --- yavta.c | 4 1 file changed, 4 insertions(+) diff --git a/yavta.c b/yavta.c index 47b817c..7a6888f

[yavta PATCH v2 2/3] yavta: Update headers from upstream kernel

Include packed raw 10-bit definitions as well. Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com --- include/linux/v4l2-common.h | 2 + include/linux/v4l2-controls.h | 6 +++ include/linux/videodev2.h | 121 +++--- 3 files changed, 111

[yavta PATCH v2 1/3] yavta: Implement data_offset support for multi plane buffers

Support data_offset for multi plane buffers. Also add an option to write the data in the buffer before data offset (--buffer-prefix). Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com --- yavta.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git

[yavta PATCH v2 0/3] Support data_offset and 10-bit packed raw bayer formats

Hi Laurent, Compared to v1, a field remaining from the single plane data_offset support patch has been removed. Also the kernel headers have been updated with the 10-bit packed raw bayer pixel format definitions. -- Kind regards, Sakari -- To unsubscribe from this list: send the line

Re: [PATCH 1/1] yavta: Set plane size for mplane buffers in qbuf

Hi Sakari, Thank you for the patch. On Monday 15 December 2014 17:27:44 Sakari Ailus wrote: The plane size was left zero for mplane buffers when queueing a buffer. Fix this. Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com --- yavta.c | 8 ++-- 1 file changed, 6

[yavta PATCH v2 3/3] yavta: Add support for 10-bit packed raw bayer formats

Add support for these pixel formats: V4L2_PIX_FMT_SBGGR10P V4L2_PIX_FMT_SGBRG10P V4L2_PIX_FMT_SGRBG10P V4L2_PIX_FMT_SRGGB10P Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com --- yavta.c | 4 1 file changed, 4 insertions(+) diff --git a/yavta.c b/yavta.c index 003d6ba..f40562a

Re: [yavta PATCH v2 2/3] yavta: Update headers from upstream kernel

Hi Sakari, Thank you for the patch. On Monday 15 December 2014 18:26:48 Sakari Ailus wrote: Include packed raw 10-bit definitions as well. Could you please mention in the commit message which upstream tag or commit ID has been used to generate the headers ? Signed-off-by: Sakari Ailus

Re: [yavta PATCH v2 3/3] yavta: Add support for 10-bit packed raw bayer formats

Hi Sakari, Thank you for the patch. On Monday 15 December 2014 18:26:49 Sakari Ailus wrote: Add support for these pixel formats: V4L2_PIX_FMT_SBGGR10P V4L2_PIX_FMT_SGBRG10P V4L2_PIX_FMT_SGRBG10P V4L2_PIX_FMT_SRGGB10P Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com Acked-by:

[RFC v01] Driver for Toshiba TC358743 CSI-2 to HDMI bridge

From: Mats Randgaard matra...@cisco.com The driver is tested on our hardware and all the implemented features works as expected. Missing features: - CEC support - HDCP repeater support - IR support Signed-off-by: Mats Randgaard matra...@cisco.com --- MAINTAINERS|6 +

Re: [yavta PATCH v2 1/3] yavta: Implement data_offset support for multi plane buffers

Hi Sakari, Thank you for the patch. On Monday 15 December 2014 18:26:47 Sakari Ailus wrote: Support data_offset for multi plane buffers. Also add an option to write the data in the buffer before data offset (--buffer-prefix). Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com ---

Re: [tvtime] Broke support for cards with multiple numbers of the input

Em Mon, 15 Dec 2014 11:56:16 + grigore calugar zradu1...@gmail.com escreveu: After commit:http://git.linuxtv.org/cgit.cgi/tvtime.git/commit/?id=c49ebc47c51e0bcf9e8c4403efdf0f31bf1b4479 support for support for cards with multiple numbers of the input is broken. My tuner has 4 inputs and

[yavta PATCH v3 3/3] yavta: Add support for 10-bit packed raw bayer formats

Add support for these pixel formats: V4L2_PIX_FMT_SBGGR10P V4L2_PIX_FMT_SGBRG10P V4L2_PIX_FMT_SGRBG10P V4L2_PIX_FMT_SRGGB10P Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com --- yavta.c | 4 1 file changed, 4 insertions(+) diff --git a/yavta.c b/yavta.c index cf8239b..e79abd6

[yavta PATCH v3 0/3] Support data_offset and 10-bit packed raw bayer

Hi Laurent, since v2: - Reworked patch 1, - List media-tree and on-list patches included in the headers. -- Kind regards, Sakari -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at

[yavta PATCH v3 2/3] yavta: Update headers from upstream kernel

Include packed raw 10-bit definitions as well. This includes patches up to and including [media] mn88473: One function call less in mn88473_init() after error and the following patches (v2 sent to linux-media): DocBook: v4l: Fix raw bayer pixel format documentation wording, DocBook: v4l:

[yavta PATCH v3 1/3] yavta: Implement data_offset support for multi plane buffers

Support data_offset for multi plane buffers. Also add an option to write the data in the buffer before data offset (--buffer-prefix). Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com --- yavta.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 1/1] yavta: Set plane size for mplane buffers in qbuf

Hi Laurent, On Mon, Dec 15, 2014 at 06:31:01PM +0200, Laurent Pinchart wrote: Hi Sakari, Thank you for the patch. On Monday 15 December 2014 17:27:44 Sakari Ailus wrote: The plane size was left zero for mplane buffers when queueing a buffer. Fix this. Signed-off-by: Sakari Ailus

Re: [yavta PATCH v3 2/3] yavta: Update headers from upstream kernel

Hi Sakari, Thank you for the patch. On Monday 15 December 2014 21:58:39 Sakari Ailus wrote: Include packed raw 10-bit definitions as well. This includes patches up to and including [media] mn88473: One function call less in mn88473_init() after error and the following patches (v2 sent to

Re: [yavta PATCH v3 1/3] yavta: Implement data_offset support for multi plane buffers

Hi Sakari, Thank you for the patch. On Monday 15 December 2014 21:58:38 Sakari Ailus wrote: Support data_offset for multi plane buffers. Also add an option to write the data in the buffer before data offset (--buffer-prefix). Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com

[PATCH 0/3] yavta: Compound control support

Hello, This patch set implements compound control get and set support for yavta. Only the integer types are currently supported. I'm not sure to be happy with the way compound control values are printed. I'm open to suggestions (or better, patches ;-)) on how to improve this. Laurent Pinchart

[PATCH 3/3] Implement compound control set support

Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- yavta.c | 217 1 file changed, 165 insertions(+), 52 deletions(-) diff --git a/yavta.c b/yavta.c index 006bab6..843c561 100644 --- a/yavta.c +++ b/yavta.c @@

[PATCH 2/3] Implement compound control get support

Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- yavta.c | 158 +++- 1 file changed, 116 insertions(+), 42 deletions(-) diff --git a/yavta.c b/yavta.c index b9b8bb8..006bab6 100644 --- a/yavta.c +++ b/yavta.c @@

[PATCH 1/3] Implement VIDIOC_QUERY_EXT_CTRL support

Use the new extended control query ioctl when available with an automatic fall back to VIDIOC_QUERYCTRL. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- yavta.c | 47 +++ 1 file changed, 39 insertions(+), 8 deletions(-) diff

[PATCH 1/2] qv4l2: enable qt5 opengl build

Signed-off-by: Peter Seiderer ps.rep...@gmx.net --- configure.ac | 12 ++-- utils/qv4l2/qv4l2.pro | 7 ++- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index 588dd9e..dce2848 100644 --- a/configure.ac +++ b/configure.ac @@

[PATCH 2/2] qv4l2: fix qt5 opengl runtime errors

Fix the following two runtime errors with qt-5.3.2: - QOpenGLFunctions created with non-current context Program received signal SIGSEGV, Segmentation fault. #0 0x762819f0 in QOpenGLContext::shareGroup() const () at /usr/lib64/libQt5Gui.so.5 #1 0x764ff470 in () at

[PATCH 0/3] Various fixes for s5p-mfc driver

This patchset fixes ability to drain the decoder due to use of wrong enumeration name and fixes implementation of display delay controls for MFC firmware v6 and higher. Note that there is no need in the display delay fix for trying to be backward compatible with what the comment was saying since

[PATCH 2/3] s5p-mfc-dec: Don't use encoder stop command

The decoder should handle V4L2_DEC_CMD_STOP to trigger drain, but it currently expecting V4L2_ENC_CMD_STOP. Signed-off-by: Nicolas Dufresne nicolas.dufre...@collabora.com --- drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/3] s5p-mfc-v6+: Use display_delay_enable CID

The MFC driver has two controls, DISPLAY_DELAY and DISPLAY_DELAY_ENABLE that allow forcing the decoder to return a decoded frame sooner regardless of the order. The added support for firmware version 6 and higher was not taking into account the DISPLAY_DELAY_ENABLE boolean. Instead it had a

[PATCH 3/3] media-doc: Fix MFC display delay control doc

The V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY_ENABLE control is a boolean but was documented as a integer. The documentation was also slightly miss-leading. Signed-off-by: Nicolas Dufresne nicolas.dufre...@collabora.com --- Documentation/DocBook/media/v4l/controls.xml | 11 +--

Re: [RFC] video support for Samsung SUR40

Hello Hans, On 15.12.2014 17:01, Hans Verkuil wrote: On 12/15/2014 04:47 PM, Florian Echtler wrote: However, I'm running into an issue I have a hard time understanding. In particular, as soon as I load the kernel module, I'm getting a kernel oops (NULL pointer dereference) in line 354 or 355

Re: [RFC] video support for Samsung SUR40

On 12/15/2014 11:15 PM, Florian Echtler wrote: Hello Hans, On 15.12.2014 17:01, Hans Verkuil wrote: On 12/15/2014 04:47 PM, Florian Echtler wrote: However, I'm running into an issue I have a hard time understanding. In particular, as soon as I load the kernel module, I'm getting a kernel

Fwd: Instalation issue on S960

Dear support team , i have spent 4 days trying to get my S960 setup in my raspberrry Pi I have tried multiple options and using the linuxtv.org drivers the power light switches on but then i get the below message [8.561909] usb 1-1.5: dvb_usb_v2: found a 'DVBSky S960/S860' in warm state [

[PATCH] mn88472: implement lock for all delivery systems

Signed-off-by: Benjamin Larsson benja...@southpole.se --- drivers/staging/media/mn88472/mn88472.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c index 68f5036..426f0ed

Re: Instalation issue on S960

Hi, I was recently trying to build drivers for another tuner on a Pi and also came across a similar problem [unable to find symbols], it turns out that the Raspberry Pi kernel doesn't have I2C_MUX enabled which is needed by some modules. You could try rebuilding the kernel with the above option

RE: Kedves: Webmail Elofizeto

From: Maria Kovalska Sent: Tue 12/16/2014 2:01 Subject: Kedves: Webmail Elofizeto Kedves: Webmail Elofizeto Felhívjuk figyelmét, hogy az e-mail fiók meghaladta tárolókapacitás. Ön nem tud küldeni és fogadni e-maileket és a e-mail fiókja törlésre kerül a

Re: [PATCH] mn88472: implement lock for all delivery systems

Moikka! On 12/16/2014 01:40 AM, Benjamin Larsson wrote: Signed-off-by: Benjamin Larsson benja...@southpole.se --- drivers/staging/media/mn88472/mn88472.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/mn88472/mn88472.c

Re: Instalation issue on S960

On 12/16/2014 02:09 AM, Mark Clarkstone wrote: Hi, I was recently trying to build drivers for another tuner on a Pi and also came across a similar problem [unable to find symbols], it turns out that the Raspberry Pi kernel doesn't have I2C_MUX enabled which is needed by some modules. That's

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Dec 16 04:00:25 CET 2014 git branch: test git hash: e272d95f8c0544cff55c485a10828b063c8e417c gcc

Re: [PATCH 1/6] Use LUT based implementation for (co)sine functions

Antti, Mauro, Thanks for your comments. On 15/12/14 7:00 pm, Antti Palosaari cr...@iki.fi wrote: On 12/15/2014 03:13 PM, Mauro Carvalho Chehab wrote: Em Mon, 15 Dec 2014 14:49:17 +0530 Prashant Laddha prlad...@cisco.com escreveu: Replaced Taylor series calculation for (co)sine with a look