Re: [PATCH 03/14] clkdev: get rid of redundant clk_add_alias() prototype in linux/clk.h

2015-04-05 Thread Sekhar Nori
On Friday 03 April 2015 10:42 PM, Russell King wrote: clk_add_alias() is provided by clkdev, and is not part of the clk API. Howver, it is prototyped in two locations: linux/clkdev.h and linux/clk.h. This is a mess. Get rid of the redundant and unnecessary version in linux/clk.h.

cron job: media_tree daily build: ERRORS

2015-04-05 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Apr 6 04:00:15 CEST 2015 git branch: test git hash: a5562f65b1371a0988b707c10c44fcc2bba56990 gcc

[PATCH 4/16] [media] as102: fix error return code

2015-04-05 Thread Julia Lawall
Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ ( if (\(ret 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when !=

[PATCH 2/16] [media] si4713: fix error return code

2015-04-05 Thread Julia Lawall
Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ ( if (\(ret 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when !=

[PATCH 0/16] fix error return code

2015-04-05 Thread Julia Lawall
The complate semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @ok exists@ identifier f,ret,i; expression e; constant c; @@ // identify a function that returns a negative return value at least once. f(...) { ... when any ( return -c@i; | ret = -c@i; ...

[PATCH 3/16] [media] radio: fix error return code

2015-04-05 Thread Julia Lawall
Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ ( if (\(ret 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when !=

Re: [PATCH 00/14] Fix fallout from per-user struct clk patches

2015-04-05 Thread Russell King - ARM Linux
On Sun, Apr 05, 2015 at 11:04:56AM +0200, Geert Uytterhoeven wrote: Hi Russell, On Fri, Apr 3, 2015 at 7:11 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Sorry for posting this soo close to the 4.1 merge window, I had completely forgotten about this chunk of work I did

Re: [PATCH 07/14] media: omap3isp: remove unused clkdev

2015-04-05 Thread Russell King - ARM Linux
On Sat, Apr 04, 2015 at 12:44:35AM +0300, Laurent Pinchart wrote: Hi Russell, Thank you for the patch; On Friday 03 April 2015 18:12:58 Russell King wrote: No merged platform supplies xclks via platform data. As we want to slightly change the clkdev interface, rather than fixing this

Re: [PATCH 00/14] Fix fallout from per-user struct clk patches

2015-04-05 Thread Geert Uytterhoeven
Hi Russell, On Fri, Apr 3, 2015 at 7:11 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Sorry for posting this soo close to the 4.1 merge window, I had completely forgotten about this chunk of work I did earlier this month. The per-user struct clk patches rather badly broke clkdev

Re: [PATCH V2] [media] V4L: soc-camera: add SPI device support

2015-04-05 Thread Guennadi Liakhovetski
Hi Kassey, Thanks for updating your patch and addressing my comments! In your reply to v1 of this patch you said, that you would add DT support in v2, i.e. in this version, right? Is it now present in this patch? If yes - can you explain to me how it works? For I2C the