Re: [PATCH v2 3/3] media: atmel-isi: add sanity check for supported formats in set_fmt()

2015-08-20 Thread Josh Wu
Hi, Laurent Thanks for the review. On 8/21/2015 2:30 AM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Wednesday 05 August 2015 11:26:29 Josh Wu wrote: After adding the format check in set_fmt(), we don't need any format check in configure_geometry(). So make configure_geometr

cron job: media_tree daily build: WARNINGS

2015-08-20 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Aug 21 04:00:17 CEST 2015 git branch: test git hash: 3a6b0605c73d1d695f6d4e49289deaa3fa3e73ee gcc versi

Re: [PATCH v6 6/8] [media] media: add messages when media device gets (un)registered

2015-08-20 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Wednesday 19 August 2015 08:01:53 Mauro Carvalho Chehab wrote: > We can only free the media device after being sure that no > graph object is used. media_device_release() is currently broken as it should call back to the driver that has allocated the media_

Re: [PATCH v6 7/8] [media] media: add a debug message to warn about gobj creation/removal

2015-08-20 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Wednesday 19 August 2015 08:01:54 Mauro Carvalho Chehab wrote: > It helps to check if the media controller is doing the > right thing with the object creation and removal. > > No extra code/data will be produced if DEBUG or > CONFIG_DYNAMIC_DEBUG is not enab

Re: [PATCH v6 3/8] [media] media: use media_gobj inside entities

2015-08-20 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Wednesday 19 August 2015 08:01:50 Mauro Carvalho Chehab wrote: > As entities are graph elements, let's embed media_gobj > on it. That ensures an unique ID for entities that can be > global along the entire media controller. > > For now, we'll keep the alread

Re: [PATCH v6 2/8] [media] media: add a common struct to be embed on media graph objects

2015-08-20 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Wednesday 19 August 2015 08:01:49 Mauro Carvalho Chehab wrote: > Due to the MC API proposed changes, we'll need to have an unique > object ID for all graph objects, and have some shared fields > that will be common on all media graph objects. > > Right now,

[PATCH RFC 0/2] NVIDIA Tegra VI V4L2 driver

2015-08-20 Thread Bryan Wu
NVIDIA Tegra SoC includes a Video Input controller, which can talk with external camera sensors. This patch set is still under development, since it's based on some out of tree Tegra patches. And media controller part still needs some rework after upstream finalize the MC redesign work. Currently

[PATCH RFC 0/2] NVIDIA Tegra VI V4L2 driver

2015-08-20 Thread Bryan Wu
NVIDIA Tegra SoC includes a Video Input controller, which can talk with external camera sensors. This patch set is still under development, since it's based on some out of tree Tegra patches. And media controller part still needs some rework after upstream finalize the MC redesign work. Currently

[PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-20 Thread Bryan Wu
NVIDIA Tegra processor contains a powerful Video Input (VI) hardware controller which can support up to 6 MIPI CSI camera sensors. This patch adds a V4L2 media controller and capture driver to support Tegra VI hardware. It's verified with Tegra built-in test pattern generator. Signed-off-by: Brya

[PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-20 Thread Bryan Wu
NVIDIA Tegra processor contains a powerful Video Input (VI) hardware controller which can support up to 6 MIPI CSI camera sensors. This patch adds a V4L2 media controller and capture driver to support Tegra VI hardware. It's verified with Tegra built-in test pattern generator. Signed-off-by: Brya

[PATCH 2/2] ARM64: add tegra-vi support in T210 device-tree

2015-08-20 Thread Bryan Wu
Following device tree support for Tegra VI now: - "vi" node which might have 6 ports/endpoints - in TPG mode, "vi" node don't need to define any ports/endpoints - ports/endpoints defines the link between VI and external sensors. Signed-off-by: Bryan Wu --- arch/arm64/boot/dts/nvidia/tegra210-

[PATCH 2/2] ARM64: add tegra-vi support in T210 device-tree

2015-08-20 Thread Bryan Wu
Following device tree support for Tegra VI now: - "vi" node which might have 6 ports/endpoints - in TPG mode, "vi" node don't need to define any ports/endpoints - ports/endpoints defines the link between VI and external sensors. Signed-off-by: Bryan Wu --- arch/arm64/boot/dts/nvidia/tegra210-

Re: [PATCH v6 1/8] [media] media: create a macro to get entity ID

2015-08-20 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Wednesday 19 August 2015 08:01:48 Mauro Carvalho Chehab wrote: > Instead of accessing directly entity.id, let's create a macro, > as this field will be moved into a common struct later on. > > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Hans Verkuil >

Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id()

2015-08-20 Thread Javier Martinez Canillas
Hello Laurent, On 08/21/2015 02:15 AM, Laurent Pinchart wrote: > Hi Javier, > > On Friday 21 August 2015 02:14:05 Javier Martinez Canillas wrote: >> On 08/20/2015 08:37 PM, Laurent Pinchart wrote: >>> On Wednesday 19 August 2015 17:35:19 Javier Martinez Canillas wrote: The struct media_entit

Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id()

2015-08-20 Thread Laurent Pinchart
Hi Javier, On Friday 21 August 2015 02:14:05 Javier Martinez Canillas wrote: > On 08/20/2015 08:37 PM, Laurent Pinchart wrote: > > On Wednesday 19 August 2015 17:35:19 Javier Martinez Canillas wrote: > >> The struct media_entity does not have an .id field anymore since > >> now the entity ID is st

Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id()

2015-08-20 Thread Javier Martinez Canillas
Hello Laurent, On 08/20/2015 08:37 PM, Laurent Pinchart wrote: > Hi Javier, > > Thank you for the patch. > > On Wednesday 19 August 2015 17:35:19 Javier Martinez Canillas wrote: >> The struct media_entity does not have an .id field anymore since >> now the entity ID is stored in the embedded str

Re: VIMC: API proposal, configuring the topology through user space

2015-08-20 Thread Laurent Pinchart
Hi Mauro, On Thursday 20 August 2015 00:13:43 Mauro Carvalho Chehab wrote: > Em Thu, 20 Aug 2015 02:33:15 +0300 Laurent Pinchart escreveu: > > On Tuesday 18 August 2015 07:06:36 Mauro Carvalho Chehab wrote: > >> Em Tue, 18 Aug 2015 09:35:14 +0300 Laurent Pinchart escreveu: > >>> On Friday 14 Augus

Re: [PATCH] rcar_vin: propagate querystd() error upstream

2015-08-20 Thread Laurent Pinchart
Hi Sergei, Thank you for the patch. On Thursday 20 August 2015 00:02:17 Sergei Shtylyov wrote: > rcar_vin_set_fmt() defaults to PAL when the subdevice's querystd() method > call fails (e.g. due to I2C error). This doesn't work very well when a > camera being used outputs NTSC which has differe

Re: [PATCH 00/18] Export SPI and OF module aliases in missing drivers

2015-08-20 Thread Javier Martinez Canillas
Hello Brian, On 08/20/2015 11:11 PM, Brian Norris wrote: > On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote: >> Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches > > ^^^ I'm dying to know how this sentence ends :) > Sigh, I did some last minute restructu

Re: [PATCH 00/18] Export SPI and OF module aliases in missing drivers

2015-08-20 Thread Brian Norris
On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote: > Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches ^^^ I'm dying to know how this sentence ends :) > Patch #18 changes the logic of spi_uevent() to report an OF modalias if > the device was registered usi

[PATCH] cx231xx: Use wake_up_interruptible() instead of wake_up_interruptible_nr()

2015-08-20 Thread Steven Rostedt
While looking at use cases of the wake queues in order to add support for simple wait queues, I noticed that there was only a single user of wake_up_interruptible_nr(), and that use was doing a single task wake up. Have that user use the proper wake_up_interruptible() instead, and perhaps we can ev

Re: [PATCH 1/4] [media] staging: omap4iss: get entity ID using media_entity_id()

2015-08-20 Thread Laurent Pinchart
Hi Javier, Thank you for the patch. On Wednesday 19 August 2015 17:35:19 Javier Martinez Canillas wrote: > The struct media_entity does not have an .id field anymore since > now the entity ID is stored in the embedded struct media_gobj. > > This caused the omap4iss driver fail to build. Fix by u

Re: [PATCH v2 3/3] media: atmel-isi: add sanity check for supported formats in set_fmt()

2015-08-20 Thread Laurent Pinchart
Hi Josh, Thank you for the patch. On Wednesday 05 August 2015 11:26:29 Josh Wu wrote: > After adding the format check in set_fmt(), we don't need any format check > in configure_geometry(). So make configure_geometry() as void type. > > Signed-off-by: Josh Wu > --- > > Changes in v2: > - new a

Re: [PATCH 0/4] [media] Media entity cleanups and build fixes

2015-08-20 Thread Javier Martinez Canillas
Hello Hans, On 08/20/2015 02:41 PM, Hans Verkuil wrote: > On 08/19/15 17:35, Javier Martinez Canillas wrote: >> Hello, >> >> This series contains a couple of build fixes and cleanups for the >> Media Controller framework. The goal of the series is to get rid of >> the struct media_entity .parent m

Re: [PATCH 3/4] [media] media: use entity.graph_obj.mdev instead of .parent

2015-08-20 Thread Hans Verkuil
On 08/19/15 17:35, Javier Martinez Canillas wrote: > The struct media_entity has a .parent field that stores a pointer > to the parent struct media_device. But recently a media_gobj was > embedded into the entities and since struct media_gojb already has > a pointer to a struct media_device in the

Re: [PATCH 4/4] [media] media: remove media entity .parent field

2015-08-20 Thread Hans Verkuil
On 08/19/15 17:35, Javier Martinez Canillas wrote: > Now that the struct media_entity .parent field is unused, it can be > safely removed. Since all the previous users were converted to use > the .mdev field from the embedded struct media_gobj instead. > > Suggested-by: Mauro Carvalho Chehab > Si

Re: [PATCH 0/4] [media] Media entity cleanups and build fixes

2015-08-20 Thread Hans Verkuil
On 08/19/15 17:35, Javier Martinez Canillas wrote: > Hello, > > This series contains a couple of build fixes and cleanups for the > Media Controller framework. The goal of the series is to get rid of > the struct media_entity .parent member since now that a media_gobj is > embedded into entities,

Re: [RFC v3 02/19] media/v4l2-core: add new ioctl VIDIOC_G_DEF_EXT_CTRLS

2015-08-20 Thread Hans Verkuil
On 08/20/15 00:19, Laurent Pinchart wrote: > Hi Hans, > > I like your proposal, and especially how it would integrate with the requests > API. Should we give the requests API a try to make sure your proposal works > fine with it ? To be honest, I don't see what there is to test. Request IDs hav

RE: [PATCH] s5p-mfc: fix state check from encoder queue_setup

2015-08-20 Thread Kamil Debski
Hi, > From: Andrzej Hajda [mailto:a.ha...@samsung.com] > Sent: Tuesday, August 18, 2015 3:32 PM > > On 05/13/2015 09:25 AM, Seung-Woo Kim wrote: > > MFCINST_GOT_INST state is set to encoder context with set_format only > > for catpure buffer. In queue_setup of encoder called during reqbufs, > > i

[PATCH] au0828: Fix the logic that enables the analog demoder link

2015-08-20 Thread Mauro Carvalho Chehab
This logic was broken on the original patch, likely due to a cut-and-paste mistake. Fix it. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c index a9087f05b29a..4511e2893282 100644 --- a/drivers/media/usb/au0828

Re: [PATCH v2 3/3] media: atmel-isi: add sanity check for supported formats in set_fmt()

2015-08-20 Thread Josh Wu
Hi, Laurent Could you have time to review this patch? so that I can send a pull request with your reviewed-by tags. Best Regards, Josh Wu On 8/5/2015 11:26 AM, Josh Wu wrote: After adding the format check in set_fmt(), we don't need any format check in configure_geometry(). So make configure

[PATCH] [media] tc358743: only queue subdev notifications if devnode is set

2015-08-20 Thread Philipp Zabel
Hardware interrupts are enabled in the probe function, before the subdev is registered to its v4l2_device. Until v4l2_device_register_subdev_node is called, sd->devnode is NULL and v4l2_subdev_notify_event must not be called. Signed-off-by: Philipp Zabel --- drivers/media/i2c/tc358743.c | 3 ++-

[PATCH 00/18] Export SPI and OF module aliases in missing drivers

2015-08-20 Thread Javier Martinez Canillas
Hello, Short version: This patch series is the SPI equivalent of the I2C one posted before [0]. This series add the missing MODULE_DEVICE_TABLE() for OF and SPI tables to export that information so modules have the correct aliases built-in and autoloading works correctly. Longer version: The S

[PATCH 08/18] [media] s5c73m3: Export OF module alias information

2015-08-20 Thread Javier Martinez Canillas
The SPI core always reports the MODALIAS uevent as "spi:" regardless of the mechanism that was used to register the device (i.e: OF or board code) and the table that is used later to match the driver with the device (i.e: SPI id table or OF match table). So drivers needs to export the SPI id table