Re: Call for help: em28xx: new board id [1f4d:1abe]

2015-09-06 Thread Ronald Tallent
Hey Mauro, Thanks for the reply. Relieved to know I'm not invisible. =) I'm a total noob to linux driver issues, so if I'm posting this in the wrong area, please forgive me. I only posted here because this is where linuxtv.org said to go to ask for help. Until now all my hardware has just

cron job: media_tree daily build: OK

2015-09-06 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Sep 7 04:00:16 CEST 2015 git branch: test git hash: 50ef28a6ac216fd8b796257a3768fef8f57b917d gcc

Re: 3rd posting: em28xx: new board id [1f4d:1abe]

2015-09-06 Thread Mauro Carvalho Chehab
Hi Ronald, Well, probably nobody knows what to do with that ;) If I understood well your post, video didn't work, right? So, either you or someone else with the same hardware as you have would need to make it work and send a patch to the mailing list adding support for this new ID. Probably,

Re: [PATCH] [media] atmel-isi: Protect PM-only functions to kill warning

2015-09-06 Thread Josh Wu
Hi, Geert Uytterhoeven Thanks for the patch. On 9/6/2015 6:08 PM, Geert Uytterhoeven wrote: If CONFIG_PM=n: drivers/media/platform/soc_camera/atmel-isi.c:1044: warning: ‘atmel_isi_runtime_suspend’ defined but not used drivers/media/platform/soc_camera/atmel-isi.c:1054: warning:

[PATCH] [media] atmel-isi: Protect PM-only functions to kill warning

2015-09-06 Thread Geert Uytterhoeven
If CONFIG_PM=n: drivers/media/platform/soc_camera/atmel-isi.c:1044: warning: ‘atmel_isi_runtime_suspend’ defined but not used drivers/media/platform/soc_camera/atmel-isi.c:1054: warning: ‘atmel_isi_runtime_resume’ defined but not used Protect the unused functions by #ifdef CONFIG_PM to

Re: [PATCH v8 21/55] [media] media: make media_link more generic to handle interace links

2015-09-06 Thread Mauro Carvalho Chehab
By adding an union at media_link, we get for free a way to represent interface->entity links. No need to change anything at the code, just at the internal header file. Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil diff --git

Re: [PATCH v8 20/55] [media] media: make add link more generic

2015-09-06 Thread Mauro Carvalho Chehab
The media_entity_add_link() function takes an entity as an argument just to get the list head. Make it more generic by changing the function argument to list_head. No functional changes. Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil

Re: [PATCH v8 22/55] [media] media: make link debug printk more generic

2015-09-06 Thread Mauro Carvalho Chehab
Remove entity name from the link as this exists only if the object type is PAD on both link ends. Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab diff --git

Re: [PATCH v8 16/55] [media] media: Don't accept early-created links

2015-09-06 Thread Mauro Carvalho Chehab
Links are graph objects that represent the links of two already existing objects in the graph. While with the current implementation, it is possible to create the links earlier, It doesn't make any sense to allow linking two objects when they are not both created. So, remove the code that would

Re: [PATCH v8 26/55] [media] media: add a linked list to track interfaces by mdev

2015-09-06 Thread Mauro Carvalho Chehab
The media device should list the interface objects, so add a linked list for those interfaces in struct media_device. Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil diff --git a/drivers/media/media-device.c

Re: [PATCH v8 47/55] [media] media-device: add pads and links to media_device

2015-09-06 Thread Mauro Carvalho Chehab
The MC next gen API sends objects to userspace grouped by their types. In the case of pads and links, in order to improve performance and have a simpler code, the best is to store them also on separate linked lists at MC. If we don't do that, we would need this kind of interaction to send data

Re: [PATCH v8 24/55] [media] media-entity: add a helper function to create interface

2015-09-06 Thread Mauro Carvalho Chehab
As we'll be adding other interface types in the future, put the common interface create code on a separate function. Suggested-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil diff --git

[PATCH] [media] atmel-isi:

2015-09-06 Thread Geert Uytterhoeven
If CONFIG_PM=n: drivers/media/platform/soc_camera/atmel-isi.c:1044: warning: ‘atmel_isi_runtime_suspend’ defined but not used drivers/media/platform/soc_camera/atmel-isi.c:1054: warning: ‘atmel_isi_runtime_resume’ defined but not used Protect the unused functions by #ifdef CONFIG_PM to

[PATCH v5 4/4] media: pxa_camera: conversion to dmaengine

2015-09-06 Thread Robert Jarzmik
Convert pxa_camera to dmaengine. This removes all DMA registers manipulation in favor of the more generic dmaengine API. The functional level should be the same as before. The biggest change is in the videobuf_sg_splice() function, which splits a videobuf-dma into several scatterlists for 3

[PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-09-06 Thread Robert Jarzmik
Fix the error path where the video buffer wasn't allocated nor mapped. In this case, in the driver free path don't try to unmap memory which was not mapped in the first place. Signed-off-by: Robert Jarzmik --- Since v3: take into account the 2 paths possibilities to

[PATCH v5 3/4] media: pxa_camera: trivial move of dma irq functions

2015-09-06 Thread Robert Jarzmik
This moves the dma irq handling functions up in the source file, so that they are available before DMA preparation functions. It prepares the conversion to DMA engine, where the descriptors are populated with these functions as callbacks. Signed-off-by: Robert Jarzmik ---

Re: [PATCH v8 55/55] [media] media-entity.h: document all the structs

2015-09-06 Thread Mauro Carvalho Chehab
Only a few structs are documented on kernel-doc-nano format (the ones added by the MC next gen patches). Add a documentation for all structs, and ensure that they'll be producing the documentation at the Kernel's device driver DocBook. Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH v8 39/55] [media] media controller: get rid of entity subtype on Kernel

2015-09-06 Thread Mauro Carvalho Chehab
Don't use anymore the type/subtype entity data/macros inside the Kernel. Signed-off-by: Mauro Carvalho Chehab diff --git a/include/media/media-entity.h b/include/media/media-entity.h index 220864319d21..7320cdc45833 100644 --- a/include/media/media-entity.h +++

Re: [PATCH v8.2 19/55] [media] media: convert links from array to list

2015-09-06 Thread Mauro Carvalho Chehab
The entire logic that represent graph links were developed on a time where there were no needs to dynamic remove links. So, although links are created/removed one by one via some functions, they're stored as an array inside the entity struct. As the array may grow, there's a logic inside the code

Re: [PATCH v8 46/55] [media] media: move mdev list init to gobj

2015-09-06 Thread Mauro Carvalho Chehab
Let's control the topology changes inside the graph_object. So, move the addition and removal of interfaces/entities from the mdev lists to media_gobj_init() and media_gobj_remove(). The main reason is that mdev should have lists for all object types, as the new MC api will require to store

Re: [PATCH v8 45/55] [media] media: Use a macro to interate between all interfaces

2015-09-06 Thread Mauro Carvalho Chehab
Just like we do with entities, use a similar macro for the interfaces loop. Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c index

Re: [PATCH v8 51/55] [media] remove interface links at media_entity_unregister()

2015-09-06 Thread Mauro Carvalho Chehab
Interface links connected to an entity should be removed before being able of removing the entity. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index 96a476eeb16e..7c37aeab05bb 100644 ---

Re: [PATCH v8 14/55] [media] media: add functions to allow creating interfaces

2015-09-06 Thread Mauro Carvalho Chehab
Interfaces are different than entities: they represent a Kernel<->userspace interaction, while entities represent a piece of hardware/firmware/software that executes a function. Let's distinguish them by creating a separate structure to store the interfaces. Later patches should change the

Re: [PATCH v8 48/55] [media] media_device: add a topology version field

2015-09-06 Thread Mauro Carvalho Chehab
Every time a graph object is added or removed, the version of the topology changes. That's a requirement for the new MEDIA_IOC_G_TOPOLOGY, in order to allow userspace to know that the topology has changed after a previous call to it. Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH v8 31/55] [media] media: add macros to check if subdev or V4L2 DMA

2015-09-06 Thread Mauro Carvalho Chehab
As we'll be removing entity subtypes from the Kernel, we need to provide a way for drivers and core to check if a given entity is represented by a V4L2 subdev or if it is an V4L2 I/O entity (typically with DMA). Signed-off-by: Mauro Carvalho Chehab diff --git

Re: [PATCH v8 40/55] [media] media.h: don't use legacy entity macros at Kernel

2015-09-06 Thread Mauro Carvalho Chehab
Put the legacy MEDIA_ENT_* macros under a #ifndef __KERNEL__, in order to be sure that none of those old symbols are used inside the Kernel. Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil diff --git a/include/uapi/linux/media.h

Re: [PATCH v8 44/55] [media] uapi/media.h: Add MEDIA_IOC_G_TOPOLOGY ioctl

2015-09-06 Thread Mauro Carvalho Chehab
Add a new ioctl that will report the entire topology on one go. Signed-off-by: Mauro Carvalho Chehab diff --git a/include/media/media-entity.h b/include/media/media-entity.h index 7320cdc45833..2d5ad40254b7 100644 --- a/include/media/media-entity.h +++

Re: [PATCH v8 52/55] [media] media-device: remove interfaces and interface links

2015-09-06 Thread Mauro Carvalho Chehab
Just like what's done with entities, when the media controller is unregistered, release any interface and interface links that might still be there. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index

Re: [PATCH v8 28/55] [media] uapi/media.h: Fix entity namespace

2015-09-06 Thread Mauro Carvalho Chehab
Now that interfaces got created, we need to fix the entity namespace. So, let's create a consistent new namespace and add backward compatibility macros to keep the old namespace preserved. Signed-off-by: Mauro Carvalho Chehab diff --git

Re: [PATCH v8 23/55] [media] media: add support to link interfaces and entities

2015-09-06 Thread Mauro Carvalho Chehab
Now that we have a new graph object called "interfaces", we need to be able to link them to the entities. Add a linked list to the interfaces to allow them to be linked to the entities. Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil

Re: [PATCH v8 41/55] [media] DocBook: update descriptions for the media controller entities

2015-09-06 Thread Mauro Carvalho Chehab
Cleanup the media controller entities description: - remove MEDIA_ENT_T_DEVNODE and MEDIA_ENT_T_V4L2_SUBDEV entity types, as they don't mean anything; - add MEDIA_ENT_T_UNKNOWN with a proper description; - remove ALSA and FB entity types. Those should not be used, as the types are deprecated.

Re: [PATCH v8 50/55] [media] media-entity: unregister entity links

2015-09-06 Thread Mauro Carvalho Chehab
Add functions to explicitly unregister all entity links. This function is called automatically when an entity link is destroyed. Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil diff --git a/drivers/media/media-entity.c

Re: [PATCH v8 42/55] [media] dvb: modify core to implement interfaces/entities at MC new gen

2015-09-06 Thread Mauro Carvalho Chehab
The Media Controller New Generation redefines the types for both interfaces and entities to be used on DVB. Make the needed changes at the DVB core for all interfaces, entities and data and interface links to appear in the graph. Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH v8 53/55] [media] v4l2-core: create MC interfaces for devnodes

2015-09-06 Thread Mauro Carvalho Chehab
V4L2 device (and subdevice) nodes should create an interface, if the Media Controller support is enabled. Please notice that radio devices should not create an entity, as radio input/output is either via wires or via ALSA. Signed-off-by: Mauro Carvalho Chehab diff

Re: [PATCH v8 38/55] [media] v4l2-subdev: use MEDIA_ENT_T_UNKNOWN for new subdevs

2015-09-06 Thread Mauro Carvalho Chehab
Instead of abusing MEDIA_ENT_T_V4L2_SUBDEV, initialize new subdev entities as MEDIA_ENT_T_UNKNOWN. Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index

Re: [PATCH v8 49/55] [media] media-device: add support for MEDIA_IOC_G_TOPOLOGY ioctl

2015-09-06 Thread Mauro Carvalho Chehab
Add support for the new MEDIA_IOC_G_TOPOLOGY ioctl, according with the RFC for the MC next generation. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index 5b2c9f7fcd45..96a476eeb16e 100644 ---

Re: [PATCH v8 27/55] [media] dvbdev: add support for indirect interface links

2015-09-06 Thread Mauro Carvalho Chehab
Some interfaces indirectly control multiple entities. Add support for those. Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c index

Re: [PATCH v8 43/55] [media] media: report if a pad is sink or source at debug msg

2015-09-06 Thread Mauro Carvalho Chehab
Sometimes, it is important to see if the created pad is sink or source. Add info to track that. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c index d8038a53f945..6ed5eef88593 100644 ---

Re: [PATCH v8 15/55] [media] uapi/media.h: Declare interface types for ALSA

2015-09-06 Thread Mauro Carvalho Chehab
Declare the interface types to be used on alsa for the new G_TOPOLOGY ioctl. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c index dc679dfe8ade..27fce6224972 100644 --- a/drivers/media/media-entity.c +++

[PATCH] [media] VIDEO_RENESAS_JPU should depend on HAS_DMA

2015-09-06 Thread Geert Uytterhoeven
If NO_DMA=y: warning: (VIDEO_STI_BDISP && VIDEO_RENESAS_JPU && VIDEO_DM365_VPFE && VIDEO_OMAP4) selects VIDEOBUF2_DMA_CONTIG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA) drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:

[PATCH v5 2/4] media: pxa_camera: move interrupt to tasklet

2015-09-06 Thread Robert Jarzmik
In preparation for dmaengine conversion, move the camera interrupt handling into a tasklet. This won't change the global flow, as this interrupt is only used to detect the end of frame and activate DMA fifos handling. Signed-off-by: Robert Jarzmik ---

Charity Project Worth $1,000,000.00 Dollars

2015-09-06 Thread Bill William And Andrea Groner
My wife and I have awarded you with a donation of 1 million Dollars from part of our Jackpot Lottery of 50 Million Dollars, respond with your details for claims. http://www.huffingtonpost.ca/2014/07/22/50-million-edmonton-lotto_n_5610890.html We await your earliest response and God Bless

Charity Project Worth $1,000,000.00 Dollars

2015-09-06 Thread Bill William And Andrea Groner
My wife and I have awarded you with a donation of 1 million Dollars from part of our Jackpot Lottery of 50 Million Dollars, respond with your details for claims. http://www.huffingtonpost.ca/2014/07/22/50-million-edmonton-lotto_n_5610890.html We await your earliest response and God Bless

[PATCH 07/18] [media] dvbdev: returns error if graph object creation fails

2015-09-06 Thread Mauro Carvalho Chehab
Right now, if something gets wrong at dvb_create_media_entity() or at dvb_create_media_graph(), the device will still be registered. Change the logic to properly handle it and free all media graph objects if something goes wrong at dvb_register_device(). Also, change the logic at

[PATCH 17/18] [media] dvbdev: move indirect links on dvr/demux to a separate function

2015-09-06 Thread Mauro Carvalho Chehab
Cleanup the code a little bit by moving the routine that creates links between DVR and demux to the I/O entitis into a separate function. While here, fix the code to use strncmp() instead of strcmp(). Signed-off-by: Mauro Carvalho Chehab diff --git

[PATCH 06/18] [media] media.h: create connector entities for hybrid TV devices

2015-09-06 Thread Mauro Carvalho Chehab
Add entities to represent the connectors that exists inside a hybrid TV device. Signed-off-by: Mauro Carvalho Chehab diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h index b17f6763aff4..69433405aec2 100644 --- a/include/uapi/linux/media.h +++

[PATCH 18/18] [media] dvbdev: Don't create indirect links

2015-09-06 Thread Mauro Carvalho Chehab
Indirect links are those whose the interface indirectly controls other functions. There are two interfaces that have indirect controls at the DVB side: - the network interface, with also controls the demux; - the DVR interface with also controls the demux. One could argue that the frontend

[PATCH 13/18] [media] media-entity.h: rename entity.type to entity.function

2015-09-06 Thread Mauro Carvalho Chehab
Entities should have one or more functions. Calling it as a type proofed to not be correct, as an entity could eventually have more than one type. So, rename the field as function. Please notice that this patch doesn't extend support for multiple function entities. Such change will happen when

[PATCH 03/18] [media] au0828: Create connector links

2015-09-06 Thread Mauro Carvalho Chehab
Now that connectors are entities, we need to represent the connector links. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c index fe9a60484343..35c607c35155 100644 ---

[PATCH 05/18] [media] media-controller: enable all interface links at init

2015-09-06 Thread Mauro Carvalho Chehab
Interface links are normally enabled, meaning that the interfaces are bound to the entities. So, any ioctl send to the interface are reflected at the entities managed by the interface. However, when a device is usage, other interfaces for the same hardware could be decoupled from the entities

[PATCH 02/18] [media] au0828: add support for the connectors

2015-09-06 Thread Mauro Carvalho Chehab
Depending on the input, an au0828 may have a different number of connectors. add entities to represent them. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c index

[PATCH 15/18] [media] uapi/media.h: Rename entities types to functions

2015-09-06 Thread Mauro Carvalho Chehab
Rename the userspace types from MEDIA_ENT_T_ to MEDIA_ENT_F_ and add the backward compatibility bits. The changes at the .c files was generated by the following coccinelle script: @@ @@ -MEDIA_ENT_T_UNKNOWN +MEDIA_ENT_F_UNKNOWN @@ @@ -MEDIA_ENT_T_DVB_BASE +MEDIA_ENT_F_DVB_BASE @@ @@

[PATCH 12/18] [media] media-entity: must check media_create_pad_link()

2015-09-06 Thread Mauro Carvalho Chehab
Drivers should check if media_create_pad_link() actually worked. Signed-off-by: Mauro Carvalho Chehab diff --git a/include/media/media-entity.h b/include/media/media-entity.h index 62f882d872b1..8bdc10dcc5e7 100644 --- a/include/media/media-entity.h +++

[PATCH 00/18] MC fixes, improvements and cleanups

2015-09-06 Thread Mauro Carvalho Chehab
This patch series go after the previous series: "MC next generation patches" http://www.spinics.net/lists/linux-media/msg93108.html It contains a series of fixes and cleanup the MC Next gen. The first patches add connector entities to represent RF, S-Video and Composite

[PATCH 09/18] [media] media-entity: enforce check of interface and links creation

2015-09-06 Thread Mauro Carvalho Chehab
Drivers should check if interfaces and interface links were created. Add a must_check for them. Signed-off-by: Mauro Carvalho Chehab diff --git a/include/media/media-entity.h b/include/media/media-entity.h index 3d389f142a1d..62f882d872b1 100644 ---

[PATCH 04/18] [media] media-device: supress backlinks at G_TOPOLOGY ioctl

2015-09-06 Thread Mauro Carvalho Chehab
Due to the graph traversal algorithm currently in usage, we need a copy of all data links. Those backlinks should not be send to userspace, as otherwise, all links there will be duplicated. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/media-device.c

[PATCH 10/18] [media] cx231xx: enforce check for graph creation

2015-09-06 Thread Mauro Carvalho Chehab
If the graph creation fails, don't register the device. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx/cx231xx-cards.c index 1070d87efc65..c05aaef85491 100644 ---

[PATCH 01/18] [media] tuner-core: add an input pad

2015-09-06 Thread Mauro Carvalho Chehab
Tuners actually have at least one connector on its input. Add a PAD to connect it. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c index f00f1a5f279c..a8e7e2398f7a 100644 ---

[PATCH 16/18] [media] DocBook: update entities documentation

2015-09-06 Thread Mauro Carvalho Chehab
Due to the rename, the documentation became outdated. Update it to reflect what's there at media.h. Signed-off-by: Mauro Carvalho Chehab diff --git a/Documentation/DocBook/media/v4l/media-ioc-enum-entities.xml

[PATCH 08/18] [media] dvb core: must check dvb_create_media_graph()

2015-09-06 Thread Mauro Carvalho Chehab
If media controller is enabled and mdev is filled, it should ensure that the media graph will be properly initialized. Enforce that. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/common/siano/smsdvb-main.c b/drivers/media/common/siano/smsdvb-main.c

[PATCH 14/18] [media] media-device: export the entity function via new ioctl

2015-09-06 Thread Mauro Carvalho Chehab
Now that entities have a main function, expose it via MEDIA_IOC_G_TOPOLOGY ioctl. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index ccef9621d147..32090030c342 100644 --- a/drivers/media/media-device.c +++

[PATCH 11/18] [media] au0828:: enforce check for graph creation

2015-09-06 Thread Mauro Carvalho Chehab
If the graph creation fails, don't register the device. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c index 35c607c35155..399c6712faf9 100644 ---

3rd posting: em28xx: new board id [1f4d:1abe]

2015-09-06 Thread Ronald Tallent
Hi, This is my third attempt to post this information to mailing list in a little over a week. Am I invisible? Can nobody see my messages? I have precisely followed the instructions posted on linuxtv.org/wiki/index.php/Em28xx_devices#How_to_validate_my_vendor.2Fproduct_id_at_upstream_kernel.3F