Re: [RFC 0/9] Unrestricted media entity ID range support

2015-09-18 Thread Mauro Carvalho Chehab
Hi Sakari, On Fri, 11 Sep 2015 13:09:03 +0300 Sakari Ailus wrote: > Hi all, > > This patchset adds an API for managing entity enumerations, i.e. > storing a bit of information per entity. The entity ID is no longer > limited to small integers (e.g. 31 or 63), but

[PATCH] [media] c8sectpfe: Fix uninitialized return in load_c8sectpfe_fw_step1()

2015-09-18 Thread Christian Engelmayer
In case of failure loading the firmware, function load_c8sectpfe_fw_step1() uses the uninitialized variable ret as return value instead of the retrieved error value. Make sure the result is deterministic. Detected by Coverity CID 1324230. Signed-off-by: Christian Engelmayer ---

Re: [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval

2015-09-18 Thread Hans Verkuil
On 09/17/15 23:19, Arnd Bergmann wrote: > The v4l2 API uses a 'struct timeval' to communicate time stamps to user > space. This is broken on 32-bit architectures as soon as we have a C library > that defines time_t as 64 bit, which then changes the structure layout of > struct v4l2_buffer. > >

Re: [PATCH v2 8/9] [media] handle 64-bit time_t in v4l2_buffer

2015-09-18 Thread Hans Verkuil
On 09/18/15 11:26, Arnd Bergmann wrote: > On Friday 18 September 2015 09:18:45 Hans Verkuil wrote: >> Hi Arnd, >> >> Thanks once again for working on this! Unfortunately, this approach won't >> work, see my comments below. >> >> BTW, I would expect to see compile errors when compiling for 32 bit.

Re: [PATCH v2 8/9] [media] handle 64-bit time_t in v4l2_buffer

2015-09-18 Thread Arnd Bergmann
On Friday 18 September 2015 09:18:45 Hans Verkuil wrote: > Hi Arnd, > > Thanks once again for working on this! Unfortunately, this approach won't > work, see my comments below. > > BTW, I would expect to see compile errors when compiling for 32 bit. Did > you try that? I only tested on 32-bit,

Re: [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval

2015-09-18 Thread Hans Verkuil
On 09/18/15 11:09, Arnd Bergmann wrote: > On Friday 18 September 2015 10:05:06 Hans Verkuil wrote: >> On 09/17/15 23:19, Arnd Bergmann wrote: >>> The v4l2 API uses a 'struct timeval' to communicate time stamps to user >>> space. This is broken on 32-bit architectures as soon as we have a C library

Re: [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval

2015-09-18 Thread Hans Verkuil
On 09/18/15 12:08, Arnd Bergmann wrote: > On Friday 18 September 2015 11:52:28 Hans Verkuil wrote: >> On 09/18/15 11:43, Arnd Bergmann wrote: >>> On Friday 18 September 2015 11:27:40 Hans Verkuil wrote: Ah, OK. Got it. I think this is dependent on the upcoming media workshop next

Re: [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity

2015-09-18 Thread Nicolas Ferre
Le 04/08/2015 13:22, Laurent Pinchart a écrit : > Hi Josh, > > Thank you for the patch. > > On Tuesday 04 August 2015 17:37:49 Josh Wu wrote: >> This patch will get the DT parameters of vsync/hsync/pixclock polarity, and >> pass to driver. >> >> Also add a debug information for test purpose. >>

Re: [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval

2015-09-18 Thread Arnd Bergmann
On Friday 18 September 2015 11:27:40 Hans Verkuil wrote: > Ah, OK. Got it. > > I think this is dependent on the upcoming media workshop next month. If we > decide to redesign v4l2_buffer anyway, then we can avoid timeval completely. > And the only place where we would need to convert it in the

Re: [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval

2015-09-18 Thread Hans Verkuil
On 09/18/15 11:43, Arnd Bergmann wrote: > On Friday 18 September 2015 11:27:40 Hans Verkuil wrote: >> Ah, OK. Got it. >> >> I think this is dependent on the upcoming media workshop next month. If we >> decide to redesign v4l2_buffer anyway, then we can avoid timeval completely. >> And the only

Re: [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval

2015-09-18 Thread Arnd Bergmann
On Friday 18 September 2015 11:52:28 Hans Verkuil wrote: > On 09/18/15 11:43, Arnd Bergmann wrote: > > On Friday 18 September 2015 11:27:40 Hans Verkuil wrote: > >> Ah, OK. Got it. > >> > >> I think this is dependent on the upcoming media workshop next month. If we > >> decide to redesign

Re: [PATCH v2 8/9] [media] handle 64-bit time_t in v4l2_buffer

2015-09-18 Thread Hans Verkuil
Hi Arnd, Thanks once again for working on this! Unfortunately, this approach won't work, see my comments below. BTW, I would expect to see compile errors when compiling for 32 bit. Did you try that? On 09/17/2015 11:19 PM, Arnd Bergmann wrote: > This is the final change to enable user space

Re: [PATCH v2 8/9] [media] handle 64-bit time_t in v4l2_buffer

2015-09-18 Thread Arnd Bergmann
On Friday 18 September 2015 11:49:50 Hans Verkuil wrote: > *If* the conversion takes place only in v4l2-ioctl.c, then it makes sense > have these structs + ioctls moved to v4l2-ioctl.h. Ok. > I noticed that v4l2-compat-ioctl32.c wasn't changed. Is that right? I have > unfortunately no time to

cron job: media_tree daily build: OK

2015-09-18 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Sep 19 04:00:20 CEST 2015 git branch: test git hash: 9ddf9071ea17b83954358b2dac42b34e5857a9af gcc

[PATCH] [media] c8sectpfe: Fix uninitialized variable in load_slim_core_fw()

2015-09-18 Thread Christian Engelmayer
Variable err in function load_slim_core_fw() is used without initializer. Make sure that the result is deterministic. Detected by Coverity CID 1324265. Signed-off-by: Christian Engelmayer --- Compile tested only. Applies against linux-next. ---

Re: [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity

2015-09-18 Thread Guennadi Liakhovetski
Hi Josh, On Fri, 18 Sep 2015, Josh Wu wrote: > Hi, Guennadi > > On 9/18/2015 5:44 PM, Guennadi Liakhovetski wrote: > > Hi Nicolas, > > > > Patch handling is on my todo for the coming weekend... > > Beside this patch, Atmel-isi still have server other patches in the patchwork > for a long

Re: [PATCH] media: soc-camera: increase the length of clk_name on soc_of_bind()

2015-09-18 Thread Josh Wu
Hi, Guennadi On 8/30/2015 10:06 PM, Guennadi Liakhovetski wrote: Hi Josh, Sorry, I missed the 4.3 merge cycle, but isn't this patch a fix? Isn't it fixing soc-camera / atmel-isi on a specific platform, where the clock name is longer, than currently supported? Is this platform in the mainline

Re: [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity

2015-09-18 Thread Josh Wu
Hi, Guennadi On 9/18/2015 5:44 PM, Guennadi Liakhovetski wrote: Hi Nicolas, Patch handling is on my todo for the coming weekend... Beside this patch, Atmel-isi still have server other patches in the patchwork for a long time. So some patch may need to rebase. Just for your convenience I

Re: [PATCH v2 7/9] [media] v4l2: introduce v4l2_timeval

2015-09-18 Thread Arnd Bergmann
On Friday 18 September 2015 10:05:06 Hans Verkuil wrote: > On 09/17/15 23:19, Arnd Bergmann wrote: > > The v4l2 API uses a 'struct timeval' to communicate time stamps to user > > space. This is broken on 32-bit architectures as soon as we have a C library > > that defines time_t as 64 bit, which

[PATCH 1/4] s5p-jpeg: generalize clocks handling

2015-09-18 Thread Andrzej Pietrasiewicz
From: Marek Szyprowski Allow jpeg codec variants declare clocks they need. Before this patch is applied jpeg-core gets jpeg->sclk "speculatively": if it is not there, we assume no problem. This patch eliminates this by explicitly declaring what clocks are needed for

[PATCH 0/4] Exynos 5433 jpeg h/w codec support

2015-09-18 Thread Andrzej Pietrasiewicz
Support for Exynos 5433 to the s5p-jpeg driver. The series also includes jpeg codec node definition for Device Tree, but it depends on: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git branch v4.3-drop/dt64-samsung which has not made it into 4.3, but the driver is meant for

[PATCH 3/4] MAINTAINERS: add exynos jpeg codec maintainers

2015-09-18 Thread Andrzej Pietrasiewicz
Add Andrzej Pietrasiewicz and Jacek Anaszewski as maintainers of drivers/media/platform/s5p-jpeg. Signed-off-by: Andrzej Pietrasiewicz --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8133cef..ee9240b 100644 ---

[PATCH 2/4] s5p-jpeg: add support for 5433

2015-09-18 Thread Andrzej Pietrasiewicz
JPEG IP found in Exynos5433 is similar to what is in Exynos4, but there are some subtle differences which this patch takes into account. The most important difference is in what is processed by the JPEG IP and what has to be provided to it. In case of 5433 the IP does not parse Huffman and

Re: [PATCH 1/4] s5p-jpeg: generalize clocks handling

2015-09-18 Thread Jacek Anaszewski
Hi Andrzej, Marek, On 09/18/2015 04:20 PM, Andrzej Pietrasiewicz wrote: From: Marek Szyprowski Allow jpeg codec variants declare clocks they need. Before this patch is applied jpeg-core gets jpeg->sclk "speculatively": if it is not there, we assume no problem. This

[PATCH 4/4] ARM64: dts: exynos5433: add jpeg node

2015-09-18 Thread Andrzej Pietrasiewicz
From: Marek Szyprowski Add Exynos 5433 jpeg h/w codec node. Signed-off-by: Marek Szyprowski Signed-off-by: Andrzej Pietrasiewicz --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 21 + 1 file

Re: [PATCH 3/4] MAINTAINERS: add exynos jpeg codec maintainers

2015-09-18 Thread Jacek Anaszewski
On 09/18/2015 04:20 PM, Andrzej Pietrasiewicz wrote: Add Andrzej Pietrasiewicz and Jacek Anaszewski as maintainers of drivers/media/platform/s5p-jpeg. Signed-off-by: Andrzej Pietrasiewicz --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git

Re: [PATCH 2/4] s5p-jpeg: add support for 5433

2015-09-18 Thread Jacek Anaszewski
Hi Andrzej, On 09/18/2015 04:20 PM, Andrzej Pietrasiewicz wrote: JPEG IP found in Exynos5433 is similar to what is in Exynos4, but there are some subtle differences which this patch takes into account. The most important difference is in what is processed by the JPEG IP and what has to be

Re: [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity

2015-09-18 Thread Guennadi Liakhovetski
Hi Nicolas, Patch handling is on my todo for the coming weekend... Thanks Guennadi On Fri, 18 Sep 2015, Nicolas Ferre wrote: > Le 04/08/2015 13:22, Laurent Pinchart a écrit : > > Hi Josh, > > > > Thank you for the patch. > > > > On Tuesday 04 August 2015 17:37:49 Josh Wu wrote: > >> This