[PATCH] tda10071: Fix dependency to REGMAP_I2C

Without I get this error for by dvb-card: tda10071: Unknown symbol devm_regmap_init_i2c (err 0) cx23885_dvb_register() dvb_register failed err = -22 cx23885_dev_setup() Failed to register dvb adapters on VID_B Signed-off-by: Matthias Schwarzott ---

media_build using regmap-i2c

Hi! I noticed for a media_build installation, that tda10071 was not loadable because regmap-i2c did not exist. The only way I saw to get regmap-i2c compiled, is to enable any other kernel module that has a "select REGMAP_I2C" in Kconfig. I choose "CONFIG_SENSORS_ADS7828=m". Maybe the kernel

Re: [PATCH 05/18] [media] media-controller: enable all interface links at init

Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 14:30:48 Mauro Carvalho Chehab wrote: > Interface links are normally enabled, meaning that the interfaces are > bound to the entities. So, any ioctl send to the interface are reflected s/send/sent/ > at the entities managed by the

Re: [PATCH] tda10071: Fix dependency to REGMAP_I2C

Moikka! Thank you for the patch! Usually these are nowadays found by automated build test, but for some reason not that one... On 11/23/2015 09:19 PM, Matthias Schwarzott wrote: Without I get this error for by dvb-card: tda10071: Unknown symbol devm_regmap_init_i2c (err 0)

Re: [PATCH 06/18] [media] media.h: create connector entities for hybrid TV devices

Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 14:30:49 Mauro Carvalho Chehab wrote: > Add entities to represent the connectors that exists inside a > hybrid TV device. > > Signed-off-by: Mauro Carvalho Chehab > > diff --git

Re: [PATCH 04/18] [media] media-device: supress backlinks at G_TOPOLOGY ioctl

Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 14:30:47 Mauro Carvalho Chehab wrote: > Due to the graph traversal algorithm currently in usage, we > need a copy of all data links. Those backlinks should not be > send to userspace, as otherwise, all links there will be >

Re: [PATCH 01/18] [media] tuner-core: add an input pad

Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 14:30:44 Mauro Carvalho Chehab wrote: > Tuners actually have at least one connector on its > input. > > Add a PAD to connect it. The patch looks fine to me, but have you checked that there are no driver instantiating a tuner that

Re: [PATCH v8 55/55] [media] media-entity.h: document all the structs

Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 09:03:14 Mauro Carvalho Chehab wrote: > Only a few structs are documented on kernel-doc-nano format > (the ones added by the MC next gen patches). > > Add a documentation for all structs, and ensure that they'll > be producing the

Re: [media-workshop] [PATCH v8.4 81/83] [media] media-entity: init pads on entity init if was registered before

Hello Laurent, On 11/23/2015 01:20 PM, Laurent Pinchart wrote: > Hi Javier, > > (Replying to linux-media instead of media-workshop, I can't find this patch > in > my linux-media folder) > > Thank you for the patch. > Thanks for your feedback. > On Monday 12 October 2015 13:44:10 Mauro

Re: Interrupt handler responsibility

On 11/21/2015 11:20 PM, Ran Shalit wrote: > Hello, > > I am trying to understand the interrupt handler responsibility in > v4l2, also with respect to dma usage. I see that it is not defined as > part of the videobuf2 API. > > This is what I understand this far: > 1. start_streaming is

Re: DVBSky T330 DVB-C regression Linux 4.1.12 to 4.3

Moikka! On 11/19/2015 01:36 AM, Stephan Eisvogel wrote: Hey Olli, Antti, culprit is: http://git.linuxtv.org/cgit.cgi/linux.git/commit/drivers/media/dvb-frontends/si2168.c?id=7adf99d20ce0e96a70755f452e3a63824b14060f I removed it like this: /* error bit set? */ /* if

[PATCH] [media] rc-core: Try loading modules if the kernel supports them

Always try to load modules for RC keymaps when the kernel supports modules, not just when the RC Core is build as a module. Fixes module autoloading issues when the core is builtin but the keymaps are not. Signed-off-by: Sjoerd Simons ---

Re: [PATCH v8 48/55] [media] media_device: add a topology version field

Hi Mauro and Hans, On Monday 31 August 2015 14:29:28 Hans Verkuil wrote: > On 08/30/2015 05:06 AM, Mauro Carvalho Chehab wrote: > > Every time a graph object is added or removed, the version > > of the topology changes. That's a requirement for the new > > MEDIA_IOC_G_TOPOLOGY, in order to allow

Re: [PATCH v8 49/55] [media] media-device: add support for MEDIA_IOC_G_TOPOLOGY ioctl

Hi Mauro, Thank you for the patch. Sakari and Hans have made several comments on this and the previous version of the same patch and I generally agree with them. I'll thus review the next version. On Sunday 06 September 2015 09:03:09 Mauro Carvalho Chehab wrote: > Add support for the new

Re: [PATCH v8 48/55] [media] media_device: add a topology version field

Hi Mauro, On Friday 04 September 2015 14:08:27 Mauro Carvalho Chehab wrote: > Em Mon, 31 Aug 2015 15:35:38 +0200 Hans Verkuil escreveu: > > On 08/31/2015 02:52 PM, Mauro Carvalho Chehab wrote: > >> Em Mon, 31 Aug 2015 14:29:28 +0200 Hans Verkuil escreveu: > >>> On 08/30/2015 05:06 AM, Mauro

Re: [PATCH v8 45/55] [media] media: Use a macro to interate between all interfaces

Hi Mauro, Thank you for the patch. In the subject line, s/interate between all/iterate over all/ On Sunday 06 September 2015 09:03:05 Mauro Carvalho Chehab wrote: > Just like we do with entities, use a similar macro for the > interfaces loop. > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH v8 47/55] [media] media-device: add pads and links to media_device

Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 09:03:07 Mauro Carvalho Chehab wrote: > The MC next gen API sends objects to userspace grouped by > their types. > > In the case of pads and links, in order to improve performance Are we sure it really improves performances ? >

Re: [PATCH v8 46/55] [media] media: move mdev list init to gobj

Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 09:03:06 Mauro Carvalho Chehab wrote: > Let's control the topology changes inside the graph_object. So, move the > addition and removal of interfaces/entities from the mdev lists to > media_gobj_init() and media_gobj_remove(). > >

Re: [PATCH v2] [media] move media platform data to linux/platform_data/media

On Tue, Nov 17, 2015 at 09:21:13AM -0200, Mauro Carvalho Chehab wrote: > Now that media has its own subdirectory inside platform_data, > let's move the headers that are already there to such subdir. > > After moving those files, the references were adjusted using this > script: > >

[PATCH] dtv-scan-tables: Add all muxes currently in use for Colombia.

Works for me in conjuction with the latest dvbv5-scan. -Dan --- dvb-t/co-All | 34 ++ 1 file changed, 34 insertions(+) create mode 100644 dvb-t/co-All diff --git a/dvb-t/co-All b/dvb-t/co-All new file mode 100644 index 000..c06056a --- /dev/null +++

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Nov 24 04:00:25 CET 2015 git branch: test git hash: 10897dacea26943dd80bd6629117f4620fc320ef gcc

Re: [PATCH 0/4] VSP1: Add support for lookup tables

On Mon, Nov 16, 2015 at 06:46:41AM +0200, Laurent Pinchart wrote: > Hello, > > The VSP1 includes two lookup table modules, a 1D LUT and a 3D cubic lookup > table (CLU). This patch series fixes the LUT implementation and adds support > for the CLU. > > The patches are based on top of > >

Re: [PATCH v8.2 19/55] [media] media: convert links from array to list

Hi Mauro, (Resending as I've replied by mistake to the version of the patch you had sent to the media workshop list only) Thank you for the patch. On Monday 12 October 2015 13:43:13 Mauro Carvalho Chehab wrote: > The entire logic that represent graph links were developed on a > time where

Re: [PATCH 1/2] [media] media: don't try to empty links list in media_entity_cleanup()

Hello Javier, (Resending as I've replied by mistake to the version of the patch you had sent to the media workshop list only) Thank you for the patch. On Monday 12 October 2015 13:44:11 Mauro Carvalho Chehab wrote: > From: Javier Martinez Canillas > > The

Re: [media-workshop] [PATCH v8.4 81/83] [media] media-entity: init pads on entity init if was registered before

Hi Javier, (Replying to linux-media instead of media-workshop, I can't find this patch in my linux-media folder) Thank you for the patch. On Monday 12 October 2015 13:44:10 Mauro Carvalho Chehab wrote: > From: Javier Martinez Canillas > > If an entity is registered

Re: [PATCH v8.2 19/55] [media] media: convert links from array to list

Em Mon, 23 Nov 2015 17:37:54 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > (Resending as I've replied by mistake to the version of the patch you had > sent > to the media workshop list only) (resending my answer to your previously sent review to the WS

Re: [PATCH 2/2] [media] media-device: use unsigned ints on some places

Hi Mauro, Thank you for the patch. On Wednesday 09 September 2015 08:32:03 Mauro Carvalho Chehab wrote: > The entity->num_pads are defined as u16. So, better to use an > unsigned int, as this prevents additional warnings when W=2 > (or W=1 on some architectures). > > The "i" counter at

Re: [PATCH 1/2] [media] media_entity: remove gfp_flags argument

Hi Mauro, Thank you for the patch. On Wednesday 09 September 2015 08:32:02 Mauro Carvalho Chehab wrote: > We should not be creating device nodes at IRQ contexts. So, > the only flags we'll be using will be GFP_KERNEL. Let's > remove the gfp_flags, in order to make the interface simpler. > > If

Re: [PATCH v8 17/55] [media] omap3isp: separate links creation from entities init

Hello Laurent, On 11/23/2015 12:55 PM, Laurent Pinchart wrote: > Hi Javier and Mauro, > > Thank you for the patch. > Thanks for your feedback. > On Monday 12 October 2015 13:43:05 Mauro Carvalho Chehab wrote: >> From: Javier Martinez Canillas >> >> The omap3isp driver

Re: [PATCH 14/18] [media] media-device: export the entity function via new ioctl

Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 14:30:57 Mauro Carvalho Chehab wrote: > Now that entities have a main function, expose it via > MEDIA_IOC_G_TOPOLOGY ioctl. > > Signed-off-by: Mauro Carvalho Chehab > > diff --git

Re: [PATCH 12/18] [media] media-entity: must check media_create_pad_link()

Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 14:30:55 Mauro Carvalho Chehab wrote: > Drivers should check if media_create_pad_link() actually > worked. > > Signed-off-by: Mauro Carvalho Chehab > > diff --git a/include/media/media-entity.h

Re: [PATCH 13/18] [media] media-entity.h: rename entity.type to entity.function

Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 14:30:56 Mauro Carvalho Chehab wrote: > Entities should have one or more functions. Calling it as a > type proofed to not be correct, as an entity could eventually s/proofed/proved/ > have more than one type. > > So, rename the

Re: [PATCH v8 17/55] [media] omap3isp: separate links creation from entities init

Hi Javier and Mauro, Thank you for the patch. On Monday 12 October 2015 13:43:05 Mauro Carvalho Chehab wrote: > From: Javier Martinez Canillas > > The omap3isp driver initializes the entities and creates the pads links > before the entities are registered with the media

Re: [PATCH v8 53/55] [media] v4l2-core: create MC interfaces for devnodes

Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 09:03:13 Mauro Carvalho Chehab wrote: > V4L2 device (and subdevice) nodes should create an interface, if the > Media Controller support is enabled. > > Please notice that radio devices should not create an entity, as radio >

Re: [PATCH v8 52/55] [media] media-device: remove interfaces and interface links

Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 09:03:12 Mauro Carvalho Chehab wrote: > Just like what's done with entities, when the media controller is > unregistered, release any interface and interface links that > might still be there. > > Signed-off-by: Mauro Carvalho

Re: [PATCH v8 50/55] [media] media-entity: unregister entity links

Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 09:03:10 Mauro Carvalho Chehab wrote: > Add functions to explicitly unregister all entity links. > This function is called automatically when an entity > link is destroyed. > > Signed-off-by: Mauro Carvalho Chehab