Re: [PATCH v2 3/3] [media] mt9v032: Add V4L2 controls for AEC and AGC

2015-12-15 Thread Laurent Pinchart
Hi Markus, Thank you for the patch. On Monday 14 December 2015 15:41:53 Markus Pargmann wrote: > This patch adds V4L2 controls for Auto Exposure Control and Auto Gain > Control settings. These settings include low pass filter, update > frequency of these settings and the update interval for those

cron job: media_tree daily build: WARNINGS

2015-12-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Dec 16 04:00:15 CET 2015 git branch: test git hash: 52d60eb7e6d6429a766ea1b8f67e01c3b2dcd3c5 gcc versio

Re: [PATCH v2 03/22] media: Add an API to manage entity enumerations

2015-12-15 Thread Sakari Ailus
Hi Mauro, On Sun, Dec 13, 2015 at 10:54:57PM -0200, Mauro Carvalho Chehab wrote: > > >> +e->idx_max = idx_max; > > >> + > > >> +return 0; > > >> +} > > >> +EXPORT_SYMBOL_GPL(__media_entity_enum_init); > > >> + > > >> +/** > > >> + * media_entity_enum_cleanup - Release resources of

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 11:00 AM, Gustavo Padovan wrote: > 2015-12-15 Daniel Vetter : > >> On Mon, Dec 14, 2015 at 05:29:55PM -0800, Dmitry Torokhov wrote: >> > Userspace can close the sync device while there are still active fence >> > points, in which case kernel produces the following warning:

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Gustavo Padovan
2015-12-15 Daniel Vetter : > On Mon, Dec 14, 2015 at 05:29:55PM -0800, Dmitry Torokhov wrote: > > Userspace can close the sync device while there are still active fence > > points, in which case kernel produces the following warning: > > > > [ 43.853176] [ cut here ] > >

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 5:30 AM, Gustavo Padovan wrote: > 2015-12-14 Dmitry Torokhov : > >> Userspace can close the sync device while there are still active fence >> points, in which case kernel produces the following warning: >> >> [ 43.853176] [ cut here ] >> [ 43.857

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 5:50 AM, Frank Binns wrote: > Is this not the issue fixed by 8e43c9c75? No because if we start teardown without waiting for the fence to be signaled it will still be on the active_list. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 1:26 AM, Daniel Vetter wrote: > On Mon, Dec 14, 2015 at 05:29:55PM -0800, Dmitry Torokhov wrote: >> Userspace can close the sync device while there are still active fence >> points, in which case kernel produces the following warning: >> >> [ 43.853176] [ cut

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 2:01 AM, Maarten Lankhorst wrote: > Op 15-12-15 om 02:29 schreef Dmitry Torokhov: >> Userspace can close the sync device while there are still active fence >> points, in which case kernel produces the following warning: >> >> [ 43.853176] [ cut here ]-

[PATCH] V4L: add Y12I, Y8I and Z16 pixel format documentation

2015-12-15 Thread Guennadi Liakhovetski
Add documentation for 3 formats, used by RealSense cameras like R200. Signed-off-by: Guennadi Liakhovetski --- Documentation/DocBook/media/v4l/pixfmt-y12i.xml | 49 +++ Documentation/DocBook/media/v4l/pixfmt-y8i.xml | 80 + Documentation/DocBook/media/v4l/pix

Re: [Patch v5 1/2] media: v4l: ti-vpe: Add CAL v4l2 camera capture driver

2015-12-15 Thread Mauro Carvalho Chehab
Em Fri, 11 Dec 2015 16:16:33 -0600 Benoit Parrot escreveu: > Mauro Carvalho Chehab wrote on Thu [2015-Dec-03 > 11:19:22 -0200]: > > Em Wed, 18 Nov 2015 14:47:11 -0600 > > Benoit Parrot escreveu: > > > > > The Camera Adaptation Layer (CAL) is a block which consists of a dual > > > port CSI2/MI

Re: [PATCH v2 6/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

2015-12-15 Thread Hans Verkuil
On 12/15/15 14:51, tiffany lin wrote: > Hi Hans, > > Thanks for your time. > > On Mon, 2015-12-14 at 13:50 +0100, Hans Verkuil wrote: >> Hi Tiffany, >> >> My apologies for the long delay, but I finally have time to do a review of >> this >> code. >> >> On 12/11/2015 10:55 AM, Tiffany Lin wrote

Re: [PATCH v2 6/8] [Media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver

2015-12-15 Thread tiffany lin
Hi Hans, Thanks for your time. On Mon, 2015-12-14 at 13:50 +0100, Hans Verkuil wrote: > Hi Tiffany, > > My apologies for the long delay, but I finally have time to do a review of > this > code. > > On 12/11/2015 10:55 AM, Tiffany Lin wrote: > > From: Andrew-CT Chen > > > > Add v4l2 layer enc

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Frank Binns
Is this not the issue fixed by 8e43c9c75? Thanks Frank On 15/12/15 13:30, Gustavo Padovan wrote: > 2015-12-14 Dmitry Torokhov : > >> Userspace can close the sync device while there are still active fence >> points, in which case kernel produces the following warning: >> >> [ 43.853176]

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Gustavo Padovan
2015-12-14 Dmitry Torokhov : > Userspace can close the sync device while there are still active fence > points, in which case kernel produces the following warning: > > [ 43.853176] [ cut here ] > [ 43.857834] WARNING: CPU: 0 PID: 892 at > /mnt/host/source/src/third_p

[PATCH v2] [media] media-device: handle errors at media_device_init()

2015-12-15 Thread Mauro Carvalho Chehab
Changeset 43ac4401dca9 ("[media] media-device: split media initialization and registration") broke media device register into two separate functions, but introduced a BUG_ON() and made media_device_init() void. It also introduced several warnings. Instead of adding BUG_ON(), let's revert to WARN_O

[PATCH] [media] media-device: handle errors at media_device_init()

2015-12-15 Thread Mauro Carvalho Chehab
Changeset 43ac4401dca9 ("[media] media-device: split media initialization and registration") broke media device register into two separate functions, but introduced a BUG_ON() and made media_device_init() void. It also introduced several warnings. Instead of adding BUG_ON(), let's revert to WARN_O

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-12-15 Thread Mauro Carvalho Chehab
Em Thu, 10 Sep 2015 20:14:04 +0300 Sakari Ailus escreveu: > Hi Javier, > > Thanks for the set! A few comments below. > > Javier Martinez Canillas wrote: > > The media device node is registered and so made visible to user-space > > before entities are registered and links created which means tha

[patch] [media] v4l2-device: fix a missing error code

2015-12-15 Thread Dan Carpenter
We need to set "err = -ENOMEM" here. Fixes: 38b11f19667a ('[media] v4l2-core: create MC interfaces for devnodes') Signed-off-by: Dan Carpenter diff --git a/drivers/media/v4l2-core/v4l2-device.c b/drivers/media/v4l2-core/v4l2-device.c index 85f724b..85b1e98 100644 --- a/drivers/media/v4l2-core/v

[patch] [media] media-device: copy_to/from_user() returns positive

2015-12-15 Thread Dan Carpenter
The copy_to/from_user() functions return the number of bytes *not* copied. They don't return error codes. Fixes: 4f6b3f363475 ('media] media-device: add support for MEDIA_IOC_G_TOPOLOGY ioctl') Signed-off-by: Dan Carpenter diff --git a/drivers/media/media-device.c b/drivers/media/media-device.

[PATCH 1/2] [media] media-device: move media entity register/unregister functions

2015-12-15 Thread Mauro Carvalho Chehab
media entity register and unregister functions are called by media device register/unregister. Move them to occur earlier, as we'll need an unlocked version of media_device_entity_unregister() and we don't want to add a function prototype without needing it. No functional changes. Signed-off-by:

[PATCH 2/2] [media] media-device: better lock media_device_unregister()

2015-12-15 Thread Mauro Carvalho Chehab
If media_device_unregister() is called by two different drivers, a race condition may happen, as the check if the device is not registered is not protected. Move the spin_lock() to happen earlier in the function, in order to prevent such race condition. Reported-by: Shuah Khan Signed-off-by: Mau

Re: [PATCH v5 1/3] [media] media-device: check before unregister if mdev was registered

2015-12-15 Thread Mauro Carvalho Chehab
Em Fri, 11 Dec 2015 16:36:27 -0700 Shuah Khan escreveu: > On 12/11/2015 03:57 PM, Javier Martinez Canillas wrote: > > Most media functions that unregister, check if the corresponding register > > function succeed before. So these functions can safely be called even if a > > registration was never

Re: [RFC PATCH] vb2: Stop allocating 'alloc_ctx', just set the device instead

2015-12-15 Thread Marek Szyprowski
Hello, On 2015-12-15 11:14, Hans Verkuil wrote: On 12/15/15 11:01, Marek Szyprowski wrote: On 2015-12-14 16:40, Laurent Pinchart wrote: On Monday 14 December 2015 15:36:04 Hans Verkuil wrote: (Before I post this as the 'final' patch and CC all the driver developers that are affected, I'd like

Fw: [PATCH 2/2] [media] media-entity: cache media_device on object removal

2015-12-15 Thread Mauro Carvalho Chehab
Hi Dan, This were supposed to be C/C to you. Thanks and Regards, Mauro Forwarded message: Date: Tue, 15 Dec 2015 08:08:39 -0200 From: Mauro Carvalho Chehab To: Cc: Mauro Carvalho Chehab , Linux Media Mailing List , Mauro Carvalho Chehab Subject: [PATCH 2/2] [media] media-entity: cache media

Re: [RFC PATCH] vb2: Stop allocating 'alloc_ctx', just set the device instead

2015-12-15 Thread Hans Verkuil
On 12/15/15 11:01, Marek Szyprowski wrote: > Hello, > > On 2015-12-14 16:40, Laurent Pinchart wrote: >> Hi Hans, >> >> On Monday 14 December 2015 15:36:04 Hans Verkuil wrote: >>> (Before I post this as the 'final' patch and CC all the driver developers >>> that are affected, I'd like to do an RFC

[PATCH 2/2] [media] media-entity: cache media_device on object removal

2015-12-15 Thread Mauro Carvalho Chehab
As pointed by Dan, the patch f8fd4c61b5ae: "[media] media-entity: protect object creation/removal using spin lock" leads to the following static checker warning: drivers/media/media-entity.c:781 media_remove_intf_link() error: dereferencing freed memory 'link' drivers/media/media-

[PATCH 1/2] [media] media-entity: use mutes for link setup

2015-12-15 Thread Mauro Carvalho Chehab
Changeset f8fd4c61b5ae ("[media] media-entity: protect object creation/removal using spin lock") changed the object creation/removal protection to spin lock, as this is what's used on media-device, keeping the mutex reserved for graph traversal routines. However, it also changed the link setup, by

[patch] [media] media_entity: logical vs bitwise AND typo

2015-12-15 Thread Dan Carpenter
This was obviously supposed to be a bitwise AND. Fixes: 403da6ca3465 ('[media] media: move MEDIA_LNK_FL_INTERFACE_LINK logic to link creation') Signed-off-by: Dan Carpenter diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c index 7895e17..6926e06 100644 --- a/drivers/media

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Maarten Lankhorst
Op 15-12-15 om 02:29 schreef Dmitry Torokhov: > Userspace can close the sync device while there are still active fence > points, in which case kernel produces the following warning: > > [ 43.853176] [ cut here ] > [ 43.857834] WARNING: CPU: 0 PID: 892 at > /mnt/host/sou

Re: [RFC PATCH] vb2: Stop allocating 'alloc_ctx', just set the device instead

2015-12-15 Thread Marek Szyprowski
Hello, On 2015-12-14 16:40, Laurent Pinchart wrote: Hi Hans, On Monday 14 December 2015 15:36:04 Hans Verkuil wrote: (Before I post this as the 'final' patch and CC all the driver developers that are affected, I'd like to do an RFC post first. I always hated the alloc context for obfuscating w

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Daniel Vetter
On Mon, Dec 14, 2015 at 05:29:55PM -0800, Dmitry Torokhov wrote: > Userspace can close the sync device while there are still active fence > points, in which case kernel produces the following warning: > > [ 43.853176] [ cut here ] > [ 43.857834] WARNING: CPU: 0 PID: 892

Re: [PATCH v2 1/3] [media] mt9v032: Add reset and standby gpios

2015-12-15 Thread Markus Pargmann
Hi, On Monday 14 December 2015 21:26:25 Laurent Pinchart wrote: > Hi Markus, > > Thank you for the patch. > > On Monday 14 December 2015 15:41:51 Markus Pargmann wrote: > > Add optional reset and standby gpios. The reset gpio is used to reset > > the chip in power_on(). > > > > The standby gpio

Re: [PATCH v2 4/7] media: vb2-dma-contig: add helper for setting dma max seg size

2015-12-15 Thread Marek Szyprowski
Hi Laurent, On 2015-12-14 16:50, Laurent Pinchart wrote: Hi Marek, On Monday 14 December 2015 10:20:22 Marek Szyprowski wrote: On 2015-12-13 20:57, Laurent Pinchart wrote: On Wednesday 09 December 2015 14:58:19 Marek Szyprowski wrote: Add a helper function for device drivers to set DMA's max

Re: [PATCH v2 5/8] arm64: dts: mediatek: Add Video Encoder for MT8173

2015-12-15 Thread tiffany lin
Hi Matthias, On Mon, 2015-12-14 at 19:18 +0100, Matthias Brugger wrote: > On Friday 11 Dec 2015 17:55:40 Tiffany Lin wrote: > > Add video encoder node for MT8173 > > > > Signed-off-by: Tiffany Lin > > --- > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 47 > > ++ 1 f

Re: [PATCH v2 4/8] dt-bindings: Add a binding for Mediatek Video Encoder

2015-12-15 Thread tiffany lin
Hi Matthias, On Mon, 2015-12-14 at 12:36 +0100, Matthias Brugger wrote: > > On 14/12/15 09:26, tiffany lin wrote: > > On Fri, 2015-12-11 at 11:29 -0600, Rob Herring wrote: > >> On Fri, Dec 11, 2015 at 05:55:39PM +0800, Tiffany Lin wrote: > >>> Add a DT binding documentation of Video Encoder for