On Thu, 8 Sep 2016, Andrey Utkin wrote:
> Thanks for looking into this.
> I have tested that it compiles and passes checks (C=2) cleanly after
> this patch.
>
> Acked-by: Andrey Utkin
>
> While we're at it, what about constification of
> *-core.c:static struct
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Thu Sep 8 04:00:15 CEST 2016
git branch: test
git hash: 036bbb8213ecca49799217f30497dc0484178e53
gcc
Thanks for looking into this.
I have tested that it compiles and passes checks (C=2) cleanly after
this patch.
Acked-by: Andrey Utkin
While we're at it, what about constification of
*-core.c:static struct pci_driver *_pci_driver = {
*-video.c:static struct
Check for snd_pcm_ops structures that are only stored in the ops field of a
snd_soc_platform_driver structure or passed as the third argument to
snd_pcm_set_ops. The corresponding field or parameter is declared const,
so snd_pcm_ops structures that have this property can be declared as const
Check for snd_pcm_ops structures that are only stored in the ops field of a
snd_soc_platform_driver structure or passed as the third argument to
snd_pcm_set_ops. The corresponding field or parameter is declared const,
so snd_pcm_ops structures that have this property can be declared as const
From: Geert Uytterhoeven
drivers/media/platform/rcar_fdp1.c:1972:2: warning: initialization from
incompatible pointer type
.queue_setup = fdp1_queue_setup,
^
drivers/media/platform/rcar_fdp1.c:1972:2: warning: (near initialization
for
The structure is not used, remove it.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/rcar_fdp1.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/media/platform/rcar_fdp1.c
b/drivers/media/platform/rcar_fdp1.c
From: Kieran Bingham
The FCP must be powered up for the FDP1 to function, even when the FDP1
does not make use of the FCNL features. Extend the compatible list
to allow us to use the power domain and runtime-pm support.
Signed-off-by: Kieran Bingham
From: Kieran Bingham
The FDP1 driver performs advanced de-interlacing on a memory 2 memory
based video stream, and supports conversion from YCbCr/YUV
to RGB pixel formats
Signed-off-by: Kieran Bingham
---
MAINTAINERS|9 +
- Constify data tables
- Add missing break in switch statement
- Use struct video_device::device_caps
- Don't set read-only flag manually for V4L2_CID_MIN_BUFFERS_FOR_CAPTURE
- Use V4L2_YCBCR_ENC_709 instead of V4L2_COLORSPACE_REC709 for ycbcr_enc
- Fix handling of V4L2_FIELD_INTERLACED
- Use the
Hello,
Here's the third version of the Renesas R-Car FDP1 driver.
The FDP1 (Fine Display Processor) is a hardware memory-to-memory de-interlacer
device, with capability to convert from various YCbCr/YUV formats to both
YCbCr/YUV and RGB formats at the same time as converting interlaced content
The menu control selects the operation mode of a video deinterlacer. The
menu entries are driver specific.
Signed-off-by: Laurent Pinchart
---
Documentation/media/uapi/v4l/extended-controls.rst | 4
drivers/media/v4l2-core/v4l2-ctrls.c
Ensure that the buffer field matches the field configured for the
format.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/rcar_fdp1.c | 40 +++---
1 file changed, 33 insertions(+), 7 deletions(-)
diff --git
The handling of the TRY_FMT and S_FMT ioctls isn't correct. In
particular, the sink format isn't propagated to the source format
automatically, the strides are not computed when the device is opened,
and the colorspace handling is wrong.
Rewrite the implementation.
Signed-off-by: Laurent
The struct fdp1_buffer instances are allocated separately from the vb2
buffers, with one instance per field. Simplify the allocation by
splitting the fdp1_buffer structure in per-buffer and per-field data,
and let vb2 allocate the the fdp1_buffer structure.
Signed-off-by: Laurent Pinchart
The S_FMT and TRY_FMT handlers in multiplane mode attempt at clearing
the reserved fields of the v4l2_format structure after the pix_mp
member. However, the reserved fields are inside pix_mp, not after it.
Signed-off-by: Laurent Pinchart
Tested-by:
On Thu, Sep 1, 2016 at 1:47 PM, Wolfram Sang wrote:
> On Thu, Sep 01, 2016 at 01:39:16PM +0200, Sylwester Nawrocki wrote:
>> Since commit 04f59143b571161d25315dd52d7a2ecc022cb71a
>> ("i2c: let I2C masters ignore their children for PM")
>> the power.ignore_children flag is set
Hi!
> The driver used integers for what boolean would have been a better fit.
> Use boolean instead.
>
> Signed-off-by: Sakari Ailus
Acked-by: Pavel Machek
And... thanks :-).
Pavel
> It is broken (see below). Have you ever used dvbv5 tools with vdr format
> output or did you know a "VDR user" who is using dvbv5-scan and not wscan?
In my experience the v4l scanner, wscan, and VDR's internal scanner
has never worked well (for NA). I use nscan, which has easily been the
most
From: Colin Ian King
pdev is being null checked, however, prior to that it is being
dereferenced by platform_get_drvdata. Move the assignments of
vpu and run to after the pdev null check to avoid a potential
null pointer dereference.
Signed-off-by: Colin Ian King
Hi Niklas,
Thank you for the patch.
On Wednesday 07 Sep 2016 14:09:38 Niklas Söderlund wrote:
> The HGT is a Histogram Generator Two-Dimensions. It computes a weighted
> frequency histograms for hue and saturation areas over a configurable
> region of the image with optional subsampling.
>
>
The HGT is a Histogram Generator Two-Dimensions. It computes a weighted
frequency histograms for hue and saturation areas over a configurable
region of the image with optional subsampling.
Signed-off-by: Niklas Söderlund
---
The format is used on the R-Car VSP1 video queues that carry
2-D histogram statistics data.
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
---
Documentation/media/uapi/v4l/meta-formats.rst | 1 +
Hi,
This series add support for the VSP1 2-D histogram engine HGT.
It's based on top of Laurent Pinchart tree at
git://linuxtv.org/pinchartl/media.git hgo. And depends on Laurents patch
'[PATCH] v4l: vsp1: Move subdev operations from HGO to common histogram
code'.
It is tested on Koelsch using
Le 12/08/2016 à 15:17, Hans Verkuil a écrit :
> On 08/04/2016 05:39 PM, Charles-Antoine Couret wrote:
>
> A commit log is missing here.
Yeah I will fix that.
>> diff --git a/Documentation/media/uapi/v4l/vidioc-g-dv-timings.rst
>> b/Documentation/media/uapi/v4l/vidioc-g-dv-timings.rst
>> index
This adds core part of the vidc driver common helper functions
used by encoder and decoder specific files.
* core.c has implemented the platform dirver methods, file
operations and v4l2 registration.
* helpers.c has implemented common helper functions for:
- buffer management
- vb2_ops
Adds binding document for vidc video encoder/decoder driver
Cc: Rob Herring
Cc: Mark Rutland
Cc: devicet...@vger.kernel.org
Signed-off-by: Stanimir Varbanov
---
.../devicetree/bindings/media/qcom,vidc.txt| 61
Makefile and Kconfig files to build the video codec driver.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/Kconfig | 8
drivers/media/platform/qcom/Makefile | 6 ++
drivers/media/platform/qcom/vidc/Makefile | 15
One thing you need to add is a patch for the MAINTAINERS file. It needs
an entry for this new driver.
I think pretty much all new drivers I've reviewed recently forgot to update
that file :-(
Regards,
Hans
On 09/07/16 13:37, Stanimir Varbanov wrote:
Changes since v1:
-
This is the implementation of HFI. It is loaded with the
responsibility to comunicate with the firmware through an
interface commands and messages.
- hfi.c has interface functions used by the core, decoder
and encoder parts to comunicate with the firmware. For example
there are functions for
This consists of video decoder implementation plus decoder
controls.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/vidc/vdec.c | 1091 +
drivers/media/platform/qcom/vidc/vdec.h | 29 +
This adds encoder part of the driver plus encoder controls.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/vidc/venc.c | 1252 +
drivers/media/platform/qcom/vidc/venc.h | 29 +
Here is the implementation of Venus video accelerator low-level
functionality. It contanins code which setup the registers and
startup uthe processor, allocate and manipulates with the shared
memory used for sending commands and receiving messages.
Signed-off-by: Stanimir Varbanov
Changes since v1:
- s/ENOTSUPP/EINVAL in vidc_set_color_format()
- use video_device_alloc
- fill struct device pointer in vb2_queue_init instead of .setup_queue
- fill device_caps in struct video_device instead of .vidioc_querycap
- fill colorspace, ycbcr_enc, quantization and xfer_func
This adds changes in v4l2 platform directory to include the
vidc driver and show it in kernel config.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/Kconfig | 1 +
drivers/media/platform/Makefile | 1 +
2 files changed, 2 insertions(+)
diff --git
In addition to setting the ACK mask, also set the logical address mask
setting in the dongle. This is (and not the ACK mask) is persisted for
use in autonomous mode.
The logical address mask to use is deduced from the primary device type
in adap->log_addrs.
Signed-off-by: Johan Fjeldtvedt
Linux4Linux -> Video4Linux
Signed-off-by: Hans Verkuil
--
v1 had one diff too many :-)
---
diff --git a/Documentation/media/v4l-drivers/fourcc.rst
b/Documentation/media/v4l-drivers/fourcc.rst
index f7c8cef..9c82106 100644
---
Linux4Linux -> Video4Linux
Signed-off-by: Hans Verkuil
---
diff --git a/Documentation/media/v4l-drivers/fourcc.rst
b/Documentation/media/v4l-drivers/fourcc.rst
index f7c8cef..9c82106 100644
--- a/Documentation/media/v4l-drivers/fourcc.rst
+++
Define the number of pads explicitly in initialising the sub-devices.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git
Hi Niklas,
On Wednesday 07 Sep 2016 12:05:26 Niklas Söderlund wrote:
> On 2016-09-06 22:59:22 +0300, Laurent Pinchart wrote:
> > On Tuesday 06 Sep 2016 16:38:56 Niklas Söderlund wrote:
> >> The HGT is a Histogram Generator Two-Dimensions. It computes a weighted
> >> frequency histograms for hue
Simplify smiapp_init() by moving the initialisation of individual
sub-devices to a separate function.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 108 +++--
1 file changed, 49 insertions(+), 59 deletions(-)
The same pixel array size is required for the active format of each
sub-device sink pad and try format of each sink pad of each opened file
handle as well as for the native size rectangle.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 39
Initialise the sensor in probe. The reason why it wasn't previously done
in case of platform data was that the probe() of the driver that provided
the clock through the set_xclk() callback would need to finish before the
probe() function of the smiapp driver. The set_xclk() callback no longer
Remove the loop in sub-device registration and create each sub-device
explicitly instead.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 82 ++
1 file changed, 43 insertions(+), 39 deletions(-)
diff --git
Instead, calculate how much is needed and then allocate the memory
dynamically.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 24 ++--
drivers/media/i2c/smiapp/smiapp.h | 8 ++--
2 files changed, 20
Hi,
This set further cleans up the smiapp driver and prepares for later
changes.
--
Kind regards,
Sakari
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
This allows determining the number of pads in the entity based on the
sensor.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/smiapp/smiapp-core.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
Hi Laurent,
Thanks for your review.
On 2016-09-06 22:59:22 +0300, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Tuesday 06 Sep 2016 16:38:56 Niklas Söderlund wrote:
> > The HGT is a Histogram Generator Two-Dimensions. It computes a weighted
> > frequency histograms
Hi Hans,
I am testing the patch for x86 and I manage to allocate buffer through
dma-contig. New patch is coming soon including your previous work and
work from Philipp Zabel all rebased on media_tree master branch.
BR
Vincent
On 09/02/2016 05:20 PM, Hans Verkuil wrote:
> Hi Vincent,
>
> On
The function is defined in a header file when HAVE_DVBV5_REMOTE is not
set. It needs to be marked as static inline.
Signed-off-by: Laurent Pinchart
---
lib/include/libdvbv5/dvb-dev.h | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git
Am 06.09.2016 um 17:47 schrieb Mauro Carvalho Chehab :
> Em Tue, 6 Sep 2016 08:16:22 -0700
> VDR User escreveu:
>
>> I can tell you that people do still use VDR-1.6.0-3. It would be
>> unwise (and unnecessary) to break backwards compatible, which
On 09/07/16 08:56, Tiffany Lin wrote:
Add V4L2_PIX_FMT_MT21C documentation
Signed-off-by: Tiffany Lin
---
Documentation/media/uapi/v4l/pixfmt-reserved.rst |6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst
Hi Hans,
On 09/05/2016 05:47 PM, Hans Verkuil wrote:
> On 08/22/2016 03:13 PM, Stanimir Varbanov wrote:
>> This patchset introduces a basic support for Qualcomm video
>> acceleration hardware used for video stream decoding/encoding.
>> The video IP can found on various qcom SoCs like apq8084,
Hi Mauro,
These patches add support for HSV.
HSV formats are extremely useful for image segmentation. This set of
patches makes v4l2 aware of this kind of formats.
Vivid changes have been divided to ease the reviewing process.
We are working on patches for Gstreamer and OpenCV that will make
version 9 changes:
- rebased on 4.8-rc5
- struct dma_attrs doesn't exist anymore so update CMA allocator
to compile with new dma_*_attr functions
- add example SMAF use case in cover letter
version 8 changes:
- rework of the structures used within ioctl
by adding a version field and
This module is allow testing secure calls of SMAF.
Signed-off-by: Benjamin Gaignard
---
drivers/smaf/Kconfig | 6 +++
drivers/smaf/Makefile | 1 +
drivers/smaf/smaf-testsecure.c | 90 ++
3 files changed,
SMAF CMA allocator implement helpers functions to allow SMAF
to allocate contiguous memory.
match() each if at least one of the attached devices have coherent_dma_mask
set to DMA_BIT_MASK(32).
For allocation it use dma_alloc_attrs() with DMA_ATTR_WRITE_COMBINE and not
dma_alloc_writecombine to
Secure Memory Allocation Framework goal is to be able
to allocate memory that can be securing.
There is so much ways to allocate and securing memory that SMAF
doesn't do it by itself but need help of additional modules.
To be sure to use the correct allocation method SMAF implement
deferred
Am 06.09.2016 um 17:55 schrieb Mauro Carvalho Chehab :
...
>> Sphinx has some more of these tuples with fixed length (remember
>> conf.py, the latex_documents settings) where IMHO hash/value pairs
>> (dicts) are more suitable.
>
> Well, the LaTeX stuff at conf.py seems to
Hi Laurent,
Thanks for your help with this. Good to see that the DU driver is
getting closer to work with the IPMMU hardware! Please see below for
some feedback from me.
On Fri, Aug 19, 2016 at 5:39 PM, Laurent Pinchart
wrote:
> Hello,
>
> This patch
On 08/18/16 16:33, Ricardo Ribalda Delgado wrote:
HSV formats are extremely useful for image segmentation. This set of
patches makes v4l2 aware of this kind of formats.
Vivid changes have been divided to ease the reviewing process.
We are working on patches for Gstreamer and OpenCV that will
On 08/22/16 11:28, Ricardo Ribalda Delgado wrote:
Some hardware maps the Hue between 0 and 255 instead of 0-179. Support
this format with a new field hsv_enc.
Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Hans Verkuil
---
v5_2:
On 09/07/16 02:14, Laurent Pinchart wrote:
Support both the HSV24 and HSV32 formats. From a hardware point of view
pretend the formats are RGB, the RPF and WPF will just pass the data
through without performing any processing.
Signed-off-by: Laurent Pinchart
From: Markus Heiser
Hi Jon,
according to your remarks I fixed the first and second patch. The third patch is
resend unchanged;
> Am 06.09.2016 um 14:28 schrieb Jonathan Corbet :
>
> As others have pointed out, we generally want to hide the difference
From: Markus Heiser
For function-like macros, sphinx creates 'FOO (C function)' entries.
With this patch 'FOO (C macro)' are created for function-like macros,
which is the same for object-like macros.
Signed-off-by: Markus Heiser
---
From: Markus Heiser
Handle signatures of function-like macros well. Don't try to deduce
arguments types of function-like macros.
Signed-off-by: Markus Heiser
---
Documentation/sphinx/cdomain.py | 55
From: Markus Heiser
The self.indexnode's tuple has changed in sphinx version 1.4, from a
former 4 element tuple to a 5 element tuple.
https://github.com/sphinx-doc/sphinx/commit/e6a5a3a92e938fcd75866b4227db9e0524d58f7c
Signed-off-by: Markus Heiser
Hi Laurent,
On Wed, Sep 7, 2016 at 9:09 AM, Laurent Pinchart
wrote:
>>
>> Signed-off-by: Ricardo Ribalda Delgado
>
> Do you mean Acked-by ?
Acked-by: Ricardo Ribalda Delgado
Ups, my bad
>
> Feel free
Hi Ricardo,
On Wednesday 07 Sep 2016 09:07:35 Ricardo Ribalda Delgado wrote:
> Hi Laurent
>
> Thank you very much!
You're welcome.
> On Wed, Sep 7, 2016 at 2:14 AM, Laurent Pinchart wrote:
> > Support both the HSV24 and HSV32 formats. From a hardware point of view
> > pretend the formats are
Add Tiffany Lin and Andrew-CT Chen as maintainers for
Mediatek MT8173 vcodec drivers
Signed-off-by: Tiffany Lin
Signed-off-by: Andrew-CT Chen
---
v3: Move MEDIATEK MEDIA DRIVER after MEDIATEK ETHERNET DRIVER to follow
alphabet sequence
Hi Laurent
Thank you very much!
On Wed, Sep 7, 2016 at 2:14 AM, Laurent Pinchart
wrote:
> Support both the HSV24 and HSV32 formats. From a hardware point of view
> pretend the formats are RGB, the RPF and WPF will just pass the data
> through without
Add V4L2_PIX_FMT_MT21C support
Signed-off-by: Tiffany Lin
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
This patch series add Mediatek compressed block format V4L2_PIX_FMT_MT21C, the
decoder driver will decoded bitstream to V4L2_PIX_FMT_MT21C format.
User space applications could use MT8173 MDP driver to convert
V4L2_PIX_FMT_MT21C to
V4L2_PIX_FMT_NV12M, V4L2_PIX_FMT_YUV420M and
Add video decoder node for MT8173
Signed-off-by: Tiffany Lin
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++
1 file changed, 44 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
Add V4L2_PIX_FMT_MT21C format used on MT8173 driver.
It is compressed format and need MT8173 MDP driver to transfer to other
standard format.
Signed-off-by: Tiffany Lin
---
drivers/media/v4l2-core/v4l2-ioctl.c |1 +
include/uapi/linux/videodev2.h |1 +
2
Add V4L2_PIX_FMT_MT21C documentation
Signed-off-by: Tiffany Lin
---
Documentation/media/uapi/v4l/pixfmt-reserved.rst |6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst
Add Tiffany Lin and Andrew-CT Chen as maintainers for
Mediatek MT8173 vcodec drivers
Signed-off-by: Tiffany Lin
Signed-off-by: Andrew-CT Chen
---
v2: Rename MT8173 MEDIA DRIVER to MEDIATEK MEDIA DRIVER
---
MAINTAINERS |9 +
1
This patch fix decoder compiler/sparse warnings
Signed-off-by: Tiffany Lin
---
.../media/platform/mtk-vcodec/vdec/vdec_h264_if.c |7 ---
.../media/platform/mtk-vcodec/vdec/vdec_vp8_if.c |1 +
.../media/platform/mtk-vcodec/vdec/vdec_vp9_if.c |4 ++--
On Tue, 2016-09-06 at 14:35 +0800, Tiffany Lin wrote:
> Add Tiffany Lin and Andrew-CT Chen as maintainers for
> Mediatek MT8173 vcodec drivers
>
> Signed-off-by: Tiffany Lin
> Signed-off-by: Andrew-CT Chen
> ---
> MAINTAINERS |9
79 matches
Mail list logo