Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

Hi Andi, Thank for your reminder. I will refine the code based on your work. to have elegant code and easy error handling. Sean On Fri, 2017-01-06 at 12:43 +0900, Andi Shyti wrote: > Hi Sean, > > > + ir->rc = rc_allocate_device(); > > Yes, you should use devm_rc_allocate_device(...) > >

Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

Hi Sean, Thanks for your effort for code reviewing. I add comments inline. On Thu, 2017-01-05 at 17:12 +, Sean Young wrote: > Hi Sean, > > Some review comments. > > On Fri, Jan 06, 2017 at 12:06:24AM +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > >

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Jan 6 05:00:09 CET 2017 media-tree git hash:40eca140c404505c09773d1c6685d818cb55ab1a media_build

Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

Hi Sean, > + ir->rc = rc_allocate_device(); Yes, you should use devm_rc_allocate_device(...) Besides, standing to this patch which is not in yet: https://lkml.org/lkml/2016/12/18/39 rc_allocate_device should provide the driver type during allocation, so it should be: ir->rc =

Re: [PATCH v6 3/3] arm: dts: mt2701: Add node for Mediatek JPEG Decoder

Hi Hans, The dependence on [1] has been merged in 4.10, but [2] has not.Do you have any idea about this patch series? Should we wait for [2] or we could merge the source code and dt-binding first? Best Regards, Rick On Wed, 2016-11-23 at 17:43 +0800, Rick Chang wrote: > On Wed, 2016-11-23 at

Re: Enabling peer to peer device transactions for PCIe devices

On Thu, Jan 05, 2017 at 05:30:34PM -0700, Jason Gunthorpe wrote: > On Thu, Jan 05, 2017 at 06:23:52PM -0500, Jerome Glisse wrote: > > > > I still don't understand what you driving at - you've said in both > > > cases a user VMA exists. > > > > In the former case no, there is no VMA directly but

Re: [PATCH v2 10/19] media: Add i.MX media core driver

On 01/04/2017 05:33 AM, Vladimir Zapolskiy wrote: Hi Steve, On 01/03/2017 10:57 PM, Steve Longerbeam wrote: Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 205 + v2 was sent

Re: Enabling peer to peer device transactions for PCIe devices

On 2017-01-05 07:30 PM, Jason Gunthorpe wrote: but I am opposed to the idea we need two API paths that the *driver* has to figure out. That is fundamentally not what I want as a driver developer. Give me a common API to convert '__user *' to a scatter list and pin the pages.

Re: Enabling peer to peer device transactions for PCIe devices

On Thu, Jan 05, 2017 at 06:23:52PM -0500, Jerome Glisse wrote: > > I still don't understand what you driving at - you've said in both > > cases a user VMA exists. > > In the former case no, there is no VMA directly but if you want one than > a device can provide one. But such VMA is useless as

Re: Enabling peer to peer device transactions for PCIe devices

On Thu, Jan 05, 2017 at 03:42:15PM -0700, Jason Gunthorpe wrote: > On Thu, Jan 05, 2017 at 03:19:36PM -0500, Jerome Glisse wrote: > > > > Always having a VMA changes the discussion - the question is how to > > > create a VMA that reprensents IO device memory, and how do DMA > > > consumers

Re: [PATCH v2 6/6] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT is set

On Thursday, January 5, 2017 4:35:33 PM CET Andrew F. Davis wrote: > On 01/05/2017 03:42 PM, Arnd Bergmann wrote: > > On Thursday, January 5, 2017 3:01:58 PM CET Andrew F. Davis wrote: > >> @@ -109,7 +109,8 @@ obj-$(CONFIG_SERIO) += input/serio/ > >> obj-$(CONFIG_GAMEPORT) +=

Re: Enabling peer to peer device transactions for PCIe devices

On Thu, Jan 05, 2017 at 03:19:36PM -0500, Jerome Glisse wrote: > > Always having a VMA changes the discussion - the question is how to > > create a VMA that reprensents IO device memory, and how do DMA > > consumers extract the correct information from that VMA to pass to the > > kernel DMA API

Re: [PATCH v2 6/6] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT is set

On 01/05/2017 03:42 PM, Arnd Bergmann wrote: > On Thursday, January 5, 2017 3:01:58 PM CET Andrew F. Davis wrote: >> @@ -109,7 +109,8 @@ obj-$(CONFIG_SERIO) += input/serio/ >> obj-$(CONFIG_GAMEPORT) += input/gameport/ >> obj-$(CONFIG_INPUT)+= input/ >>

Re: [PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

On 01/04/2017 04:33 AM, Vladimir Zapolskiy wrote: + + camera: ov5642@3c { ov5642: camera@3c done. + pwdn-gpios = < 16 GPIO_ACTIVE_HIGH>; /* SD1_DAT0 */ + reset-gpios = < 17 GPIO_ACTIVE_LOW>; /* SD1_DAT1 */ Comments about SD1_* pad names are redundant.

Re: [PATCH v2 09/19] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

On 01/04/2017 04:41 AM, Vladimir Zapolskiy wrote: On 01/03/2017 10:57 PM, Steve Longerbeam wrote: + + camera: adv7180@21 { adv7180: camera@21 done. + pinctrl_ipu1_csi0: ipu1grp-csi0 { Please rename node name to ipu1csi0grp. done. Steve -- To unsubscribe

Re: [PATCH v2 6/6] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT is set

On Thursday, January 5, 2017 3:01:58 PM CET Andrew F. Davis wrote: > @@ -109,7 +109,8 @@ obj-$(CONFIG_SERIO) += input/serio/ > obj-$(CONFIG_GAMEPORT) += input/gameport/ > obj-$(CONFIG_INPUT)+= input/ > obj-$(CONFIG_RTC_LIB) += rtc/ > -obj-y

Re: Enabling peer to peer device transactions for PCIe devices

On Thu, Jan 05, 2017 at 01:07:19PM -0700, Jason Gunthorpe wrote: > On Thu, Jan 05, 2017 at 02:54:24PM -0500, Jerome Glisse wrote: > > > Mellanox and NVidia support peer to peer with what they market a > > GPUDirect. It only works without IOMMU. It is probably not upstream : > > > >

Re: Enabling peer to peer device transactions for PCIe devices

On Thu, Jan 05, 2017 at 02:54:24PM -0500, Jerome Glisse wrote: > Mellanox and NVidia support peer to peer with what they market a > GPUDirect. It only works without IOMMU. It is probably not upstream : > > https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg21402.html > > I thought it

Re: Enabling peer to peer device transactions for PCIe devices

On Thu, Jan 05, 2017 at 12:01:13PM -0700, Jason Gunthorpe wrote: > On Thu, Jan 05, 2017 at 01:39:29PM -0500, Jerome Glisse wrote: > > > 1) peer-to-peer because of userspace specific API like NVidia GPU > > direct (AMD is pushing its own similar API i just can't remember > > marketing

Re: [PATCH v2 04/19] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

Hi Vladimir, On 01/04/2017 04:25 AM, Vladimir Zapolskiy wrote: Hi Steve, On 01/03/2017 10:57 PM, Steve Longerbeam wrote: Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. Both hang off the same i2c2 bus, so they require different (and non- default) i2c slave

Re: Enabling peer to peer device transactions for PCIe devices

On Thu, Jan 05, 2017 at 01:39:29PM -0500, Jerome Glisse wrote: > 1) peer-to-peer because of userspace specific API like NVidia GPU > direct (AMD is pushing its own similar API i just can't remember > marketing name). This does not happen through a vma, this happens > through

Re: Enabling peer to peer device transactions for PCIe devices

Sorry to revive this thread but it fells through my filters and i miss it. I have been going through it and i think the discussion has been hinder by the fact that distinct problems were merge while they should be address separately. First for peer-to-peer we need to be clear on how this happens.

Re: [PATCH v2 2/2] [media] v4l: Add 10/16-bits per channel YUV pixel formats

Hi Randy, On Thu, Jan 05, 2017 at 11:22:26PM +0800, ayaka wrote: > > > On 01/05/2017 06:30 PM, Sakari Ailus wrote: > >Hi Randy, > > > >Thanks for the update. > > > >On Thu, Jan 05, 2017 at 12:29:11AM +0800, Randy Li wrote: > >>The formats added by this patch are: > >>V4L2_PIX_FMT_P010 > >>

Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

Hi Sean, Some review comments. On Fri, Jan 06, 2017 at 12:06:24AM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > This patch adds driver for IR controller on > Mediatek MT7623 SoC. Currently testing successfully > on NEC and SONY remote controller only but it

[PATCH 1/2] Documentation: devicetree: Add document bindings for mtk-cir

From: Sean Wang This patch adds documentation for devicetree bindings for Mediatek IR controller. Signed-off-by: Sean Wang --- .../devicetree/bindings/media/mtk-cir.txt | 23 ++ 1 file changed, 23 insertions(+)

[PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

From: Sean Wang This patch adds driver for IR controller on Mediatek MT7623 SoC. Currently testing successfully on NEC and SONY remote controller only but it should work on others (lirc, rc-5 and rc-6). Signed-off-by: Sean Wang ---

[PATCH 0/2] media: rc: add support for IR receiver on MT7623 SoC

From: Sean Wang This patchset introduces Consumer IR (CIR) support for MT7623 SoC or other similar SoC and implements raw mode for more compatibility with different protocols. The driver simply reports the duration of pulses and spaces to rc core logic to decode. Sean

Re: [PATCH v2 2/2] [media] v4l: Add 10/16-bits per channel YUV pixel formats

On 01/05/2017 06:30 PM, Sakari Ailus wrote: Hi Randy, Thanks for the update. On Thu, Jan 05, 2017 at 12:29:11AM +0800, Randy Li wrote: The formats added by this patch are: V4L2_PIX_FMT_P010 V4L2_PIX_FMT_P010M V4L2_PIX_FMT_P016 V4L2_PIX_FMT_P016M Currently,

[PATCH] v4l: s5c73m3: fix negation operator

Bool values should be negated using logical operators. Using bitwise operators results in unexpected and possibly incorrect results. Reported-by: David Binderman Signed-off-by: Andrzej Hajda --- drivers/media/i2c/s5c73m3/s5c73m3-ctrls.c | 2 +- 1 file

Re: [PATCH v2 2/2] [media] v4l: Add 10/16-bits per channel YUV pixel formats

Hi Randy, Thanks for the update. On Thu, Jan 05, 2017 at 12:29:11AM +0800, Randy Li wrote: > The formats added by this patch are: > V4L2_PIX_FMT_P010 > V4L2_PIX_FMT_P010M > V4L2_PIX_FMT_P016 > V4L2_PIX_FMT_P016M > Currently, none of driver uses those format, but some

[GIT FIXES FOR v4.10] Media entity enumeration entity type fix

Hi Mauro, The big Media controller changes seem to have broken media entity type reporting in MEDIA_IOC_ENUM_ENTITIES IOCTL for non-device node types. No-one seems to have noticed until now. Stable is cc'd (for v4.5 and up). Please pull. The following changes since commit