cron job: media_tree daily build: ERRORS

2017-02-02 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Feb 3 05:00:16 CET 2017 media-tree git hash:e7b3a2b22176d01db0c3b31d6389ccf542ba1967 media_build

Re: ir-keytable: infinite loops, segfaults

2017-02-02 Thread Sean Young
Hi Vincent, On Thu, Feb 02, 2017 at 10:18:52PM +1100, Vincent McIntyre wrote: > On 11/30/16, Vincent McIntyre wrote: > > On Sun, Nov 27, 2016 at 07:35:10PM +, Sean Young wrote: > >> > >> > I wanted to mention that the IR protocol is still showing as unknown. > >>

Hello Forgive My Intrusion From Silvia.

2017-02-02 Thread Silviana Olander
Hello Friend, I'm Silviana Olander and I'm Swede. I found your email contact while surfing the Internet. I don't think you have a clue but my reason for writing you is to seek your friendship! Just being adventurous and decided to use this letter as a resource tool to get your attention.As

[PATCH] [media] mce_kbd: add missing keys from UK layout

2017-02-02 Thread Sean Young
The UK layout of the Microsoft Remote Keyboard has two missing keys: the hash key, and the messenger key which is sent using rc6 mce. Signed-off-by: Sean Young --- drivers/media/rc/ir-mce_kbd-decoder.c | 2 +- drivers/media/rc/keymaps/rc-rc6-mce.c | 1 + 2 files changed, 2

[PATCH] [media] lirc: cannot read from tx-only device

2017-02-02 Thread Sean Young
Bail out early, otherwise we follow a null pointer. Signed-off-by: Sean Young --- drivers/media/rc/lirc_dev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c index 0030ce0..a54ca53 100644 ---

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-02-02 Thread Russell King - ARM Linux
On Fri, Jan 06, 2017 at 06:11:34PM -0800, Steve Longerbeam wrote: > +/* register an internal subdev as a platform device */ > +static struct imx_media_subdev * > +add_internal_subdev(struct imx_media_dev *imxmd, > + const struct internal_subdev *isd, > + int ipu_id)

Re: [PATCH v3 16/24] media: Add i.MX media core driver

2017-02-02 Thread Russell King - ARM Linux
On Fri, Jan 06, 2017 at 06:11:34PM -0800, Steve Longerbeam wrote: > +struct imx_media_dev { > + struct media_device md; > + struct v4l2_device v4l2_dev; This is similarly buggy. struct v4l2_device { struct device *dev; #if defined(CONFIG_MEDIA_CONTROLLER) struct

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

2017-02-02 Thread Russell King - ARM Linux
On Fri, Jan 06, 2017 at 06:11:38PM -0800, Steve Longerbeam wrote: > +struct camif_priv { > + struct device *dev; > + struct video_devicevfd; You can't do this. > +static struct video_device camif_videodev = { > + .fops = _fops, > + .ioctl_ops =

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-02 Thread Russell King - ARM Linux
On Thu, Feb 02, 2017 at 11:12:41AM -0800, Steve Longerbeam wrote: > Here is the current .queue_setup() op in imx-media-capture.c: > > static int capture_queue_setup(struct vb2_queue *vq, >unsigned int *nbuffers, >unsigned int

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-02 Thread Steve Longerbeam
On 02/02/2017 10:58 AM, Russell King - ARM Linux wrote: On Thu, Feb 02, 2017 at 10:26:55AM -0800, Steve Longerbeam wrote: On 02/02/2017 09:56 AM, Russell King - ARM Linux wrote: and for whatever reason we end up falling out through free_ring. This is VERY bad news, because it means that the

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-02 Thread Russell King - ARM Linux
On Thu, Feb 02, 2017 at 10:26:55AM -0800, Steve Longerbeam wrote: > On 02/02/2017 09:56 AM, Russell King - ARM Linux wrote: > >and for whatever reason we end up falling out through free_ring. This > >is VERY bad news, because it means that the ring which SMFC took a copy > >of is now freed

Re: metadata node

2017-02-02 Thread Guennadi Liakhovetski
Hi Stanimir, On Mon, 30 Jan 2017, Stanimir Varbanov wrote: > Hi Guennadi, > > On 01/11/2017 11:42 AM, Guennadi Liakhovetski wrote: [snip] > > In any case, _if_ we do keep the current approach of separate /dev/video* > > nodes, we need a way to associate video and metadata nodes. Earlier I >

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-02 Thread Steve Longerbeam
On 02/02/2017 09:56 AM, Russell King - ARM Linux wrote: On Thu, Feb 02, 2017 at 05:22:46PM +, Russell King - ARM Linux wrote: I thought, maybe, it's the IPU overwriting past the end of the buffer, but I've added checks and that doesn't seem to have fired. I also wondered if it was some

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-02 Thread Russell King - ARM Linux
On Thu, Feb 02, 2017 at 05:22:46PM +, Russell King - ARM Linux wrote: > I thought, maybe, it's the IPU overwriting past the end of the buffer, > but I've added checks and that doesn't seem to have fired. I also > wondered if it was some kind of use-after-free of the ring, so I made >

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-02 Thread Steve Longerbeam
Hi Russell, I don't recommend spending too much time debugging this OOPS. The dma buffer ring has been removed completely in version 4 (which I'm trying to get ready to post hopefully by end of this week). Steve On 02/02/2017 09:22 AM, Russell King - ARM Linux wrote: I seem to be getting

Re: [PATCH v3 00/24] i.MX Media Driver

2017-02-02 Thread Russell King - ARM Linux
I seem to be getting some sort of memory corruption with this driver. I've had two instances now of uninitialised spinlocks in imx_media_dma_buf_get_active() which show that the spinlock being taken in this function is all-zeros. That very quickly leads to an oops, where I've seen buf->ring is

Re: [PATCH v7 2/2] media: Add a driver for the ov5645 camera sensor.

2017-02-02 Thread Todor Tomov
Hi, Just to point it here - there is one more one-line correction needed below: On 11/14/2016 12:24 PM, Todor Tomov wrote: > The ov5645 sensor from Omnivision supports up to 2592x1944 > and CSI2 interface. > > The driver adds support for the following modes: > - 1280x960 > - 1920x1080 > -

Re: [STLinux Kernel] [PATCH v6 02/10] ARM: dts: STiH410: add DELTA dt node

2017-02-02 Thread Hugues FRUCHET
Hi Peter, This is now fixed in v7. Best regards, Hugues. On 02/01/2017 07:37 PM, Peter Griffin wrote: > On Wed, 01 Feb 2017, Hugues Fruchet wrote: > >> This patch adds DT node for STMicroelectronics >> DELTA V4L2 video decoder >> >> Signed-off-by: Hugues Fruchet >> ---

[PATCH v7 08/10] [media] st-delta: EOS (End Of Stream) support

2017-02-02 Thread Hugues Fruchet
EOS (End Of Stream) support allows user to get all the potential decoded frames remaining in decoder pipeline after having reached the end of video bitstream. To do so, user calls VIDIOC_DECODER_CMD(V4L2_DEC_CMD_STOP) which will drain the decoder and get the drained frames that are then returned

[PATCH v7 09/10] [media] st-delta: add mjpeg support

2017-02-02 Thread Hugues Fruchet
Adds support of DELTA MJPEG video decoder back-end, implemented by calling JPEG_DECODER_HW0 firmware using RPMSG IPC communication layer. Acked-by: Peter Griffin Signed-off-by: Hugues Fruchet --- drivers/media/platform/Kconfig

[PATCH v7 07/10] [media] st-delta: rpmsg ipc support

2017-02-02 Thread Hugues Fruchet
IPC (Inter Process Communication) support for communication with DELTA coprocessor firmware using rpmsg kernel framework. Based on 4 services open/set_stream/decode/close and their associated rpmsg messages. The messages structures are duplicated on both host and firmware side and are packed (use

[PATCH v7 06/10] [media] st-delta: add memory allocator helper functions

2017-02-02 Thread Hugues Fruchet
Helper functions used by decoder back-ends to allocate physically contiguous memory required by hardware video decoder. Acked-by: Peter Griffin Signed-off-by: Hugues Fruchet --- drivers/media/platform/sti/delta/Makefile| 2 +-

[PATCH v7 05/10] [media] st-delta: STiH4xx multi-format video decoder v4l2 driver

2017-02-02 Thread Hugues Fruchet
This V4L2 driver enables DELTA multi-format video decoder of STMicroelectronics STiH4xx SoC series. Acked-by: Peter Griffin Signed-off-by: Hugues Fruchet --- drivers/media/platform/Kconfig| 28 + drivers/media/platform/Makefile

[PATCH v7 03/10] ARM: multi_v7_defconfig: enable STMicroelectronics DELTA Support

2017-02-02 Thread Hugues Fruchet
Enables support of STMicroelectronics STiH4xx SoC series DELTA multi-format video decoder V4L2 driver. Acked-by: Peter Griffin Signed-off-by: Hugues Fruchet --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v7 10/10] [media] st-delta: debug: trace stream/frame information & summary

2017-02-02 Thread Hugues Fruchet
Adds some trace points showing input compressed stream or output decoded frame information. Adds an unconditional trace point when streaming starts showing the compressed stream and the decoded frame information. Adds an unconditional trace point at instance closure summarizing into a single line

[PATCH v7 04/10] [media] MAINTAINERS: add st-delta driver

2017-02-02 Thread Hugues Fruchet
Add entry for the STMicroelectronics DELTA driver. Acked-by: Peter Griffin Signed-off-by: Hugues Fruchet --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cfff2c9..38cc652 100644 ---

[PATCH 2/4] [media] em28xx: reduce stack usage in probe functions

2017-02-02 Thread Arnd Bergmann
The two i2c probe functions use a lot of stack since they put an i2c_client structure in a local variable: drivers/media/usb/em28xx/em28xx-camera.c: In function 'em28xx_probe_sensor_micron': drivers/media/usb/em28xx/em28xx-camera.c:205:1: error: the frame size of 1256 bytes is larger than 1152

[PATCH 1/4] [media] pvrusb2: reduce stack usage pvr2_eeprom_analyze()

2017-02-02 Thread Arnd Bergmann
The driver uses a relatively large data structure on the stack, which showed up on my radar as we get a warning with the "latent entropy" GCC plugin: drivers/media/usb/pvrusb2/pvrusb2-eeprom.c:153:1: error: the frame size of 1376 bytes is larger than 1152 bytes [-Werror=frame-larger-than=] The

[PATCH] [media] ttpci: address stringop overflow warning

2017-02-02 Thread Arnd Bergmann
gcc-7.0.1 warns about old code in ttpci: In file included from drivers/media/pci/ttpci/av7110.c:63:0: In function 'irdebi.isra.2', inlined from 'start_debi_dma' at drivers/media/pci/ttpci/av7110.c:376:3, inlined from 'gpioirq' at drivers/media/pci/ttpci/av7110.c:659:3:

[PATCH v7 02/10] ARM: dts: STiH407-family: add DELTA dt node

2017-02-02 Thread Hugues Fruchet
This patch adds DT node for STMicroelectronics DELTA V4L2 video decoder Signed-off-by: Hugues Fruchet --- arch/arm/boot/dts/stih407-family.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/stih407-family.dtsi

[PATCH v7 01/10] Documentation: DT: add bindings for ST DELTA

2017-02-02 Thread Hugues Fruchet
This patch adds DT binding documentation for STMicroelectronics DELTA V4L2 video decoder. Acked-by: Peter Griffin Signed-off-by: Hugues Fruchet --- Documentation/devicetree/bindings/media/st,st-delta.txt | 17 + 1 file changed,

[PATCH v7 00/10] Add support for DELTA video decoder of STMicroelectronics STiH4xx SoC series

2017-02-02 Thread Hugues Fruchet
This patchset introduces a basic support for DELTA multi-format video decoder of STMicroelectronics STiH4xx SoC series. DELTA hardware IP is controlled by a remote firmware loaded in a ST231 coprocessor. Communication with firmware is done within an IPC layer using rpmsg kernel framework and a

[PATCH 4/4] [media] mxl111sf: reduce stack usage in init function

2017-02-02 Thread Arnd Bergmann
mxl111sf uses a lot of kernel stack memory as it puts an i2c_client structure on the stack: drivers/media/usb/dvb-usb-v2/mxl111sf.c: In function 'mxl111sf_init': drivers/media/usb/dvb-usb-v2/mxl111sf.c:953:1: error: the frame size of 1248 bytes is larger than 1152 bytes

[PATCH 3/4] [media] cx231xx-i2c: reduce stack size in bus scan

2017-02-02 Thread Arnd Bergmann
The cx231xx_do_i2c_scan function needs a lot of stack because it puts an i2c_client structure on it: drivers/media/usb/cx231xx/cx231xx-i2c.c: In function 'cx231xx_do_i2c_scan': drivers/media/usb/cx231xx/cx231xx-i2c.c:518:1: error: the frame size of 1248 bytes is larger than 1152 bytes

[PATCH] [media] dvb-usb-v2: avoid use-after-free

2017-02-02 Thread Arnd Bergmann
I ran into a stack frame size warning because of the on-stack copy of the USB device structure: drivers/media/usb/dvb-usb-v2/dvb_usb_core.c: In function 'dvb_usbv2_disconnect': drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:1029:1: error: the frame size of 1104 bytes is larger than 1024 bytes

Re: [PATCH v2] Documentation: devicetree: meson-ir: "linux,rc-map-name" is supported

2017-02-02 Thread Andreas Färber
Am 01.02.2017 um 23:26 schrieb Martin Blumenstingl: > On Wed, Feb 1, 2017 at 11:14 PM, Martin Blumenstingl > wrote: >> The driver already parses the "linux,rc-map-name" property. Add this >> information to the documentation so .dts maintainers don't have to

Re: [PATCH] [media] staging: bcm2835: mark all symbols as 'static'

2017-02-02 Thread Arnd Bergmann
On Thu, Feb 2, 2017 at 1:22 PM, Greg Kroah-Hartman wrote: > On Thu, Feb 02, 2017 at 01:11:36PM +0100, Arnd Bergmann wrote: >> On Thu, Feb 2, 2017 at 1:04 PM, Arnd Bergmann wrote: >> > On Thu, Feb 2, 2017 at 12:34 PM, Arnd Bergmann wrote:

Re: [PATCH] [media] staging: bcm2835: mark all symbols as 'static'

2017-02-02 Thread Greg Kroah-Hartman
On Thu, Feb 02, 2017 at 01:11:36PM +0100, Arnd Bergmann wrote: > On Thu, Feb 2, 2017 at 1:04 PM, Arnd Bergmann wrote: > > On Thu, Feb 2, 2017 at 12:34 PM, Arnd Bergmann wrote: > >> I got a link error in allyesconfig: > >> Fixes: 7b3ad5abf027 ("staging: Import the

Re: [PATCH] [media] exynos-gsc: Avoid spamming the log on VIDIOC_TRY_FMT

2017-02-02 Thread Javier Martinez Canillas
Hello Shuah, On 02/01/2017 11:25 PM, Shuah Khan wrote: > On 01/24/2017 02:42 PM, Javier Martinez Canillas wrote: >> There isn't an ioctl to enum the supported field orders, so a user-space >> application can call VIDIOC_TRY_FMT using different field orders to know >> if one is supported. For

[PATCH] staging: bcm2835: don't mark 'bcm2835_v4l2_debug' as static

2017-02-02 Thread Arnd Bergmann
This one unfortunately slipped through my own build testing, my patch caused a new build error: bcm2835-camera.c:53:12: error: static declaration of 'bcm2835_v4l2_debug' follows non-static declaration We want the symbol to be global as it is indeed used in more than one file and declared

Re: [PATCH v7 1/2] media: i2c/ov5645: add the device tree binding document

2017-02-02 Thread Todor Tomov
Hi Rob, Could you please take a look again at this patch? It had received an Ack from you for patch v3. Up to v7 the changes are: - frequency of the sensor external clock added to DT; - names of the hardware pins of the gpios are added in the description (the -gpios properties are still the

Re: [PATCH] [media] staging: bcm2835: mark all symbols as 'static'

2017-02-02 Thread Arnd Bergmann
On Thu, Feb 2, 2017 at 1:04 PM, Arnd Bergmann wrote: > On Thu, Feb 2, 2017 at 12:34 PM, Arnd Bergmann wrote: >> I got a link error in allyesconfig: >> Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera >> driver.") >> Signed-off-by: Arnd

Re: [PATCH] [media] staging: bcm2835: mark all symbols as 'static'

2017-02-02 Thread Arnd Bergmann
On Thu, Feb 2, 2017 at 12:34 PM, Arnd Bergmann wrote: > I got a link error in allyesconfig: > > drivers/staging/media/platform/bcm2835/bcm2835-camera.o: In function > `vidioc_enum_framesizes': > bcm2835-camera.c:(.text.vidioc_enum_framesizes+0x0): multiple definition of >

Re: [PATCH v3 21/24] media: imx: Add MIPI CSI-2 Receiver subdev driver

2017-02-02 Thread Philipp Zabel
On Fri, 2017-01-06 at 18:11 -0800, Steve Longerbeam wrote: > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > for sensors with a MIPI CSI2 interface. > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/Makefile| 1 + >

[PATCH] [media] staging: bcm2835: mark all symbols as 'static'

2017-02-02 Thread Arnd Bergmann
I got a link error in allyesconfig: drivers/staging/media/platform/bcm2835/bcm2835-camera.o: In function `vidioc_enum_framesizes': bcm2835-camera.c:(.text.vidioc_enum_framesizes+0x0): multiple definition of `vidioc_enum_framesizes'

Re: ir-keytable: infinite loops, segfaults

2017-02-02 Thread Vincent McIntyre
Hey there On 11/30/16, Vincent McIntyre wrote: > On Sun, Nov 27, 2016 at 07:35:10PM +, Sean Young wrote: >> >> > I wanted to mention that the IR protocol is still showing as unknown. >> > Is there anything that can be done to sort that out? >> >> It would be nice

Re: [STLinux Kernel] [PATCH v6 04/10] [media] MAINTAINERS: add st-delta driver

2017-02-02 Thread Patrice CHOTARD
Hi Peter On 02/01/2017 07:22 PM, Peter Griffin wrote: > Hi Hugues, > > On Wed, 01 Feb 2017, Hugues Fruchet wrote: > >> Add entry for the STMicroelectronics DELTA driver. >> >> Signed-off-by: Hugues Fruchet >> --- >> MAINTAINERS | 8 >> 1 file changed, 8

Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver

2017-02-02 Thread Laurent Pinchart
Hi Steve, Thank you for the patch. Many of the comments below apply to the ov5642 driver too, please take them into account when reworking patch 23/24. On Friday 06 Jan 2017 18:11:40 Steve Longerbeam wrote: > This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta > branch,

Re: [PATCH 09/11] [media] s5p-mfc: Add support for HEVC encoder

2017-02-02 Thread Andrzej Hajda
On 18.01.2017 11:02, Smitha T Murthy wrote: > Add HEVC encoder support and necessary registers, V4L2 CIDs, > and hevc encoder parameters > > Signed-off-by: Smitha T Murthy > --- > drivers/media/platform/s5p-mfc/regs-mfc-v10.h | 28 +- >

Re: [PATCH 08/11] [media] s5p-mfc: Add VP9 decoder support

2017-02-02 Thread Andrzej Hajda
On 18.01.2017 11:02, Smitha T Murthy wrote: > Add support for codec definition and corresponding buffer > requirements for VP9 decoder. > > Signed-off-by: Smitha T Murthy > --- > drivers/media/platform/s5p-mfc/regs-mfc-v10.h |6 + >

Re: [PATCH 06/11] [media] videodev2.h: Add v4l2 definition for HEVC

2017-02-02 Thread Andrzej Hajda
On 18.01.2017 11:02, Smitha T Murthy wrote: > Add V4L2 definition for HEVC compressed format > > Signed-off-by: Smitha T Murthy Beside small nitpick. Reviewed-by: Andrzej Hajda > --- > include/uapi/linux/videodev2.h |1 + > 1 files changed, 1

Re: [PATCH 04/11] [media] s5p-mfc: Support MFCv10.10 buffer requirements

2017-02-02 Thread Andrzej Hajda
Hi Smitha, Ups, I have missed this patch, I hope it wont influence the review :) On 18.01.2017 11:02, Smitha T Murthy wrote: > Aligning the luma_dpb_size, chroma_dpb_size, mv_size and me_buffer_size > for MFCv10.10. > > Signed-off-by: Smitha T Murthy > --- >

Re: [PATCH 05/11] [media] s5p-mfc: Add support for HEVC decoder

2017-02-02 Thread Andrzej Hajda
On 02.02.2017 08:58, Andrzej Hajda wrote: > On 18.01.2017 11:02, Smitha T Murthy wrote: >> Add support for codec definition and corresponding buffer >> requirements for HEVC decoder. >> >> Signed-off-by: Smitha T Murthy >> --- >>