Re: [PATCH 2/2] [media] cx231xx: Fix I2C on Internal Master 3 Bus

2017-02-12 Thread Oleh Kravchenko
On 13.02.17 06:58, Antti Palosaari wrote: > On 02/07/2017 09:35 PM, Oleh Kravchenko wrote: >> Internal Master 3 Bus can send and receive only 4 bytes per time. >> >> Signed-off-by: Oleh Kravchenko >> --- >> drivers/media/usb/cx231xx/cx231xx-core.c | 7 ++- >> 1 file

Re: [PATCH 2/3] si2157: Si2141/2151 tuner support.

2017-02-12 Thread Antti Palosaari
Hello You still didn't addressed the issues I pointed. For example that repeating loop looks simply wrong and you don't even care to add comment why this kind of ugly looking hack is there. Stefan sent yesterday new set of patches for this device and those looks correct. There is not even

Re: [PATCH 10/11] [media] v4l2: Add v4l2 control IDs for HEVC encoder

2017-02-12 Thread Smitha T Murthy
On Mon, 2017-02-06 at 15:54 +0100, Andrzej Hajda wrote: > Hi Smitha, > > I have no big experience with HEVC, so it is hard to review it > appropriately but I will try do my best. > As these control names goes to user space you should be very careful > about it. > I guess it could be good to

cron job: media_tree daily build: WARNINGS

2017-02-12 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Feb 13 05:00:15 CET 2017 media-tree git hash:9eeb0ed0f30938f31a3d9135a88b9502192c18dd media_build

Re: [PATCH 0/3] Add support for MyGica T230C DVB-T2 stick

2017-02-12 Thread Antti Palosaari
On 02/12/2017 05:26 PM, Stefan Brüns wrote: The required command sequence for the new tuner (Si2141) was traced from the current Windows driver and verified with a small python script/libusb. The changes to the Si2168 and cxusb driver are mostly addition of the required IDs and some glue code.

Re: [PATCH 2/2] [media] cx231xx: Fix I2C on Internal Master 3 Bus

2017-02-12 Thread Antti Palosaari
On 02/07/2017 09:35 PM, Oleh Kravchenko wrote: Internal Master 3 Bus can send and receive only 4 bytes per time. Signed-off-by: Oleh Kravchenko --- drivers/media/usb/cx231xx/cx231xx-core.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH] v4l: vsp1: Fix WPF U/V order in 3-planar formats on Gen3

2017-02-12 Thread Laurent Pinchart
The WPF U/V order bit has no effect for 3-planar formats on Gen3 hardware. Swap the U and V planes manually instead in that case. Fixes: b915bd24a034 ("[media] v4l: vsp1: Add tri-planar memory formats support") Signed-off-by: Laurent Pinchart ---

Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver

2017-02-12 Thread Steve Longerbeam
(resending text only) On 02/02/2017 02:36 AM, Laurent Pinchart wrote: Hi Steve, Thank you for the patch. Many of the comments below apply to the ov5642 driver too, please take them into account when reworking patch 23/24. On Friday 06 Jan 2017 18:11:40 Steve Longerbeam wrote: This driver is

Re: [PATCH 4/4] media-ctl: add colorimetry support

2017-02-12 Thread Sakari Ailus
On Tue, Feb 07, 2017 at 05:08:50PM +0100, Philipp Zabel wrote: > media-ctl can be used to propagate v4l2 subdevice pad formats from > source pads of one subdevice to another one's sink pads. These formats > include colorimetry information, so media-ctl should be able to print > or change it using

Re: [PATCH 3/4] media-ctl: propagate frame interval

2017-02-12 Thread Sakari Ailus
Hi Philipp, On Tue, Feb 07, 2017 at 05:08:49PM +0100, Philipp Zabel wrote: > Same as the media bus format, the frame interval should be propagated > from output pads to connected entities' input pads. > > Signed-off-by: Philipp Zabel Acked-by: Sakari Ailus

Re: [PATCH 2/4] media-ctl: print the configured frame interval

2017-02-12 Thread Sakari Ailus
On Tue, Feb 07, 2017 at 05:08:48PM +0100, Philipp Zabel wrote: > After the pad format, also print the frame interval, if already configured. > > Signed-off-by: Philipp Zabel Acked-by: Sakari Ailus -- Sakari Ailus e-mail:

Re: [PATCH 1/4] media-ctl: add pad support to set/get_frame_interval

2017-02-12 Thread Sakari Ailus
Hi Philipp, On Tue, Feb 07, 2017 at 05:08:47PM +0100, Philipp Zabel wrote: > This allows to set and get the frame interval on pads other than pad 0. > > Signed-off-by: Philipp Zabel > --- > utils/media-ctl/libv4l2subdev.c | 24 ++-- >

Re: Device Tree formatting for multiple virtual channels in ti-vpe/cal driver?

2017-02-12 Thread Sakari Ailus
Hi Thomas, On Fri, Feb 10, 2017 at 09:34:46AM +, Thomas Axelsson wrote: > Hi, > > I have a TI AM571x CPU, and I'm trying to add support for multiple MIPI > CSI-2 virtual channels per PHY (port) to the ti-vpe/cal.c driver > (CAMSS/CAL peripheral, ch. 8 in Datasheet [1]). This CPU can have

Re: [PATCH] smiapp: add CCP2 support

2017-02-12 Thread Sakari
Hi Pavel, On Sun, Feb 12, 2017 at 12:22:58AM +0100, Pavel Machek wrote: > Hi! > > > Besides this patch, what else is needed? The CSI-2 / CCP2 support is > > missing in V4L2 OF at least. It'd be better to have this all in the same > > set. > > Quite a lot of is needed. > > > I pushed the two DT

[PATCH] Staging: media: bcm2048: Fixed coding style issue.

2017-02-12 Thread Ran Algawi
Fixed a coding style issue, where an octal value was needed insted of decimal. Signed-off-by: Ran Algawi --- drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c

Re: [PATCH] Staging: media: bcm2048: Fixed an error

2017-02-12 Thread Greg Kroah-Hartman
On Sun, Feb 12, 2017 at 11:12:42PM +0200, Ran Algawi wrote: > Hello Greg, > First, I appreciate you taking the time to educate me. I used the checkpatch > script on the file I fixed and he reported the line as an error. Do you > consider all checkpatch warnings/error/checks as coding style fixes?

Re: [PATCH] Staging: media: bcm2048: Fixed an error

2017-02-12 Thread Ran Algawi
Hello Greg, I apperaciate you taking the time to educate me. Do you consider all checkpatch errors/warnnings/checks as code style fixes? With regards, Ran A.

[PATCH] media: rc: nuvoton: fix deadlock in nvt_write_wakeup_codes

2017-02-12 Thread Heiner Kallweit
nvt_write_wakeup_codes acquires the same lock as the ISR but doesn't disable interrupts on the local CPU. This caused the following deadlock. Fix this by using spin_lock_irqsave. [ 432.362008] [ 432.362074] WARNING: inconsistent lock state [ 432.362144]

Re: [PATCH RESEND 1/1] media: platform: Renesas IMR driver

2017-02-12 Thread Laurent Pinchart
Hi Sergei, (CC'ing the dri-evel mailing list) Thank you for the patch. On Saturday 11 Feb 2017 23:02:01 Sergei Shtylyov wrote: > From: Konstantin Kozhevnikov > > The image renderer light extended 4 (IMR-LX4) or the distortion correction > engine is a

[PATCH 3/3] [media] cxusb: MyGica T230C support

2017-02-12 Thread Stefan Brüns
Mygica T230 DVB-T/T2/C USB stick support. It uses the same FX2/Si2168 bridge/demodulator combo as the T230, but uses the Si2141 tuner. Factor out the common code and pass the tuner type and if port as parameter, to avoid duplicating the initialization code. Signed-off-by: Stefan Brüns

[PATCH 0/3] Add support for MyGica T230C DVB-T2 stick

2017-02-12 Thread Stefan Brüns
The required command sequence for the new tuner (Si2141) was traced from the current Windows driver and verified with a small python script/libusb. The changes to the Si2168 and cxusb driver are mostly addition of the required IDs and some glue code. Stefan Brüns (3): [media] si2157: Add

[PATCH 1/3] [media] si2157: Add support for Si2141-A10

2017-02-12 Thread Stefan Brüns
The Si2141 needs two distinct commands for powerup/reset, otherwise it will not respond to chip revision requests. It also needs a firmware to run properly. Signed-off-by: Stefan Brüns --- drivers/media/tuners/si2157.c | 23 +--

[PATCH 2/3] [media] si2168: add support for Si2168-D60

2017-02-12 Thread Stefan Brüns
Add handling for new revision, requiring new firmware. Signed-off-by: Stefan Brüns --- drivers/media/dvb-frontends/si2168.c | 4 drivers/media/dvb-frontends/si2168_priv.h | 2 ++ 2 files changed, 6 insertions(+) diff --git

[PATCH v2] [media] dvb-usb-firmware: don't do DMA on stack

2017-02-12 Thread Stefan Brüns
The buffer allocation for the firmware data was changed in commit 43fab9793c1f ("dvb-usb: don't use stack for firmware load"), but the same applies for the reset value. Signed-off-by: Stefan Brüns --- This patch replaces the earlier submission conflicting with

Re: [PATCH] smiapp: add CCP2 support

2017-02-12 Thread kbuild test robot
Hi Pavel, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.10-rc7 next-20170210] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCHv2] v4l: split lane parsing code

2017-02-12 Thread Pavel Machek
Hi! > The patch looks good to me. Could you post a patchset containing all the > needed patches, maybe on top of the DT patches in the ccp2 branch, please? > It'd be easier to handle this that way. Ok, will do. Best regards, Pavel

Re: [PATCH] Staging: media: bcm2048: Fixed an error

2017-02-12 Thread Greg KH
On Sat, Feb 11, 2017 at 12:41:29AM +0200, Ran Algawi wrote: > Fixed an error where the system was given a code in the form of decimal > instead of octal. It's not really an "error", right? Please be more descriptive of exactly what is going on here (hint, it's a coding style warning...) thanks,