Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-17 Thread Pavel Machek
Hi! > > > This is quite a lot of boilerplate for that. Would it make sense to > > > provide helper function at least for this? > > > > Yes. I've been thinking of having helper functions for notifiers and > > sub-notifiers. Most of the receiver drivers are implementing exactly the > > same thing

Re: [PATCH v2 09/12] intel-ipu3: css hardware setup

2017-06-17 Thread Andy Shevchenko
On Sat, Jun 17, 2017 at 9:43 PM, Sakari Ailus wrote: > On Sat, Jun 17, 2017 at 01:54:51AM +0300, Andy Shevchenko wrote: >> On Thu, Jun 15, 2017 at 1:19 AM, Yong Zhi wrote: >> > +static void writes(void *mem, ssize_t len, void __iomem *reg) >> > +{ >> > +

Re: [PATCH v2 09/12] intel-ipu3: css hardware setup

2017-06-17 Thread Sakari Ailus
On Sat, Jun 17, 2017 at 01:54:51AM +0300, Andy Shevchenko wrote: > On Thu, Jun 15, 2017 at 1:19 AM, Yong Zhi wrote: > > Commit message. > > > Signed-off-by: Yong Zhi > > > +static void writes(void *mem, ssize_t len, void __iomem *reg) > > +{ > > +

Re: [PATCH v2 12/12] intel-ipu3: imgu top level pci device

2017-06-17 Thread Sakari Ailus
On Sat, Jun 17, 2017 at 11:37:11AM +0300, Andy Shevchenko wrote: > On Sat, Jun 17, 2017 at 9:32 AM, Tomasz Figa wrote: > > On Sat, Jun 17, 2017 at 9:00 AM, Zhi, Yong wrote: > >>> On Thu, Jun 15, 2017 at 1:19 AM, Yong Zhi wrote: > >

Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-17 Thread Pavel Machek
Hi! > > This is quite a lot of boilerplate for that. Would it make sense to > > provide helper function at least for this? > > Yes. I've been thinking of having helper functions for notifiers and > sub-notifiers. Most of the receiver drivers are implementing exactly the > same thing but with

Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-17 Thread Pavel Machek
Hi! > These types devices aren't directly related to the sensor, but are > nevertheless handled by the smiapp driver due to the relationship of these > component to the main part of the camera module --- the sensor. > > Additionally, for the async sub-device registration to work, the notifier >

Re: [PATCH 6/6] rc-core: add protocol to EVIOC[GS]KEYCODE_V2 ioctl

2017-06-17 Thread David Härdeman
On Sun, Jun 11, 2017 at 05:17:40PM +0100, Sean Young wrote: >On Sat, Apr 29, 2017 at 10:44:58AM +0200, David Härdeman wrote: >> >This can be implemented without breaking userspace. >> >> How? > >The current keymaps we have do not specify the protocol variant, only >the protocol (rc6 vs rc6-mce).

Re: [PATCH 03/16] lirc_dev: correct error handling

2017-06-17 Thread David Härdeman
On Sun, May 28, 2017 at 04:04:30PM +0100, Sean Young wrote: >On Sun, May 28, 2017 at 10:23:37AM +0200, David Härdeman wrote: >> On Sun, May 21, 2017 at 09:57:13AM +0100, Sean Young wrote: >> >On Mon, May 01, 2017 at 06:03:51PM +0200, David Härdeman wrote: >> >> If an error is generated,

Re: [PATCH 3/7] rc-core: img-nec-decoder - leave the internals of rc_dev alone

2017-06-17 Thread David Härdeman
On Sun, Jun 11, 2017 at 05:02:24PM +0100, Sean Young wrote: >On Sun, May 28, 2017 at 10:28:44AM +0200, David Härdeman wrote: >> On Mon, May 22, 2017 at 09:40:30PM +0100, Sean Young wrote: >> >On Mon, May 01, 2017 at 06:10:06PM +0200, David Härdeman wrote: >> >> Obvious fix, leave repeat handling

Re: [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices

2017-06-17 Thread Pavel Machek
Hi! > > > These types devices aren't directly related to the sensor, but are > > > nevertheless handled by the smiapp driver due to the relationship of these > > > component to the main part of the camera module --- the sensor. > > > > > > Additionally, for the async sub-device registration to

Re: [PATCH v2 12/12] intel-ipu3: imgu top level pci device

2017-06-17 Thread Andy Shevchenko
On Sat, Jun 17, 2017 at 9:32 AM, Tomasz Figa wrote: > On Sat, Jun 17, 2017 at 9:00 AM, Zhi, Yong wrote: >>> On Thu, Jun 15, 2017 at 1:19 AM, Yong Zhi wrote: >>> > + /* Set Power */ >>> > + r = pm_runtime_get_sync(dev); >>>

cron job: media_tree daily build: ERRORS

2017-06-17 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Jun 17 05:00:16 CEST 2017 media-tree git hash:acec3630155763c170c7ae6508cf973355464508 media_build

Re: [PATCH v2] [media] davinci: vpif: adaptions for DT support

2017-06-17 Thread Sylwester Nawrocki
On 06/09/2017 06:10 PM, Kevin Hilman wrote: The davinci VPIF is a single hardware block, but the existing driver is broken up into a common library (vpif.c), output (vpif_display.c) and intput (vpif_capture.c). When migrating to DT, to better model the hardware, and because registers,

Re: [PATCH v2 12/12] intel-ipu3: imgu top level pci device

2017-06-17 Thread Tomasz Figa
On Sat, Jun 17, 2017 at 9:00 AM, Zhi, Yong wrote: > Hi, Andy, > >> -Original Message- >> From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] >> Sent: Friday, June 16, 2017 3:59 PM >> To: Zhi, Yong >> Cc: Linux Media Mailing List