[PATCH 4/4] [media] zr364xx: Fix a typo in a comment line of the file header

From: Markus Elfring Date: Mon, 28 Aug 2017 22:46:30 +0200 Fix a word in this description. Signed-off-by: Markus Elfring --- drivers/media/usb/zr364xx/zr364xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/4] [media] zr364xx: Adjust ten checks for null pointers

From: Markus Elfring Date: Mon, 28 Aug 2017 22:40:47 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

[PATCH 2/4] [media] zr364xx: Improve a size determination in zr364xx_probe()

From: Markus Elfring Date: Mon, 28 Aug 2017 22:28:02 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/4] [media] zr364xx: Delete an error message for a failed memory allocation in two functions

From: Markus Elfring Date: Mon, 28 Aug 2017 22:23:56 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/4] [media] zr364xx: Adjustments for some function implementations

From: Markus Elfring Date: Tue, 29 Aug 2017 07:17:07 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Delete an error message for a failed memory allocation in two functions Improve a size

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Aug 29 05:00:15 CEST 2017 media-tree git hash:9a45bf28bc39ff6ed45a008f7201289c8e9e60a6 media_build

[PATCH v2 1/2] media:imx274 device tree binding file

From: Leon Luo The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann --- .../devicetree/bindings/media/i2c/imx274.txt | 32 ++ 1 file

[PATCH v2 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

From: Leon Luo The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface is 4-lane MIPI running at 1.44Gbps each. This driver has been tested on Xilinx ZCU102 platform with a Leopard

[PATCH 2/2] media: dvb-core: fix demux.h non-ASCII characters

From: Randy Dunlap Fix non-ASCII charactes in kernel-doc comment to prevent the kernel-doc build warning below. WARNING: kernel-doc '../scripts/kernel-doc -rst -enable-lineno ../drivers/media/dvb-core/demux.h' processing failed with: 'ascii' codec can't decode byte 0xe2

[PATCH 1/2] docs: kernel-doc comments are ASCII

From: Randy Dunlap kernel-doc parsing uses as ASCII codec, so let people know that kernel-doc comments should be in ASCII characters only. WARNING: kernel-doc '../scripts/kernel-doc -rst -enable-lineno ../drivers/media/dvb-core/demux.h' processing failed with: 'ascii'

Re: DRM Format Modifiers in v4l2

On Mon, Aug 28, 2017 at 8:07 PM, Nicolas Dufresne wrote: > Le jeudi 24 août 2017 à 13:26 +0100, Brian Starkey a écrit : >> > What I mean was: an application can use the modifier to give buffers from >> > one device to another without needing to understand it. >> > >> > But a

Re: [PATCH v2] [media] pci: make video_device const

On 26/Aug/2017 18:38, Bhumika Goyal wrote: > Make these const as they are either used during a copy operation or > passed to a const argument of the function cx88_vdev_init. > > Signed-off-by: Bhumika Goyal > --- > * Combine the patch series sent for drivers/media/pci/ into a

Re: [PATCH 3/5] [media] solo6x10: make video_device const

On 26/Aug/2017 16:43, Bhumika Goyal wrote: > Make this const as it is only used in a copy operation. > > Signed-off-by: Bhumika Goyal > --- > drivers/media/pci/solo6x10/solo6x10-v4l2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

On Mon, 2017-08-28 at 14:22:03 -0400, Nicolas Dufresne wrote: > Le lundi 28 août 2017 à 08:15 -0700, Soren Brinkmann a écrit : [...] > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index 94153895fcd4..4e8b64575b2a 100644 > > --- a/drivers/media/i2c/Kconfig > > +++

Re: [PATCH 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

Le lundi 28 août 2017 à 08:15 -0700, Soren Brinkmann a écrit : > From: Leon Luo > > The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. > It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface > is 4-lane MIPI running at 1.44Gbps each. > >

Re: DRM Format Modifiers in v4l2

Le jeudi 24 août 2017 à 13:26 +0100, Brian Starkey a écrit : > > What I mean was: an application can use the modifier to give buffers from > > one device to another without needing to understand it. > > > > But a generic video capture application that processes the video itself > > cannot be

[PATCH] [media_build] update v4.7_dma_attrs.patch

From: Daniel Scheller Fixes apply_patches wrt commit 5b6f9abe5a49 ("media: vb2: add bidirectional flag in vb2_queue") Signed-off-by: Daniel Scheller Tested-by: Jasmin Jessich --- Tested and verified by Jasmin on 3.13, 3.4 and 2.6.36,

Re: [3/7,media] dvb: don't use 'time_t' in event ioctl

On Tue, Sep 15, 2015 at 05:49:04PM +0200, Arnd Bergmann wrote: > 'struct video_event' is used for the VIDEO_GET_EVENT ioctl, implemented > by drivers/media/pci/ivtv/ivtv-ioctl.c and > drivers/media/pci/ttpci/av7110_av.c. The structure contains a 'time_t', > which will be redefined in the future to

[PATCH 1/2] media:imx274 device tree binding file

From: Leon Luo The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann --- .../devicetree/bindings/media/i2c/imx274.txt | 32 ++ 1 file

[PATCH 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

From: Leon Luo The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface is 4-lane MIPI running at 1.44Gbps each. This driver has been tested on Xilinx ZCU102 platform with a Leopard

[PATCH] Staging: bcm2048 fix bare use of 'unsigned' in radio-bcm2048.c

This is a patch to the radio-bcm2048.c file that fixes up a warning found by the checkpatch.pl tool. Removed unused 'size' argument from property_read macro. In property_write macro, 'signal, size' is replaced by 'prop_type'. This change implys the update of DEFINE_SYSFS_PROPERTY macro and all

Re: [RFC 0/2] BCM283x Camera Receiver driver

Hi Dave, What is the status of this work? I ask because I tried to use this driver plus my tc358743 on my rpi-2b without any luck. Specifically the tc358843 isn't able to read from the i2c bus. This is probably a bug in my dts, if you have a tree somewhere containing a working dts for this, then

V4L2 device node centric - Was: [PATCH v4 6/7] media: videodev2: add a flag for MC-centric devices

Em Mon, 28 Aug 2017 11:41:58 +0200 Hans Verkuil escreveu: > > +control, and thus can't be used by **v4l2-centric** applications. > > vdev-centric > > TBD: I still think I prefer V4L2-centric over vdev-centric. I'm splitting it on a separate thread, to make easier

[PATCH v5 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

Add a glossary of terms for V4L2, as several concepts are complex enough to cause misunderstandings. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/glossary.rst | 147 ++ Documentation/media/uapi/v4l/v4l2.rst | 1

[PATCH v5 4/7] media: open.rst: document devnode-centric and mc-centric types

When we added support for omap3, back in 2010, we added a new type of V4L2 devices that aren't fully controlled via the V4L2 device node. Yet, we have never clearly documented in the V4L2 specification the differences between the two types. Let's document them based on the the current

[PATCH v5 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

The documentation doesn't mention if vdev-centric hardware control would have subdev API or not. Add a notice about that, reflecting the current status, where three drivers use it, in order to support some subdev-specific controls. Signed-off-by: Mauro Carvalho Chehab

[PATCH v5 0/7] document types of hardware control for V4L2

On Kernel 2.6.39, the omap3 driver was introduced together with a new way to control complex V4L2 devices used on embedded systems, but this was never documented, as the original idea were to have "soon" support for standard apps to use it as well, via libv4l, but that didn't happen so far. Also,

[PATCH v5 6/7] media: videodev2: add a flag for MC-centric devices

As both vdev-centric and MC-centric devices may implement the same APIs, we need a flag to allow userspace to distinguish between them. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/open.rst| 7 +++

[PATCH v5 2/7] media: open.rst: better document device node naming

Right now, only kAPI documentation describes the device naming. However, such description is needed at the uAPI too. Add it, and describe how to get an unique identify for a given device. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab

[PATCH v5 5/7] media: open.rst: Adjust some terms to match the glossary

As we now have a glossary, some terms used on open.rst require adjustments. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/uapi/v4l/open.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH v5 3/7] media: open.rst: remove the minor number range

minor numbers use to range between 0 to 255, but that was changed a long time ago. While it still applies when CONFIG_VIDEO_FIXED_MINOR_RANGES, when the minor number is dynamically allocated, this may not be true. In any case, this is not relevant, as udev will take care of it. So, remove this

Re: [PATCH v4 4/7] media: open.rst: document devnode-centric and mc-centric types

Em Mon, 28 Aug 2017 11:36:13 +0200 Hans Verkuil escreveu: > On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > > When we added support for omap3, back in 2010, we added a new > > type of V4L2 devices that aren't fully controlled via the V4L2 > > device node. > > > > Yet, we

[PATCH 3/3] [media] Siano: Adjust five checks for null pointers

From: Markus Elfring Date: Mon, 28 Aug 2017 12:50:28 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

[PATCH 2/3] [media] Siano: Improve a size determination in six functions

From: Markus Elfring Date: Mon, 28 Aug 2017 12:38:39 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/3] [media] Siano: Delete an error message for a failed memory allocation in three functions

From: Markus Elfring Date: Mon, 28 Aug 2017 12:30:11 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/3] [media] Siano: Adjustments for some function implementations

From: Markus Elfring Date: Mon, 28 Aug 2017 12:55:43 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in three functions Improve a size

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

Hi! > Thanks for the review! > > On 08/28/17 13:33, Pavel Machek wrote: > > Hi! > > > >> + > >> +Ranges below noted as [a, b] are closed ranges between a and b, i.e. a > >> +and b are included in the range. > > > > Normally I've seen for closed ranges, (a, b) for open > > ranges. Is

Re: [PATCH v3 2/3] leds: as3645a: Add LED flash class driver

On Wed 2017-08-23 11:10:59, Sakari Ailus wrote: > Add a LED flash class driver for the as3654a flash controller. A V4L2 flash > driver for it already exists (drivers/media/i2c/as3645a.c), and this driver > is based on that. We do not want to have two drivers for same hardware... how is that

Re: [PATCH v3 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

Hi! > +led-max-microamp: Maximum torch (assist) current in microamperes. The > + value must be in the range between [2, 16] and > + divisible by 2. > +ams,input-max-microamp: Maximum flash controller input current. The "in microamperes". > +

Re: [PATCH v4 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

On 28/08/17 12:30, Mauro Carvalho Chehab wrote: > Em Mon, 28 Aug 2017 12:05:06 +0200 > Hans Verkuil escreveu: > >> On 26/08/17 13:53, Mauro Carvalho Chehab wrote: >>> The documentation doesn't mention if vdev-centric hardware >>> control would have subdev API or not. >>> >>>

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

Hi Pavel, Thanks for the review! On 08/28/17 13:33, Pavel Machek wrote: > Hi! > >> + >> +Ranges below noted as [a, b] are closed ranges between a and b, i.e. a >> +and b are included in the range. > > Normally I've seen for closed ranges, (a, b) for open > ranges. Is that different in

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

Hi! > + > +Ranges below noted as [a, b] are closed ranges between a and b, i.e. a > +and b are included in the range. Normally I've seen for closed ranges, (a, b) for open ranges. Is that different in your country? Otherwise Acked-by: Pavel Machek -- (english)

Re: [PATCH v4 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

Em Mon, 28 Aug 2017 12:05:06 +0200 Hans Verkuil escreveu: > On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > > The documentation doesn't mention if vdev-centric hardware > > control would have subdev API or not. > > > > Add a notice about that, reflecting the current

[PATCH 2/2] [media] Cypress: Improve a size determination in cypress_load_firmware()

From: Markus Elfring Date: Mon, 28 Aug 2017 11:55:16 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/2] [media] Cypress: Delete an error message for a failed memory allocation in cypress_load_firmware()

From: Markus Elfring Date: Mon, 28 Aug 2017 11:46:57 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/2] [media] Cypress: Adjustments for cypress_load_firmware()

From: Markus Elfring Date: Mon, 28 Aug 2017 12:00:21 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

Re: [PATCH v4 7/7] media: open.rst: add a notice about subdev-API on vdev-centric

On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > The documentation doesn't mention if vdev-centric hardware > control would have subdev API or not. > > Add a notice about that, reflecting the current status, where > three drivers use it, in order to support some subdev-specific > controls. I

Re: [PATCH v4 6/7] media: videodev2: add a flag for MC-centric devices

On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > As both vdev-centric and MC-centric devices may implement the > same APIs, we need a flag to allow userspace to distinguish > between them. > > Signed-off-by: Mauro Carvalho Chehab > --- >

Re: [PATCH v4 5/7] media: open.rst: Adjust some terms to match the glossary

On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > As we now have a glossary, some terms used on open.rst > require adjustments. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Hans Verkuil Regards, Hans > --- >

Re: [PATCH] cobalt: do not register subdev nodes

On Mon, Aug 28, 2017 at 10:45:58AM +0200, Hans Verkuil wrote: > In the distant past the adv7604 driver used private controls. In order to > access > them the v4l-subdevX nodes were needed. Later the is_private tag was removed > in > the adv7604 driver and the need for v4l-subdevX device nodes

Re: [PATCH v4 4/7] media: open.rst: document devnode-centric and mc-centric types

On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > When we added support for omap3, back in 2010, we added a new > type of V4L2 devices that aren't fully controlled via the V4L2 > device node. > > Yet, we have never clearly documented in the V4L2 specification > the differences between the two

Re: [PATCH v4 3/7] media: open.rst: remove the minor number range

On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > minor numbers use to range between 0 to 255, but that > was changed a long time ago. While it still applies when > CONFIG_VIDEO_FIXED_MINOR_RANGES, when the minor number is > dynamically allocated, this may not be true. In any case, > this is not

Re: [PATCH v4 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

This is a partial review. I think I need to review the other patches first before continuing this review. But it doesn't hurt to post this now. On 26/08/17 13:53, Mauro Carvalho Chehab wrote: > Add a glossary of terms for V4L2, as several concepts are complex > enough to cause misunderstandings.

[PATCH] cobalt: do not register subdev nodes

In the distant past the adv7604 driver used private controls. In order to access them the v4l-subdevX nodes were needed. Later the is_private tag was removed in the adv7604 driver and the need for v4l-subdevX device nodes disappeared. Remove the creation of those device nodes from this driver.

[PATCH] [media] pci: make i2c_client const

Make these const as they are only used in a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- drivers/media/pci/cx23885/cx23885-i2c.c | 2 +- drivers/media/pci/cx25821/cx25821-i2c.c | 2 +- drivers/media/pci/ivtv/ivtv-i2c.c | 2 +-

[PATCH] [media] usb: make i2c_client const

Make these const as they are only used in a copy operation. Done using Coccinelle. @match disable optional_qualifier@ identifier s; @@ static struct i2c_client s = {...}; @ref@ position p; identifier match.s; @@ s@p @good1@ position ref.p; identifier match.s,f,c; expression e; @@ ( e = s@p | e

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

Hi Daniel, On 25.08.2017 17:10, Daniel Mack wrote: > Hi Todor, > > Thanks a lot for working on the upstream support for this! > > On 08/08/2017 03:30 PM, Todor Tomov wrote: >> +The Camera Subsystem hardware found on 8x16 processors and supported by the >> +driver consists of: >> + >> +- 2

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

Hi Maxime, On Fri, 25 Aug 2017 15:41:14 +0200 Maxime Ripard wrote: > Hi Yong, > > On Wed, Aug 23, 2017 at 10:32:16AM +0800, Yong wrote: > > > > > > +static int sun6i_graph_notify_complete(struct v4l2_async_notifier > > > > > > *notifier) > > > > > > +{ > > >

[PATCH] [media] uvcvideo: zero seq number when disabling stream

For bulk-based devices, when disabling the video stream, in addition to issue CLEAR_FEATURE(HALT), it is better to set alternate setting 0 as well or the sequnce number in host side will probably not reset to zero. Then in next time video stream start, the device will expect host starts packet